[HBASE-19417] Remove boolean return value from postBulkLoadHFile hook

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta-1, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Apekshit Sharma
• Created: 04/Dec/17 17:12
• Updated: 01/Aug/18 06:22
• Resolved: 06/Dec/17 22:24

Description

See the discussion at the tail of HBASE-17123 where Appy pointed out that the override of loaded should be placed inside else block:

      } else {
        // secure bulk load
        map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region, request);
      }
      BulkLoadHFileResponse.Builder builder = BulkLoadHFileResponse.newBuilder();
      if (map != null) {
        loaded = true;
      }

This issue is to address the review comment.

After several review iterations, here are the changes:

• Return value of boolean for postBulkLoadHFile() hook are changed to void.
• Coprocessor hooks (pre and post) are added for the scenario where bulk load manager is used.