Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19417

Remove boolean return value from postBulkLoadHFile hook

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-beta-1, 2.0.0
    • None
    • None
    • Reviewed

    Description

      See the discussion at the tail of HBASE-17123 where Appy pointed out that the override of loaded should be placed inside else block:

            } else {
              // secure bulk load
              map = regionServer.secureBulkLoadManager.secureBulkLoadHFiles(region, request);
            }
            BulkLoadHFileResponse.Builder builder = BulkLoadHFileResponse.newBuilder();
            if (map != null) {
              loaded = true;
            }
      

      This issue is to address the review comment.

      After several review iterations, here are the changes:

      • Return value of boolean for postBulkLoadHFile() hook are changed to void.
      • Coprocessor hooks (pre and post) are added for the scenario where bulk load manager is used.

      Attachments

        1. 19417.v8.txt
          10 kB
          Ted Yu
        2. 19417.v7.txt
          8 kB
          Ted Yu
        3. 19417.v6.txt
          9 kB
          Ted Yu
        4. 19417.v5.txt
          7 kB
          Ted Yu
        5. 19417.v4.txt
          5 kB
          Ted Yu
        6. 19417.v3.txt
          4 kB
          Ted Yu
        7. 19417.v2.txt
          2 kB
          Ted Yu
        8. 19417.v1.txt
          0.9 kB
          Ted Yu

        Activity

          People

            yuzhihong@gmail.com Ted Yu
            appy Apekshit Sharma
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: