[HBASE-19052] FixedFileTrailer should recognize CellComparatorImpl class in branch-1.x

• Type: Improvement
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.4.0, 1.3.2, 1.1.13, 1.2.7
• Component/s: HFile
• Hadoop Flags: Reviewed

Release Note

FixedFileTrailer#getComparatorClass() recognizes CellComparatorImpl and CellComparatorImpl$MetaCellComparator classes.

This is for rolling upgrade from 1.x release to 2.0 release.

• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 19/Oct/17 17:28
• Updated: 09/Nov/17 01:58
• Resolved: 23/Oct/17 16:44

Description

HBASE-18945 has gone into branch-2 .
Let's consider rolling upgrade scenario from 1.x to 2.0 where there're three servers: s1, s2, s3

s1 is upgraded to 2.0 first. It flushes to hfile in region r1 with CellComparatorImpl written in the hfile trailer.
Somehow s1 crashes and master assigns r1 to s2 which is still running 1.x
The following code in FixedFileTrailer would be triggered:

      try {
        comparatorKlass = (Class<? extends CellComparator>) Class.forName(comparatorClassName);
      } catch (ClassNotFoundException e) {
        throw new IOException(e);
      }

since s2 is not aware of CellComparatorImpl.

This issue is to backport CellComparatorImpl related change to branch-1.x
Note: CellComparatorImpl wouldn't be used in write path, only in read path.

Issue Links

• is related to: HBASE-16189 [Rolling Upgrade] 2.0 hfiles cannot be opened by 1.x servers