Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-alpha-4
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      CellCompartor has been added as an interface with IA.LimitedPrivate. It has the following methods
      #int compare(Cell leftCell, Cell rightCell);
      #int compareRows(Cell leftCell, Cell rightCell)
      #int compareRows(Cell cell, byte[] bytes, int offset, int length)
      #int compareWithoutRow(Cell leftCell, Cell rightCell)
      #int compareFamilies(Cell leftCell, Cell rightCell
      #int compareQualifiers(Cell leftCell, Cell rightCell)
      #int compareTimestamps(Cell leftCell, Cell rightCell)
      #int compareTimestamps(long leftCellts, long rightCellts)

      This is exposed to CPs and CPs can make use of the above methods to do comparisons on the cells.
      For internal usage we have CellComparatorImpl and it has static references to COMPARATOR and META_CELL_COMPARATOR.
      So when a region or store is initialized we should use one of the above comparator. For META table we need the META_CELL_COMPARATOR and all other table's regions/stores will use the COMPARTOR.
      While writing the comparator name in FixedFileTrailer of the Hfile we have now ensured that this rename of CellComparator.COMPARATOR/CellComparator.META_CELL_COMPARATOR to CellComparatorImpl.COMPARATOR/CellComparatorImpl.META_CELL_COMPARATOR is handled.

      CellUtils is an util method that provides lot of APIs that helps to do compare, matching functionalities between two cells, or with a cell and a corrpesponding byte[] etc. Some of the APIs are internally used which will be cleaned up in a follow on JIRA HBASE-18995.
      Show
      CellCompartor has been added as an interface with IA.LimitedPrivate. It has the following methods #int compare(Cell leftCell, Cell rightCell); #int compareRows(Cell leftCell, Cell rightCell) #int compareRows(Cell cell, byte[] bytes, int offset, int length) #int compareWithoutRow(Cell leftCell, Cell rightCell) #int compareFamilies(Cell leftCell, Cell rightCell #int compareQualifiers(Cell leftCell, Cell rightCell) #int compareTimestamps(Cell leftCell, Cell rightCell) #int compareTimestamps(long leftCellts, long rightCellts) This is exposed to CPs and CPs can make use of the above methods to do comparisons on the cells. For internal usage we have CellComparatorImpl and it has static references to COMPARATOR and META_CELL_COMPARATOR. So when a region or store is initialized we should use one of the above comparator. For META table we need the META_CELL_COMPARATOR and all other table's regions/stores will use the COMPARTOR. While writing the comparator name in FixedFileTrailer of the Hfile we have now ensured that this rename of CellComparator.COMPARATOR/CellComparator.META_CELL_COMPARATOR to CellComparatorImpl.COMPARATOR/CellComparatorImpl.META_CELL_COMPARATOR is handled. CellUtils is an util method that provides lot of APIs that helps to do compare, matching functionalities between two cells, or with a cell and a corrpesponding byte[] etc. Some of the APIs are internally used which will be cleaned up in a follow on JIRA HBASE-18995 .

      Description

      Based on discussions over in HBASE-18826 and HBASE-18183 it is better we expose CellComparator as a public interface so that it could be used in Region/Store interfaces to be exposed to CPs.
      Currently the Comparator is exposed in Region, STore and StoreFile. There is another discussion whether to expose it at all layers or only at Region. However since we are exposing this to CPs CellComparator being @Private is not the ideal way to do it. We have to change it to LimitedPrivate. But CellComparator has lot of additional methods which are internal (like where a Cell is compared with an incoming byte[] used in index comparsions etc).
      One way to expose is that as being done now in HBASE-18826 - by exposing the return type as Comparator<Cell>. But this is not powerful. It only allows to compare cells. So we try to expose an IA.LimitedPrivate interface that is more powerful and allows comparing individual cell components also.

      1. 18945-addendum-branch-2.txt
        2 kB
        Ted Yu
      2. HBASE-18495.patch
        351 kB
        ramkrishna.s.vasudevan
      3. HBASE-18945_2.patch
        40 kB
        ramkrishna.s.vasudevan
      4. HBASE-18945_3.patch
        281 kB
        ramkrishna.s.vasudevan
      5. HBASE-18945_4.patch
        285 kB
        ramkrishna.s.vasudevan
      6. HBASE-18945_5.patch
        280 kB
        ramkrishna.s.vasudevan
      7. HBASE-18945_6.patch
        294 kB
        ramkrishna.s.vasudevan
      8. HBASE-18945_6.patch
        277 kB
        ramkrishna.s.vasudevan
      9. HBASE-18945_7.patch
        294 kB
        ramkrishna.s.vasudevan

        Issue Links

          Activity

          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -
          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Ping Duo Zhang and Anoop Sam John .
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Move it as a sub task for HBASE-18169?

          Show
          anoop.hbase Anoop Sam John added a comment - Move it as a sub task for HBASE-18169 ?
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Ya did it. I forgot to make it as a sub-task at first.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Ya did it. I forgot to make it as a sub-task at first.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          So for this issue also shall we use the new CellCompartor interface's impl through out the code and only in the Store/REgion expose the interface with some minimal compare methods? The same philosophy as done for refactoring Region/HRegion and Store/HStore.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - So for this issue also shall we use the new CellCompartor interface's impl through out the code and only in the Store/REgion expose the interface with some minimal compare methods? The same philosophy as done for refactoring Region/HRegion and Store/HStore.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          +1
          Also see whether we need this getComparator from many CP exposed interfaces. We have it in Region, Store, StoreFile etc. May be from higher level alone is good enough?

          Show
          anoop.hbase Anoop Sam John added a comment - +1 Also see whether we need this getComparator from many CP exposed interfaces. We have it in Region, Store, StoreFile etc. May be from higher level alone is good enough?
          Hide
          chia7712 Chia-Ping Tsai added a comment -

          Should we purge the Serializable if we prepare to make CellComparator IA.Public?

          Show
          chia7712 Chia-Ping Tsai added a comment - Should we purge the Serializable if we prepare to make CellComparator IA.Public?
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          We have it in Region, Store, StoreFile etc.

          Reading the code I think for having Comparator in Store or not depends on what type of InternalScanner are we going to expose. How ever if the new interface is only exposing some restrcited but powerful APIs then it is still fine to expose in Store? So that CPs in case they need to filter out or do some processing on KVs can do it at the InternalScanner level?
          StoreFile level we may not need it IMHO.

          Should we purge the Serializable if we prepare to make CellComparator IA.Public?

          Is there any harm in having it Serializable? Am not very sure on this.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - We have it in Region, Store, StoreFile etc. Reading the code I think for having Comparator in Store or not depends on what type of InternalScanner are we going to expose. How ever if the new interface is only exposing some restrcited but powerful APIs then it is still fine to expose in Store? So that CPs in case they need to filter out or do some processing on KVs can do it at the InternalScanner level? StoreFile level we may not need it IMHO. Should we purge the Serializable if we prepare to make CellComparator IA.Public? Is there any harm in having it Serializable? Am not very sure on this.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          What I mean is the Comparator that we return from Store will be same as that we have in Region right? And again in StoreFile also. The comparator will be diff at Table level. ie. for META a special one. Thats it. That is why I was asking .. Any way not a big deal. Even if Store and StoreFile also expose it is just fine only.

          Should we purge the Serializable if we prepare to make CellComparator IA.Public?

          May be we can. We are not serializing the comparator object. In HFiles, we just write the comparator class name which is used

          Show
          anoop.hbase Anoop Sam John added a comment - What I mean is the Comparator that we return from Store will be same as that we have in Region right? And again in StoreFile also. The comparator will be diff at Table level. ie. for META a special one. Thats it. That is why I was asking .. Any way not a big deal. Even if Store and StoreFile also expose it is just fine only. Should we purge the Serializable if we prepare to make CellComparator IA.Public? May be we can. We are not serializing the comparator object. In HFiles, we just write the comparator class name which is used
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Even if Store and StoreFile also expose it is just fine only.

          Ya . But I was telling in terms of ease of use for CPs users. Anyway all the layers the compareator is going to be same except for the META region.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Even if Store and StoreFile also expose it is just fine only. Ya . But I was telling in terms of ease of use for CPs users. Anyway all the layers the compareator is going to be same except for the META region.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Exposes CellComparator as an interface and CellComparatorImpl as its impl. The hbase code will assume to work with CellComparatorImpl.
          Cellcomparator exposes -
          compare(Cell , Cell)
          compareRows(cell, cell)
          compareWithoutRow(cell, cell)
          compareFamilies(cell, cell)
          compareQualifiers(cell, cell)
          compareTimestamp(cell, cell)
          compareTimestamp(long, long)
          It does not expose compareType. I have changed the Region, Store and StoreFile to expose this new interface but not removed them for now. Will try QA.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Exposes CellComparator as an interface and CellComparatorImpl as its impl. The hbase code will assume to work with CellComparatorImpl. Cellcomparator exposes - compare(Cell , Cell) compareRows(cell, cell) compareWithoutRow(cell, cell) compareFamilies(cell, cell) compareQualifiers(cell, cell) compareTimestamp(cell, cell) compareTimestamp(long, long) It does not expose compareType. I have changed the Region, Store and StoreFile to expose this new interface but not removed them for now. Will try QA.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 20s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 60 new or modified test files.
          0 mvndep 0m 19s Maven dependency ordering for branch
          +1 mvninstall 4m 14s master passed
          +1 compile 3m 46s master passed
          +1 checkstyle 3m 0s master passed
          +1 mvneclipse 1m 54s master passed
          +1 shadedjars 8m 59s branch has no errors when building our shaded downstream artifacts.
          +1 findbugs 5m 41s master passed
          +1 javadoc 1m 57s master passed
          +1 scaladoc 1m 33s master passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 3m 13s the patch passed
          +1 compile 3m 1s the patch passed
          +1 javac 3m 1s the patch passed
          +1 scalac 3m 1s the patch passed
          +1 checkstyle 2m 39s the patch passed
          +1 mvneclipse 1m 45s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 shadedjars 3m 57s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 36m 34s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 6m 30s the patch passed
          +1 javadoc 1m 59s the patch passed
          +1 scaladoc 1m 33s the patch passed
          +1 unit 2m 16s hbase-common in the patch passed.
          +1 unit 2m 30s hbase-client in the patch passed.
          +1 unit 0m 24s hbase-prefix-tree in the patch passed.
          +1 unit 99m 56s hbase-server in the patch passed.
          +1 unit 8m 52s hbase-mapreduce in the patch passed.
          +1 unit 9m 15s hbase-backup in the patch passed.
          +1 unit 0m 30s hbase-it in the patch passed.
          +1 unit 4m 29s hbase-spark in the patch passed.
          +1 asflicense 1m 59s The patch does not generate ASF License warnings.
          216m 27s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18945
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12890668/HBASE-18495.patch
          Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc
          uname Linux 42938927f794 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / e2ad4c0
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/8969/artifact/patchprocess/whitespace-eol.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8969/testReport/
          modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8969/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 20s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 60 new or modified test files. 0 mvndep 0m 19s Maven dependency ordering for branch +1 mvninstall 4m 14s master passed +1 compile 3m 46s master passed +1 checkstyle 3m 0s master passed +1 mvneclipse 1m 54s master passed +1 shadedjars 8m 59s branch has no errors when building our shaded downstream artifacts. +1 findbugs 5m 41s master passed +1 javadoc 1m 57s master passed +1 scaladoc 1m 33s master passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 3m 13s the patch passed +1 compile 3m 1s the patch passed +1 javac 3m 1s the patch passed +1 scalac 3m 1s the patch passed +1 checkstyle 2m 39s the patch passed +1 mvneclipse 1m 45s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 shadedjars 3m 57s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 36m 34s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 6m 30s the patch passed +1 javadoc 1m 59s the patch passed +1 scaladoc 1m 33s the patch passed +1 unit 2m 16s hbase-common in the patch passed. +1 unit 2m 30s hbase-client in the patch passed. +1 unit 0m 24s hbase-prefix-tree in the patch passed. +1 unit 99m 56s hbase-server in the patch passed. +1 unit 8m 52s hbase-mapreduce in the patch passed. +1 unit 9m 15s hbase-backup in the patch passed. +1 unit 0m 30s hbase-it in the patch passed. +1 unit 4m 29s hbase-spark in the patch passed. +1 asflicense 1m 59s The patch does not generate ASF License warnings. 216m 27s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 JIRA Issue HBASE-18945 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12890668/HBASE-18495.patch Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc uname Linux 42938927f794 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / e2ad4c0 Default Java 1.8.0_144 findbugs v3.1.0-RC3 whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/8969/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/8969/testReport/ modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/8969/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stack stack added a comment -

          You have to strike @InterfaceStability.Evolving from CellComparator if you are making it public.

          Can you make the case in the description for this issue? This is a big change. Pawing back through JIRAs is a pain. I'm afraid I've missed key argument when just a JIRA number (do I have to read the whole JIRA or just a piece).

          Seems like the idea is to purge from CellComparator methods that depend on a particular Cell implementation? To take these internal, and only expose 'Comparator' functions in CellComparator? Seems good to me.

          CellComparatorImpl seems like a mouth full though and perhaps the methods should be elsewhere than in a CellComparatorImpl? In CellUtil ?

          CellComparator looks good though.

          Show
          stack stack added a comment - You have to strike @InterfaceStability.Evolving from CellComparator if you are making it public. Can you make the case in the description for this issue? This is a big change. Pawing back through JIRAs is a pain. I'm afraid I've missed key argument when just a JIRA number (do I have to read the whole JIRA or just a piece). Seems like the idea is to purge from CellComparator methods that depend on a particular Cell implementation? To take these internal, and only expose 'Comparator' functions in CellComparator? Seems good to me. CellComparatorImpl seems like a mouth full though and perhaps the methods should be elsewhere than in a CellComparatorImpl? In CellUtil ? CellComparator looks good though.
          Hide
          chia7712 Chia-Ping Tsai added a comment - - edited

          You have to strike @InterfaceStability.Evolving from CellComparator if you are making it public.

          I remember this (HBASE-17857). It seems the CellComparator is used for CP only? If so, is IA.LimitedPrivate better? How do users get CellComparator impl if it is exposed as IA.Public?

          public class CellComparatorImpl implements CellComparator {
            static final Log LOG = LogFactory.getLog(CellComparatorImpl.class);
            private static final long serialVersionUID = -8760041766259623329L;
          

          I guess the serialVersionUID can be removed also.

          Show
          chia7712 Chia-Ping Tsai added a comment - - edited You have to strike @InterfaceStability.Evolving from CellComparator if you are making it public. I remember this ( HBASE-17857 ). It seems the CellComparator is used for CP only? If so, is IA.LimitedPrivate better? How do users get CellComparator impl if it is exposed as IA.Public? public class CellComparatorImpl implements CellComparator { static final Log LOG = LogFactory.getLog(CellComparatorImpl.class); private static final long serialVersionUID = -8760041766259623329L; I guess the serialVersionUID can be removed also.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Thanks for the reviews.
          Oh. I think we have to make it IA.LimitedPrivate only and not private. Sorry my bad. I think I wanted that annotation and copied a wrong one.

          You have to strike @InterfaceStability.Evolving from CellComparator if you are making it public.

          As said above it has to LimitedPrivate. My mistake.

          CellComparatorImpl seems like a mouth full though and perhaps the methods should be elsewhere than in a CellComparatorImpl?

          Can change the name. I wanted to but did not get a good name.
          For the methods generally the matchingXXX and util methiods we wanted to add here. And all the compareXXX we thought of adding in CellComparator. So I have still keep that same. You want to change that too?

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Thanks for the reviews. Oh. I think we have to make it IA.LimitedPrivate only and not private. Sorry my bad. I think I wanted that annotation and copied a wrong one. You have to strike @InterfaceStability.Evolving from CellComparator if you are making it public. As said above it has to LimitedPrivate. My mistake. CellComparatorImpl seems like a mouth full though and perhaps the methods should be elsewhere than in a CellComparatorImpl? Can change the name. I wanted to but did not get a good name. For the methods generally the matchingXXX and util methiods we wanted to add here. And all the compareXXX we thought of adding in CellComparator. So I have still keep that same. You want to change that too?
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Can you make the case in the description for this issue? This is a big change. Pawing back through JIRAs is a pain. I'm afraid I've missed key argument when just a JIRA number (do I have to read the whole JIRA or just a piece).

          I have updated. Pls check if it is helping now.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Can you make the case in the description for this issue? This is a big change. Pawing back through JIRAs is a pain. I'm afraid I've missed key argument when just a JIRA number (do I have to read the whole JIRA or just a piece). I have updated. Pls check if it is helping now.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Can we name it as HCellComparator? Or SimpleCellComparator?

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Can we name it as HCellComparator? Or SimpleCellComparator?
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Can we some way keep the name of the impl class as CellComparator itself. So that we can reduce this patch size. Or else, the patch is touching almost all files!! We would need a new name for the interface then.

          Show
          anoop.hbase Anoop Sam John added a comment - Can we some way keep the name of the impl class as CellComparator itself. So that we can reduce this patch size. Or else, the patch is touching almost all files!! We would need a new name for the interface then.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Yes. That is what am trying now. Name the interfaces as SimpleCellComparator? Or CoprocessorCellComparator? And make the impl to be CellComparator only?

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Yes. That is what am trying now. Name the interfaces as SimpleCellComparator? Or CoprocessorCellComparator? And make the impl to be CellComparator only?
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          I finally thought let the existing CellComparator remain and will introduce HCellComparator as the interface? But this is orthogonal to Store/HStore where Store is exposed to CP and HStore is internal. Here it is the other way round.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - I finally thought let the existing CellComparator remain and will introduce HCellComparator as the interface? But this is orthogonal to Store/HStore where Store is exposed to CP and HStore is internal. Here it is the other way round.
          Hide
          chia7712 Chia-Ping Tsai added a comment -

          existing CellComparator remain and will introduce HCellComparator as the interface? But this is orthogonal to Store/HStore where Store is exposed to CP and HStore is internal.

          That is really weird...If avoiding the large patch is primary condition, the CoprocessorCellComparator is acceptable name. The CoprocessorRegionServerServices is already in our hbase.

          Show
          chia7712 Chia-Ping Tsai added a comment - existing CellComparator remain and will introduce HCellComparator as the interface? But this is orthogonal to Store/HStore where Store is exposed to CP and HStore is internal. That is really weird...If avoiding the large patch is primary condition, the CoprocessorCellComparator is acceptable name. The CoprocessorRegionServerServices is already in our hbase.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          That is really weird...If avoiding the large patch is primary condition,

          CoprocessorCellComparator for an interface is not right IMO. I thought CellComparator which is implemented and used every where seems to be a type of some comparator which is only for Coprocessors?
          So if we go with bigger patch only - any suggestions for the interface and impl class name?

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - That is really weird...If avoiding the large patch is primary condition, CoprocessorCellComparator for an interface is not right IMO. I thought CellComparator which is implemented and used every where seems to be a type of some comparator which is only for Coprocessors? So if we go with bigger patch only - any suggestions for the interface and impl class name?
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Renamed the new interface to CPCellComparator and the actual CellComparator implements it. Still am not very sure on the name. /suggestions welcome.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Renamed the new interface to CPCellComparator and the actual CellComparator implements it. Still am not very sure on the name. /suggestions welcome.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 13m 20s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 37s Maven dependency ordering for branch
          +1 mvninstall 4m 27s master passed
          +1 compile 1m 34s master passed
          +1 checkstyle 1m 24s master passed
          +1 mvneclipse 0m 52s master passed
          +1 shadedjars 6m 21s branch has no errors when building our shaded downstream artifacts.
          +1 findbugs 4m 27s master passed
          +1 javadoc 1m 16s master passed
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 1m 41s the patch passed
          +1 compile 1m 33s the patch passed
          +1 javac 1m 33s the patch passed
          +1 checkstyle 1m 25s the patch passed
          +1 mvneclipse 0m 58s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 4m 9s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 39m 27s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 4m 55s the patch passed
          +1 javadoc 1m 13s the patch passed
          +1 unit 2m 18s hbase-common in the patch passed.
          +1 unit 2m 36s hbase-client in the patch passed.
          +1 unit 99m 42s hbase-server in the patch passed.
          +1 unit 9m 37s hbase-mapreduce in the patch passed.
          +1 asflicense 1m 1s The patch does not generate ASF License warnings.
          199m 50s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18945
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12891314/HBASE-18945_2.patch
          Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 52c6d5727757 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 73b6bd0
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9026/testReport/
          modules C: hbase-common hbase-client hbase-server hbase-mapreduce U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9026/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 13m 20s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 37s Maven dependency ordering for branch +1 mvninstall 4m 27s master passed +1 compile 1m 34s master passed +1 checkstyle 1m 24s master passed +1 mvneclipse 0m 52s master passed +1 shadedjars 6m 21s branch has no errors when building our shaded downstream artifacts. +1 findbugs 4m 27s master passed +1 javadoc 1m 16s master passed 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 1m 41s the patch passed +1 compile 1m 33s the patch passed +1 javac 1m 33s the patch passed +1 checkstyle 1m 25s the patch passed +1 mvneclipse 0m 58s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 9s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 39m 27s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 4m 55s the patch passed +1 javadoc 1m 13s the patch passed +1 unit 2m 18s hbase-common in the patch passed. +1 unit 2m 36s hbase-client in the patch passed. +1 unit 99m 42s hbase-server in the patch passed. +1 unit 9m 37s hbase-mapreduce in the patch passed. +1 asflicense 1m 1s The patch does not generate ASF License warnings. 199m 50s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 JIRA Issue HBASE-18945 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12891314/HBASE-18945_2.patch Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 52c6d5727757 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 73b6bd0 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9026/testReport/ modules C: hbase-common hbase-client hbase-server hbase-mapreduce U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9026/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -
          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Ping Stack and Chia-Ping Tsai .
          Hide
          chia7712 Chia-Ping Tsai added a comment -

          Adding the prefix "CP" is ok to me, but the one thing i care is the prefix should be consistent in all cp-only class.

          Show
          chia7712 Chia-Ping Tsai added a comment - Adding the prefix "CP" is ok to me, but the one thing i care is the prefix should be consistent in all cp-only class.
          Hide
          Apache9 Duo Zhang added a comment -

          I think CellComparator as the interface name is better than CoprocessorCellComparator, but the name of the implementation class is a bit difficult to choose...

          Or that it is OK for us to also use the interface in our code other than the implementation class? I do not think we will provide more methods other than the exposed one in interface? The static methods could be moved to CellUtil I think. If we can avoid referencing the implementation class everywhere then I think it is OK to just call it CellComparatorImpl.

          Thanks.

          Show
          Apache9 Duo Zhang added a comment - I think CellComparator as the interface name is better than CoprocessorCellComparator, but the name of the implementation class is a bit difficult to choose... Or that it is OK for us to also use the interface in our code other than the implementation class? I do not think we will provide more methods other than the exposed one in interface? The static methods could be moved to CellUtil I think. If we can avoid referencing the implementation class everywhere then I think it is OK to just call it CellComparatorImpl. Thanks.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Or that it is OK for us to also use the interface in our code other than the implementation class? I do not think we will provide more methods other than the exposed one in interface?

          Same thing I also have .. Just wanted to comment that and see u already added it. Ya that make sense I think. When we really need to add some extra things in the impl and not expose via interface, we can change the core code parts to use/refer the impl rather than interface.

          Show
          anoop.hbase Anoop Sam John added a comment - Or that it is OK for us to also use the interface in our code other than the implementation class? I do not think we will provide more methods other than the exposed one in interface? Same thing I also have .. Just wanted to comment that and see u already added it. Ya that make sense I think. When we really need to add some extra things in the impl and not expose via interface, we can change the core code parts to use/refer the impl rather than interface.
          Hide
          chia7712 Chia-Ping Tsai added a comment - - edited

          If the compareKeyBasedOnColHint and compareKeyIgnoresMvcc are moved to CellUtil, it is ok to use the interface in our code base. I meant the both of methods should not exposed to CP user.

          Show
          chia7712 Chia-Ping Tsai added a comment - - edited If the compareKeyBasedOnColHint and compareKeyIgnoresMvcc are moved to CellUtil , it is ok to use the interface in our code base. I meant the both of methods should not exposed to CP user.
          Hide
          stack stack added a comment -

          I am arguing elsewhere AGAINST CoprocessorRegionServerServices; that instead it should be RegionServerServices (though it means lots of code churn). So, I'd argue against CPCellComparator for same reason. Agree the statics should be moved out to CellUtil .

          Show
          stack stack added a comment - I am arguing elsewhere AGAINST CoprocessorRegionServerServices; that instead it should be RegionServerServices (though it means lots of code churn). So, I'd argue against CPCellComparator for same reason. Agree the statics should be moved out to CellUtil .
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Patch based on comments. It is still bigger but the main changes are
          -> CellComparator is the interface.
          -> Impl class is CellComparatorImpl
          -> Most of the places it remains as CellComparator only.
          -> CellComparator#compareRow(Cell, byte[], offset, len) is now added to the interface itself as we have wide use of it in the code base and also it is useful when exposed to do a compare of rows of normal table and meta table. If you feel this is not need then it has to go to CellUtil.
          -> Many static APIs have been moved to CellUtil and also some new ones have been added.
          -> FixedFileTrailer has to be fixed for BC for files which have been serialized with the name of CellComparator.

          Will try QA.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Patch based on comments. It is still bigger but the main changes are -> CellComparator is the interface. -> Impl class is CellComparatorImpl -> Most of the places it remains as CellComparator only. -> CellComparator#compareRow(Cell, byte[], offset, len) is now added to the interface itself as we have wide use of it in the code base and also it is useful when exposed to do a compare of rows of normal table and meta table. If you feel this is not need then it has to go to CellUtil. -> Many static APIs have been moved to CellUtil and also some new ones have been added. -> FixedFileTrailer has to be fixed for BC for files which have been serialized with the name of CellComparator. Will try QA.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -
          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Here is the RB link https://reviews.apache.org/r/62926/
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          'ramkrishna vasudevan got a fish trophy!' - Interesting to see this in RB. It says the review number is a palindrome (62926)

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - 'ramkrishna vasudevan got a fish trophy!' - Interesting to see this in RB. It says the review number is a palindrome (62926)
          Hide
          chia7712 Chia-Ping Tsai added a comment -

          'ramkrishna vasudevan got a fish trophy!' - Interesting to see this in RB. It says the review number is a palindrome (62926)

          congrats

          Leave some comment in RB.

          Show
          chia7712 Chia-Ping Tsai added a comment - 'ramkrishna vasudevan got a fish trophy!' - Interesting to see this in RB. It says the review number is a palindrome (62926) congrats Leave some comment in RB.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Submit for QA. Retry.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Submit for QA. Retry.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 61 new or modified test files.
          0 mvndep 0m 17s Maven dependency ordering for branch
          +1 mvninstall 3m 35s master passed
          +1 compile 3m 1s master passed
          +1 checkstyle 2m 43s master passed
          +1 mvneclipse 1m 46s master passed
          +1 shadedjars 8m 37s branch has no errors when building our shaded downstream artifacts.
          +1 findbugs 6m 4s master passed
          +1 javadoc 2m 25s master passed
          +1 scaladoc 1m 51s master passed
          0 mvndep 0m 20s Maven dependency ordering for patch
          +1 mvninstall 3m 48s the patch passed
          +1 compile 3m 20s the patch passed
          +1 javac 3m 20s the patch passed
          +1 scalac 3m 20s the patch passed
          +1 checkstyle 2m 54s the patch passed
          +1 mvneclipse 1m 59s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 4m 7s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 40m 19s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 7m 4s the patch passed
          -1 javadoc 0m 16s hbase-common generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0)
          +1 scaladoc 1m 36s the patch passed
          +1 unit 2m 20s hbase-common in the patch passed.
          +1 unit 2m 36s hbase-client in the patch passed.
          +1 unit 0m 25s hbase-prefix-tree in the patch passed.
          -1 unit 107m 50s hbase-server in the patch failed.
          +1 unit 9m 1s hbase-mapreduce in the patch passed.
          +1 unit 8m 48s hbase-backup in the patch passed.
          +1 unit 0m 29s hbase-it in the patch passed.
          +1 unit 4m 20s hbase-spark in the patch passed.
          +1 asflicense 1m 54s The patch does not generate ASF License warnings.
          229m 11s



          Reason Tests
          Failed junit tests hadoop.hbase.regionserver.TestWalAndCompactingMemStoreFlush
            hadoop.hbase.client.TestAsyncTableGetMultiThreaded
            hadoop.hbase.regionserver.TestRecoveredEdits
            hadoop.hbase.regionserver.TestWALLockup
            hadoop.hbase.regionserver.TestHRegionReplayEvents
            hadoop.hbase.io.hfile.TestScannerFromBucketCache
            hadoop.hbase.regionserver.TestRegionIncrement
            hadoop.hbase.TestIOFencing
            hadoop.hbase.regionserver.TestFailedAppendAndSync
            hadoop.hbase.regionserver.TestStoreScanner
            hadoop.hbase.regionserver.TestMajorCompaction
          Timed out junit tests org.apache.hadoop.hbase.TestAcidGuarantees



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18945
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12891987/HBASE-18945_4.patch
          Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc
          uname Linux c98ab0ce42a5 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 883c358
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9091/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9091/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9091/testReport/
          modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9091/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 61 new or modified test files. 0 mvndep 0m 17s Maven dependency ordering for branch +1 mvninstall 3m 35s master passed +1 compile 3m 1s master passed +1 checkstyle 2m 43s master passed +1 mvneclipse 1m 46s master passed +1 shadedjars 8m 37s branch has no errors when building our shaded downstream artifacts. +1 findbugs 6m 4s master passed +1 javadoc 2m 25s master passed +1 scaladoc 1m 51s master passed 0 mvndep 0m 20s Maven dependency ordering for patch +1 mvninstall 3m 48s the patch passed +1 compile 3m 20s the patch passed +1 javac 3m 20s the patch passed +1 scalac 3m 20s the patch passed +1 checkstyle 2m 54s the patch passed +1 mvneclipse 1m 59s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 7s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 40m 19s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 7m 4s the patch passed -1 javadoc 0m 16s hbase-common generated 5 new + 0 unchanged - 0 fixed = 5 total (was 0) +1 scaladoc 1m 36s the patch passed +1 unit 2m 20s hbase-common in the patch passed. +1 unit 2m 36s hbase-client in the patch passed. +1 unit 0m 25s hbase-prefix-tree in the patch passed. -1 unit 107m 50s hbase-server in the patch failed. +1 unit 9m 1s hbase-mapreduce in the patch passed. +1 unit 8m 48s hbase-backup in the patch passed. +1 unit 0m 29s hbase-it in the patch passed. +1 unit 4m 20s hbase-spark in the patch passed. +1 asflicense 1m 54s The patch does not generate ASF License warnings. 229m 11s Reason Tests Failed junit tests hadoop.hbase.regionserver.TestWalAndCompactingMemStoreFlush   hadoop.hbase.client.TestAsyncTableGetMultiThreaded   hadoop.hbase.regionserver.TestRecoveredEdits   hadoop.hbase.regionserver.TestWALLockup   hadoop.hbase.regionserver.TestHRegionReplayEvents   hadoop.hbase.io.hfile.TestScannerFromBucketCache   hadoop.hbase.regionserver.TestRegionIncrement   hadoop.hbase.TestIOFencing   hadoop.hbase.regionserver.TestFailedAppendAndSync   hadoop.hbase.regionserver.TestStoreScanner   hadoop.hbase.regionserver.TestMajorCompaction Timed out junit tests org.apache.hadoop.hbase.TestAcidGuarantees Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 JIRA Issue HBASE-18945 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12891987/HBASE-18945_4.patch Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc uname Linux c98ab0ce42a5 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 883c358 Default Java 1.8.0_144 findbugs v3.1.0-RC3 javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9091/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9091/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9091/testReport/ modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9091/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Retry QA.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Retry QA.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Fixed some test case issues.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Fixed some test case issues.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 19s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 61 new or modified test files.
          0 mvndep 0m 30s Maven dependency ordering for branch
          +1 mvninstall 5m 24s master passed
          +1 compile 5m 3s master passed
          +1 checkstyle 3m 37s master passed
          +1 mvneclipse 2m 38s master passed
          +1 shadedjars 11m 12s branch has no errors when building our shaded downstream artifacts.
          +1 findbugs 8m 5s master passed
          +1 javadoc 2m 40s master passed
          +1 scaladoc 2m 14s master passed
          0 mvndep 0m 25s Maven dependency ordering for patch
          +1 mvninstall 4m 49s the patch passed
          +1 compile 4m 44s the patch passed
          +1 javac 4m 44s the patch passed
          +1 scalac 4m 44s the patch passed
          +1 checkstyle 3m 2s the patch passed
          +1 mvneclipse 1m 49s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 4m 2s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 37m 30s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 6m 35s the patch passed
          -1 javadoc 0m 15s hbase-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          -1 javadoc 0m 18s hbase-client generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
          +1 scaladoc 1m 33s the patch passed
          +1 unit 2m 16s hbase-common in the patch passed.
          +1 unit 2m 34s hbase-client in the patch passed.
          +1 unit 0m 25s hbase-prefix-tree in the patch passed.
          +1 unit 89m 2s hbase-server in the patch passed.
          +1 unit 8m 17s hbase-mapreduce in the patch passed.
          +1 unit 9m 4s hbase-backup in the patch passed.
          +1 unit 0m 29s hbase-it in the patch passed.
          +1 unit 4m 4s hbase-spark in the patch passed.
          +1 asflicense 1m 53s The patch does not generate ASF License warnings.
          218m 17s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18945
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892056/HBASE-18945_5.patch
          Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc
          uname Linux 37c6039347c6 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision master / 883c358
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9099/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9099/artifact/patchprocess/diff-javadoc-javadoc-hbase-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9099/testReport/
          modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9099/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 61 new or modified test files. 0 mvndep 0m 30s Maven dependency ordering for branch +1 mvninstall 5m 24s master passed +1 compile 5m 3s master passed +1 checkstyle 3m 37s master passed +1 mvneclipse 2m 38s master passed +1 shadedjars 11m 12s branch has no errors when building our shaded downstream artifacts. +1 findbugs 8m 5s master passed +1 javadoc 2m 40s master passed +1 scaladoc 2m 14s master passed 0 mvndep 0m 25s Maven dependency ordering for patch +1 mvninstall 4m 49s the patch passed +1 compile 4m 44s the patch passed +1 javac 4m 44s the patch passed +1 scalac 4m 44s the patch passed +1 checkstyle 3m 2s the patch passed +1 mvneclipse 1m 49s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 2s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 37m 30s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 6m 35s the patch passed -1 javadoc 0m 15s hbase-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) -1 javadoc 0m 18s hbase-client generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2) +1 scaladoc 1m 33s the patch passed +1 unit 2m 16s hbase-common in the patch passed. +1 unit 2m 34s hbase-client in the patch passed. +1 unit 0m 25s hbase-prefix-tree in the patch passed. +1 unit 89m 2s hbase-server in the patch passed. +1 unit 8m 17s hbase-mapreduce in the patch passed. +1 unit 9m 4s hbase-backup in the patch passed. +1 unit 0m 29s hbase-it in the patch passed. +1 unit 4m 4s hbase-spark in the patch passed. +1 asflicense 1m 53s The patch does not generate ASF License warnings. 218m 17s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 JIRA Issue HBASE-18945 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892056/HBASE-18945_5.patch Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc uname Linux 37c6039347c6 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / 883c358 Default Java 1.8.0_144 findbugs v3.1.0-RC3 javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9099/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9099/artifact/patchprocess/diff-javadoc-javadoc-hbase-client.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9099/testReport/ modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9099/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Updated patch. Fixed the java doc comments. All tests passes now.
          Ping for comments/+1.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Updated patch. Fixed the java doc comments. All tests passes now. Ping for comments/+1.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 63 new or modified test files.
          0 mvndep 0m 29s Maven dependency ordering for branch
          +1 mvninstall 3m 39s master passed
          +1 compile 3m 0s master passed
          +1 checkstyle 2m 41s master passed
          +1 mvneclipse 1m 47s master passed
          +1 shadedjars 8m 24s branch has no errors when building our shaded downstream artifacts.
          +1 findbugs 5m 23s master passed
          +1 javadoc 1m 57s master passed
          +1 scaladoc 1m 33s master passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          -1 mvninstall 0m 12s hbase-common in the patch failed.
          -1 mvninstall 0m 14s hbase-client in the patch failed.
          -1 mvninstall 0m 10s hbase-prefix-tree in the patch failed.
          -1 mvninstall 0m 23s hbase-server in the patch failed.
          -1 mvninstall 0m 14s hbase-mapreduce in the patch failed.
          -1 mvninstall 0m 13s hbase-backup in the patch failed.
          -1 mvninstall 0m 16s hbase-it in the patch failed.
          -1 mvninstall 0m 22s hbase-spark in the patch failed.
          -1 compile 0m 12s hbase-common in the patch failed.
          -1 compile 0m 15s hbase-client in the patch failed.
          -1 compile 0m 10s hbase-prefix-tree in the patch failed.
          -1 compile 0m 23s hbase-server in the patch failed.
          -1 compile 0m 14s hbase-mapreduce in the patch failed.
          -1 compile 0m 14s hbase-backup in the patch failed.
          -1 compile 0m 16s hbase-it in the patch failed.
          -1 compile 0m 22s hbase-spark in the patch failed.
          -1 javac 0m 12s hbase-common in the patch failed.
          -1 javac 0m 15s hbase-client in the patch failed.
          -1 javac 0m 10s hbase-prefix-tree in the patch failed.
          -1 javac 0m 23s hbase-server in the patch failed.
          -1 javac 0m 14s hbase-mapreduce in the patch failed.
          -1 javac 0m 14s hbase-backup in the patch failed.
          -1 javac 0m 16s hbase-it in the patch failed.
          -1 javac 0m 22s hbase-spark in the patch failed.
          -1 scalac 0m 12s hbase-common in the patch failed.
          -1 scalac 0m 15s hbase-client in the patch failed.
          -1 scalac 0m 10s hbase-prefix-tree in the patch failed.
          -1 scalac 0m 23s hbase-server in the patch failed.
          -1 scalac 0m 14s hbase-mapreduce in the patch failed.
          -1 scalac 0m 14s hbase-backup in the patch failed.
          -1 scalac 0m 16s hbase-it in the patch failed.
          -1 scalac 0m 22s hbase-spark in the patch failed.
          +1 checkstyle 2m 38s the patch passed
          +1 mvneclipse 1m 43s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 shadedjars 0m 52s patch has 54 errors when building our shaded downstream artifacts.
          -1 hadoopcheck 1m 31s The patch causes 54 errors with Hadoop v2.6.1.
          -1 hadoopcheck 2m 12s The patch causes 54 errors with Hadoop v2.6.2.
          -1 hadoopcheck 2m 51s The patch causes 54 errors with Hadoop v2.6.3.
          -1 hadoopcheck 3m 30s The patch causes 54 errors with Hadoop v2.6.4.
          -1 hadoopcheck 4m 10s The patch causes 54 errors with Hadoop v2.6.5.
          -1 hadoopcheck 4m 50s The patch causes 54 errors with Hadoop v2.7.1.
          -1 hadoopcheck 5m 29s The patch causes 54 errors with Hadoop v2.7.2.
          -1 hadoopcheck 6m 8s The patch causes 54 errors with Hadoop v2.7.3.
          -1 hadoopcheck 6m 49s The patch causes 54 errors with Hadoop v3.0.0-alpha4.
          -1 findbugs 0m 12s hbase-common in the patch failed.
          -1 findbugs 0m 15s hbase-client in the patch failed.
          -1 findbugs 0m 9s hbase-prefix-tree in the patch failed.
          -1 findbugs 0m 22s hbase-server in the patch failed.
          -1 findbugs 0m 15s hbase-mapreduce in the patch failed.
          -1 findbugs 0m 13s hbase-backup in the patch failed.
          -1 findbugs 0m 22s hbase-spark in the patch failed.
          -1 javadoc 0m 15s hbase-common generated 27 new + 0 unchanged - 0 fixed = 27 total (was 0)
          -1 javadoc 0m 17s hbase-client generated 6 new + 2 unchanged - 0 fixed = 8 total (was 2)
          -1 javadoc 0m 9s hbase-prefix-tree generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          -1 javadoc 0m 27s hbase-server generated 23 new + 0 unchanged - 0 fixed = 23 total (was 0)
          -1 javadoc 0m 13s hbase-mapreduce generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
          -1 scaladoc 0m 24s hbase-spark generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          -1 unit 0m 12s hbase-common in the patch failed.
          -1 unit 0m 14s hbase-client in the patch failed.
          -1 unit 0m 10s hbase-prefix-tree in the patch failed.
          -1 unit 0m 22s hbase-server in the patch failed.
          -1 unit 0m 14s hbase-mapreduce in the patch failed.
          -1 unit 0m 14s hbase-backup in the patch failed.
          -1 unit 0m 16s hbase-it in the patch failed.
          -1 unit 0m 22s hbase-spark in the patch failed.
          +1 asflicense 0m 52s The patch does not generate ASF License warnings.
          49m 55s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18945
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892332/HBASE-18945_6.patch
          Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc
          uname Linux c8da787979fc 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 83af5f2
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-common.txt
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-client.txt
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-prefix-tree.txt
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-server.txt
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-mapreduce.txt
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-backup.txt
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-it.txt
          mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-spark.txt
          compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-common.txt
          compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-client.txt
          compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-prefix-tree.txt
          compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-server.txt
          compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-mapreduce.txt
          compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-backup.txt
          compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-it.txt
          compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-spark.txt
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-common.txt
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-client.txt
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-prefix-tree.txt
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-server.txt
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-mapreduce.txt
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-backup.txt
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-it.txt
          javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-spark.txt
          scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-common.txt
          scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-client.txt
          scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-prefix-tree.txt
          scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-server.txt
          scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-mapreduce.txt
          scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-backup.txt
          scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-it.txt
          scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-spark.txt
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-common.txt
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-client.txt
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-prefix-tree.txt
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-server.txt
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-mapreduce.txt
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-backup.txt
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-spark.txt
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-client.txt
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-prefix-tree.txt
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-mapreduce.txt
          scaladoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-scaladoc-scaladoc-hbase-spark.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-common.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-client.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-prefix-tree.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-server.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-mapreduce.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-backup.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-it.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-spark.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9128/testReport/
          modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9128/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 63 new or modified test files. 0 mvndep 0m 29s Maven dependency ordering for branch +1 mvninstall 3m 39s master passed +1 compile 3m 0s master passed +1 checkstyle 2m 41s master passed +1 mvneclipse 1m 47s master passed +1 shadedjars 8m 24s branch has no errors when building our shaded downstream artifacts. +1 findbugs 5m 23s master passed +1 javadoc 1m 57s master passed +1 scaladoc 1m 33s master passed 0 mvndep 0m 18s Maven dependency ordering for patch -1 mvninstall 0m 12s hbase-common in the patch failed. -1 mvninstall 0m 14s hbase-client in the patch failed. -1 mvninstall 0m 10s hbase-prefix-tree in the patch failed. -1 mvninstall 0m 23s hbase-server in the patch failed. -1 mvninstall 0m 14s hbase-mapreduce in the patch failed. -1 mvninstall 0m 13s hbase-backup in the patch failed. -1 mvninstall 0m 16s hbase-it in the patch failed. -1 mvninstall 0m 22s hbase-spark in the patch failed. -1 compile 0m 12s hbase-common in the patch failed. -1 compile 0m 15s hbase-client in the patch failed. -1 compile 0m 10s hbase-prefix-tree in the patch failed. -1 compile 0m 23s hbase-server in the patch failed. -1 compile 0m 14s hbase-mapreduce in the patch failed. -1 compile 0m 14s hbase-backup in the patch failed. -1 compile 0m 16s hbase-it in the patch failed. -1 compile 0m 22s hbase-spark in the patch failed. -1 javac 0m 12s hbase-common in the patch failed. -1 javac 0m 15s hbase-client in the patch failed. -1 javac 0m 10s hbase-prefix-tree in the patch failed. -1 javac 0m 23s hbase-server in the patch failed. -1 javac 0m 14s hbase-mapreduce in the patch failed. -1 javac 0m 14s hbase-backup in the patch failed. -1 javac 0m 16s hbase-it in the patch failed. -1 javac 0m 22s hbase-spark in the patch failed. -1 scalac 0m 12s hbase-common in the patch failed. -1 scalac 0m 15s hbase-client in the patch failed. -1 scalac 0m 10s hbase-prefix-tree in the patch failed. -1 scalac 0m 23s hbase-server in the patch failed. -1 scalac 0m 14s hbase-mapreduce in the patch failed. -1 scalac 0m 14s hbase-backup in the patch failed. -1 scalac 0m 16s hbase-it in the patch failed. -1 scalac 0m 22s hbase-spark in the patch failed. +1 checkstyle 2m 38s the patch passed +1 mvneclipse 1m 43s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 shadedjars 0m 52s patch has 54 errors when building our shaded downstream artifacts. -1 hadoopcheck 1m 31s The patch causes 54 errors with Hadoop v2.6.1. -1 hadoopcheck 2m 12s The patch causes 54 errors with Hadoop v2.6.2. -1 hadoopcheck 2m 51s The patch causes 54 errors with Hadoop v2.6.3. -1 hadoopcheck 3m 30s The patch causes 54 errors with Hadoop v2.6.4. -1 hadoopcheck 4m 10s The patch causes 54 errors with Hadoop v2.6.5. -1 hadoopcheck 4m 50s The patch causes 54 errors with Hadoop v2.7.1. -1 hadoopcheck 5m 29s The patch causes 54 errors with Hadoop v2.7.2. -1 hadoopcheck 6m 8s The patch causes 54 errors with Hadoop v2.7.3. -1 hadoopcheck 6m 49s The patch causes 54 errors with Hadoop v3.0.0-alpha4. -1 findbugs 0m 12s hbase-common in the patch failed. -1 findbugs 0m 15s hbase-client in the patch failed. -1 findbugs 0m 9s hbase-prefix-tree in the patch failed. -1 findbugs 0m 22s hbase-server in the patch failed. -1 findbugs 0m 15s hbase-mapreduce in the patch failed. -1 findbugs 0m 13s hbase-backup in the patch failed. -1 findbugs 0m 22s hbase-spark in the patch failed. -1 javadoc 0m 15s hbase-common generated 27 new + 0 unchanged - 0 fixed = 27 total (was 0) -1 javadoc 0m 17s hbase-client generated 6 new + 2 unchanged - 0 fixed = 8 total (was 2) -1 javadoc 0m 9s hbase-prefix-tree generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) -1 javadoc 0m 27s hbase-server generated 23 new + 0 unchanged - 0 fixed = 23 total (was 0) -1 javadoc 0m 13s hbase-mapreduce generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) -1 scaladoc 0m 24s hbase-spark generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) -1 unit 0m 12s hbase-common in the patch failed. -1 unit 0m 14s hbase-client in the patch failed. -1 unit 0m 10s hbase-prefix-tree in the patch failed. -1 unit 0m 22s hbase-server in the patch failed. -1 unit 0m 14s hbase-mapreduce in the patch failed. -1 unit 0m 14s hbase-backup in the patch failed. -1 unit 0m 16s hbase-it in the patch failed. -1 unit 0m 22s hbase-spark in the patch failed. +1 asflicense 0m 52s The patch does not generate ASF License warnings. 49m 55s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 JIRA Issue HBASE-18945 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892332/HBASE-18945_6.patch Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc uname Linux c8da787979fc 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 83af5f2 Default Java 1.8.0_144 findbugs v3.1.0-RC3 mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-common.txt mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-client.txt mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-prefix-tree.txt mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-server.txt mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-mapreduce.txt mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-backup.txt mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-it.txt mvninstall https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-mvninstall-hbase-spark.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-common.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-client.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-prefix-tree.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-server.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-mapreduce.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-backup.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-it.txt compile https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-spark.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-common.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-client.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-prefix-tree.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-server.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-mapreduce.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-backup.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-it.txt javac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-spark.txt scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-common.txt scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-client.txt scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-prefix-tree.txt scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-server.txt scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-mapreduce.txt scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-backup.txt scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-it.txt scalac https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-compile-hbase-spark.txt findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-common.txt findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-client.txt findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-prefix-tree.txt findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-server.txt findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-mapreduce.txt findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-backup.txt findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-findbugs-hbase-spark.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-client.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-prefix-tree.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-server.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-javadoc-javadoc-hbase-mapreduce.txt scaladoc https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/diff-scaladoc-scaladoc-hbase-spark.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-common.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-client.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-prefix-tree.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-mapreduce.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-backup.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-it.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9128/artifact/patchprocess/patch-unit-hbase-spark.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9128/testReport/ modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9128/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Oh sorry. I did not add the new file while updating the patch.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Oh sorry. I did not add the new file while updating the patch.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Patch that avoid compilation error.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Patch that avoid compilation error.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -
          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Chia-Ping Tsai , Duo Zhang , Stack , Anoop Sam John Ping for reviews.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 63 new or modified test files.
          0 mvndep 0m 32s Maven dependency ordering for branch
          +1 mvninstall 4m 15s master passed
          +1 compile 3m 37s master passed
          +1 checkstyle 2m 49s master passed
          +1 mvneclipse 1m 50s master passed
          +1 shadedjars 8m 51s branch has no errors when building our shaded downstream artifacts.
          +1 findbugs 6m 6s master passed
          +1 javadoc 2m 4s master passed
          +1 scaladoc 1m 47s master passed
          0 mvndep 0m 21s Maven dependency ordering for patch
          +1 mvninstall 3m 28s the patch passed
          +1 compile 3m 12s the patch passed
          +1 javac 3m 12s the patch passed
          +1 scalac 3m 12s the patch passed
          +1 checkstyle 2m 51s the patch passed
          +1 mvneclipse 2m 6s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 4m 12s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 39m 7s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 6m 46s the patch passed
          +1 javadoc 2m 4s the patch passed
          +1 scaladoc 1m 35s the patch passed
          +1 unit 2m 18s hbase-common in the patch passed.
          +1 unit 2m 31s hbase-client in the patch passed.
          +1 unit 0m 26s hbase-prefix-tree in the patch passed.
          +1 unit 97m 31s hbase-server in the patch passed.
          +1 unit 12m 37s hbase-mapreduce in the patch passed.
          +1 unit 10m 10s hbase-backup in the patch passed.
          +1 unit 0m 39s hbase-it in the patch passed.
          +1 unit 5m 14s hbase-spark in the patch passed.
          +1 asflicense 2m 14s The patch does not generate ASF License warnings.
          224m 35s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18945
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892337/HBASE-18945_6.patch
          Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc
          uname Linux 3a679750945c 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 83af5f2
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9129/testReport/
          modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9129/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 63 new or modified test files. 0 mvndep 0m 32s Maven dependency ordering for branch +1 mvninstall 4m 15s master passed +1 compile 3m 37s master passed +1 checkstyle 2m 49s master passed +1 mvneclipse 1m 50s master passed +1 shadedjars 8m 51s branch has no errors when building our shaded downstream artifacts. +1 findbugs 6m 6s master passed +1 javadoc 2m 4s master passed +1 scaladoc 1m 47s master passed 0 mvndep 0m 21s Maven dependency ordering for patch +1 mvninstall 3m 28s the patch passed +1 compile 3m 12s the patch passed +1 javac 3m 12s the patch passed +1 scalac 3m 12s the patch passed +1 checkstyle 2m 51s the patch passed +1 mvneclipse 2m 6s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 12s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 39m 7s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 6m 46s the patch passed +1 javadoc 2m 4s the patch passed +1 scaladoc 1m 35s the patch passed +1 unit 2m 18s hbase-common in the patch passed. +1 unit 2m 31s hbase-client in the patch passed. +1 unit 0m 26s hbase-prefix-tree in the patch passed. +1 unit 97m 31s hbase-server in the patch passed. +1 unit 12m 37s hbase-mapreduce in the patch passed. +1 unit 10m 10s hbase-backup in the patch passed. +1 unit 0m 39s hbase-it in the patch passed. +1 unit 5m 14s hbase-spark in the patch passed. +1 asflicense 2m 14s The patch does not generate ASF License warnings. 224m 35s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 JIRA Issue HBASE-18945 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892337/HBASE-18945_6.patch Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc uname Linux 3a679750945c 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 83af5f2 Default Java 1.8.0_144 findbugs v3.1.0-RC3 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9129/testReport/ modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9129/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          QA is green. Ping !!!

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - QA is green. Ping !!!
          Hide
          Apache9 Duo Zhang added a comment -

          Left a few comments on RB. Overall LGTM. +1.

          Show
          Apache9 Duo Zhang added a comment - Left a few comments on RB. Overall LGTM. +1.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Updated patch as per RB comments from Duo Zhang. Will commit later in the evening unless objections.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Updated patch as per RB comments from Duo Zhang . Will commit later in the evening unless objections.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 63 new or modified test files.
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 3m 48s master passed
          +1 compile 3m 13s master passed
          +1 checkstyle 2m 46s master passed
          +1 mvneclipse 1m 46s master passed
          +1 shadedjars 8m 28s branch has no errors when building our shaded downstream artifacts.
          +1 findbugs 5m 59s master passed
          +1 javadoc 2m 3s master passed
          +1 scaladoc 1m 34s master passed
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 3m 31s the patch passed
          +1 compile 3m 13s the patch passed
          +1 javac 3m 13s the patch passed
          +1 scalac 3m 13s the patch passed
          +1 checkstyle 2m 47s the patch passed
          +1 mvneclipse 1m 48s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 3m 51s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 37m 45s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 8m 42s the patch passed
          +1 javadoc 2m 35s the patch passed
          +1 scaladoc 1m 52s the patch passed
          +1 unit 2m 34s hbase-common in the patch passed.
          +1 unit 2m 59s hbase-client in the patch passed.
          +1 unit 0m 33s hbase-prefix-tree in the patch passed.
          -1 unit 101m 9s hbase-server in the patch failed.
          +1 unit 17m 1s hbase-mapreduce in the patch passed.
          +1 unit 10m 58s hbase-backup in the patch passed.
          +1 unit 0m 45s hbase-it in the patch passed.
          +1 unit 5m 9s hbase-spark in the patch passed.
          +1 asflicense 2m 32s The patch does not generate ASF License warnings.
          233m 51s



          Reason Tests
          Timed out junit tests org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId
            org.apache.hadoop.hbase.master.TestMasterFailover
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
            org.apache.hadoop.hbase.master.TestGetInfoPort
            org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster
            org.apache.hadoop.hbase.master.TestMasterMetrics
            org.apache.hadoop.hbase.master.TestTableStateManager
            org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner
            org.apache.hadoop.hbase.master.TestSplitLogManager
            org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport
            org.apache.hadoop.hbase.master.TestRollingRestart
            org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer
            org.apache.hadoop.hbase.master.TestDistributedLogSplitting
            org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions
            org.apache.hadoop.hbase.master.TestMasterFileSystem



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123
          JIRA Issue HBASE-18945
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892546/HBASE-18945_7.patch
          Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc
          uname Linux dc5a764c4863 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 9a27ac8
          Default Java 1.8.0_144
          findbugs v3.1.0-RC3
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9152/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9152/testReport/
          modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9152/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 63 new or modified test files. 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 3m 48s master passed +1 compile 3m 13s master passed +1 checkstyle 2m 46s master passed +1 mvneclipse 1m 46s master passed +1 shadedjars 8m 28s branch has no errors when building our shaded downstream artifacts. +1 findbugs 5m 59s master passed +1 javadoc 2m 3s master passed +1 scaladoc 1m 34s master passed 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 3m 31s the patch passed +1 compile 3m 13s the patch passed +1 javac 3m 13s the patch passed +1 scalac 3m 13s the patch passed +1 checkstyle 2m 47s the patch passed +1 mvneclipse 1m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 3m 51s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 37m 45s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 8m 42s the patch passed +1 javadoc 2m 35s the patch passed +1 scaladoc 1m 52s the patch passed +1 unit 2m 34s hbase-common in the patch passed. +1 unit 2m 59s hbase-client in the patch passed. +1 unit 0m 33s hbase-prefix-tree in the patch passed. -1 unit 101m 9s hbase-server in the patch failed. +1 unit 17m 1s hbase-mapreduce in the patch passed. +1 unit 10m 58s hbase-backup in the patch passed. +1 unit 0m 45s hbase-it in the patch passed. +1 unit 5m 9s hbase-spark in the patch passed. +1 asflicense 2m 32s The patch does not generate ASF License warnings. 233m 51s Reason Tests Timed out junit tests org.apache.hadoop.hbase.master.TestGetLastFlushedSequenceId   org.apache.hadoop.hbase.master.TestMasterFailover   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer2   org.apache.hadoop.hbase.master.TestGetInfoPort   org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster   org.apache.hadoop.hbase.master.TestMasterMetrics   org.apache.hadoop.hbase.master.TestTableStateManager   org.apache.hadoop.hbase.master.cleaner.TestReplicationZKNodeCleaner   org.apache.hadoop.hbase.master.TestSplitLogManager   org.apache.hadoop.hbase.master.balancer.TestFavoredNodeTableImport   org.apache.hadoop.hbase.master.TestRollingRestart   org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer   org.apache.hadoop.hbase.master.TestDistributedLogSplitting   org.apache.hadoop.hbase.master.balancer.TestRegionsOnMasterOptions   org.apache.hadoop.hbase.master.TestMasterFileSystem Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:5d60123 JIRA Issue HBASE-18945 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12892546/HBASE-18945_7.patch Optional Tests asflicense shadedjars javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile scalac scaladoc uname Linux dc5a764c4863 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 9a27ac8 Default Java 1.8.0_144 findbugs v3.1.0-RC3 unit https://builds.apache.org/job/PreCommit-HBASE-Build/9152/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9152/testReport/ modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-backup hbase-it hbase-spark U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9152/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Pushed to master and branch-2. Thanks for all the reviews. The latest failures are time out related issues.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Pushed to master and branch-2. Thanks for all the reviews. The latest failures are time out related issues.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Jenkins build for 2.0 fails with:

          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) on project hbase-mapreduce: Compilation failure: Compilation failure:
          [ERROR] /home/jenkins/jenkins-slave/workspace/HBase-2.0/a3159d73/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java:[167,28] package CellComparator does not exist
          [ERROR] /home/jenkins/jenkins-slave/workspace/HBase-2.0/a3159d73/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/KeyValueSortReducer.java:[45,57] cannot find symbol
          [ERROR] symbol:   variable COMPARATOR
          [ERROR] location: interface org.apache.hadoop.hbase.CellComparator
          
          Show
          yuzhihong@gmail.com Ted Yu added a comment - Jenkins build for 2.0 fails with: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile ( default -compile) on project hbase-mapreduce: Compilation failure: Compilation failure: [ERROR] /home/jenkins/jenkins-slave/workspace/HBase-2.0/a3159d73/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java:[167,28] package CellComparator does not exist [ERROR] /home/jenkins/jenkins-slave/workspace/HBase-2.0/a3159d73/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/KeyValueSortReducer.java:[45,57] cannot find symbol [ERROR] symbol: variable COMPARATOR [ERROR] location: interface org.apache.hadoop.hbase.CellComparator
          Hide
          elserj Josh Elser added a comment -

          Ted Yu, why didn't PreCommit catch this?

          Show
          elserj Josh Elser added a comment - Ted Yu , why didn't PreCommit catch this?
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Ram didn't run patch for branch-2 thru QA.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Ram didn't run patch for branch-2 thru QA.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-2.0 #706 (See https://builds.apache.org/job/HBase-2.0/706/)
          HBASE-18945 Make a IA.LimitedPrivate interface for CellComparator - (tedyu: rev 998bc32ec9bd89d61a0d918b2955f84772492f03)

          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/KeyValueSortReducer.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #706 (See https://builds.apache.org/job/HBase-2.0/706/ ) HBASE-18945 Make a IA.LimitedPrivate interface for CellComparator - (tedyu: rev 998bc32ec9bd89d61a0d918b2955f84772492f03) (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/KeyValueSortReducer.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
          Hide
          stack stack added a comment -

          I took a look at the patch. Seems good. What is the philosophy regards when CellComparator vs CellComparatorImpl vs CellUtils? Can you stick it in release note?

          It seems like its use CCI internally which is fine. Also it seems like CellUtils methods take a CellComparator which seems good too. Main concern is that we have different CellComparator implemenations – one for Meta Table Rows and another for user-table Rows – and you have to use the right one else you get wonky results. Seems like you are doing right thing but just checking.

          Thanks ramkrishna.s.vasudevan

          Show
          stack stack added a comment - I took a look at the patch. Seems good. What is the philosophy regards when CellComparator vs CellComparatorImpl vs CellUtils? Can you stick it in release note? It seems like its use CCI internally which is fine. Also it seems like CellUtils methods take a CellComparator which seems good too. Main concern is that we have different CellComparator implemenations – one for Meta Table Rows and another for user-table Rows – and you have to use the right one else you get wonky results. Seems like you are doing right thing but just checking. Thanks ramkrishna.s.vasudevan
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Ted Yu
          Thanks for the addendum. I was away the whole day and did not have access to my laptop. Sorry for the trouble.

          I took a look at the patch. Seems good. What is the philosophy regards when CellComparator vs CellComparatorImpl vs CellUtils? Can you stick it in release note?

          Yes will do it.
          We already have CellUtil clean up JIRa - HBASE-18995.

          Main concern is that we have different CellComparator implemenations – one for Meta Table Rows and another for user-table Rows – and you have to use the right one else you get wonky results. Seems like you are doing right thing but just checking.

          Yes it has been taken care of . Generally the REgion and Store uses the CellComparator and that is where we will get MetaCellcomparator and the generic comparator. That place works as usual and infact we are continuing with CellComparator only as a reference.
          In the layers of ColumnTrackers there we are passing CellComparatorImpl.COMPARATOR because there is no rows involved. But Chia-Ping Tsai has raised another issue to continue with CellComparator that is passed from ScanInfo so that we don't have this static references as far as possible.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Ted Yu Thanks for the addendum. I was away the whole day and did not have access to my laptop. Sorry for the trouble. I took a look at the patch. Seems good. What is the philosophy regards when CellComparator vs CellComparatorImpl vs CellUtils? Can you stick it in release note? Yes will do it. We already have CellUtil clean up JIRa - HBASE-18995 . Main concern is that we have different CellComparator implemenations – one for Meta Table Rows and another for user-table Rows – and you have to use the right one else you get wonky results. Seems like you are doing right thing but just checking. Yes it has been taken care of . Generally the REgion and Store uses the CellComparator and that is where we will get MetaCellcomparator and the generic comparator. That place works as usual and infact we are continuing with CellComparator only as a reference. In the layers of ColumnTrackers there we are passing CellComparatorImpl.COMPARATOR because there is no rows involved. But Chia-Ping Tsai has raised another issue to continue with CellComparator that is passed from ScanInfo so that we don't have this static references as far as possible.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Stack
          You are good with this release note here?

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Stack You are good with this release note here?
          Hide
          busbey Sean Busbey added a comment -

          I think this breaks our ability to do rolling upgrade come 2.0.0-beta-*

          diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java
          index d82dd170dd..115302e9d1 100644
          --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java
          +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java
          @@ -28,7 +28,8 @@ import java.nio.ByteBuffer;
           
           import org.apache.hadoop.fs.FSDataInputStream;
           import org.apache.hadoop.hbase.CellComparator;
          -import org.apache.hadoop.hbase.CellComparator.MetaCellComparator;
          +import org.apache.hadoop.hbase.CellComparatorImpl;
          +import org.apache.hadoop.hbase.CellComparatorImpl.MetaCellComparator;
           import org.apache.hadoop.hbase.KeyValue;
           import org.apache.yetus.audience.InterfaceAudience;
           import org.apache.hadoop.hbase.io.compress.Compression;
          @@ -109,7 +110,7 @@ public class FixedFileTrailer {
           
             /** Raw key comparator class name in version 3 */
             // We could write the actual class name from 2.0 onwards and handle BC
          -  private String comparatorClassName = CellComparator.COMPARATOR.getClass().getName();
          +  private String comparatorClassName = CellComparatorImpl.COMPARATOR.getClass().getName();
           
             /** The encryption key */
             private byte[] encryptionKey;
          @@ -559,11 +560,15 @@ public class FixedFileTrailer {
             private static Class<? extends CellComparator> getComparatorClass(String comparatorClassName)
                 throws IOException {
               Class<? extends CellComparator> comparatorKlass;
          +    // for BC
               if (comparatorClassName.equals(KeyValue.COMPARATOR.getLegacyKeyComparatorName())
          -        || comparatorClassName.equals(KeyValue.COMPARATOR.getClass().getName())) {
          -      comparatorKlass = CellComparator.class;
          +        || comparatorClassName.equals(KeyValue.COMPARATOR.getClass().getName())
          +        || (comparatorClassName.equals("org.apache.hadoop.hbase.CellComparator"))) {
          +      comparatorKlass = CellComparatorImpl.class;
               } else if (comparatorClassName.equals(KeyValue.META_COMPARATOR.getLegacyKeyComparatorName())
          -        || comparatorClassName.equals(KeyValue.META_COMPARATOR.getClass().getName())) {
          +        || comparatorClassName.equals(KeyValue.META_COMPARATOR.getClass().getName())
          +        || (comparatorClassName
          +            .equals("org.apache.hadoop.hbase.CellComparator$MetaCellComparator"))) {
                 comparatorKlass = MetaCellComparator.class;
               } else if (comparatorClassName.equals("org.apache.hadoop.hbase.KeyValue.RawBytesComparator")
                   || comparatorClassName.equals("org.apache.hadoop.hbase.util.Bytes$ByteArrayComparator")) {
          

          The above snippet in the hfile trailer handles the case where an older server is writing hfiles that say the comparator is CellComparator. But our newly-upgraded RegionServers will be writing out hfiles that have a comparator of CellComparatorImpl. None of the old RegionServers will know how to handle that class.

          reopen or file a follow-on jira?

          Show
          busbey Sean Busbey added a comment - I think this breaks our ability to do rolling upgrade come 2.0.0-beta-* diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java index d82dd170dd..115302e9d1 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/FixedFileTrailer.java @@ -28,7 +28,8 @@ import java.nio.ByteBuffer; import org.apache.hadoop.fs.FSDataInputStream; import org.apache.hadoop.hbase.CellComparator; - import org.apache.hadoop.hbase.CellComparator.MetaCellComparator; + import org.apache.hadoop.hbase.CellComparatorImpl; + import org.apache.hadoop.hbase.CellComparatorImpl.MetaCellComparator; import org.apache.hadoop.hbase.KeyValue; import org.apache.yetus.audience.InterfaceAudience; import org.apache.hadoop.hbase.io.compress.Compression; @@ -109,7 +110,7 @@ public class FixedFileTrailer { /** Raw key comparator class name in version 3 */ // We could write the actual class name from 2.0 onwards and handle BC - private String comparatorClassName = CellComparator.COMPARATOR.getClass().getName(); + private String comparatorClassName = CellComparatorImpl.COMPARATOR.getClass().getName(); /** The encryption key */ private byte [] encryptionKey; @@ -559,11 +560,15 @@ public class FixedFileTrailer { private static Class <? extends CellComparator> getComparatorClass( String comparatorClassName) throws IOException { Class <? extends CellComparator> comparatorKlass; + // for BC if (comparatorClassName.equals(KeyValue.COMPARATOR.getLegacyKeyComparatorName()) - || comparatorClassName.equals(KeyValue.COMPARATOR.getClass().getName())) { - comparatorKlass = CellComparator.class; + || comparatorClassName.equals(KeyValue.COMPARATOR.getClass().getName()) + || (comparatorClassName.equals( "org.apache.hadoop.hbase.CellComparator" ))) { + comparatorKlass = CellComparatorImpl.class; } else if (comparatorClassName.equals(KeyValue.META_COMPARATOR.getLegacyKeyComparatorName()) - || comparatorClassName.equals(KeyValue.META_COMPARATOR.getClass().getName())) { + || comparatorClassName.equals(KeyValue.META_COMPARATOR.getClass().getName()) + || (comparatorClassName + .equals( "org.apache.hadoop.hbase.CellComparator$MetaCellComparator" ))) { comparatorKlass = MetaCellComparator.class; } else if (comparatorClassName.equals( "org.apache.hadoop.hbase.KeyValue.RawBytesComparator" ) || comparatorClassName.equals( "org.apache.hadoop.hbase.util.Bytes$ByteArrayComparator" )) { The above snippet in the hfile trailer handles the case where an older server is writing hfiles that say the comparator is CellComparator. But our newly-upgraded RegionServers will be writing out hfiles that have a comparator of CellComparatorImpl. None of the old RegionServers will know how to handle that class. reopen or file a follow-on jira?
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Wouldn't HBASE-19052 solve the above concern ?

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Wouldn't HBASE-19052 solve the above concern ?
          Hide
          stack stack added a comment -

          As said over on HBASE-19052, that 'approach' is brittle.

          Wouldn't changing the trailer require a change in file version? Can hbase2 not write old style until cluster is all up on hbase2? hbase2 could write old style but when it read in the Interface, it could substitute the Impl? Better do this than require poor old user upgrade whole cluster first to latest branch-1 (we may have to do this for rolling upgrade but perhaps we can avoid it... that'd be great).

          Show
          stack stack added a comment - As said over on HBASE-19052 , that 'approach' is brittle. Wouldn't changing the trailer require a change in file version? Can hbase2 not write old style until cluster is all up on hbase2? hbase2 could write old style but when it read in the Interface, it could substitute the Impl? Better do this than require poor old user upgrade whole cluster first to latest branch-1 (we may have to do this for rolling upgrade but perhaps we can avoid it... that'd be great).
          Hide
          busbey Sean Busbey added a comment -

          I think we could just have hbase-2 always write the old class name in as the comparator. they're referring to the same logical implementation.

          Show
          busbey Sean Busbey added a comment - I think we could just have hbase-2 always write the old class name in as the comparator. they're referring to the same logical implementation.
          Hide
          busbey Sean Busbey added a comment -

          nevermind me, taking my comments over to HBASE-19052

          Show
          busbey Sean Busbey added a comment - nevermind me, taking my comments over to HBASE-19052
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Patch is a wrong place Stack?

          Show
          anoop.hbase Anoop Sam John added a comment - Patch is a wrong place Stack?
          Hide
          stack stack added a comment -

          Thanks Anoop.

          Show
          stack stack added a comment - Thanks Anoop.

            People

            • Assignee:
              ram_krish ramkrishna.s.vasudevan
              Reporter:
              ram_krish ramkrishna.s.vasudevan
            • Votes:
              0 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development