Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-18169 Coprocessor fix and cleanup before 2.0.0 release
  3. HBASE-18995

Move methods that are for internal usage from CellUtil to Private util class

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-alpha-3
    • Fix Version/s: 2.0.0-alpha-4
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Split CellUtil into public CellUtil and PrivateCellUtil for Internal use only.

      Description

      This was brought up long time back. We need to move some of the public APIs from CellUtil to internal private Util class because they are used in some internal flow and does not make sense to have it in a @public exposed Util class.
      The topic again came in HBASE-18945 RB comments also.

      1. HBASE-18995_2.patch
        520 kB
        ramkrishna.s.vasudevan
      2. HBASE-18995_2.patch
        520 kB
        ramkrishna.s.vasudevan
      3. HBASE-18995_003-branch-2.patch
        536 kB
        ramkrishna.s.vasudevan
      4. HBASE-18995_002-branch-2.patch
        536 kB
        ramkrishna.s.vasudevan
      5. HBASE-18995_1.patch
        519 kB
        ramkrishna.s.vasudevan
      6. HBASE-18995_002-branch-2.patch
        535 kB
        ramkrishna.s.vasudevan
      7. HBASE-18995-branch-2.002.patch
        535 kB
        ramkrishna.s.vasudevan
      8. HBASE-18995-branch-2_2.patch
        535 kB
        ramkrishna.s.vasudevan
      9. HBASE-18995-branch-2_1.patch
        533 kB
        stack
      10. HBASE-18995-branch-2_1.patch
        535 kB
        ramkrishna.s.vasudevan
      11. HBASE-18995-branch-2_1.patch
        535 kB
        ramkrishna.s.vasudevan
      12. HBASE-18995-branch-2_1.patch
        533 kB
        ramkrishna.s.vasudevan
      13. HBASE-18995-branch-2.patch
        460 kB
        ramkrishna.s.vasudevan

        Issue Links

          Activity

          Hide
          mdrob Mike Drob added a comment -

          Thanks for the analysis here ramkrishna.s.vasudevan. I'll file a new JIRA for exposing some additional stuff and we can discuss there.

          Show
          mdrob Mike Drob added a comment - Thanks for the analysis here ramkrishna.s.vasudevan . I'll file a new JIRA for exposing some additional stuff and we can discuss there.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          I read the Crunch projec't hbase-support related code.
          -> It uses both CellUtil (Public exposed) and KeyValueUtil (@Private) classes for helper methods.
          -> All methods in CellUtil that are getting used are even now exposed in branch-2's CellUtil and they are very common helper methods. So we are safe here.
          -> Wrt KeyValueUtil the API is createFirstOnRow(). It is used in test cases and in some core code. In most of the places they are trying to create the splitKeys from the region's start keys and that is also getting persisted. I think here they can safely create a cell out of the given byte[] of the row.
          But there is one place where they are trying to do some scanning on a HFileScanner directly (@Private) scanner. So this should be changed because it is an internal interface for us. And on this scanner they have copied our seekTo() code into their source files for some scanning purpose. In this code they are actually using the KvUtil.createFirstOnRow() to seek to that first cell of that row.
          More over I think in branch-2 we are restricting even CPs from accessing some of our internal scanners and they can only use InternalScanner interface. So this code in crunch needs heavy refactoring to work with branch-2 in case they want to fit into the Public/Private exposed semantics that HBase presents to the downstreamers.
          -> If still they want some APIs like this we can expose CellUtil#createFirstOnRow, createLastOnRow, createFirstOnCol and createLastOnCol at the maximum. I think others are not useful and are more internal stuffs.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - I read the Crunch projec't hbase-support related code. -> It uses both CellUtil (Public exposed) and KeyValueUtil (@Private) classes for helper methods. -> All methods in CellUtil that are getting used are even now exposed in branch-2's CellUtil and they are very common helper methods. So we are safe here. -> Wrt KeyValueUtil the API is createFirstOnRow(). It is used in test cases and in some core code. In most of the places they are trying to create the splitKeys from the region's start keys and that is also getting persisted. I think here they can safely create a cell out of the given byte[] of the row. But there is one place where they are trying to do some scanning on a HFileScanner directly (@Private) scanner. So this should be changed because it is an internal interface for us. And on this scanner they have copied our seekTo() code into their source files for some scanning purpose. In this code they are actually using the KvUtil.createFirstOnRow() to seek to that first cell of that row. More over I think in branch-2 we are restricting even CPs from accessing some of our internal scanners and they can only use InternalScanner interface. So this code in crunch needs heavy refactoring to work with branch-2 in case they want to fit into the Public/Private exposed semantics that HBase presents to the downstreamers. -> If still they want some APIs like this we can expose CellUtil#createFirstOnRow, createLastOnRow, createFirstOnCol and createLastOnCol at the maximum. I think others are not useful and are more internal stuffs.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Thanks Stack will check and report back here.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Thanks Stack will check and report back here.
          Hide
          stack stack added a comment - - edited
          Show
          stack stack added a comment - - edited Just check out apache crunch ramkrishna.s.vasudevan git clone https://git-wip-us.apache.org/repos/asf/crunch.git
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          We need to help Crunch get up on the factory and builders.

          Yes. Agree.
          Can you get us a link to the code base to see what is the use of createFirstOnRow and how it is getting used in their code flow.
          If it is possible can we suggest alternates? Its good to know people use these APIs even in client side usages.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - We need to help Crunch get up on the factory and builders. Yes. Agree. Can you get us a link to the code base to see what is the use of createFirstOnRow and how it is getting used in their code flow. If it is possible can we suggest alternates? Its good to know people use these APIs even in client side usages.
          Hide
          stack stack added a comment -

          I think createFirstOnRow is the only one that is missed?

          Yes.

          I see too why you'd want to hide the others Crunch is using.

          We need to help Crunch get up on the factory and builders.

          It is fair to call it client-side code (MR/Spark and misc).

          Thanks.

          Show
          stack stack added a comment - I think createFirstOnRow is the only one that is missed? Yes. I see too why you'd want to hide the others Crunch is using. We need to help Crunch get up on the factory and builders. It is fair to call it client-side code (MR/Spark and misc). Thanks.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          I see three methods in CellUtil with Private annotation. Any reason they were not moved? I see they are @Deprecated. Is that because they have been moved already?

          I left it because they are still exposed in 2.0. You mean they are left over in 3.0 also? If so it is my mistake. I have to remove them.

          Are there methods from PrivateCellUtil you want to expose to Coprocessors?

          As said in the other JIRA. We need to know what others can we expose. We can definitely move some more to the LPCellUtil which needs to be exposed but for now I can see Tag related APIs.
          But coming to createfirstOnRow(), createLastOnRow() - that is something internal. Why should that be in CellUtil? In one of the review comments it was discussed we need not expose them. I am fine if there is an usage but again there are lot of variants which are not worth exposing we need to see which are really useful and which are internally used. In the list of APIs used by Crunch I think createFirstOnRow is the only one that is missed? All other APIs are still available in Public CellUtil.
          So this project Crunch is it a CP based project or is it a client side code?

          (static methods on interfaces is one of the benefits of us being on jdk8 now: ref)

          I like this idea. How ever I think what needs to go as static methods in Cell interface is still questionable because there are cases like this createFirstOnRow() which goes to IA.Private but Cell does not have it and still it is not helping them.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - I see three methods in CellUtil with Private annotation. Any reason they were not moved? I see they are @Deprecated. Is that because they have been moved already? I left it because they are still exposed in 2.0. You mean they are left over in 3.0 also? If so it is my mistake. I have to remove them. Are there methods from PrivateCellUtil you want to expose to Coprocessors? As said in the other JIRA. We need to know what others can we expose. We can definitely move some more to the LPCellUtil which needs to be exposed but for now I can see Tag related APIs. But coming to createfirstOnRow(), createLastOnRow() - that is something internal. Why should that be in CellUtil? In one of the review comments it was discussed we need not expose them. I am fine if there is an usage but again there are lot of variants which are not worth exposing we need to see which are really useful and which are internally used. In the list of APIs used by Crunch I think createFirstOnRow is the only one that is missed? All other APIs are still available in Public CellUtil. So this project Crunch is it a CP based project or is it a client side code? (static methods on interfaces is one of the benefits of us being on jdk8 now: ref) I like this idea. How ever I think what needs to go as static methods in Cell interface is still questionable because there are cases like this createFirstOnRow() which goes to IA.Private but Cell does not have it and still it is not helping them.
          Hide
          busbey Sean Busbey added a comment -

          Moving stuff into PrivateCellUtil is a bad idea, IMHO. Method level annotations work fine. If someone is going to ignore a method being IA.Private, they're also going to ignore a class being IA.Private. We already hide them from our downstream facing javadocs. If we need more, we can invest the time in making an enforcer rule that folks can opt-into.

          If we want to make some CellUtil methods "more public" why not just move them to be static methods on the Cell interface and mark all of CellUtil as deprecated / going IA.Private in HBase 3? (static methods on interfaces is one of the benefits of us being on jdk8 now: ref) This has the nice side effect of starting to undo all of the FooUtil classes that litter our codebase.

          Show
          busbey Sean Busbey added a comment - Moving stuff into PrivateCellUtil is a bad idea, IMHO. Method level annotations work fine. If someone is going to ignore a method being IA.Private, they're also going to ignore a class being IA.Private. We already hide them from our downstream facing javadocs. If we need more, we can invest the time in making an enforcer rule that folks can opt-into. If we want to make some CellUtil methods "more public" why not just move them to be static methods on the Cell interface and mark all of CellUtil as deprecated / going IA.Private in HBase 3? (static methods on interfaces is one of the benefits of us being on jdk8 now: ref ) This has the nice side effect of starting to undo all of the FooUtil classes that litter our codebase.
          Hide
          stack stack added a comment -

          The use case Mike Drob ran into was CellUtil.createFirstOnRow. Its not in CellUtil anymore ramkrishna.s.vasudevan

          Here are other uses of CellUtil by Crunch:

          ./crunch-hbase/src/it/java/org/apache/crunch/io/hbase/HFileTargetIT.java:        Cell cell = CellUtil.createCell(Bytes.toBytes(w), Bytes.toBytes(c));
          ./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileOutputFormatForCrunch.java:        InetSocketAddress preferredNodeForRow = regionLocationTable.getPreferredNodeForRow(CellUtil.cloneRow(cell));
          ./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileUtils.java:      return ByteBuffer.wrap(CellUtil.cloneRow(input));
          ./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileUtils.java:      LOG.debug("split row: " + Bytes.toString(CellUtil.cloneRow(kv)));
          ./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileUtils.java:        emitter.emit(ByteBuffer.wrap(CellUtil.cloneRow(foundCell)));
          ./crunch-spark/src/it/java/org/apache/crunch/SparkHFileTargetIT.java:        Cell cell = CellUtil.createCell(Bytes.toBytes(w), Bytes.toBytes(c));
          
          Show
          stack stack added a comment - The use case Mike Drob ran into was CellUtil.createFirstOnRow. Its not in CellUtil anymore ramkrishna.s.vasudevan Here are other uses of CellUtil by Crunch: ./crunch-hbase/src/it/java/org/apache/crunch/io/hbase/HFileTargetIT.java: Cell cell = CellUtil.createCell(Bytes.toBytes(w), Bytes.toBytes(c)); ./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileOutputFormatForCrunch.java: InetSocketAddress preferredNodeForRow = regionLocationTable.getPreferredNodeForRow(CellUtil.cloneRow(cell)); ./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileUtils.java: return ByteBuffer.wrap(CellUtil.cloneRow(input)); ./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileUtils.java: LOG.debug( "split row: " + Bytes.toString(CellUtil.cloneRow(kv))); ./crunch-hbase/src/main/java/org/apache/crunch/io/hbase/HFileUtils.java: emitter.emit(ByteBuffer.wrap(CellUtil.cloneRow(foundCell))); ./crunch-spark/src/it/java/org/apache/crunch/SparkHFileTargetIT.java: Cell cell = CellUtil.createCell(Bytes.toBytes(w), Bytes.toBytes(c));
          Hide
          stack stack added a comment -

          ramkrishna.s.vasudevan I see three methods in CellUtil with Private annotation. Any reason they were not moved? I see they are @Deprecated. Is that because they have been moved already?

          Are there methods from PrivateCellUtil you want to expose to Coprocessors?

          Show
          stack stack added a comment - ramkrishna.s.vasudevan I see three methods in CellUtil with Private annotation. Any reason they were not moved? I see they are @Deprecated. Is that because they have been moved already? Are there methods from PrivateCellUtil you want to expose to Coprocessors?
          Hide
          stack stack added a comment -

          Mike Drob

          Annotating on the method-level is unusual in the codebase. Usual is to annotate on the class. Some methods remain annotated Private in CellUtil even after this change but I think the sense is that this is a failing to be fixed.

          We are having trouble with CellUtil and TagUtil and a profusion of classes colored by access. Annotation by method might help.

          Background.

          Much of the alpha-4 project (and before this) is about shutting down access to internals either removing private classes as parameters to Coprocessors or sorting classes by private and public portions (usually returning an Interface that has the public methods but internally we'll use the implementation that allows access to all methods or populating Coprocessor Environments/Context with methods that have been properly santized).

          This CellUtil (and TagUtil) are a little difficult. Their static methods generally so options are less. A long running project has been about undoing dependence on our internal Cell representation so we can change it one day. There are Factories and Builders if you want to make Cells. We want to steer folks this direction. CellUtil is peppered with methods that are for nought but internal devs and a particular context. Hiding them from non-devs saves them trouble should the format change.

          Show
          stack stack added a comment - Mike Drob Annotating on the method-level is unusual in the codebase. Usual is to annotate on the class. Some methods remain annotated Private in CellUtil even after this change but I think the sense is that this is a failing to be fixed. We are having trouble with CellUtil and TagUtil and a profusion of classes colored by access. Annotation by method might help. Background. Much of the alpha-4 project (and before this) is about shutting down access to internals either removing private classes as parameters to Coprocessors or sorting classes by private and public portions (usually returning an Interface that has the public methods but internally we'll use the implementation that allows access to all methods or populating Coprocessor Environments/Context with methods that have been properly santized). This CellUtil (and TagUtil) are a little difficult. Their static methods generally so options are less. A long running project has been about undoing dependence on our internal Cell representation so we can change it one day. There are Factories and Builders if you want to make Cells. We want to steer folks this direction. CellUtil is peppered with methods that are for nought but internal devs and a particular context. Hiding them from non-devs saves them trouble should the format change.
          Hide
          mdrob Mike Drob added a comment -

          Hold up... right in the CellUtil javadoc it has...

          (before the changes)

          * Utility methods helpful slinging {@link Cell} instances.
          * Some methods below are for internal use only and are marked InterfaceAudience.Private at the
          * method level.
          

          So I don't understand the motivation for moving things to a new class when they were already annotated?

          Show
          mdrob Mike Drob added a comment - Hold up... right in the CellUtil javadoc it has... (before the changes) * Utility methods helpful slinging {@link Cell} instances. * Some methods below are for internal use only and are marked InterfaceAudience.Private at the * method level. So I don't understand the motivation for moving things to a new class when they were already annotated?
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-2.0 #759 (See https://builds.apache.org/job/HBase-2.0/759/)
          HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev efb5d7b24df5111cd0f4d4282a1ffd6c98ef405a)

          • (add) hbase-common/src/main/java/org/apache/hadoop/hbase/PrivateCellUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #759 (See https://builds.apache.org/job/HBase-2.0/759/ ) HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev efb5d7b24df5111cd0f4d4282a1ffd6c98ef405a) (add) hbase-common/src/main/java/org/apache/hadoop/hbase/PrivateCellUtil.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3959 (See https://builds.apache.org/job/HBase-Trunk_matrix/3959/)
          HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev bfaacfdba306061477d3103754fd5c5ac3612e1b)

          • (add) hbase-common/src/main/java/org/apache/hadoop/hbase/PrivateCellUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3959 (See https://builds.apache.org/job/HBase-Trunk_matrix/3959/ ) HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev bfaacfdba306061477d3103754fd5c5ac3612e1b) (add) hbase-common/src/main/java/org/apache/hadoop/hbase/PrivateCellUtil.java
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Thanks a ton for taking this through Stack.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Thanks a ton for taking this through Stack .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-2.0 #758 (See https://builds.apache.org/job/HBase-2.0/758/)
          HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev 250a8bc7ad05080692b461a28f6fe1fa614b5830)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ExplicitColumnTracker.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AllowPartialScanResultCache.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedStoreScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NormalUserScanQueryMatcher.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DiffKeyDeltaEncoder.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowColBloomHashKey.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedHFileOutputFormat2.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
          • (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestByteBufferKeyValue.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestSeekToBlockWithEncoders.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          • (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellComparator.java
          • (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeCell.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/StripeCompactionScanQueryMatcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithVisibilityLabels.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/MajorCompactionScanQueryMatcher.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedKeyValueHeap.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRecoveredEdits.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NewVersionBehaviorTracker.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/util/MapReduceCell.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/BatchScanResultCache.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CellSortReducer.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/IndividualBytesFieldCell.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/TableSnapshotScanner.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
          • (edit) hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/TestPrefixTreeSearcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestTagRewriteCell.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedRegionScannerImpl.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/querymatcher/TestUserScanQueryMatcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlFilter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/HFileTestUtil.java
          • (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArraySearcher.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
          • (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/PrefixTreeSeeker.java
          • (edit) hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/BaseTestRowData.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CompoundBloomFilterWriter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerFromBucketCache.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestSyncTable.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/NoneEncoder.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MutableSegment.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanWildcardColumnTracker.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
          • (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestCellBlockBuilder.java
          • (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArrayScanner.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowBloomHashKey.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CellSerialization.java
          • (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/encode/PrefixTreeEncoder.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/DisabledWALProvider.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ReplicationProtbufUtil.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedImportExport2.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/RowColBloomContext.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/FastDiffDeltaEncoder.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTestUtil.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/PrefixKeyDeltaEncoder.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/DoubleColumnInterpreter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/MinorCompactionScanQueryMatcher.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestSplitTableRegionProcedure.java
          • (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TagUtil.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/LongColumnInterpreter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileReader.java
          • (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
          • (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/filter/TestComparators.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Segment.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithOperationAttributes.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
          • (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellUtil.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableScanMetrics.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALEdit.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-2.0 #758 (See https://builds.apache.org/job/HBase-2.0/758/ ) HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev 250a8bc7ad05080692b461a28f6fe1fa614b5830) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ExplicitColumnTracker.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AllowPartialScanResultCache.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedStoreScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NormalUserScanQueryMatcher.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DiffKeyDeltaEncoder.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowColBloomHashKey.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedHFileOutputFormat2.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestByteBufferKeyValue.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestSeekToBlockWithEncoders.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellComparator.java (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeCell.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/StripeCompactionScanQueryMatcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithVisibilityLabels.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/MajorCompactionScanQueryMatcher.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedKeyValueHeap.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRecoveredEdits.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NewVersionBehaviorTracker.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/util/MapReduceCell.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/BatchScanResultCache.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CellSortReducer.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/IndividualBytesFieldCell.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/TableSnapshotScanner.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java (edit) hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/TestPrefixTreeSearcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestTagRewriteCell.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedRegionScannerImpl.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/querymatcher/TestUserScanQueryMatcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlFilter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/HFileTestUtil.java (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArraySearcher.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/PrefixTreeSeeker.java (edit) hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/BaseTestRowData.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CompoundBloomFilterWriter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerFromBucketCache.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestSyncTable.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/NoneEncoder.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MutableSegment.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanWildcardColumnTracker.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestCellBlockBuilder.java (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArrayScanner.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowBloomHashKey.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CellSerialization.java (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/encode/PrefixTreeEncoder.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/DisabledWALProvider.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ReplicationProtbufUtil.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestCellBasedImportExport2.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/RowColBloomContext.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/FastDiffDeltaEncoder.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTestUtil.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/PrefixKeyDeltaEncoder.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/DoubleColumnInterpreter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/MinorCompactionScanQueryMatcher.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestSplitTableRegionProcedure.java (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TagUtil.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/LongColumnInterpreter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileReader.java (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/filter/TestComparators.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Segment.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithOperationAttributes.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellUtil.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableScanMetrics.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALEdit.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3958 (See https://builds.apache.org/job/HBase-Trunk_matrix/3958/)
          HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev f6c2490b82968f33e7d7db0b96896eebdf745e19)

          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NewVersionBehaviorTracker.java
          • (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellUtil.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ReplicationProtbufUtil.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedKeyValueHeap.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/BatchScanResultCache.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestSeekToBlockWithEncoders.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedStoreScanner.java
          • (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestCellBlockBuilder.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestSyncTable.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/filter/TestComparators.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowBloomHashKey.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableScanMetrics.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NormalUserScanQueryMatcher.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/LongColumnInterpreter.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestSplitTableRegionProcedure.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CompoundBloomFilterWriter.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/NoneEncoder.java
          • (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestByteBufferKeyValue.java
          • (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/PrefixTreeSeeker.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ExplicitColumnTracker.java
          • (edit) hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/BaseTestRowData.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/FastDiffDeltaEncoder.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowColBloomHashKey.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/querymatcher/TestUserScanQueryMatcher.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/HFileTestUtil.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/DisabledWALProvider.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileReader.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/DoubleColumnInterpreter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerFromBucketCache.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
          • (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java
          • (edit) hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/TestPrefixTreeSearcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALEdit.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithOperationAttributes.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MutableSegment.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CellSerialization.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
          • (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/encode/PrefixTreeEncoder.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java
          • (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArraySearcher.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/RowColBloomContext.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
          • (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArrayScanner.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRecoveredEdits.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/IndividualBytesFieldCell.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithVisibilityLabels.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTestUtil.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedRegionScannerImpl.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlFilter.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TagUtil.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/TableSnapshotScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/util/MapReduceCell.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java
          • (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/MinorCompactionScanQueryMatcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
          • (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/PrefixKeyDeltaEncoder.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestTagRewriteCell.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CellSortReducer.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/MajorCompactionScanQueryMatcher.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
          • (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellComparator.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
          • (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DiffKeyDeltaEncoder.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AllowPartialScanResultCache.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Segment.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanWildcardColumnTracker.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/StripeCompactionScanQueryMatcher.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java
          • (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeCell.java
          • (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3958 (See https://builds.apache.org/job/HBase-Trunk_matrix/3958/ ) HBASE-18995 Move methods that are for internal usage from CellUtil to (stack: rev f6c2490b82968f33e7d7db0b96896eebdf745e19) (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/BufferedDataBlockEncoder.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStoreFile.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFileRefresherChore.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/CompareFilter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTags.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StripeMultiFileWriter.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPrefixFilter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NewVersionBehaviorTracker.java (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellUtil.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ReplicationProtbufUtil.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedKeyValueHeap.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValue.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCellCodec.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestServerSideScanMetricsFromClientSide.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/FuzzyRowFilter.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/BatchScanResultCache.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestSeekToBlockWithEncoders.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedStoreScanner.java (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestCellBlockBuilder.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTreeEncoding.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultMemStore.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobUtils.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestSyncTable.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALPrettyPrinter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestPartialResultsFromClientSide.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Delete.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/AbstractFSWAL.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java (edit) hbase-client/src/test/java/org/apache/hadoop/hbase/filter/TestComparators.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowBloomHashKey.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFile.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAsyncTableScanMetrics.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestDataBlockEncoders.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/NormalUserScanQueryMatcher.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Increment.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/LongColumnInterpreter.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionUtils.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestSplitTableRegionProcedure.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/SingleColumnValueFilter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CompoundBloomFilterWriter.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/NoneEncoder.java (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestByteBufferKeyValue.java (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/PrefixTreeSeeker.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ExplicitColumnTracker.java (edit) hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/BaseTestRowData.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/FastDiffDeltaEncoder.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/util/RowColBloomHashKey.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/querymatcher/TestUserScanQueryMatcher.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/HFileTestUtil.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/DisabledWALProvider.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileReader.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/DoubleColumnInterpreter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientSideRegionScanner.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerFromBucketCache.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Result.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java (edit) hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java (edit) hbase-prefix-tree/src/test/java/org/apache/hadoop/hbase/codec/prefixtree/row/TestPrefixTreeSearcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestCoprocessorScanPolicy.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALEdit.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithOperationAttributes.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MutableSegment.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CellSerialization.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/encode/PrefixTreeEncoder.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/FSWALEntry.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTsv.java (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArraySearcher.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultipleColumnPrefixFilter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/RowColBloomContext.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeArrayScanner.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRecoveredEdits.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/IndividualBytesFieldCell.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithVisibilityLabels.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/TimestampsFilter.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueTestUtil.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Put.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ReversedRegionScannerImpl.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlFilter.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnPaginationFilter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestSeekTo.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/TagUtil.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/client/TableSnapshotScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALSplitter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterImpl.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/util/MapReduceCell.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SecureWALCellCodec.java (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestKeyValue.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/MinorCompactionScanQueryMatcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java (edit) hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/PrefixKeyDeltaEncoder.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/TestTagRewriteCell.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFilePrettyPrinter.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/CellSortReducer.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/MajorCompactionScanQueryMatcher.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/MultiRowRangeFilter.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileBlockIndex.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/filter/ColumnRangeFilter.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java (edit) hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellComparator.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java (edit) hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/DiffKeyDeltaEncoder.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/AllowPartialScanResultCache.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Segment.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanWildcardColumnTracker.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/StripeCompactionScanQueryMatcher.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java (edit) hbase-prefix-tree/src/main/java/org/apache/hadoop/hbase/codec/prefixtree/decode/PrefixTreeCell.java (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/client/Mutation.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java
          Hide
          stack stack added a comment -

          Pushed to master and branch-2. Thanks for the nice patch Ram.

          Check me. I pushed HBASE-18995-branch-2.002.patch to branch-2 and HBASE-18995_2.patch to master. That what you wanted sir? ramkrishna.s.vasudevan Thanks.

          Show
          stack stack added a comment - Pushed to master and branch-2. Thanks for the nice patch Ram. Check me. I pushed HBASE-18995 -branch-2.002.patch to branch-2 and HBASE-18995 _2.patch to master. That what you wanted sir? ramkrishna.s.vasudevan Thanks.
          Hide
          appy Appy added a comment -

          Good work drawing the boundary in utils. Can move it around in followups if something needs to get out in public or get inside private.
          +1

          Show
          appy Appy added a comment - Good work drawing the boundary in utils. Can move it around in followups if something needs to get out in public or get inside private. +1
          Hide
          stack stack added a comment -

          Should I commit this ramkrishna.s.vasudevan? I can address javadoc and whitespace on commit.

          We still need this?

          // TODO : Make Tag IA.LimitedPrivate and move some of the Util methods to CP exposed Util class

          Is this a follow-on?

          We can do teething issues w/ this patch in a follow-on? Meantime this is a big change so good to land it?

          Thanks.

          Show
          stack stack added a comment - Should I commit this ramkrishna.s.vasudevan ? I can address javadoc and whitespace on commit. We still need this? // TODO : Make Tag IA.LimitedPrivate and move some of the Util methods to CP exposed Util class Is this a follow-on? We can do teething issues w/ this patch in a follow-on? Meantime this is a big change so good to land it? Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          0 findbugs 0m 0s Findbugs executables are not available.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 47 new or modified test files.
          0 mvndep 0m 14s Maven dependency ordering for branch
          +1 mvninstall 5m 1s master passed
          +1 compile 2m 27s master passed
          +1 checkstyle 2m 16s master passed
          +1 mvneclipse 1m 44s master passed
          +1 shadedjars 8m 50s branch has no errors when building our shaded downstream artifacts.
          +1 javadoc 1m 54s master passed
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 4m 43s the patch passed
          +1 compile 2m 25s the patch passed
          +1 javac 2m 25s the patch passed
          +1 checkstyle 2m 15s the patch passed
          +1 mvneclipse 1m 42s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 shadedjars 4m 51s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 49m 1s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          -1 javadoc 0m 17s hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 unit 2m 12s hbase-common in the patch passed.
          +1 unit 2m 30s hbase-client in the patch passed.
          +1 unit 0m 28s hbase-prefix-tree in the patch passed.
          +1 unit 91m 47s hbase-server in the patch passed.
          +1 unit 10m 48s hbase-mapreduce in the patch passed.
          +1 unit 1m 52s hbase-thrift in the patch passed.
          +1 asflicense 1m 53s The patch does not generate ASF License warnings.
          193m 24s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
          JIRA Issue HBASE-18995
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894349/HBASE-18995_2.patch
          Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
          uname Linux cc76f8075636 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 15b32460f9
          Default Java 1.8.0_141
          whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/9450/artifact/patchprocess/whitespace-eol.txt
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9450/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9450/testReport/
          modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-thrift U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9450/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 47 new or modified test files. 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 5m 1s master passed +1 compile 2m 27s master passed +1 checkstyle 2m 16s master passed +1 mvneclipse 1m 44s master passed +1 shadedjars 8m 50s branch has no errors when building our shaded downstream artifacts. +1 javadoc 1m 54s master passed 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 4m 43s the patch passed +1 compile 2m 25s the patch passed +1 javac 2m 25s the patch passed +1 checkstyle 2m 15s the patch passed +1 mvneclipse 1m 42s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 shadedjars 4m 51s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 49m 1s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. -1 javadoc 0m 17s hbase-common generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 unit 2m 12s hbase-common in the patch passed. +1 unit 2m 30s hbase-client in the patch passed. +1 unit 0m 28s hbase-prefix-tree in the patch passed. +1 unit 91m 47s hbase-server in the patch passed. +1 unit 10m 48s hbase-mapreduce in the patch passed. +1 unit 1m 52s hbase-thrift in the patch passed. +1 asflicense 1m 53s The patch does not generate ASF License warnings. 193m 24s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-18995 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894349/HBASE-18995_2.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux cc76f8075636 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 15b32460f9 Default Java 1.8.0_141 whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/9450/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9450/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9450/testReport/ modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-thrift U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9450/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Resubmitting for QA again. I checked the patch applies cleanly on master.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Resubmitting for QA again. I checked the patch applies cleanly on master.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          -1 patch 0m 4s HBASE-18995 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help.



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01
          JIRA Issue HBASE-18995
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894338/HBASE-18995_2.patch
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9449/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. -1 patch 0m 4s HBASE-18995 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help. Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 JIRA Issue HBASE-18995 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894338/HBASE-18995_2.patch Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9449/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          The same patch which did not run against branch-2 this time ran. I have corrected the whitespace and the javadoc thing in both master and branch-2.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - The same patch which did not run against branch-2 this time ran. I have corrected the whitespace and the javadoc thing in both master and branch-2.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
          0 findbugs 0m 0s Findbugs executables are not available.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 49 new or modified test files.
          0 mvndep 0m 24s Maven dependency ordering for branch
          +1 mvninstall 4m 38s branch-2 passed
          +1 compile 2m 13s branch-2 passed
          +1 checkstyle 2m 7s branch-2 passed
          +1 mvneclipse 1m 36s branch-2 passed
          +1 shadedjars 8m 18s branch has no errors when building our shaded downstream artifacts.
          +1 javadoc 1m 45s branch-2 passed
          0 mvndep 0m 13s Maven dependency ordering for patch
          +1 mvninstall 4m 28s the patch passed
          +1 compile 2m 11s the patch passed
          +1 javac 2m 11s the patch passed
          +1 checkstyle 2m 7s the patch passed
          +1 mvneclipse 1m 37s the patch passed
          -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 shadedjars 4m 33s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 45m 57s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          -1 javadoc 0m 15s hbase-common generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0)
          +1 unit 2m 10s hbase-common in the patch passed.
          +1 unit 2m 32s hbase-client in the patch passed.
          +1 unit 0m 27s hbase-prefix-tree in the patch passed.
          +1 unit 93m 1s hbase-server in the patch passed.
          +1 unit 12m 44s hbase-mapreduce in the patch passed.
          +1 unit 1m 57s hbase-thrift in the patch passed.
          +1 asflicense 1m 53s The patch does not generate ASF License warnings.
          191m 37s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db
          JIRA Issue HBASE-18995
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894297/HBASE-18995_002-branch-2.patch
          Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
          uname Linux 395a91954727 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision branch-2 / 8e6d116ae3
          Default Java 1.8.0_141
          whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/9447/artifact/patchprocess/whitespace-eol.txt
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9447/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9447/testReport/
          modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-thrift U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9447/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. 0 findbugs 0m 0s Findbugs executables are not available. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 49 new or modified test files. 0 mvndep 0m 24s Maven dependency ordering for branch +1 mvninstall 4m 38s branch-2 passed +1 compile 2m 13s branch-2 passed +1 checkstyle 2m 7s branch-2 passed +1 mvneclipse 1m 36s branch-2 passed +1 shadedjars 8m 18s branch has no errors when building our shaded downstream artifacts. +1 javadoc 1m 45s branch-2 passed 0 mvndep 0m 13s Maven dependency ordering for patch +1 mvninstall 4m 28s the patch passed +1 compile 2m 11s the patch passed +1 javac 2m 11s the patch passed +1 checkstyle 2m 7s the patch passed +1 mvneclipse 1m 37s the patch passed -1 whitespace 0m 0s The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 shadedjars 4m 33s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 45m 57s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. -1 javadoc 0m 15s hbase-common generated 6 new + 0 unchanged - 0 fixed = 6 total (was 0) +1 unit 2m 10s hbase-common in the patch passed. +1 unit 2m 32s hbase-client in the patch passed. +1 unit 0m 27s hbase-prefix-tree in the patch passed. +1 unit 93m 1s hbase-server in the patch passed. +1 unit 12m 44s hbase-mapreduce in the patch passed. +1 unit 1m 57s hbase-thrift in the patch passed. +1 asflicense 1m 53s The patch does not generate ASF License warnings. 191m 37s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db JIRA Issue HBASE-18995 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894297/HBASE-18995_002-branch-2.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux 395a91954727 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision branch-2 / 8e6d116ae3 Default Java 1.8.0_141 whitespace https://builds.apache.org/job/PreCommit-HBASE-Build/9447/artifact/patchprocess/whitespace-eol.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9447/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9447/testReport/ modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-thrift U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9447/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Updated branch-2 patch. Now from CellUtil we cal PrivateCellUtil APIs for the deprecated methods. Previously I had missed doing that.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Updated branch-2 patch. Now from CellUtil we cal PrivateCellUtil APIs for the deprecated methods. Previously I had missed doing that.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          PAtch for master. Had to manually apply changes from the branch-2 patch to CellUtil.
          Also along with this ensured that we call the PRivateCellUtil API for all the deprecated methods in CellUtil. The same I have done for branch-2 also.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - PAtch for master. Had to manually apply changes from the branch-2 patch to CellUtil. Also along with this ensured that we call the PRivateCellUtil API for all the deprecated methods in CellUtil. The same I have done for branch-2 also.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          -1 patch 0m 5s HBASE-18995 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help.



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db
          JIRA Issue HBASE-18995
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894293/HBASE-18995_002-branch-2.patch
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9446/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. -1 patch 0m 5s HBASE-18995 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help. Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db JIRA Issue HBASE-18995 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894293/HBASE-18995_002-branch-2.patch Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9446/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Trying as per Anoop suggestion.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Trying as per Anoop suggestion.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Can u try with name as HBASE-18995_002-branch-2.patch ?

          Show
          anoop.hbase Anoop Sam John added a comment - Can u try with name as HBASE-18995 _002-branch-2.patch ?
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          I don't know what is wrong with the patch name. So I have to prepare a patch against master now.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - I don't know what is wrong with the patch name. So I have to prepare a patch against master now.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 26s Docker mode activated.
          -1 patch 0m 6s HBASE-18995 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help.



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db
          JIRA Issue HBASE-18995
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894284/HBASE-18995-branch-2.002.patch
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9442/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. -1 patch 0m 6s HBASE-18995 does not apply to branch-2. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help. Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db JIRA Issue HBASE-18995 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894284/HBASE-18995-branch-2.002.patch Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9442/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Rename the patch file to see if it picks up against branch-2.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Rename the patch file to see if it picks up against branch-2.
          Hide
          stack stack added a comment -

          Thanks for name change Ram.

          Show
          stack stack added a comment - Thanks for name change Ram.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 6s HBASE-18995 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help.



          Subsystem Report/Notes
          JIRA Issue HBASE-18995
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894281/HBASE-18995-branch-2_2.patch
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9441/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s HBASE-18995 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/0.4.0/precommit-patchnames for help. Subsystem Report/Notes JIRA Issue HBASE-18995 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12894281/HBASE-18995-branch-2_2.patch Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9441/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Try QA once again against branch-2. The same patch is not applying on master cleanly. I think I will commit this to branch-2 then with that reference will prepare a patch for master so that it is easy to apply on master.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Try QA once again against branch-2. The same patch is not applying on master cleanly. I think I will commit this to branch-2 then with that reference will prepare a patch for master so that it is easy to apply on master.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Also, let's commit this to both master and branch-2? Reason being, removing all this stuff now will make backports hard. Let's remove them after 2.0 release.

          We may need another Util class just for CP and that is where the Tag related things may come in.
          So I think it is better we push this in first as is and then work on that other tasks to create CPCellUtil. And regarding the commit I think we will commit now to branch-2 and master as is and later work on removing the deprecated methods. File a blocker against 3.0 and work with that JIRA?

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Also, let's commit this to both master and branch-2? Reason being, removing all this stuff now will make backports hard. Let's remove them after 2.0 release. We may need another Util class just for CP and that is where the Tag related things may come in. So I think it is better we push this in first as is and then work on that other tasks to create CPCellUtil. And regarding the commit I think we will commit now to branch-2 and master as is and later work on removing the deprecated methods. File a blocker against 3.0 and work with that JIRA?
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Appy and Stack
          Thanks for your comments on RB. I have replied to most of your comments. Let me know what you think. Patch wise nothing much to change except for renaming to InternalCellUtil to privateCellUtil. I am fine with any of these two names. I first named it as PrivatecellUtil but since already @PRivate tag was there I thought InternalCellUtil is better.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Appy and Stack Thanks for your comments on RB. I have replied to most of your comments. Let me know what you think. Patch wise nothing much to change except for renaming to InternalCellUtil to privateCellUtil. I am fine with any of these two names. I first named it as PrivatecellUtil but since already @PRivate tag was there I thought InternalCellUtil is better.
          Hide
          stack stack added a comment -

          I like the @appy review comments on Util naming. PrivateCellUtil to match the IA annotation sounds good.

          Let me review more up on RB.

          Show
          stack stack added a comment - I like the @appy review comments on Util naming. PrivateCellUtil to match the IA annotation sounds good. Let me review more up on RB.
          Hide
          appy Appy added a comment -

          Skimming rest of the patch, looks okay.
          Confused on the part where we are removing functions which aren't really exposing anything extra/new, they are just convenience functions.

          Show
          appy Appy added a comment - Skimming rest of the patch, looks okay. Confused on the part where we are removing functions which aren't really exposing anything extra/new, they are just convenience functions.
          Hide
          appy Appy added a comment -

          I seem some duplication of code (For eg. boolean matchingQualifier(final Cell left, ..... If we are moving fns to internal one and marking them deprecated in public one, let's redirect calls to InternalUtil's fns instead.

          As for naming, unless you already have a name for LP CellUtil in mind, let's think it through with future naming needs in perspective. I'd suggest following naming - CellUtil, LPCellUtil, PrivateCellUtil
          (PublicCU, LPCU, and CU would have been better, but hands tied )

          Also, let's commit this to both master and branch-2? Reason being, removing all this stuff now will make backports hard. Let's remove them after 2.0 release.
          In fact, i think it'd probably be a better strategy to delete stuff marked for removal things in version X close to release of X - maximum compat for backports.

          Show
          appy Appy added a comment - I seem some duplication of code (For eg. boolean matchingQualifier(final Cell left, .... . If we are moving fns to internal one and marking them deprecated in public one, let's redirect calls to InternalUtil's fns instead. As for naming, unless you already have a name for LP CellUtil in mind, let's think it through with future naming needs in perspective. I'd suggest following naming - CellUtil, LPCellUtil, PrivateCellUtil (PublicCU, LPCU, and CU would have been better, but hands tied ) Also, let's commit this to both master and branch-2? Reason being, removing all this stuff now will make backports hard. Let's remove them after 2.0 release. In fact, i think it'd probably be a better strategy to delete stuff marked for removal things in version X close to release of X - maximum compat for backports.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Trying QA once again.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Trying QA once again.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Patch for branch-2. Cleaned up more APIs that were added for 2.0. I was thinking the createFirst and createLAst API were already there. Yes but they were in KVUtil in branch-1.4. So removed all of them from CellUtil and made them internal.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Patch for branch-2. Cleaned up more APIs that were added for 2.0. I was thinking the createFirst and createLAst API were already there. Yes but they were in KVUtil in branch-1.4. So removed all of them from CellUtil and made them internal.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          So any name for the InternalCellUtil ? Will change it and then upload to RB.

          I think this is ok.

          Show
          anoop.hbase Anoop Sam John added a comment - So any name for the InternalCellUtil ? Will change it and then upload to RB. I think this is ok.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment - - edited

          Ok makes sense.
          So any name for the InternalCellUtil ? Will change it and then upload to RB.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - - edited Ok makes sense. So any name for the InternalCellUtil ? Will change it and then upload to RB.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          I would say make this new Internal Util class as Private for this jira and commit. Tag making LP and making a LP util class can be done as part of another issue.

          Show
          anoop.hbase Anoop Sam John added a comment - I would say make this new Internal Util class as Private for this jira and commit. Tag making LP and making a LP util class can be done as part of another issue.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          For the CP expose thing I agree - like not all would be needed. But still if it is exposed to CP do you think it will be misused?
          Making Tag LimitedPRivate should be a seperate task and yes when we do that all the related Util APIs also should move.

          So do you say that for this JIRA itself we need split and first ensure the Tag is made LP and then move related classes to that and then create another PRivate Util class to move all other APIs to it?

          The ones with offset, length and all, ya lets keep in private util

          If we are going to have for CPs then we can have all versions and types of matchingXXX in the CP version only IMHO.

          . Any APIs which were not released in 1.x branches, we can remove from public CellUtil if needed. No deprecation cycle for them

          Yes this has been done.
          Infact the API that take byteRange and write to specific byte etc can actually directly removed since I don't think anyone will even use it but since we follow some version control mechanism I thought for 2.0 lets go this way of deprecate and then remove them though it may be unnecessary.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - For the CP expose thing I agree - like not all would be needed. But still if it is exposed to CP do you think it will be misused? Making Tag LimitedPRivate should be a seperate task and yes when we do that all the related Util APIs also should move. So do you say that for this JIRA itself we need split and first ensure the Tag is made LP and then move related classes to that and then create another PRivate Util class to move all other APIs to it? The ones with offset, length and all, ya lets keep in private util If we are going to have for CPs then we can have all versions and types of matchingXXX in the CP version only IMHO. . Any APIs which were not released in 1.x branches, we can remove from public CellUtil if needed. No deprecation cycle for them Yes this has been done. Infact the API that take byteRange and write to specific byte etc can actually directly removed since I don't think anyone will even use it but since we follow some version control mechanism I thought for 2.0 lets go this way of deprecate and then remove them though it may be unnecessary.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Just summarizing the points from RB comments and replies.
          1. I was saying abt the need for a non public but LP for CP util class.. I did not see the new Util already with LP for CP. Then we will need 3 Utils. CellUtil public, an LP exposed one and a private one. We have many APIs which not even to be given to CPs.
          2. Ya we better make Tag also LP and have the related methods moved to CP exposed Util class. May be we can even remove those APIs from public CellUtil with out deprecation cycle? Because no user would have been using it in client side as we never exposed Tags in client side. Ya CP side would have been using but any way lots of BC breaks around CP
          3. Matching APIs ya lets keep the ones which take Cells as param and Cell and byte[] as params in LP class. It will be useful for CPs. The ones with offset, length and all, ya lets keep in private util
          4. We have APIs like write parts of cells to OS etc. All these can be in private CellUtil. Those which work on ByteRange also.
          5. Any APIs which were not released in 1.x branches, we can remove from public CellUtil if needed. No deprecation cycle for them

          Any other points. Feel free to split this entire thig as a follow on jira also as needed. The hard thing would be to get names for diff levels of exposed classes

          Show
          anoop.hbase Anoop Sam John added a comment - Just summarizing the points from RB comments and replies. 1. I was saying abt the need for a non public but LP for CP util class.. I did not see the new Util already with LP for CP. Then we will need 3 Utils. CellUtil public, an LP exposed one and a private one. We have many APIs which not even to be given to CPs. 2. Ya we better make Tag also LP and have the related methods moved to CP exposed Util class. May be we can even remove those APIs from public CellUtil with out deprecation cycle? Because no user would have been using it in client side as we never exposed Tags in client side. Ya CP side would have been using but any way lots of BC breaks around CP 3. Matching APIs ya lets keep the ones which take Cells as param and Cell and byte[] as params in LP class. It will be useful for CPs. The ones with offset, length and all, ya lets keep in private util 4. We have APIs like write parts of cells to OS etc. All these can be in private CellUtil. Those which work on ByteRange also. 5. Any APIs which were not released in 1.x branches, we can remove from public CellUtil if needed. No deprecation cycle for them Any other points. Feel free to split this entire thig as a follow on jira also as needed. The hard thing would be to get names for diff levels of exposed classes
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Resubmitting for QA. I have kept InternalCellUtil as is till I get a better name. CoprocessorCellUtil seems not good to me. This is mainly for QA to see any findbugs warning and test case issues. Because in last run there was a stack overflow exception because of one change.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Resubmitting for QA. I have kept InternalCellUtil as is till I get a better name. CoprocessorCellUtil seems not good to me. This is mainly for QA to see any findbugs warning and test case issues. Because in last run there was a stack overflow exception because of one change.
          Hide
          stack stack added a comment -

          I thought it is better we allow CPs to use this? Probably will be helpful for cases like the timeline server projects where they need access to tags?

          Good point.

          Show
          stack stack added a comment - I thought it is better we allow CPs to use this? Probably will be helpful for cases like the timeline server projects where they need access to tags? Good point.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          License text is mangled in a few files.

          Will fix them.

          Or I suppose, it still holds. The Private methods have been Deprecated.

          Currently some of them have been deprecated. Only in 3.0 we could actually change that comment and remove all the deprecated ones.

          don't like the name InternalCellUtil but it is explicit as to its use.

          Any better name?

          Change this? 47 @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC) to Private I'd say.

          I thought it is better we allow CPs to use this? Probably will be helpful for cases like the timeline server projects where they need access to tags?

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - License text is mangled in a few files. Will fix them. Or I suppose, it still holds. The Private methods have been Deprecated. Currently some of them have been deprecated. Only in 3.0 we could actually change that comment and remove all the deprecated ones. don't like the name InternalCellUtil but it is explicit as to its use. Any better name? Change this? 47 @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC) to Private I'd say. I thought it is better we allow CPs to use this? Probably will be helpful for cases like the timeline server projects where they need access to tags?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 14m 21s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 29 new or modified test files.
          0 mvndep 1m 22s Maven dependency ordering for branch
          +1 mvninstall 5m 51s branch-2 passed
          +1 compile 1m 59s branch-2 passed
          +1 checkstyle 2m 29s branch-2 passed
          +1 mvneclipse 1m 25s branch-2 passed
          +1 shadedjars 8m 6s branch has no errors when building our shaded downstream artifacts.
          -1 findbugs 2m 6s hbase-server in branch-2 has 1 extant Findbugs warnings.
          +1 javadoc 1m 46s branch-2 passed
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 3m 36s the patch passed
          +1 compile 1m 57s the patch passed
          +1 javac 1m 57s the patch passed
          +1 checkstyle 2m 2s the patch passed
          +1 mvneclipse 1m 16s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedjars 4m 5s patch has no errors when building our shaded downstream artifacts.
          +1 hadoopcheck 38m 19s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4.
          +1 findbugs 6m 8s the patch passed
          -1 javadoc 0m 16s hbase-common generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0)
          +1 unit 2m 9s hbase-common in the patch passed.
          +1 unit 2m 31s hbase-client in the patch passed.
          +1 unit 0m 25s hbase-prefix-tree in the patch passed.
          -1 unit 19m 41s hbase-server in the patch failed.
          -1 unit 16m 32s hbase-mapreduce in the patch failed.
          -1 unit 15m 49s hbase-thrift in the patch failed.
          +1 asflicense 0m 52s The patch does not generate ASF License warnings.
          153m 54s



          Reason Tests
          Failed junit tests hadoop.hbase.io.hfile.TestSeekTo
            hadoop.hbase.mapreduce.TestCellBasedHFileOutputFormat2
            hadoop.hbase.mapreduce.TestHFileOutputFormat2



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8afa3e
          JIRA Issue HBASE-18995
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12893770/HBASE-18995-branch-2.patch
          Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
          uname Linux d0efd9331716 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision branch-2 / fe82a30
          Default Java 1.8.0_141
          findbugs v3.1.0-RC3
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9385/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9385/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9385/artifact/patchprocess/patch-unit-hbase-server.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9385/artifact/patchprocess/patch-unit-hbase-mapreduce.txt
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/9385/artifact/patchprocess/patch-unit-hbase-thrift.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9385/testReport/
          modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-thrift U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9385/console
          Powered by Apache Yetus 0.4.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 14m 21s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 29 new or modified test files. 0 mvndep 1m 22s Maven dependency ordering for branch +1 mvninstall 5m 51s branch-2 passed +1 compile 1m 59s branch-2 passed +1 checkstyle 2m 29s branch-2 passed +1 mvneclipse 1m 25s branch-2 passed +1 shadedjars 8m 6s branch has no errors when building our shaded downstream artifacts. -1 findbugs 2m 6s hbase-server in branch-2 has 1 extant Findbugs warnings. +1 javadoc 1m 46s branch-2 passed 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 3m 36s the patch passed +1 compile 1m 57s the patch passed +1 javac 1m 57s the patch passed +1 checkstyle 2m 2s the patch passed +1 mvneclipse 1m 16s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedjars 4m 5s patch has no errors when building our shaded downstream artifacts. +1 hadoopcheck 38m 19s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. +1 findbugs 6m 8s the patch passed -1 javadoc 0m 16s hbase-common generated 4 new + 0 unchanged - 0 fixed = 4 total (was 0) +1 unit 2m 9s hbase-common in the patch passed. +1 unit 2m 31s hbase-client in the patch passed. +1 unit 0m 25s hbase-prefix-tree in the patch passed. -1 unit 19m 41s hbase-server in the patch failed. -1 unit 16m 32s hbase-mapreduce in the patch failed. -1 unit 15m 49s hbase-thrift in the patch failed. +1 asflicense 0m 52s The patch does not generate ASF License warnings. 153m 54s Reason Tests Failed junit tests hadoop.hbase.io.hfile.TestSeekTo   hadoop.hbase.mapreduce.TestCellBasedHFileOutputFormat2   hadoop.hbase.mapreduce.TestHFileOutputFormat2 Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:d8afa3e JIRA Issue HBASE-18995 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12893770/HBASE-18995-branch-2.patch Optional Tests asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile uname Linux d0efd9331716 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision branch-2 / fe82a30 Default Java 1.8.0_141 findbugs v3.1.0-RC3 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/9385/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/9385/artifact/patchprocess/diff-javadoc-javadoc-hbase-common.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9385/artifact/patchprocess/patch-unit-hbase-server.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9385/artifact/patchprocess/patch-unit-hbase-mapreduce.txt unit https://builds.apache.org/job/PreCommit-HBASE-Build/9385/artifact/patchprocess/patch-unit-hbase-thrift.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/9385/testReport/ modules C: hbase-common hbase-client hbase-prefix-tree hbase-server hbase-mapreduce hbase-thrift U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/9385/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
          Hide
          stack stack added a comment -

          License text is mangled in a few files.

          Fix this text on CellUtil:

          46 * Utility methods helpful slinging

          {@link Cell}

          instances. Some methods below are for internal use
          47 * only and are marked InterfaceAudience.Private at the method level.

          Or I suppose, it still holds. The Private methods have been Deprecated.

          Deprecation in CellUtil is good.

          I don't like the name InternalCellUtil but it is explicit as to its use.

          Change this? 47 @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC) to Private I'd say... CPs messing w/ Cells other than Reading is not to be encouraged I'd say (They can construct over in CellUtil...)

          Skimmed... looking good.

          Show
          stack stack added a comment - License text is mangled in a few files. Fix this text on CellUtil: 46 * Utility methods helpful slinging {@link Cell} instances. Some methods below are for internal use 47 * only and are marked InterfaceAudience.Private at the method level. Or I suppose, it still holds. The Private methods have been Deprecated. Deprecation in CellUtil is good. I don't like the name InternalCellUtil but it is explicit as to its use. Change this? 47 @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC) to Private I'd say... CPs messing w/ Cells other than Reading is not to be encouraged I'd say (They can construct over in CellUtil...) Skimmed... looking good.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Patch to try QA against branch-2.
          We now have InternalCellUtil (any other name) with IA.LimitedPrivate. (should this be purely private?)
          Many of the methods in CellUtil are now in InternalCellUtil and those methods have been marked @deprecated except few which were only added recently.
          Am not sure whether to move the createFirstXXX and createLastXXX to InternalCellUtil. If yes I can move it.
          All Tags related APIs are moved to InternalCellUtil. Will upload to RB.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Patch to try QA against branch-2. We now have InternalCellUtil (any other name) with IA.LimitedPrivate. (should this be purely private?) Many of the methods in CellUtil are now in InternalCellUtil and those methods have been marked @deprecated except few which were only added recently. Am not sure whether to move the createFirstXXX and createLastXXX to InternalCellUtil. If yes I can move it. All Tags related APIs are moved to InternalCellUtil. Will upload to RB.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Just moved this under HBASE-18169 so that we don't lose track of this JIRa.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Just moved this under HBASE-18169 so that we don't lose track of this JIRa.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          I have updated the release version. If I can complete it early then fine else let it go into beta1.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - I have updated the release version. If I can complete it early then fine else let it go into beta1.
          Hide
          mdrob Mike Drob added a comment -

          Does this need to be in a4? I don't see it affecting CP APIs, maybe safe for b1?

          Show
          mdrob Mike Drob added a comment - Does this need to be in a4? I don't see it affecting CP APIs, maybe safe for b1?
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Some of these APIs which need to be moved out of CellUtil might be added in 2.0 only? If so, we can safely move out.

          Show
          anoop.hbase Anoop Sam John added a comment - Some of these APIs which need to be moved out of CellUtil might be added in 2.0 only? If so, we can safely move out.
          Hide
          chia7712 Chia-Ping Tsai added a comment - - edited

          If the patch will change many files, it would be better to keep branch-2 and master same as much as possible before 2.0 release. The conflicts happens on applying master patch to branch-2 can kill us in the future.

          Show
          chia7712 Chia-Ping Tsai added a comment - - edited If the patch will change many files, it would be better to keep branch-2 and master same as much as possible before 2.0 release. The conflicts happens on applying master patch to branch-2 can kill us in the future.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          I can see some methods related to createCell have already gone through deprecate cycle for 2.0. Will follow the same.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - I can see some methods related to createCell have already gone through deprecate cycle for 2.0. Will follow the same.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Should we follow Deprecation cycle for 2.0 and only in master branch move the API from CellUtil?

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Should we follow Deprecation cycle for 2.0 and only in master branch move the API from CellUtil?

            People

            • Assignee:
              ram_krish ramkrishna.s.vasudevan
              Reporter:
              ram_krish ramkrishna.s.vasudevan
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development