Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17958

Avoid passing unexpected cell to ScanQueryMatcher when optimize SEEK to SKIP

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0, 1.4.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ScanQueryMatcher.MatchCode qcode = matcher.match(cell);
      qcode = optimize(qcode, cell);
      

      The optimize method may change the MatchCode from SEEK_NEXT_COL/SEEK_NEXT_ROW to SKIP. But it still pass the next cell to ScanQueryMatcher. It will get wrong result when use some filter, etc. ColumnCountGetFilter. It just count the columns's number. If pass a same column to this filter, the count result will be wrong. So we should avoid passing cell to ScanQueryMatcher when optimize SEEK to SKIP.

      1. 0001-add-one-ut-testWithColumnCountGetFilter.patch
        6 kB
        Guanghao Zhang
      2. HBASE-17958-v1.patch
        9 kB
        Guanghao Zhang
      3. HBASE-17958-v2.patch
        14 kB
        Guanghao Zhang
      4. HBASE-17958-v3.patch
        16 kB
        Guanghao Zhang
      5. HBASE-17958-v4.patch
        22 kB
        Guanghao Zhang
      6. HBASE-17958-v5.patch
        23 kB
        Guanghao Zhang
      7. HBASE-17958-v6.patch
        23 kB
        Guanghao Zhang
      8. HBASE-17958-branch-1.patch
        33 kB
        Guanghao Zhang
      9. HBASE-17958-v7.patch
        23 kB
        Guanghao Zhang
      10. HBASE-17958-branch-1.patch
        33 kB
        Guanghao Zhang
      11. HBASE-17958-v7.patch
        23 kB
        Guanghao Zhang
      12. HBASE-17958-branch-1.patch
        33 kB
        Duo Zhang
      13. HBASE-17958-branch-1.patch
        33 kB
        Guanghao Zhang

        Issue Links

          Activity

          Hide
          Apache9 Duo Zhang added a comment -

          Yeah this is really a bad practice. The filter returns SEEK_NEXT_ROW or SEEK_NEXT_COL but we may still pass the cell of the same row or same column to SQM. We have a strange optimization in SQM called stickyNextRow(which is really confusing to me when refactoring SQM,,,) so SEEK_NEXT_ROW usually works, but for SEEK_NEXT_COL there is no such optimization so it is broken...

          In fact, if we decide that a skip is better than seek, then we should call heap.next() continuously until we reach the next row or next column, and then start to call SQM.match again. It is really confusing that SQM returns SEEK_NEXT_ROW or SEEK_NEXT_COL but it could still receive the cell from the same row or same column, right?

          Thanks.

          Show
          Apache9 Duo Zhang added a comment - Yeah this is really a bad practice. The filter returns SEEK_NEXT_ROW or SEEK_NEXT_COL but we may still pass the cell of the same row or same column to SQM. We have a strange optimization in SQM called stickyNextRow(which is really confusing to me when refactoring SQM,,,) so SEEK_NEXT_ROW usually works, but for SEEK_NEXT_COL there is no such optimization so it is broken... In fact, if we decide that a skip is better than seek, then we should call heap.next() continuously until we reach the next row or next column, and then start to call SQM.match again. It is really confusing that SQM returns SEEK_NEXT_ROW or SEEK_NEXT_COL but it could still receive the cell from the same row or same column, right? Thanks.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          In fact, if we decide that a skip is better than seek, then we should call heap.next() continuously until we reach the next row or next column, and then start to call SQM.match again.

          So the problem u say is here only when the optimize logic change seek to a skip. Ya u have a point then. Add a test case here for the bug so it will be very clear?

          Show
          anoop.hbase Anoop Sam John added a comment - In fact, if we decide that a skip is better than seek, then we should call heap.next() continuously until we reach the next row or next column, and then start to call SQM.match again. So the problem u say is here only when the optimize logic change seek to a skip. Ya u have a point then. Add a test case here for the bug so it will be very clear?
          Hide
          Apache9 Duo Zhang added a comment -

          Guanghao Zhang hit the bug when implementing ColumnCountGetFilter. He will prepare a patch soon.

          Show
          Apache9 Duo Zhang added a comment - Guanghao Zhang hit the bug when implementing ColumnCountGetFilter. He will prepare a patch soon.
          Hide
          zghaobac Guanghao Zhang added a comment -

          Anoop Sam John I found this problem when implement filter for HBASE-17125. I will upload a patch later. Thanks.

          Show
          zghaobac Guanghao Zhang added a comment - Anoop Sam John I found this problem when implement filter for HBASE-17125 . I will upload a patch later. Thanks.
          Hide
          lhofhansl Lars Hofhansl added a comment -

          Do you guys have a unit test to show this?

          Show
          lhofhansl Lars Hofhansl added a comment - Do you guys have a unit test to show this?
          Hide
          lhofhansl Lars Hofhansl added a comment -

          It is expected that the column trackers so the right thing. Filters that count the columns might be indeed be a problem, though. We should look at the column trackers in b this case.

          (I do object slightly to "this is really a bad practise", though. Seeking is unduly expensive in HBase, especially when the seek just lands is on the same block anyway.)

          Show
          lhofhansl Lars Hofhansl added a comment - It is expected that the column trackers so the right thing. Filters that count the columns might be indeed be a problem, though. We should look at the column trackers in b this case. (I do object slightly to "this is really a bad practise", though. Seeking is unduly expensive in HBase, especially when the seek just lands is on the same block anyway.)
          Hide
          Apache9 Duo Zhang added a comment -

          The idea is good, and converting seek to skip is a common optimization.

          The 'bad practice' here is the way we implement it. If the MatchCode is SEEK_NEXT_ROW or SEEK_NEXT_COL, no matter how you done the seek, either by a real seek or a sequence of skips, you should stop passing the cell in the same row or same column to the SQM, otherwise you should change the MatchCode to TRY_SEEK_NEXT_ROW and TRY_SEEK_NEXT_COL. It is really confusing.

          That's my point.

          Thanks.

          Show
          Apache9 Duo Zhang added a comment - The idea is good, and converting seek to skip is a common optimization. The 'bad practice' here is the way we implement it. If the MatchCode is SEEK_NEXT_ROW or SEEK_NEXT_COL, no matter how you done the seek, either by a real seek or a sequence of skips, you should stop passing the cell in the same row or same column to the SQM, otherwise you should change the MatchCode to TRY_SEEK_NEXT_ROW and TRY_SEEK_NEXT_COL. It is really confusing. That's my point. Thanks.
          Hide
          lhofhansl Lars Hofhansl added a comment -

          The problem is the order in which the filters and column trackers are executed.
          The column trackers do their own comparisons and do the right thing if a SKIP bubbles up (checked that carefully) - unless a filter interferes.

          On the other hand there is no right order between the trackers and the filters. Sometimes you want one order, sometimes the other.

          If in the SKIP case we call next until we hit the next row or column, we're doing the trackers' job.

          Hmm... I guess there has to be some acceptance that filters are a fairly low level concept and expose you to some of the HBase inerts.

          Especially counting filters are problematic since rows may have different number of columns and columns have varying numbers of versions.

          Show
          lhofhansl Lars Hofhansl added a comment - The problem is the order in which the filters and column trackers are executed. The column trackers do their own comparisons and do the right thing if a SKIP bubbles up (checked that carefully) - unless a filter interferes. On the other hand there is no right order between the trackers and the filters. Sometimes you want one order, sometimes the other. If in the SKIP case we call next until we hit the next row or column, we're doing the trackers' job. Hmm... I guess there has to be some acceptance that filters are a fairly low level concept and expose you to some of the HBase inerts. Especially counting filters are problematic since rows may have different number of columns and columns have varying numbers of versions.
          Hide
          Apache9 Duo Zhang added a comment -

          I do not think so.

          Can you imagine that, you call a seek on an InputStream, and the InputStream may do nothing and still return the next byte to you and you need to guess whether it really done the seek? That's not natural. If you really want to do this, do not call it seek please.

          And I do not get your point, why this is the job of the tracker? It is also strange that a ColumnTracker tells you that I have enough versions for this column so please seek to the next column or I have done with this row please seek to the next row, but you still pass the cells from the same column or same row to me and let me do the skip job? I can imagine that this question will be asked again and again by different people when they try to change the code in this area...

          Show
          Apache9 Duo Zhang added a comment - I do not think so. Can you imagine that, you call a seek on an InputStream, and the InputStream may do nothing and still return the next byte to you and you need to guess whether it really done the seek? That's not natural. If you really want to do this, do not call it seek please. And I do not get your point, why this is the job of the tracker? It is also strange that a ColumnTracker tells you that I have enough versions for this column so please seek to the next column or I have done with this row please seek to the next row, but you still pass the cells from the same column or same row to me and let me do the skip job? I can imagine that this question will be asked again and again by different people when they try to change the code in this area...
          Hide
          zghaobac Guanghao Zhang added a comment -

          Add a ut testWithColumnCountGetFilter to show this problem. When the scanner didn't optimize SEEK to SKIP, the result is right. But when scanner optimized SEEK to SKIP, the result is wrong.

          Show
          zghaobac Guanghao Zhang added a comment - Add a ut testWithColumnCountGetFilter to show this problem. When the scanner didn't optimize SEEK to SKIP, the result is right. But when scanner optimized SEEK to SKIP, the result is wrong.
          Hide
          zghaobac Guanghao Zhang added a comment -

          Code in ColumnCountGetFilter.

            public ReturnCode filterKeyValue(Cell v) {
              this.count++;
              return filterAllRemaining() ? ReturnCode.NEXT_COL : ReturnCode.INCLUDE_AND_NEXT_COL;
            }
          

          When it return ReturnCode.NEXT_COL or ReturnCode.INCLUDE_AND_NEXT_COL, it means the filter hope the next cell will have different column. But the StoreScanner optimized SEEK to SKIP and still pass the same column to the filter, then the filter's result will be wrong.

          Show
          zghaobac Guanghao Zhang added a comment - Code in ColumnCountGetFilter. public ReturnCode filterKeyValue(Cell v) { this .count++; return filterAllRemaining() ? ReturnCode.NEXT_COL : ReturnCode.INCLUDE_AND_NEXT_COL; } When it return ReturnCode.NEXT_COL or ReturnCode.INCLUDE_AND_NEXT_COL, it means the filter hope the next cell will have different column. But the StoreScanner optimized SEEK to SKIP and still pass the same column to the filter, then the filter's result will be wrong.
          Hide
          zghaobac Guanghao Zhang added a comment -

          Attach a v1 patch. The failed ut testWithCoulmnCountGetFilter fixed by this patch.

          Show
          zghaobac Guanghao Zhang added a comment - Attach a v1 patch. The failed ut testWithCoulmnCountGetFilter fixed by this patch.
          Hide
          zghaobac Guanghao Zhang added a comment -

          Attach a v2 patch. Move the optimize method to seekOrSkipToNextRow and seekOrSkipToNextColumn. Will remove old optimize method later.

          Show
          zghaobac Guanghao Zhang added a comment - Attach a v2 patch. Move the optimize method to seekOrSkipToNextRow and seekOrSkipToNextColumn. Will remove old optimize method later.
          Hide
          zghaobac Guanghao Zhang added a comment -

          Attach a v3 patch to trigger Hadoop QA.

          Show
          zghaobac Guanghao Zhang added a comment - Attach a v3 patch to trigger Hadoop QA.
          Hide
          Apache9 Duo Zhang added a comment -

          The precommit admin job is broken. I have triggered it manually.

          Show
          Apache9 Duo Zhang added a comment - The precommit admin job is broken. I have triggered it manually.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 10m 8s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 39s master passed
          +1 compile 0m 39s master passed
          +1 checkstyle 0m 50s master passed
          +1 mvneclipse 0m 15s master passed
          +1 findbugs 1m 52s master passed
          +1 javadoc 0m 29s master passed
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 38s the patch passed
          +1 javac 0m 38s the patch passed
          +1 checkstyle 0m 49s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 28m 28s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
          +1 findbugs 1m 59s the patch passed
          +1 javadoc 0m 28s the patch passed
          -1 unit 108m 37s hbase-server in the patch failed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          160m 33s



          Reason Tests
          Failed junit tests hadoop.hbase.regionserver.TestBlocksRead
            hadoop.hbase.snapshot.TestMobSecureExportSnapshot



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865237/HBASE-17958-v3.patch
          JIRA Issue HBASE-17958
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 28156023f3b6 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / 177344c
          Default Java 1.8.0_131
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/6586/artifact/patchprocess/patch-unit-hbase-server.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6586/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6586/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6586/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 8s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 39s master passed +1 compile 0m 39s master passed +1 checkstyle 0m 50s master passed +1 mvneclipse 0m 15s master passed +1 findbugs 1m 52s master passed +1 javadoc 0m 29s master passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 38s the patch passed +1 javac 0m 38s the patch passed +1 checkstyle 0m 49s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 28m 28s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 findbugs 1m 59s the patch passed +1 javadoc 0m 28s the patch passed -1 unit 108m 37s hbase-server in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 160m 33s Reason Tests Failed junit tests hadoop.hbase.regionserver.TestBlocksRead   hadoop.hbase.snapshot.TestMobSecureExportSnapshot Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865237/HBASE-17958-v3.patch JIRA Issue HBASE-17958 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 28156023f3b6 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / 177344c Default Java 1.8.0_131 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/6586/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6586/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6586/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6586/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          Apache9 Duo Zhang added a comment -

          Can avoid using lambda expression as I think the patch will also be applied to branch-1.

          And just call it 'trySkipTo' rather than 'optimizeSeekToSkip'? The name 'optimizeSeekToSkip' is bit confusing for me on whether we have done the skip when returning true.

          And I think there is a 'get' field in StoreScanner so we do not need to call scan.isGetScan()? There are bytes comparison in the method.

          Overall LGTM. +1.

          Show
          Apache9 Duo Zhang added a comment - Can avoid using lambda expression as I think the patch will also be applied to branch-1. And just call it 'trySkipTo' rather than 'optimizeSeekToSkip'? The name 'optimizeSeekToSkip' is bit confusing for me on whether we have done the skip when returning true. And I think there is a 'get' field in StoreScanner so we do not need to call scan.isGetScan()? There are bytes comparison in the method. Overall LGTM. +1.
          Hide
          lhofhansl Lars Hofhansl added a comment -

          Looks good generally.
          Are you sure we're not introducing at least one extra compare for each SKIP? We're comparing now in optimizeSeekToSkip and the ColumnTrackers will compare again before declaring a column/row as done.

          Show
          lhofhansl Lars Hofhansl added a comment - Looks good generally. Are you sure we're not introducing at least one extra compare for each SKIP? We're comparing now in optimizeSeekToSkip and the ColumnTrackers will compare again before declaring a column/row as done.
          Hide
          lhofhansl Lars Hofhansl added a comment -

          Can you imagine that, you call a seek on an InputStream, and the InputStream may do nothing and still return the next byte to you and you need to guess whether it really done the seek?

          This is different. What you get from an InputStream does not have an id. Here we do (the key of the Cell). An id that the ColumnTrackers later verifies again anyway.

          Anyway. The patch looks good, except for the potential extra compare for SKIPed columns and/or rows.

          Show
          lhofhansl Lars Hofhansl added a comment - Can you imagine that, you call a seek on an InputStream, and the InputStream may do nothing and still return the next byte to you and you need to guess whether it really done the seek? This is different. What you get from an InputStream does not have an id. Here we do (the key of the Cell). An id that the ColumnTrackers later verifies again anyway. Anyway. The patch looks good, except for the potential extra compare for SKIPed columns and/or rows.
          Hide
          Apache9 Duo Zhang added a comment -

          Yeah there will be one extra compare but I think it is OK? The code is much easier to understand right now, and Guanghao Zhang's patch has shown us that, we have already written wrong code in HBase. Make things right before making it fast, that's my point.

          Thanks.

          Show
          Apache9 Duo Zhang added a comment - Yeah there will be one extra compare but I think it is OK? The code is much easier to understand right now, and Guanghao Zhang 's patch has shown us that, we have already written wrong code in HBase. Make things right before making it fast, that's my point. Thanks.
          Hide
          Apache9 Duo Zhang added a comment -

          And if you really want to eliminate the extra compare, I think the proper way is to introduce a new method to column tracker which set a flag to indicate that the next cell will have a new qualifier. Just like what we have done when switching rows.

          Thanks.

          Show
          Apache9 Duo Zhang added a comment - And if you really want to eliminate the extra compare, I think the proper way is to introduce a new method to column tracker which set a flag to indicate that the next cell will have a new qualifier. Just like what we have done when switching rows. Thanks.
          Hide
          zghaobac Guanghao Zhang added a comment -

          Just like what we have done when switching rows.

          You mean the stickyNextRow flag?

              // if row key is changed, then we know that we have moved over to the next row
              if (rowComparator.compareRows(currentRow, cell) != 0) {
                return MatchCode.DONE;
              }
              // optimize case.
              if (this.stickyNextRow) {
                return MatchCode.SEEK_NEXT_ROW;
              }
          

          The current code in ScanQueryMatcher's preCheck method. Even SQM has the stickyNextRow flag, it still compare row first.

          Show
          zghaobac Guanghao Zhang added a comment - Just like what we have done when switching rows. You mean the stickyNextRow flag? // if row key is changed, then we know that we have moved over to the next row if (rowComparator.compareRows(currentRow, cell) != 0) { return MatchCode.DONE; } // optimize case . if ( this .stickyNextRow) { return MatchCode.SEEK_NEXT_ROW; } The current code in ScanQueryMatcher's preCheck method. Even SQM has the stickyNextRow flag, it still compare row first.
          Hide
          zghaobac Guanghao Zhang added a comment -

          1. Addressed review comments from Duo Zhang
          2. Remove stickyNextRow.

          Show
          zghaobac Guanghao Zhang added a comment - 1. Addressed review comments from Duo Zhang 2. Remove stickyNextRow.
          Hide
          zghaobac Guanghao Zhang added a comment -

          Attach a v5 patch. Add ++kvScanned in trySkip* method.

          Show
          zghaobac Guanghao Zhang added a comment - Attach a v5 patch. Add ++kvScanned in trySkip* method.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 14s master passed
          +1 compile 0m 41s master passed
          +1 checkstyle 0m 48s master passed
          +1 mvneclipse 0m 15s master passed
          +1 findbugs 1m 58s master passed
          +1 javadoc 0m 30s master passed
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 39s the patch passed
          +1 javac 0m 39s the patch passed
          +1 checkstyle 0m 49s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 29m 10s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
          +1 findbugs 2m 4s the patch passed
          +1 javadoc 0m 29s the patch passed
          -1 unit 121m 17s hbase-server in the patch failed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          164m 7s



          Reason Tests
          Failed junit tests hadoop.hbase.snapshot.TestMobSecureExportSnapshot
            hadoop.hbase.snapshot.TestExportSnapshot
            hadoop.hbase.snapshot.TestMobExportSnapshot
            hadoop.hbase.snapshot.TestSecureExportSnapshot
            hadoop.hbase.regionserver.TestBlocksRead



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865292/HBASE-17958-v4.patch
          JIRA Issue HBASE-17958
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 74b182fa0ce9 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision master / 880db3e
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/6594/artifact/patchprocess/patch-unit-hbase-server.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6594/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6594/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6594/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 14s master passed +1 compile 0m 41s master passed +1 checkstyle 0m 48s master passed +1 mvneclipse 0m 15s master passed +1 findbugs 1m 58s master passed +1 javadoc 0m 30s master passed +1 mvninstall 0m 45s the patch passed +1 compile 0m 39s the patch passed +1 javac 0m 39s the patch passed +1 checkstyle 0m 49s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 29m 10s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 findbugs 2m 4s the patch passed +1 javadoc 0m 29s the patch passed -1 unit 121m 17s hbase-server in the patch failed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 164m 7s Reason Tests Failed junit tests hadoop.hbase.snapshot.TestMobSecureExportSnapshot   hadoop.hbase.snapshot.TestExportSnapshot   hadoop.hbase.snapshot.TestMobExportSnapshot   hadoop.hbase.snapshot.TestSecureExportSnapshot   hadoop.hbase.regionserver.TestBlocksRead Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865292/HBASE-17958-v4.patch JIRA Issue HBASE-17958 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 74b182fa0ce9 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / 880db3e Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/6594/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6594/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6594/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6594/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          Apache9 Duo Zhang added a comment -

          Is TestBlocksRead related?

          Show
          Apache9 Duo Zhang added a comment - Is TestBlocksRead related?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 35s master passed
          +1 compile 0m 42s master passed
          +1 checkstyle 0m 56s master passed
          +1 mvneclipse 0m 21s master passed
          +1 findbugs 1m 55s master passed
          +1 javadoc 0m 39s master passed
          +1 mvninstall 0m 48s the patch passed
          +1 compile 0m 41s the patch passed
          +1 javac 0m 41s the patch passed
          +1 checkstyle 0m 48s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 30m 8s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
          +1 findbugs 1m 58s the patch passed
          +1 javadoc 0m 26s the patch passed
          -1 unit 107m 39s hbase-server in the patch failed.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          155m 7s



          Reason Tests
          Failed junit tests hadoop.hbase.snapshot.TestSecureExportSnapshot
            hadoop.hbase.snapshot.TestMobSecureExportSnapshot
            hadoop.hbase.master.procedure.TestModifyNamespaceProcedure
            hadoop.hbase.regionserver.TestBlocksRead
            hadoop.hbase.snapshot.TestMobExportSnapshot
          Timed out junit tests org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService
            org.apache.hadoop.hbase.TestJMXConnectorServer



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865301/HBASE-17958-v5.patch
          JIRA Issue HBASE-17958
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux ec983b7eec99 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision master / 880db3e
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/6600/artifact/patchprocess/patch-unit-hbase-server.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6600/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6600/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6600/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 35s master passed +1 compile 0m 42s master passed +1 checkstyle 0m 56s master passed +1 mvneclipse 0m 21s master passed +1 findbugs 1m 55s master passed +1 javadoc 0m 39s master passed +1 mvninstall 0m 48s the patch passed +1 compile 0m 41s the patch passed +1 javac 0m 41s the patch passed +1 checkstyle 0m 48s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 30m 8s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 findbugs 1m 58s the patch passed +1 javadoc 0m 26s the patch passed -1 unit 107m 39s hbase-server in the patch failed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 155m 7s Reason Tests Failed junit tests hadoop.hbase.snapshot.TestSecureExportSnapshot   hadoop.hbase.snapshot.TestMobSecureExportSnapshot   hadoop.hbase.master.procedure.TestModifyNamespaceProcedure   hadoop.hbase.regionserver.TestBlocksRead   hadoop.hbase.snapshot.TestMobExportSnapshot Timed out junit tests org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService   org.apache.hadoop.hbase.TestJMXConnectorServer Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:8d52d23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865301/HBASE-17958-v5.patch JIRA Issue HBASE-17958 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux ec983b7eec99 3.13.0-107-generic #154-Ubuntu SMP Tue Dec 20 09:57:27 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / 880db3e Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/6600/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6600/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6600/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6600/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          zghaobac Guanghao Zhang added a comment -

          TestBlocksRead failed on my computer, too. There is a assert failed. Let me check it.

          Show
          zghaobac Guanghao Zhang added a comment - TestBlocksRead failed on my computer, too. There is a assert failed. Let me check it.
          Hide
          zghaobac Guanghao Zhang added a comment -

          When optimize seek to skip, it will call next to next column/row. But the heap's current scanner maybe changed when call next. The new scanner maybe not seeked because the laze seek feature. So TestBlocksRead failed. One solution is decide whether to optimize before every next call. Attach a v6 patch which showed the solution.

          Show
          zghaobac Guanghao Zhang added a comment - When optimize seek to skip, it will call next to next column/row. But the heap's current scanner maybe changed when call next. The new scanner maybe not seeked because the laze seek feature. So TestBlocksRead failed. One solution is decide whether to optimize before every next call. Attach a v6 patch which showed the solution.
          Hide
          Apache9 Duo Zhang added a comment -

          I do not follow. What's the problem? The next scanner may not be seeked because of the lazy seek feature, then? I think it will do the actual seek otherwise the logic is broken and I do not think the failed UTs will be TestBlocksRead only.

          Show
          Apache9 Duo Zhang added a comment - I do not follow. What's the problem? The next scanner may not be seeked because of the lazy seek feature, then? I think it will do the actual seek otherwise the logic is broken and I do not think the failed UTs will be TestBlocksRead only.
          Hide
          Apache9 Duo Zhang added a comment -

          Oh, I see. We will pass a fake cell to SQM and SQM will return a SEEK_TO_NEXT_ROW or SEEK_NEXT_COLUMN. So if we get a fake cell when calling heap.next(), we need to do a real seek.

          Show
          Apache9 Duo Zhang added a comment - Oh, I see. We will pass a fake cell to SQM and SQM will return a SEEK_TO_NEXT_ROW or SEEK_NEXT_COLUMN. So if we get a fake cell when calling heap.next(), we need to do a real seek.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 29s master passed
          +1 compile 0m 46s master passed
          +1 checkstyle 0m 49s master passed
          +1 mvneclipse 0m 16s master passed
          +1 findbugs 2m 2s master passed
          +1 javadoc 0m 27s master passed
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 37s the patch passed
          +1 javac 0m 37s the patch passed
          +1 checkstyle 0m 47s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 27m 20s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
          +1 findbugs 1m 54s the patch passed
          +1 javadoc 0m 26s the patch passed
          -1 unit 113m 59s hbase-server in the patch failed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          154m 50s



          Reason Tests
          Failed junit tests hadoop.hbase.snapshot.TestExportSnapshot



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865476/HBASE-17958-v6.patch
          JIRA Issue HBASE-17958
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux d71d52267a1a 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision master / c4cbb41
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/6617/artifact/patchprocess/patch-unit-hbase-server.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6617/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6617/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6617/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 29s master passed +1 compile 0m 46s master passed +1 checkstyle 0m 49s master passed +1 mvneclipse 0m 16s master passed +1 findbugs 2m 2s master passed +1 javadoc 0m 27s master passed +1 mvninstall 0m 44s the patch passed +1 compile 0m 37s the patch passed +1 javac 0m 37s the patch passed +1 checkstyle 0m 47s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 27m 20s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 26s the patch passed -1 unit 113m 59s hbase-server in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 154m 50s Reason Tests Failed junit tests hadoop.hbase.snapshot.TestExportSnapshot Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865476/HBASE-17958-v6.patch JIRA Issue HBASE-17958 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux d71d52267a1a 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / c4cbb41 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/6617/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6617/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6617/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6617/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          zghaobac Guanghao Zhang added a comment -

          When the heap changed the current storefile scanner, the new storefile maybe have lots of cell for current column. And the new scanner has a new nextIndexedKey, it may be not suitable to optimize SEEK to SKIP. So we should decide whether to optimize after call heap.next() every time. Any more concerns about v6 patch? Lars Hofhansl Duo Zhang

          Show
          zghaobac Guanghao Zhang added a comment - When the heap changed the current storefile scanner, the new storefile maybe have lots of cell for current column. And the new scanner has a new nextIndexedKey, it may be not suitable to optimize SEEK to SKIP. So we should decide whether to optimize after call heap.next() every time. Any more concerns about v6 patch? Lars Hofhansl Duo Zhang
          Hide
          Apache9 Duo Zhang added a comment -

          One problem, BiFunction is introduced in java8 so we can not use it for branch-1. Overall LGTM. Let's prepare a patch for branch-1?

          Thanks.

          Show
          Apache9 Duo Zhang added a comment - One problem, BiFunction is introduced in java8 so we can not use it for branch-1. Overall LGTM. Let's prepare a patch for branch-1? Thanks.
          Hide
          zghaobac Guanghao Zhang added a comment -

          Attach a patch for branch-1. HBASE-15392 add some ut for optimize SEEK to SKIP. But the ut didn't backport to branch-1. I backport it in this patch.

          Show
          zghaobac Guanghao Zhang added a comment - Attach a patch for branch-1. HBASE-15392 add some ut for optimize SEEK to SKIP. But the ut didn't backport to branch-1. I backport it in this patch.
          Hide
          zghaobac Guanghao Zhang added a comment -

          Remove the unused import (BiFunction) in v7 patch.

          Show
          zghaobac Guanghao Zhang added a comment - Remove the unused import (BiFunction) in v7 patch.
          Hide
          zghaobac Guanghao Zhang added a comment -

          Reattached for Hadoop QA.

          Show
          zghaobac Guanghao Zhang added a comment - Reattached for Hadoop QA.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 30s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 43s master passed
          +1 compile 1m 40s master passed
          +1 checkstyle 1m 42s master passed
          +1 mvneclipse 0m 37s master passed
          +1 findbugs 4m 42s master passed
          +1 javadoc 0m 49s master passed
          +1 mvninstall 1m 26s the patch passed
          +1 compile 1m 18s the patch passed
          +1 javac 1m 18s the patch passed
          +1 checkstyle 1m 26s the patch passed
          +1 mvneclipse 0m 24s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 54m 59s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
          +1 findbugs 4m 19s the patch passed
          +1 javadoc 0m 52s the patch passed
          -1 unit 195m 8s hbase-server in the patch failed.
          +1 asflicense 0m 28s The patch does not generate ASF License warnings.
          278m 42s



          Reason Tests
          Failed junit tests hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
            hadoop.hbase.client.TestAsyncTableAdminApi
          Timed out junit tests org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd



          Subsystem Report/Notes
          Docker Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:8d52d23
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865932/HBASE-17958-v7.patch
          JIRA Issue HBASE-17958
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 16b756632287 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
          git revision master / c8a7e80
          Default Java 1.8.0_121
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/6662/artifact/patchprocess/patch-unit-hbase-server.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6662/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6662/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6662/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 30s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 43s master passed +1 compile 1m 40s master passed +1 checkstyle 1m 42s master passed +1 mvneclipse 0m 37s master passed +1 findbugs 4m 42s master passed +1 javadoc 0m 49s master passed +1 mvninstall 1m 26s the patch passed +1 compile 1m 18s the patch passed +1 javac 1m 18s the patch passed +1 checkstyle 1m 26s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 54m 59s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 findbugs 4m 19s the patch passed +1 javadoc 0m 52s the patch passed -1 unit 195m 8s hbase-server in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 278m 42s Reason Tests Failed junit tests hadoop.hbase.master.balancer.TestStochasticLoadBalancer2   hadoop.hbase.client.TestAsyncTableAdminApi Timed out junit tests org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd Subsystem Report/Notes Docker Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:8d52d23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865932/HBASE-17958-v7.patch JIRA Issue HBASE-17958 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 16b756632287 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh git revision master / c8a7e80 Default Java 1.8.0_121 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/6662/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6662/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6662/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6662/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 21s master passed
          +1 compile 0m 38s master passed
          +1 checkstyle 0m 46s master passed
          +1 mvneclipse 0m 15s master passed
          +1 findbugs 1m 46s master passed
          +1 javadoc 0m 27s master passed
          +1 mvninstall 0m 43s the patch passed
          +1 compile 0m 37s the patch passed
          +1 javac 0m 37s the patch passed
          +1 checkstyle 0m 47s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 27m 37s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2.
          +1 findbugs 1m 53s the patch passed
          +1 javadoc 0m 26s the patch passed
          +1 unit 110m 55s hbase-server in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          151m 24s



          Subsystem Report/Notes
          Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865988/HBASE-17958-v7.patch
          JIRA Issue HBASE-17958
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux e59c9d5e3485 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
          git revision master / c8a7e80
          Default Java 1.8.0_121
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6665/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6665/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 21s master passed +1 compile 0m 38s master passed +1 checkstyle 0m 46s master passed +1 mvneclipse 0m 15s master passed +1 findbugs 1m 46s master passed +1 javadoc 0m 27s master passed +1 mvninstall 0m 43s the patch passed +1 compile 0m 37s the patch passed +1 javac 0m 37s the patch passed +1 checkstyle 0m 47s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 27m 37s Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha2. +1 findbugs 1m 53s the patch passed +1 javadoc 0m 26s the patch passed +1 unit 110m 55s hbase-server in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 151m 24s Subsystem Report/Notes Docker Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12865988/HBASE-17958-v7.patch JIRA Issue HBASE-17958 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux e59c9d5e3485 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh git revision master / c8a7e80 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6665/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6665/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          Apache9 Duo Zhang added a comment -

          Retry.

          Show
          Apache9 Duo Zhang added a comment - Retry.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 24m 19s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 0m 22s Maven dependency ordering for branch
          +1 mvninstall 3m 5s branch-1 passed
          +1 compile 2m 59s branch-1 passed
          +1 checkstyle 2m 19s branch-1 passed
          +1 mvneclipse 1m 14s branch-1 passed
          -1 findbugs 0m 58s hbase-common in branch-1 has 1 extant Findbugs warnings.
          -1 findbugs 1m 0s hbase-common in branch-1 has 1 extant Findbugs warnings.
          -1 findbugs 3m 52s hbase-server in branch-1 has 3 extant Findbugs warnings.
          -1 findbugs 3m 40s hbase-server in branch-1 has 3 extant Findbugs warnings.
          +1 javadoc 2m 27s branch-1 passed
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 39s the patch passed
          +1 compile 1m 31s the patch passed
          +1 javac 0m 23s hbase-common generated 0 new + 10 unchanged - 10 fixed = 10 total (was 20)
          +1 javac 1m 8s hbase-server generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10)
          +1 checkstyle 1m 9s the patch passed
          +1 mvneclipse 0m 37s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 27m 48s The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 hbaseprotoc 0m 36s the patch passed
          +1 findbugs 5m 13s the patch passed
          +1 javadoc 0m 23s hbase-common generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2)
          +1 javadoc 0m 49s hbase-server generated 0 new + 3 unchanged - 3 fixed = 3 total (was 6)
          +1 unit 2m 42s hbase-common in the patch passed.
          -1 unit 173m 32s hbase-server in the patch failed.
          +1 asflicense 0m 45s The patch does not generate ASF License warnings.
          264m 39s



          Reason Tests
          Failed junit tests hadoop.hbase.client.TestAdmin1
            hadoop.hbase.master.balancer.TestStochasticLoadBalancer2
            hadoop.hbase.regionserver.TestRSKilledWhenInitializing
            hadoop.hbase.snapshot.TestExportSnapshot
            hadoop.hbase.regionserver.TestPerColumnFamilyFlush
            hadoop.hbase.master.procedure.TestModifyNamespaceProcedure
            hadoop.hbase.master.TestMasterBalanceThrottling
          Timed out junit tests org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
            org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd



          Subsystem Report/Notes
          Docker Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:58c504e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866102/HBASE-17958-branch-1.patch
          JIRA Issue HBASE-17958
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux 85e239ad5d5d 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/hbase.sh
          git revision branch-1 / 58c504e
          Default Java 1.8.0_131
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/branch-findbugs-hbase-common-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/branch-findbugs-hbase-common-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/patch-unit-hbase-server.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6678/testReport/
          modules C: hbase-common hbase-server U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6678/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 24m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 22s Maven dependency ordering for branch +1 mvninstall 3m 5s branch-1 passed +1 compile 2m 59s branch-1 passed +1 checkstyle 2m 19s branch-1 passed +1 mvneclipse 1m 14s branch-1 passed -1 findbugs 0m 58s hbase-common in branch-1 has 1 extant Findbugs warnings. -1 findbugs 1m 0s hbase-common in branch-1 has 1 extant Findbugs warnings. -1 findbugs 3m 52s hbase-server in branch-1 has 3 extant Findbugs warnings. -1 findbugs 3m 40s hbase-server in branch-1 has 3 extant Findbugs warnings. +1 javadoc 2m 27s branch-1 passed 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 39s the patch passed +1 compile 1m 31s the patch passed +1 javac 0m 23s hbase-common generated 0 new + 10 unchanged - 10 fixed = 10 total (was 20) +1 javac 1m 8s hbase-server generated 0 new + 5 unchanged - 5 fixed = 5 total (was 10) +1 checkstyle 1m 9s the patch passed +1 mvneclipse 0m 37s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 27m 48s The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 hbaseprotoc 0m 36s the patch passed +1 findbugs 5m 13s the patch passed +1 javadoc 0m 23s hbase-common generated 0 new + 1 unchanged - 1 fixed = 1 total (was 2) +1 javadoc 0m 49s hbase-server generated 0 new + 3 unchanged - 3 fixed = 3 total (was 6) +1 unit 2m 42s hbase-common in the patch passed. -1 unit 173m 32s hbase-server in the patch failed. +1 asflicense 0m 45s The patch does not generate ASF License warnings. 264m 39s Reason Tests Failed junit tests hadoop.hbase.client.TestAdmin1   hadoop.hbase.master.balancer.TestStochasticLoadBalancer2   hadoop.hbase.regionserver.TestRSKilledWhenInitializing   hadoop.hbase.snapshot.TestExportSnapshot   hadoop.hbase.regionserver.TestPerColumnFamilyFlush   hadoop.hbase.master.procedure.TestModifyNamespaceProcedure   hadoop.hbase.master.TestMasterBalanceThrottling Timed out junit tests org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot   org.apache.hadoop.hbase.filter.TestFuzzyRowFilterEndToEnd Subsystem Report/Notes Docker Client=17.03.0-ce Server=17.03.0-ce Image:yetus/hbase:58c504e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866102/HBASE-17958-branch-1.patch JIRA Issue HBASE-17958 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux 85e239ad5d5d 4.8.3-std-1 #1 SMP Fri Oct 21 11:15:43 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/hbase.sh git revision branch-1 / 58c504e Default Java 1.8.0_131 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/branch-findbugs-hbase-common-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/branch-findbugs-hbase-common-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6678/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6678/testReport/ modules C: hbase-common hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6678/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          Apache9 Duo Zhang added a comment -

          Guanghao Zhang Could you please verify if the failed UTs are related?

          Show
          Apache9 Duo Zhang added a comment - Guanghao Zhang Could you please verify if the failed UTs are related?
          Hide
          zghaobac Guanghao Zhang added a comment -

          The failed UTs should be not related. I try them locally and TestRSKilledWhenInitializing failed (run 3 times and failed 2 times). But it may failed on branch-1, too. So I thought it may be a flaky test of branch-1. But we don't have a flaky test dashboard for branch-1? I will reattach the patch to trigger the hadoop QA again.

          Show
          zghaobac Guanghao Zhang added a comment - The failed UTs should be not related. I try them locally and TestRSKilledWhenInitializing failed (run 3 times and failed 2 times). But it may failed on branch-1, too. So I thought it may be a flaky test of branch-1. But we don't have a flaky test dashboard for branch-1? I will reattach the patch to trigger the hadoop QA again.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 11m 43s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          0 mvndep 1m 13s Maven dependency ordering for branch
          +1 mvninstall 5m 56s branch-1 passed
          +1 compile 0m 44s branch-1 passed with JDK v1.8.0_131
          +1 compile 0m 51s branch-1 passed with JDK v1.7.0_80
          +1 checkstyle 0m 47s branch-1 passed
          +1 mvneclipse 0m 41s branch-1 passed
          -1 findbugs 1m 58s hbase-server in branch-1 has 3 extant Findbugs warnings.
          +1 javadoc 0m 47s branch-1 passed with JDK v1.8.0_131
          +1 javadoc 0m 49s branch-1 passed with JDK v1.7.0_80
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 59s the patch passed
          +1 compile 0m 51s the patch passed with JDK v1.8.0_131
          +1 javac 0m 51s the patch passed
          +1 compile 0m 52s the patch passed with JDK v1.7.0_80
          +1 javac 0m 52s the patch passed
          +1 checkstyle 0m 42s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 hadoopcheck 16m 1s The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1.
          +1 hbaseprotoc 0m 25s the patch passed
          +1 findbugs 3m 6s the patch passed
          +1 javadoc 0m 43s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 51s the patch passed with JDK v1.7.0_80
          +1 unit 1m 40s hbase-common in the patch passed.
          -1 unit 83m 34s hbase-server in the patch failed.
          +1 asflicense 0m 33s The patch does not generate ASF License warnings.
          137m 51s



          Reason Tests
          Failed junit tests hadoop.hbase.regionserver.TestCompactionInDeadRegionServer



          Subsystem Report/Notes
          Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:58c504e
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866152/HBASE-17958-branch-1.patch
          JIRA Issue HBASE-17958
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux bdbb9ed4a15d 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/hbase.sh
          git revision branch-1 / 58c504e
          Default Java 1.7.0_80
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-oracle:1.7.0_80
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/6683/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/6683/artifact/patchprocess/patch-unit-hbase-server.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6683/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6683/testReport/
          modules C: hbase-common hbase-server U: .
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6683/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 43s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 13s Maven dependency ordering for branch +1 mvninstall 5m 56s branch-1 passed +1 compile 0m 44s branch-1 passed with JDK v1.8.0_131 +1 compile 0m 51s branch-1 passed with JDK v1.7.0_80 +1 checkstyle 0m 47s branch-1 passed +1 mvneclipse 0m 41s branch-1 passed -1 findbugs 1m 58s hbase-server in branch-1 has 3 extant Findbugs warnings. +1 javadoc 0m 47s branch-1 passed with JDK v1.8.0_131 +1 javadoc 0m 49s branch-1 passed with JDK v1.7.0_80 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 59s the patch passed +1 compile 0m 51s the patch passed with JDK v1.8.0_131 +1 javac 0m 51s the patch passed +1 compile 0m 52s the patch passed with JDK v1.7.0_80 +1 javac 0m 52s the patch passed +1 checkstyle 0m 42s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 hadoopcheck 16m 1s The patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. +1 hbaseprotoc 0m 25s the patch passed +1 findbugs 3m 6s the patch passed +1 javadoc 0m 43s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 51s the patch passed with JDK v1.7.0_80 +1 unit 1m 40s hbase-common in the patch passed. -1 unit 83m 34s hbase-server in the patch failed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 137m 51s Reason Tests Failed junit tests hadoop.hbase.regionserver.TestCompactionInDeadRegionServer Subsystem Report/Notes Docker Client=1.11.2 Server=1.11.2 Image:yetus/hbase:58c504e JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12866152/HBASE-17958-branch-1.patch JIRA Issue HBASE-17958 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux bdbb9ed4a15d 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/hbase.sh git revision branch-1 / 58c504e Default Java 1.7.0_80 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-oracle:1.7.0_80 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/6683/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html unit https://builds.apache.org/job/PreCommit-HBASE-Build/6683/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/6683/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/6683/testReport/ modules C: hbase-common hbase-server U: . Console output https://builds.apache.org/job/PreCommit-HBASE-Build/6683/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          Apache9 Duo Zhang added a comment -

          +1.

          Show
          Apache9 Duo Zhang added a comment - +1.
          Hide
          zghaobac Guanghao Zhang added a comment -

          Pushed to master and branch-1. Thanks Duo Zhang for reviewing.

          Show
          zghaobac Guanghao Zhang added a comment - Pushed to master and branch-1. Thanks Duo Zhang for reviewing.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-1.4 #718 (See https://builds.apache.org/job/HBase-1.4/718/)
          HBASE-17958 Avoid passing unexpected cell to ScanQueryMatcher when (zghao: rev 9f25836d99a7468a26bacb6a3009cf0fdc9736a8)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/LegacyScanQueryMatcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java
          • (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-1.4 #718 (See https://builds.apache.org/job/HBase-1.4/718/ ) HBASE-17958 Avoid passing unexpected cell to ScanQueryMatcher when (zghao: rev 9f25836d99a7468a26bacb6a3009cf0fdc9736a8) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/LegacyScanQueryMatcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/CellUtil.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2944 (See https://builds.apache.org/job/HBase-Trunk_matrix/2944/)
          HBASE-17958 Avoid passing unexpected cell to ScanQueryMatcher when (zghao: rev 91995749c214135163d96316d915d2a084dfb690)

          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/LegacyScanQueryMatcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java
          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #2944 (See https://builds.apache.org/job/HBase-Trunk_matrix/2944/ ) HBASE-17958 Avoid passing unexpected cell to ScanQueryMatcher when (zghao: rev 91995749c214135163d96316d915d2a084dfb690) (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/LegacyScanQueryMatcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          OOO for the entire day. Expect delays in email replies.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - OOO for the entire day. Expect delays in email replies.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build HBase-HBASE-14614 #223 (See https://builds.apache.org/job/HBase-HBASE-14614/223/)
          HBASE-17958 Avoid passing unexpected cell to ScanQueryMatcher when (zghao: rev 91995749c214135163d96316d915d2a084dfb690)

          • (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/LegacyScanQueryMatcher.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
          • (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build HBase- HBASE-14614 #223 (See https://builds.apache.org/job/HBase-HBASE-14614/223/ ) HBASE-17958 Avoid passing unexpected cell to ScanQueryMatcher when (zghao: rev 91995749c214135163d96316d915d2a084dfb690) (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/LegacyScanQueryMatcher.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/UserScanQueryMatcher.java

            People

            • Assignee:
              zghaobac Guanghao Zhang
              Reporter:
              zghaobac Guanghao Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development