Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17958

Avoid passing unexpected cell to ScanQueryMatcher when optimize SEEK to SKIP

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.4.0, 2.0.0
    • None
    • None
    • Reviewed

    Description

      ScanQueryMatcher.MatchCode qcode = matcher.match(cell);
qcode = optimize(qcode, cell);

      The optimize method may change the MatchCode from SEEK_NEXT_COL/SEEK_NEXT_ROW to SKIP. But it still pass the next cell to ScanQueryMatcher. It will get wrong result when use some filter, etc. ColumnCountGetFilter. It just count the columns's number. If pass a same column to this filter, the count result will be wrong. So we should avoid passing cell to ScanQueryMatcher when optimize SEEK to SKIP.

      Attachments

        1. 0001-add-one-ut-testWithColumnCountGetFilter.patch
          6 kB
          Guanghao Zhang
        2. HBASE-17958-v1.patch
          9 kB
          Guanghao Zhang
        3. HBASE-17958-v2.patch
          14 kB
          Guanghao Zhang
        4. HBASE-17958-v3.patch
          16 kB
          Guanghao Zhang
        5. HBASE-17958-v4.patch
          22 kB
          Guanghao Zhang
        6. HBASE-17958-v5.patch
          23 kB
          Guanghao Zhang
        7. HBASE-17958-v6.patch
          23 kB
          Guanghao Zhang
        8. HBASE-17958-branch-1.patch
          33 kB
          Guanghao Zhang
        9. HBASE-17958-v7.patch
          23 kB
          Guanghao Zhang
        10. HBASE-17958-branch-1.patch
          33 kB
          Guanghao Zhang
        11. HBASE-17958-v7.patch
          23 kB
          Guanghao Zhang
        12. HBASE-17958-branch-1.patch
          33 kB
          Duo Zhang
        13. HBASE-17958-branch-1.patch
          33 kB
          Guanghao Zhang
        14. 17958-add.txt
          2 kB
          Lars Hofhansl

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. HBASE-19863 java.lang.IllegalStateException: isDelete failed when SingleColumnValueFilter is used

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. HBASE-13109 Make better SEEK vs SKIP decisions during scanning

          • Major - Major loss of function.
          • Closed
          relates to

          Sub-task - The sub-task of the issue HBASE-19034 Implement "optimize SEEK to SKIP" in storefile scanner

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. HBASE-24742 Improve performance of SKIP vs SEEK logic

          • Major - Major loss of function.
          • Closed

          Activity

            People

              zghao Guanghao Zhang
              zghao Guanghao Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: