[HBASE-17647] OffheapKeyValue#heapSize() implementation is wrong

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Component/s: regionserver
• Hadoop Flags: Incompatible change, Reviewed
• Assignee: Anoop Sam John
• Reporter: Anoop Sam John
• Created: 14/Feb/17 10:13
• Updated: 01/Jul/22 21:34
• Resolved: 23/Feb/17 06:00

Description

We consider the key and data lengths also even though the data is actually in off heap area. We should correct it.
The impact will be at ScannerContext limit tracking where we use heapSize of cells to account the result size. So my proposal is to consider the cells length and heap size in Limit tracking and accounting. We have a maxResultSize which defaults to 2MB. When the sum of all cell's data size reaches 'maxResultSize' OR the sum of all cell's heap size reaches 'maxResultSize' , we need to send back the RPC response

Issue Links

• blocks: HBASE-17338 Treat Cell data size under global memstore heap size only when that Cell can not be copied to MSLAB