[HBASE-17338] Treat Cell data size under global memstore heap size only when that Cell can not be copied to MSLAB

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Component/s: regionserver
• Hadoop Flags: Reviewed
• Assignee: Anoop Sam John
• Reporter: Anoop Sam John
• Created: 19/Dec/16 13:18
• Updated: 01/Jul/22 21:33
• Resolved: 10/Mar/17 05:43

Description

We have only data size and heap overhead being tracked globally. Off heap memstore works with off heap backed MSLAB pool. But a cell, when added to memstore, not always getting copied to MSLAB. Append/Increment ops doing an upsert, dont use MSLAB. Also based on the Cell size, we sometimes avoid MSLAB copy. But now we track these cell data size also under the global memstore data size which indicated off heap size in case of off heap memstore. For global checks for flushes (against lower/upper watermark levels), we check this size against max off heap memstore size. We do check heap overhead against global heap memstore size (Defaults to 40% of xmx) But for such cells the data size also should be accounted under the heap overhead.

Issue Links

• is blocked by: HBASE-17647 OffheapKeyValue#heapSize() implementation is wrong