[HBASE-17578] Thrift per-method metrics should still update in the case of exceptions

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0, 1.3.1, 2.0.0
• Component/s: Thrift

Release Note

In prior versions, the HBase Thrift handlers failed to increment per-method metrics when an exception was encountered. These metrics will now always be incremented, whether an exception is encountered or not. This change also adds exception-type metrics, similar to those exposed in regionservers, for individual exceptions which are received by the Thrift handlers.

• Assignee: Gary Helmling
• Reporter: Gary Helmling
• Created: 01/Feb/17 20:38
• Updated: 01/Jul/22 20:28
• Resolved: 06/Feb/17 20:43

Description

Currently, the InvocationHandler used to update per-method metrics in the Thrift server fails to update metrics if an exception occurs. This causes us to miss outliers. We should include exceptional cases in per-method latencies, and also look at adding specific exception rate metrics.

Issue Links

• blocks: HBASE-17524 HBase 1.3.1 release