Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17578

Thrift per-method metrics should still update in the case of exceptions

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0, 1.3.1, 2.0.0
    • Component/s: Thrift
    • Labels:
      None
    • Release Note:
      Hide
      In prior versions, the HBase Thrift handlers failed to increment per-method metrics when an exception was encountered. These metrics will now always be incremented, whether an exception is encountered or not. This change also adds exception-type metrics, similar to those exposed in regionservers, for individual exceptions which are received by the Thrift handlers.
      Show
      In prior versions, the HBase Thrift handlers failed to increment per-method metrics when an exception was encountered. These metrics will now always be incremented, whether an exception is encountered or not. This change also adds exception-type metrics, similar to those exposed in regionservers, for individual exceptions which are received by the Thrift handlers.

      Description

      Currently, the InvocationHandler used to update per-method metrics in the Thrift server fails to update metrics if an exception occurs. This causes us to miss outliers. We should include exceptional cases in per-method latencies, and also look at adding specific exception rate metrics.

        Attachments

        1. HBASE-17578.002.patch
          54 kB
          Gary Helmling
        2. HBASE-17578.002.patch
          54 kB
          Michael Stack
        3. HBASE-17578.001.patch
          53 kB
          Gary Helmling

          Issue Links

            Activity

              People

              • Assignee:
                ghelmling Gary Helmling
                Reporter:
                ghelmling Gary Helmling
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: