Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14790 Implement a new DFSOutputStream for logging WAL only
  3. HBASE-17085

AsyncFSWAL may issue unnecessary AsyncDFSOutput.sync

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0
    • wal
    • None
    • Reviewed

    Description

      The problem is in appendAndSync method, we will issue an AsyncDFSOutput.sync if syncFutures is not empty. The SyncFutures in syncFutures can only be removed after an AsyncDFSOutput.sync comes back, so before the AsyncDFSOutput.sync actually returns, we will always issue an AsyncDFSOutput.sync after an append even if there is no new sync request.

      Attachments

        1. HBASE-17085.patch
          17 kB
          Duo Zhang
        2. HBASE-17085-v1.patch
          16 kB
          Duo Zhang
        3. HBASE-17085-v2.patch
          20 kB
          Duo Zhang
        4. HBASE-17085-v2.patch
          20 kB
          Duo Zhang

        Issue Links

          is related to

          Sub-task - The sub-task of the issue HBASE-16494 Support setting timeout on WAL.sync

          • Major - Major loss of function.
          • Closed
          relates to

          Sub-task - The sub-task of the issue HBASE-17049 Do not issue sync request when there are still entries in ringbuffer

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: