Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.1.5
    • 1.3.0, 1.2.2, 1.1.6, 2.0.0
    • hbck
    • None

    Description

      TestHBaseFsck#testCheckTableLocks changes the "hbase.table.lock.expire.ms" config from 10 minutes default value to 1 ms. This change impacts other tests in the TestHBaseFsck test suite, especially in branch-1.1.

      conf.setLong(TableLockManager.TABLE_LOCK_EXPIRE_TIMEOUT, 1);
      

      The proposed change is to make the configuration change local for testing purpose so that other tests would not be impacted.

      Attachments

        1. HBASE-15850.v1-branch-1.1.patch
          2 kB
          Stephen Yuan Jiang
        2. HBASE-15850.v1-master.patch
          2 kB
          Stephen Yuan Jiang

        Issue Links

        Activity

          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 11m 0s branch-1.1 passed
          +1 compile 1m 1s branch-1.1 passed with JDK v1.8.0
          +1 compile 0m 45s branch-1.1 passed with JDK v1.7.0_79
          +1 checkstyle 0m 41s branch-1.1 passed
          +1 mvneclipse 0m 24s branch-1.1 passed
          -1 findbugs 2m 31s hbase-server in branch-1.1 has 78 extant Findbugs warnings.
          -1 javadoc 0m 57s hbase-server in branch-1.1 failed with JDK v1.8.0.
          +1 javadoc 0m 47s branch-1.1 passed with JDK v1.7.0_79
          +1 mvninstall 0m 56s the patch passed
          +1 compile 1m 1s the patch passed with JDK v1.8.0
          +1 javac 1m 1s the patch passed
          +1 compile 0m 49s the patch passed with JDK v1.7.0_79
          +1 javac 0m 49s the patch passed
          +1 checkstyle 0m 30s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 5m 22s Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.0.
          +1 findbugs 3m 3s the patch passed
          -1 javadoc 0m 45s hbase-server in the patch failed with JDK v1.8.0.
          +1 javadoc 0m 48s the patch passed with JDK v1.7.0_79
          +1 unit 126m 16s hbase-server in the patch passed.
          +1 asflicense 28m 4s Patch does not generate ASF License warnings.
          186m 51s



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804605/HBASE-15850.v1-branch-1.1.patch
          JIRA Issue HBASE-15850
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux proserpina.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh
          git revision branch-1.1 / ce6f111
          Default Java 1.7.0_79
          Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/1943/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/1943/artifact/patchprocess/branch-javadoc-hbase-server-jdk1.8.0.txt
          javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/1943/artifact/patchprocess/patch-javadoc-hbase-server-jdk1.8.0.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1943/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1943/console
          Powered by Apache Yetus 0.2.1 http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 11m 0s branch-1.1 passed +1 compile 1m 1s branch-1.1 passed with JDK v1.8.0 +1 compile 0m 45s branch-1.1 passed with JDK v1.7.0_79 +1 checkstyle 0m 41s branch-1.1 passed +1 mvneclipse 0m 24s branch-1.1 passed -1 findbugs 2m 31s hbase-server in branch-1.1 has 78 extant Findbugs warnings. -1 javadoc 0m 57s hbase-server in branch-1.1 failed with JDK v1.8.0. +1 javadoc 0m 47s branch-1.1 passed with JDK v1.7.0_79 +1 mvninstall 0m 56s the patch passed +1 compile 1m 1s the patch passed with JDK v1.8.0 +1 javac 1m 1s the patch passed +1 compile 0m 49s the patch passed with JDK v1.7.0_79 +1 javac 0m 49s the patch passed +1 checkstyle 0m 30s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 5m 22s Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.0. +1 findbugs 3m 3s the patch passed -1 javadoc 0m 45s hbase-server in the patch failed with JDK v1.8.0. +1 javadoc 0m 48s the patch passed with JDK v1.7.0_79 +1 unit 126m 16s hbase-server in the patch passed. +1 asflicense 28m 4s Patch does not generate ASF License warnings. 186m 51s Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804605/HBASE-15850.v1-branch-1.1.patch JIRA Issue HBASE-15850 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux proserpina.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh git revision branch-1.1 / ce6f111 Default Java 1.7.0_79 Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/1943/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/1943/artifact/patchprocess/branch-javadoc-hbase-server-jdk1.8.0.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/1943/artifact/patchprocess/patch-javadoc-hbase-server-jdk1.8.0.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1943/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1943/console Powered by Apache Yetus 0.2.1 http://yetus.apache.org This message was automatically generated.
          yuzhihong@gmail.com Ted Yu added a comment -

          lgtm

          yuzhihong@gmail.com Ted Yu added a comment - lgtm
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.3 #702 (See https://builds.apache.org/job/HBase-1.3/702/)
          HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev d3d50338e742bc7b2e6fbd73cc48d176d8f24409)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.3 #702 (See https://builds.apache.org/job/HBase-1.3/702/ ) HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev d3d50338e742bc7b2e6fbd73cc48d176d8f24409) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.3-IT #665 (See https://builds.apache.org/job/HBase-1.3-IT/665/)
          HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev d3d50338e742bc7b2e6fbd73cc48d176d8f24409)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.3-IT #665 (See https://builds.apache.org/job/HBase-1.3-IT/665/ ) HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev d3d50338e742bc7b2e6fbd73cc48d176d8f24409) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 4m 16s master passed
          +1 compile 0m 54s master passed with JDK v1.8.0
          +1 compile 0m 42s master passed with JDK v1.7.0_79
          +1 checkstyle 1m 41s master passed
          +1 mvneclipse 0m 43s master passed
          +1 findbugs 4m 18s master passed
          +1 javadoc 0m 42s master passed with JDK v1.8.0
          +1 javadoc 0m 50s master passed with JDK v1.7.0_79
          +1 mvninstall 1m 14s the patch passed
          +1 compile 1m 32s the patch passed with JDK v1.8.0
          +1 javac 1m 32s the patch passed
          +1 compile 1m 27s the patch passed with JDK v1.7.0_79
          +1 javac 1m 27s the patch passed
          +1 checkstyle 2m 8s the patch passed
          +1 mvneclipse 0m 41s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 hadoopcheck 12m 35s Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.0.
          +1 findbugs 2m 56s the patch passed
          +1 javadoc 0m 43s the patch passed with JDK v1.8.0
          +1 javadoc 0m 45s the patch passed with JDK v1.7.0_79
          -1 unit 133m 55s hbase-server in the patch failed.
          +1 asflicense 0m 17s Patch does not generate ASF License warnings.
          173m 2s



          Reason Tests
          Failed junit tests hadoop.hbase.regionserver.TestRegionServerMetrics



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804698/HBASE-15850.v1-master.patch
          JIRA Issue HBASE-15850
          Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
          uname Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh
          git revision master / 3bd9220
          Default Java 1.7.0_79
          Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HBASE-Build/1946/artifact/patchprocess/patch-unit-hbase-server.txt
          unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/1946/artifact/patchprocess/patch-unit-hbase-server.txt
          Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1946/testReport/
          modules C: hbase-server U: hbase-server
          Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1946/console
          Powered by Apache Yetus 0.2.1 http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 4m 16s master passed +1 compile 0m 54s master passed with JDK v1.8.0 +1 compile 0m 42s master passed with JDK v1.7.0_79 +1 checkstyle 1m 41s master passed +1 mvneclipse 0m 43s master passed +1 findbugs 4m 18s master passed +1 javadoc 0m 42s master passed with JDK v1.8.0 +1 javadoc 0m 50s master passed with JDK v1.7.0_79 +1 mvninstall 1m 14s the patch passed +1 compile 1m 32s the patch passed with JDK v1.8.0 +1 javac 1m 32s the patch passed +1 compile 1m 27s the patch passed with JDK v1.7.0_79 +1 javac 1m 27s the patch passed +1 checkstyle 2m 8s the patch passed +1 mvneclipse 0m 41s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 12m 35s Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.0. +1 findbugs 2m 56s the patch passed +1 javadoc 0m 43s the patch passed with JDK v1.8.0 +1 javadoc 0m 45s the patch passed with JDK v1.7.0_79 -1 unit 133m 55s hbase-server in the patch failed. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 173m 2s Reason Tests Failed junit tests hadoop.hbase.regionserver.TestRegionServerMetrics Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804698/HBASE-15850.v1-master.patch JIRA Issue HBASE-15850 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh git revision master / 3bd9220 Default Java 1.7.0_79 Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HBASE-Build/1946/artifact/patchprocess/patch-unit-hbase-server.txt unit test logs https://builds.apache.org/job/PreCommit-HBASE-Build/1946/artifact/patchprocess/patch-unit-hbase-server.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1946/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1946/console Powered by Apache Yetus 0.2.1 http://yetus.apache.org This message was automatically generated.
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.2-IT #509 (See https://builds.apache.org/job/HBase-1.2-IT/509/)
          HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev d14803534b93fc393535a7314f3596b3ba4c95c4)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.2-IT #509 (See https://builds.apache.org/job/HBase-1.2-IT/509/ ) HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev d14803534b93fc393535a7314f3596b3ba4c95c4) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java

          Failed org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.testMobMetrics has nothing to do with the change.

          syuanjiang Stephen Yuan Jiang added a comment - Failed org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics.testMobMetrics has nothing to do with the change.
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.4 #160 (See https://builds.apache.org/job/HBase-1.4/160/)
          HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev 00785225494ee2b7eca248e5d0d5ef5ff56b6003)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.4 #160 (See https://builds.apache.org/job/HBase-1.4/160/ ) HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev 00785225494ee2b7eca248e5d0d5ef5ff56b6003) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.2 #627 (See https://builds.apache.org/job/HBase-1.2/627/)
          HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev d14803534b93fc393535a7314f3596b3ba4c95c4)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.2 #627 (See https://builds.apache.org/job/HBase-1.2/627/ ) HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev d14803534b93fc393535a7314f3596b3ba4c95c4) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.1-JDK7 #1717 (See https://builds.apache.org/job/HBase-1.1-JDK7/1717/)
          HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev 55212d53139d197e1fd499592c2ff9a390ed60c5)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.1-JDK7 #1717 (See https://builds.apache.org/job/HBase-1.1-JDK7/1717/ ) HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev 55212d53139d197e1fd499592c2ff9a390ed60c5) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-1.1-JDK8 #1803 (See https://builds.apache.org/job/HBase-1.1-JDK8/1803/)
          HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev 55212d53139d197e1fd499592c2ff9a390ed60c5)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment - FAILURE: Integrated in HBase-1.1-JDK8 #1803 (See https://builds.apache.org/job/HBase-1.1-JDK8/1803/ ) HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev 55212d53139d197e1fd499592c2ff9a390ed60c5) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-Trunk_matrix #930 (See https://builds.apache.org/job/HBase-Trunk_matrix/930/)
          HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev 8aa8abfcb672e4b905c487a10f1511db431f7006)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckOneRS.java
          hudson Hudson added a comment - FAILURE: Integrated in HBase-Trunk_matrix #930 (See https://builds.apache.org/job/HBase-Trunk_matrix/930/ ) HBASE-15850 Localize the configuration change in testCheckTableLocks to (syuanjiangdev: rev 8aa8abfcb672e4b905c487a10f1511db431f7006) hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckOneRS.java

          People

            syuanjiang Stephen Yuan Jiang
            syuanjiang Stephen Yuan Jiang
            Votes:
            0 Vote for this issue
            Watchers:
            Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack