Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-15852

Backport HBASE-15125 'HBaseFsck's adoptHdfsOrphan function creates region with wrong end key boundary' to Apache HBase 1.1

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.1.5
    • 1.1.6
    • hbck
    • None

    Description

      There is a bug in HBaseFsck's adoptHdfsOrphan function.At the last of this function will create a region,which want to cover all the orphan regions.But the end key of this new region was set incorrectly.Correct region's boundary should be [startKey,endKey),but this function create a region with boundary of [startKey,endKey],this bug will leads to scan operation omit some data.
      I think we should create the region like bellow,

          // create new region on hdfs. move data into place.
          HRegionInfo hri = new HRegionInfo(template.getTableName(), orphanRegionRange.getFirst(),
              Bytes.add(orphanRegionRange.getSecond(), new byte[1]));
      

      This is to backport HBASE-15125 to branch-1.1. HBASE-15827 could not do it due to a bug in TestHBaseFsck test suite (see HBASE-15850)

      Attachments

        1. HBASE-15852.v1-branch-1.1.patch
          4 kB
          Stephen Yuan Jiang

        Issue Links

          Activity

            hadoopqa Hadoop QA added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            +1 hbaseanti 0m 0s Patch does not have any anti-patterns.
            +1 @author 0m 0s The patch does not contain any @author tags.
            +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
            +1 mvninstall 1m 21s branch-1.1 passed
            +1 compile 0m 34s branch-1.1 passed with JDK v1.8.0
            +1 compile 0m 30s branch-1.1 passed with JDK v1.7.0_79
            +1 checkstyle 0m 31s branch-1.1 passed
            +1 mvneclipse 0m 15s branch-1.1 passed
            -1 findbugs 1m 48s hbase-server in branch-1.1 has 78 extant Findbugs warnings.
            -1 javadoc 0m 25s hbase-server in branch-1.1 failed with JDK v1.8.0.
            +1 javadoc 0m 31s branch-1.1 passed with JDK v1.7.0_79
            +1 mvninstall 0m 38s the patch passed
            +1 compile 0m 33s the patch passed with JDK v1.8.0
            +1 javac 0m 33s the patch passed
            +1 compile 0m 31s the patch passed with JDK v1.7.0_79
            +1 javac 0m 31s the patch passed
            +1 checkstyle 0m 22s the patch passed
            +1 mvneclipse 0m 15s the patch passed
            +1 whitespace 0m 0s Patch has no whitespace issues.
            +1 hadoopcheck 3m 51s Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.0.
            +1 findbugs 2m 5s the patch passed
            -1 javadoc 0m 26s hbase-server in the patch failed with JDK v1.8.0.
            +1 javadoc 0m 31s the patch passed with JDK v1.7.0_79
            +1 unit 90m 49s hbase-server in the patch passed.
            +1 asflicense 0m 17s Patch does not generate ASF License warnings.
            106m 40s



            Subsystem Report/Notes
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804666/HBASE-15852.v1-branch-1.1.patch
            JIRA Issue HBASE-15852
            Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile
            uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh
            git revision branch-1.1 / 55212d5
            Default Java 1.7.0_79
            Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79
            findbugs v3.0.0
            findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/1945/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
            javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/1945/artifact/patchprocess/branch-javadoc-hbase-server-jdk1.8.0.txt
            javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/1945/artifact/patchprocess/patch-javadoc-hbase-server-jdk1.8.0.txt
            Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1945/testReport/
            modules C: hbase-server U: hbase-server
            Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1945/console
            Powered by Apache Yetus 0.2.1 http://yetus.apache.org

            This message was automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment +1 hbaseanti 0m 0s Patch does not have any anti-patterns. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 1m 21s branch-1.1 passed +1 compile 0m 34s branch-1.1 passed with JDK v1.8.0 +1 compile 0m 30s branch-1.1 passed with JDK v1.7.0_79 +1 checkstyle 0m 31s branch-1.1 passed +1 mvneclipse 0m 15s branch-1.1 passed -1 findbugs 1m 48s hbase-server in branch-1.1 has 78 extant Findbugs warnings. -1 javadoc 0m 25s hbase-server in branch-1.1 failed with JDK v1.8.0. +1 javadoc 0m 31s branch-1.1 passed with JDK v1.7.0_79 +1 mvninstall 0m 38s the patch passed +1 compile 0m 33s the patch passed with JDK v1.8.0 +1 javac 0m 33s the patch passed +1 compile 0m 31s the patch passed with JDK v1.7.0_79 +1 javac 0m 31s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 hadoopcheck 3m 51s Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.0. +1 findbugs 2m 5s the patch passed -1 javadoc 0m 26s hbase-server in the patch failed with JDK v1.8.0. +1 javadoc 0m 31s the patch passed with JDK v1.7.0_79 +1 unit 90m 49s hbase-server in the patch passed. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 106m 40s Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12804666/HBASE-15852.v1-branch-1.1.patch JIRA Issue HBASE-15852 Optional Tests asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/test_framework/yetus-0.2.1/lib/precommit/personality/hbase.sh git revision branch-1.1 / 55212d5 Default Java 1.7.0_79 Multi-JDK versions /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HBASE-Build/1945/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/1945/artifact/patchprocess/branch-javadoc-hbase-server-jdk1.8.0.txt javadoc https://builds.apache.org/job/PreCommit-HBASE-Build/1945/artifact/patchprocess/patch-javadoc-hbase-server-jdk1.8.0.txt Test Results https://builds.apache.org/job/PreCommit-HBASE-Build/1945/testReport/ modules C: hbase-server U: hbase-server Console output https://builds.apache.org/job/PreCommit-HBASE-Build/1945/console Powered by Apache Yetus 0.2.1 http://yetus.apache.org This message was automatically generated.

            People

              syuanjiang Stephen Yuan Jiang
              syuanjiang Stephen Yuan Jiang
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: