[HBASE-15713] Backport "HBASE-15477 Do not save 'next block header' when we cache hfileblocks"

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0
• Fix Version/s: 1.3.0
• Component/s: BucketCache

Release Note

(Release note has been ported from the master issue -- with an addendum)

Fix over-persisting in blockcache; no longer save the block PLUS the header of the next block (3 bytes) when writing the cache.

Also removes support for hfileblock v1; hfile block v1 was used writing hfile v1. hfile v1 was the default in hbase before hbase-0.92. hbase.96 would not start unless all v1 hfiles had been compacted out of the cluster.

This patch also removed the tests TestUpgradeTo96 and TestMetaMigrationConvertingToPB, tests deprecated since hbase-0.96 since they required support for hfile v1 (which this patch removes). HBASE-11611 removed these tests from master.

• Assignee: Michael Stack
• Reporter: Michael Stack
• Created: 26/Apr/16 17:10
• Updated: 09/Nov/17 02:57
• Resolved: 27/Apr/16 17:43

Description

Backport "HBASE-15477 Do not save 'next block header' when we cache hfileblocks"

The backport involves removing support for hfile v1/hfileblockv1 support which was our default before 0.92. The backport patch also removes tests that depended on hfile v1, tests that were deprecated post 0.96 and to be removed (0.96 was the release that would only run if the whole cluster was hfiles > v1).

mantonov Ok to commit the above to 1.3? Thanks boss.

Issue Links

• is related to: HBASE-15477 Do not save 'next block header' when we cache hfileblocks