HBase
  1. HBase
  2. HBASE-11611

Clean up ZK-based region assignment

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: Region Assignment
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We can clean up the ZK-based region assignment code and use the ZK-less one in the master branch, to make the code easier to understand and maintain.

      1. hbase-11611.patch
        688 kB
        Jimmy Xiang
      2. hbase-11611.addendum
        1 kB
        Jimmy Xiang
      3. hbase-11611_v2.patch
        697 kB
        Jimmy Xiang
      4. hbase-11611_v1.patch
        687 kB
        Jimmy Xiang

        Activity

        Hide
        Jimmy Xiang added a comment -

        Attached a patch that removed ZK related assignment code, fixed tests.

        Show
        Jimmy Xiang added a comment - Attached a patch that removed ZK related assignment code, fixed tests.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12660145/hbase-11611.patch
        against trunk revision .
        ATTACHMENT ID: 12660145

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 97 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10316//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660145/hbase-11611.patch against trunk revision . ATTACHMENT ID: 12660145 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 97 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10316//console This message is automatically generated.
        Hide
        Jimmy Xiang added a comment -
        Show
        Jimmy Xiang added a comment - Patch v1 is on RB: https://reviews.apache.org/r/24382/
        Hide
        Jimmy Xiang added a comment -

        Attached the same patch generated with --no-prefix. Our patch script is changed again?

        Show
        Jimmy Xiang added a comment - Attached the same patch generated with --no-prefix. Our patch script is changed again?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12660148/hbase-11611_v1.patch
        against trunk revision .
        ATTACHMENT ID: 12660148

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 97 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10317//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660148/hbase-11611_v1.patch against trunk revision . ATTACHMENT ID: 12660148 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 97 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10317//console This message is automatically generated.
        Hide
        Jimmy Xiang added a comment -

        That's weird. The patch applies locally.

        Show
        Jimmy Xiang added a comment - That's weird. The patch applies locally.
        Hide
        Mikhail Antonov added a comment -

        BTW, the patch doesn't apply with either 'git apply -p0' or 'git apply -p1', can only apply with Intellij Idea.

        Show
        Mikhail Antonov added a comment - BTW, the patch doesn't apply with either 'git apply -p0' or 'git apply -p1', can only apply with Intellij Idea.
        Hide
        Jimmy Xiang added a comment -

        Check dev-support/smart-apply-patch.sh. That's the command to apply the patch: $PATCH -p0 -E --dry-run < $PATCH_FILE 2>&1 > $TMP
        It should be "/usr/bin/patch" instead of "git apply".

        Show
        Jimmy Xiang added a comment - Check dev-support/smart-apply-patch.sh. That's the command to apply the patch: $PATCH -p0 -E --dry-run < $PATCH_FILE 2>&1 > $TMP It should be "/usr/bin/patch" instead of "git apply".
        Hide
        stack added a comment -

        Skimmed. Jimmy Xiang This looks to be candidate for best patch of 2014! Its great.

        Can you get hadoopqa to apply it? I think we just apply if it passes.

        Show
        stack added a comment - Skimmed. Jimmy Xiang This looks to be candidate for best patch of 2014! Its great. Can you get hadoopqa to apply it? I think we just apply if it passes.
        Hide
        Alex Newman added a comment -

        That much red makes me shed tears of joy.

        Show
        Alex Newman added a comment - That much red makes me shed tears of joy.
        Hide
        Jimmy Xiang added a comment -

        Attached v2. Hopefully it's ok with hadoopqa. Thanks.

        Show
        Jimmy Xiang added a comment - Attached v2. Hopefully it's ok with hadoopqa. Thanks.
        Hide
        Mikhail Antonov added a comment -

        for my 2 cents, would be +1 (non-binding) if hadoop qa passes, would love to see this committed.

        Show
        Mikhail Antonov added a comment - for my 2 cents, would be +1 (non-binding) if hadoop qa passes, would love to see this committed.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12660233/hbase-11611_v2.patch
        against trunk revision .
        ATTACHMENT ID: 12660233

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 97 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10328//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660233/hbase-11611_v2.patch against trunk revision . ATTACHMENT ID: 12660233 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 97 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10328//console This message is automatically generated.
        Hide
        Alex Newman added a comment -

        Looks like there's nothing wrong with the patch. Someone wanna kick the server

        Show
        Alex Newman added a comment - Looks like there's nothing wrong with the patch. Someone wanna kick the server
        Hide
        Jimmy Xiang added a comment -

        Should we just commit it? The jenkins is broken anyway. I have ran unit tests locally.

        Show
        Jimmy Xiang added a comment - Should we just commit it? The jenkins is broken anyway. I have ran unit tests locally.
        Hide
        Alex Newman added a comment -

        Poor jenkins. I have no say, but for the sake of transparency.

        • Did you run them with mvn and run the full tests?
        • What exact commandline did you run
        • What tests passed and failed. Can you paste it?
        Show
        Alex Newman added a comment - Poor jenkins. I have no say, but for the sake of transparency. Did you run them with mvn and run the full tests? What exact commandline did you run What tests passed and failed. Can you paste it?
        Hide
        Jimmy Xiang added a comment -

        Our internal jenkins: 3,509 tests (+100) Took 3 hr 36 min.

        Show
        Jimmy Xiang added a comment - Our internal jenkins: 3,509 tests (+100) Took 3 hr 36 min.
        Hide
        Alex Newman added a comment -

        Sorry to be pedantic. No failures? I'll assume the jenkins build is setup correctly. I would prefer if you could attach the report, but I trust you of course.

        Show
        Alex Newman added a comment - Sorry to be pedantic. No failures? I'll assume the jenkins build is setup correctly. I would prefer if you could attach the report, but I trust you of course.
        Hide
        stack added a comment -

        +1 on commit w/o hadoopqa run and cleaning up the mess afterward.

        Show
        stack added a comment - +1 on commit w/o hadoopqa run and cleaning up the mess afterward.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5377 (See https://builds.apache.org/job/HBase-TRUNK/5377/)
        HBASE-11611 Clean up ZK-based region assignment (jxiang: rev 17dff6818e80305ea55da0519cbcf44de644992e)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/SplitTransactionCoordination.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/migration/TestUpgradeTo96.java
        • hbase-server/src/test/data/TestNamespaceUpgrade.tgz
        • hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessor.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestZKLessAMOnCluster.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConfigUtil.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/Mocking.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionMergeTransaction.java
        • hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
        • hbase-protocol/src/main/protobuf/ZooKeeper.proto
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/migration/UpgradeTo96.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestChangingEncoding.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/master/RegionState.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRestartCluster.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/RegionTransition.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkCloseRegionCoordination.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/OpenRegionCoordination.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/migration/TestNamespaceUpgrade.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannersFromClientSide.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/RegionMergeCoordination.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/CloseRegionCoordination.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestZKLessMergeOnCluster.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkCoordinatedStateManager.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/OfflineCallback.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignCallable.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/BaseCoordinatedStateManager.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseMetaHandler.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestZKLessSplitOnCluster.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenMetaHandler.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/TestIOFencing.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkOpenRegionCoordination.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManagerOnCluster.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkRegionMergeCoordination.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java
        • hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5377 (See https://builds.apache.org/job/HBase-TRUNK/5377/ ) HBASE-11611 Clean up ZK-based region assignment (jxiang: rev 17dff6818e80305ea55da0519cbcf44de644992e) hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransactionOnCluster.java hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/SplitTransactionCoordination.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRollingRestart.java hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKAssign.java hbase-server/src/test/java/org/apache/hadoop/hbase/migration/TestUpgradeTo96.java hbase-server/src/test/data/TestNamespaceUpgrade.tgz hbase-server/src/test/java/org/apache/hadoop/hbase/TestMetaTableAccessor.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestZKLessAMOnCluster.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitTransaction.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/ConfigUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/Mocking.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionMergeTransaction.java hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerNoMaster.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java hbase-server/src/test/java/org/apache/hadoop/hbase/TestDrainingServer.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestCloseRegionHandler.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java hbase-protocol/src/main/protobuf/ZooKeeper.proto hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java hbase-server/src/main/java/org/apache/hadoop/hbase/migration/UpgradeTo96.java hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestChangingEncoding.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStateStore.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestEndToEndSplitTransaction.java hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java hbase-client/src/main/java/org/apache/hadoop/hbase/master/RegionState.java hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/RequestConverter.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestRestartCluster.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java hbase-client/src/main/java/org/apache/hadoop/hbase/RegionTransition.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicas.java hbase-server/src/test/java/org/apache/hadoop/hbase/TestZooKeeper.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkCloseRegionCoordination.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildOverlap.java hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/OpenRegionCoordination.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java hbase-server/src/test/java/org/apache/hadoop/hbase/migration/TestNamespaceUpgrade.java hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestScannersFromClientSide.java hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestZKBasedOpenCloseRegion.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildHole.java hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/RegionMergeCoordination.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/handler/TestOpenRegionHandler.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransactionOnCluster.java hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/CloseRegionCoordination.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenRegionHandler.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestZKLessMergeOnCluster.java hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkCoordinatedStateManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/OfflineCallback.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignCallable.java hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/BaseCoordinatedStateManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseMetaHandler.java hbase-server/src/test/java/org/apache/hadoop/hbase/util/hbck/TestOfflineMetaRebuildBase.java hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestZKLessSplitOnCluster.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestOpenedRegionHandler.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionStates.java hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestDistributedLogSplitting.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/OpenMetaHandler.java hbase-server/src/test/java/org/apache/hadoop/hbase/TestIOFencing.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkOpenRegionCoordination.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestAssignmentManagerOnCluster.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkRegionMergeCoordination.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/CloseRegionHandler.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterNoCluster.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        Hide
        stack added a comment -

        wahoo!!!

        Show
        stack added a comment - wahoo!!!
        Hide
        Jimmy Xiang added a comment - - edited

        No test failure but couple replica related tests hang. I messed it up in addressing some review comments. Checked in the attached addendum to fix it.

        Show
        Jimmy Xiang added a comment - - edited No test failure but couple replica related tests hang. I messed it up in addressing some review comments. Checked in the attached addendum to fix it.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in HBase-TRUNK #5380 (See https://builds.apache.org/job/HBase-TRUNK/5380/)
        HBASE-11611 Addendum to fix hanging tests (jxiang: rev 041a2ba948e7aa04d814479b7ed81bc47ce14332)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        Show
        Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5380 (See https://builds.apache.org/job/HBase-TRUNK/5380/ ) HBASE-11611 Addendum to fix hanging tests (jxiang: rev 041a2ba948e7aa04d814479b7ed81bc47ce14332) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        Hide
        Jimmy Xiang added a comment -

        HBase master jenkins is blue again. Let's keep it so:

        Show
        Jimmy Xiang added a comment - HBase master jenkins is blue again. Let's keep it so:

          People

          • Assignee:
            Jimmy Xiang
            Reporter:
            Jimmy Xiang
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development