Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
None
-
Reviewed
Description
Our guidelines should call out where users need to take special care if they have binary files in their diff. (binary files here means anything file detects as "data")
By default git diff won't include binary files, instead it'll just say something like "binary files differ". That'll render the patch useless.
- Update reasons to favor format-patch to include "can handle binary files changing by default".
- Add a note on git diff (or change the default args) to use --binary