Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-12256

Update patch submission guidelines to call out binary file support

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: documentation
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Our guidelines should call out where users need to take special care if they have binary files in their diff. (binary files here means anything file detects as "data")

      By default git diff won't include binary files, instead it'll just say something like "binary files differ". That'll render the patch useless.

      • Update reasons to favor format-patch to include "can handle binary files changing by default".
      • Add a note on git diff (or change the default args) to use --binary

        Attachments

        1. HBASE-12256.patch
          3 kB
          M Linville

          Activity

            People

            • Assignee:
              misty M Linville
              Reporter:
              busbey Sean Busbey
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: