Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11639

[Visibility controller] Replicate the visibility of Cells as strings

    Details

    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Allows the visibility tags to be replicated as Strings to the peer cluster. Useful in cases where the peer cluster and the source cluster does not have a common global LABELs table.
      In order to enable this feature configure the below property in hbase-site.xml
      <property>
      <name>
      hbase.coprocessor.regionserver.classes
      </name>
      <value>
      org.apache.hadoop.hbase.security.visibility.VisibilityController$VisibilityReplication
      </value>
      <property>
      Show
      Allows the visibility tags to be replicated as Strings to the peer cluster. Useful in cases where the peer cluster and the source cluster does not have a common global LABELs table. In order to enable this feature configure the below property in hbase-site.xml <property> <name> hbase.coprocessor.regionserver.classes </name> <value> org.apache.hadoop.hbase.security.visibility.VisibilityController$VisibilityReplication </value> <property>

      Description

      This issue is aimed at persisting the visibility labels as strings in the WAL rather than Label ordinals. This would help in replicating the label ordinals to the replication cluster as strings directly and also that after HBASE-11553 would help because the replication cluster could have an implementation as string based visibility labels.

      1. HBASE-11639_v2.patch
        62 kB
        ramkrishna.s.vasudevan
      2. HBASE-11639_v2.patch
        62 kB
        ramkrishna.s.vasudevan
      3. HBASE-11639_v3.patch
        62 kB
        ramkrishna.s.vasudevan
      4. HBASE-11639_v3.patch
        67 kB
        ramkrishna.s.vasudevan
      5. HBASE-11639_v5.patch
        63 kB
        ramkrishna.s.vasudevan
      6. HBASE-11639_v6.patch
        67 kB
        ramkrishna.s.vasudevan
      7. HBASE-11639_v9.patch
        72 kB
        ramkrishna.s.vasudevan
      8. HBASE-11639_v11.patch
        76 kB
        ramkrishna.s.vasudevan
      9. HBASE-11639_v13.patch
        74 kB
        ramkrishna.s.vasudevan
      10. HBASE-11639_v13.patch
        73 kB
        ramkrishna.s.vasudevan
      11. HBASE-11639_v14.patch
        73 kB
        ramkrishna.s.vasudevan
      12. HBASE-11639_v15.patch
        73 kB
        ramkrishna.s.vasudevan
      13. HBASE-11639_v16.patch
        71 kB
        ramkrishna.s.vasudevan
      14. HBASE-11639_v17.patch
        71 kB
        ramkrishna.s.vasudevan
      15. HBASE-11639_amend.patch
        0.8 kB
        ramkrishna.s.vasudevan

        Issue Links

        There are no Sub-Tasks for this issue.

          Activity

          Hide
          enis Enis Soztutar added a comment -

          Closing this issue after 1.0.0 release.

          Show
          enis Enis Soztutar added a comment - Closing this issue after 1.0.0 release.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #6027 (See https://builds.apache.org/job/HBase-TRUNK/6027/)
          HBASE-12620 Add HBASE-11639 related items to Ref Guide <Ramkrishna S. Vasudevan> (mstanleyjones: rev 1c45263cf491775c03f381d6345789f73473b70d)

          • src/main/asciidoc/_chapters/security.adoc
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #6027 (See https://builds.apache.org/job/HBase-TRUNK/6027/ ) HBASE-12620 Add HBASE-11639 related items to Ref Guide <Ramkrishna S. Vasudevan> (mstanleyjones: rev 1c45263cf491775c03f381d6345789f73473b70d) src/main/asciidoc/_chapters/security.adoc
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #685 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/685/)
          HBASE-12619 Backport HBASE-11639 (Replicate the visibility of Cells as strings) to 0.98 (Ramkrishna S. Vasudevan) (apurtell: rev 91341421964e3e560b96585af35d7306fd68f664)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelOrdinalProvider.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionServerObserver.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionServerObserver.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelReplicationWithExpAsString.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98-on-Hadoop-1.1 #685 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/685/ ) HBASE-12619 Backport HBASE-11639 (Replicate the visibility of Cells as strings) to 0.98 (Ramkrishna S. Vasudevan) (apurtell: rev 91341421964e3e560b96585af35d7306fd68f664) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelOrdinalProvider.java hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionServerObserver.java hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionServerObserver.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelReplicationWithExpAsString.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-0.98 #718 (See https://builds.apache.org/job/HBase-0.98/718/)
          HBASE-12619 Backport HBASE-11639 (Replicate the visibility of Cells as strings) to 0.98 (Ramkrishna S. Vasudevan) (apurtell: rev 91341421964e3e560b96585af35d7306fd68f664)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelReplicationWithExpAsString.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionServerObserver.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionServerObserver.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelOrdinalProvider.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.98 #718 (See https://builds.apache.org/job/HBase-0.98/718/ ) HBASE-12619 Backport HBASE-11639 (Replicate the visibility of Cells as strings) to 0.98 (Ramkrishna S. Vasudevan) (apurtell: rev 91341421964e3e560b96585af35d7306fd68f664) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelReplicationWithExpAsString.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/BaseRegionServerObserver.java hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionServerObserver.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelOrdinalProvider.java hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Enis Soztutar
          Whatever Anoop says. In fact any existing ReplicaitonEP impl would work even if Visibility CP is configured but with no Visibility Cells. We don't try to interfere with the actual ReplicationEP's functionality.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Enis Soztutar Whatever Anoop says. In fact any existing ReplicaitonEP impl would work even if Visibility CP is configured but with no Visibility Cells. We don't try to interfere with the actual ReplicationEP's functionality.
          Hide
          anoop.hbase Anoop Sam John added a comment - - edited

          While we are on the subject, the thing I did not fully understand in this patch and also in HBASE-11920 was that why do we do this way of getting a RE from config, then replacing that with a one coming from a CP.

          This Jira or HBASE-11920 is NOT adding any new config for reading RE class name. It adds a new CP hook which can wrap the system's RE. (plugged in or default)

          The RE is already pluggable, shouldn't the user configure RE accordingly, and then configure what RE to wrap in this new RE implementation rather.

          You mean VC introducing new RE and asking users to configure that. Also the VC's RE impl to introduce again one more config to read the actual RE to be used. VC's RE is just a wrapper. I feel this is difficult in user perspective. Too many configs. For AC/VC what we ask user is to just configure the CPs. If those can do this simple wrap in some way, that is better no? Am I missing some thing?

          Andrew Purtell Do you still have concern over usage of custom RE?

          Show
          anoop.hbase Anoop Sam John added a comment - - edited While we are on the subject, the thing I did not fully understand in this patch and also in HBASE-11920 was that why do we do this way of getting a RE from config, then replacing that with a one coming from a CP. This Jira or HBASE-11920 is NOT adding any new config for reading RE class name. It adds a new CP hook which can wrap the system's RE. (plugged in or default) The RE is already pluggable, shouldn't the user configure RE accordingly, and then configure what RE to wrap in this new RE implementation rather. You mean VC introducing new RE and asking users to configure that. Also the VC's RE impl to introduce again one more config to read the actual RE to be used. VC's RE is just a wrapper. I feel this is difficult in user perspective. Too many configs. For AC/VC what we ask user is to just configure the CPs. If those can do this simple wrap in some way, that is better no? Am I missing some thing? Andrew Purtell Do you still have concern over usage of custom RE?
          Hide
          enis Enis Soztutar added a comment -

          While we are on the subject, the thing I did not fully understand in this patch and also in HBASE-11920 was that why do we do this way of getting a RE from config, then replacing that with a one coming from a CP. The RE is already pluggable, shouldn't the user configure RE accordingly, and then configure what RE to wrap in this new RE implementation rather. It seems very indirect.

          Show
          enis Enis Soztutar added a comment - While we are on the subject, the thing I did not fully understand in this patch and also in HBASE-11920 was that why do we do this way of getting a RE from config, then replacing that with a one coming from a CP. The RE is already pluggable, shouldn't the user configure RE accordingly, and then configure what RE to wrap in this new RE implementation rather. It seems very indirect.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          I think there is no issue with custom replication endpoint. What we do is create a wrapper on top of the replication EP. This is done in VC new hook impl. So this will wrap the custom Replication EP. System calls the wrapper 1st and it convert visibility to String based and then the custom EP which can do its function. Does that sounds good enough Andy?

          Show
          anoop.hbase Anoop Sam John added a comment - I think there is no issue with custom replication endpoint. What we do is create a wrapper on top of the replication EP. This is done in VC new hook impl. So this will wrap the custom Replication EP. System calls the wrapper 1st and it convert visibility to String based and then the custom EP which can do its function. Does that sounds good enough Andy?
          Hide
          apurtell Andrew Purtell added a comment - - edited

          One higher level question I have about this whole design is what happens if we want to replicate visibility tags as Strings over an existing custom ReplicationEndpoint? That won't be guaranteed today because an endpoint is implemented by a single class, there's no opportunity for mixing in functionality, each implementation must take care to delegate. Sorry I couldn't come here earlier, and anyway what has been committed is fine, the VisibilityReplicationEndpoint delegates to whatever it finds in place, but we should figure out what is the best next step here, if any. One option would be introducing a replication observer interface - ReplicationObserver - and coprocessor upcall chains out of replication code. Custom replication endpoint specification could be extended to allow specification of observer stacks.

          /cc Lars Hofhansl Jesse Yates

          Show
          apurtell Andrew Purtell added a comment - - edited One higher level question I have about this whole design is what happens if we want to replicate visibility tags as Strings over an existing custom ReplicationEndpoint? That won't be guaranteed today because an endpoint is implemented by a single class, there's no opportunity for mixing in functionality, each implementation must take care to delegate. Sorry I couldn't come here earlier, and anyway what has been committed is fine, the VisibilityReplicationEndpoint delegates to whatever it finds in place, but we should figure out what is the best next step here, if any. One option would be introducing a replication observer interface - ReplicationObserver - and coprocessor upcall chains out of replication code. Custom replication endpoint specification could be extended to allow specification of observer stacks. /cc Lars Hofhansl Jesse Yates
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Committed the addendum to branch-1 also (1.0.0). Updating the version to 1.0.0.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Committed the addendum to branch-1 also (1.0.0). Updating the version to 1.0.0.
          Hide
          enis Enis Soztutar added a comment -

          The RC is cut. I think you can commit the addendum to branch-1 as well.

          Show
          enis Enis Soztutar added a comment - The RC is cut. I think you can commit the addendum to branch-1 as well.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #5860 (See https://builds.apache.org/job/HBase-TRUNK/5860/)
          HBASE-11639 - [Visibility controller] Replicate the visibility of Cells as (ramkrishna: rev 3db5e20834caf2e3f18e6fa9344d9c6b8079287a)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5860 (See https://builds.apache.org/job/HBase-TRUNK/5860/ ) HBASE-11639 - [Visibility controller] Replicate the visibility of Cells as (ramkrishna: rev 3db5e20834caf2e3f18e6fa9344d9c6b8079287a) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          Hide
          enis Enis Soztutar added a comment -

          no worries. I think we can do the addendum after the RC tomorrow, and add 1.0.0 as the fix version here.

          Show
          enis Enis Soztutar added a comment - no worries. I think we can do the addendum after the RC tomorrow, and add 1.0.0 as the fix version here.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Enis Soztutar
          I have already pushed this to branch-1. I was just waiting for the comments and finalising the 0.98 patch.
          Anyway will raise a Backport JIRA for that. Hence closing this issue and upgrading the release number as 0.99.2.
          Let me know if am doing something wrong here. Thanks.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Enis Soztutar I have already pushed this to branch-1. I was just waiting for the comments and finalising the 0.98 patch. Anyway will raise a Backport JIRA for that. Hence closing this issue and upgrading the release number as 0.99.2. Let me know if am doing something wrong here. Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12684574/HBASE-11639_amend.patch
          against master branch at commit 94d57f81dc114feba14906b05b3d2c6b78bf3299.
          ATTACHMENT ID: 12684574

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 checkstyle. The applied patch does not increase the total number of checkstyle errors

          -1 findbugs. The patch appears to introduce 8 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684574/HBASE-11639_amend.patch against master branch at commit 94d57f81dc114feba14906b05b3d2c6b78bf3299. ATTACHMENT ID: 12684574 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 checkstyle . The applied patch does not increase the total number of checkstyle errors -1 findbugs . The patch appears to introduce 8 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11892//console This message is automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          A minor addendum that breaks out of the while loop after removing the STRING based tag type. Will commit it unless objections.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - A minor addendum that breaks out of the while loop after removing the STRING based tag type. Will commit it unless objections.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Andrew Purtell
          I have a patch uploaded for 0.98 also. We could commit to 0.98 also and then resolve this. HBASE-11992 is already gone into 0.98.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Andrew Purtell I have a patch uploaded for 0.98 also. We could commit to 0.98 also and then resolve this. HBASE-11992 is already gone into 0.98.
          Hide
          apurtell Andrew Purtell added a comment -

          This has been committed to branch-1 and master, this JIRA should be resolved.

          Show
          apurtell Andrew Purtell added a comment - This has been committed to branch-1 and master, this JIRA should be resolved.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Would it be worth backporting to 0.98 the backwards compatibility helper for coprocessor additions from HBASE-10378 so that we can try to maintain binary compatibility for RegionServerObservers that don't have the new hook?

          Yes something like that is needed. Which means that in 0.98 the new hook should be called thro reflections and not directly. +1 on that.
          I need to add some release note for this JIRA. Will do it shortly. Also will raise sub jira for the ref doc updations.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Would it be worth backporting to 0.98 the backwards compatibility helper for coprocessor additions from HBASE-10378 so that we can try to maintain binary compatibility for RegionServerObservers that don't have the new hook? Yes something like that is needed. Which means that in 0.98 the new hook should be called thro reflections and not directly. +1 on that. I need to add some release note for this JIRA. Will do it shortly. Also will raise sub jira for the ref doc updations.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-1.0 #523 (See https://builds.apache.org/job/HBase-1.0/523/)
          HBASE-11639 - [Visibility controller] Replicate the visibility of Cells as (ramkrishna: rev 95de67bd39f6e305b143f5d17c26c4ebc766281c)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelOrdinalProvider.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelReplicationWithExpAsString.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-1.0 #523 (See https://builds.apache.org/job/HBase-1.0/523/ ) HBASE-11639 - [Visibility controller] Replicate the visibility of Cells as (ramkrishna: rev 95de67bd39f6e305b143f5d17c26c4ebc766281c) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelOrdinalProvider.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelReplicationWithExpAsString.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK #5849 (See https://builds.apache.org/job/HBase-TRUNK/5849/)
          HBASE-11639 [Visibility controller] Replicate the visibility of Cells as (ramkrishna: rev b6b88edf9310245f3dbda9cebe9b9f0060f0e13c)

          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelOrdinalProvider.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelReplicationWithExpAsString.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK #5849 (See https://builds.apache.org/job/HBase-TRUNK/5849/ ) HBASE-11639 [Visibility controller] Replicate the visibility of Cells as (ramkrishna: rev b6b88edf9310245f3dbda9cebe9b9f0060f0e13c) hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelOrdinalProvider.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityReplicationEndpoint.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelReplicationWithExpAsString.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/DefaultVisibilityExpressionResolver.java hbase-common/src/main/java/org/apache/hadoop/hbase/Tag.java hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12684438/HBASE-11639_v17.patch
          against master branch at commit 41041e8d6abcfa0d093ae321081ba01d2154c5ab.
          ATTACHMENT ID: 12684438

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 183 warning messages.

          -1 checkstyle. The applied patch generated 3539 checkstyle errors (more than the master's current 3535 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + // Only when the replication is inter cluster replication we need to covert the visibility tags to
          + // string based tags. But for intra cluster replication like region replicas it is not needed.
          + + "would happen as per the existing format and not as string type for the cell "

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684438/HBASE-11639_v17.patch against master branch at commit 41041e8d6abcfa0d093ae321081ba01d2154c5ab. ATTACHMENT ID: 12684438 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 183 warning messages. -1 checkstyle . The applied patch generated 3539 checkstyle errors (more than the master's current 3535 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + // Only when the replication is inter cluster replication we need to covert the visibility tags to + // string based tags. But for intra cluster replication like region replicas it is not needed. + + "would happen as per the existing format and not as string type for the cell " +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11882//console This message is automatically generated.
          Hide
          busbey Sean Busbey added a comment -

          Would it be worth backporting to 0.98 the backwards compatibility helper for coprocessor additions from HBASE-10378 so that we can try to maintain binary compatibility for RegionServerObservers that don't have the new hook? (I'm specifically talking about CoprocessorHost.useLegacyMethod / legacyWarning).

          Granted, there's no fallback method in this case, so we'd have to clean up the messages a little.

          Show
          busbey Sean Busbey added a comment - Would it be worth backporting to 0.98 the backwards compatibility helper for coprocessor additions from HBASE-10378 so that we can try to maintain binary compatibility for RegionServerObservers that don't have the new hook? (I'm specifically talking about CoprocessorHost.useLegacyMethod / legacyWarning). Granted, there's no fallback method in this case, so we'd have to clean up the messages a little.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Also thanks to Anoop Sam John for helping through the solution in terms of API discussion, strategy etc.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Also thanks to Anoop Sam John for helping through the solution in terms of API discussion, strategy etc.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Thanks for patient and very good reviews from Anoop Sam John and Sean Busbey.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Thanks for patient and very good reviews from Anoop Sam John and Sean Busbey .
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Patch for 0.98 and branch-1. Pushed to branch-1 and master.
          For 0.98 we need to discuss because we are introducing a new hook in the RegionServerObserver. I have added that new hook also as part of this patch only.
          Andrew Purtell
          We need that hook for this soln to be implemented. Any user code implementing RegionServerObserver would get compilation error but is it ok to add new hooks in point releases.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Patch for 0.98 and branch-1. Pushed to branch-1 and master. For 0.98 we need to discuss because we are introducing a new hook in the RegionServerObserver. I have added that new hook also as part of this patch only. Andrew Purtell We need that hook for this soln to be implemented. Any user code implementing RegionServerObserver would get compilation error but is it ok to add new hooks in point releases.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          +1

          Show
          anoop.hbase Anoop Sam John added a comment - +1
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          The javadoc warnings looks unrelated as most of them are from different classes that are not used in the current patch.
          The checkstyle warning is longlines which i can correct on commit.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - The javadoc warnings looks unrelated as most of them are from different classes that are not used in the current patch. The checkstyle warning is longlines which i can correct on commit.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12684370/HBASE-11639_v16.patch
          against master branch at commit 5985b485943e4664b83fad2f2cfd089e6031b062.
          ATTACHMENT ID: 12684370

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 182 warning messages.

          -1 checkstyle. The applied patch generated 3539 checkstyle errors (more than the master's current 3535 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + // Only when the replication is inter cluster replication we need to covert the visibility tags to
          + // string based tags. But for intra cluster replication like region replicas it is not needed.
          + + "would happen as per the existing format and not as string type for the cell "

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684370/HBASE-11639_v16.patch against master branch at commit 5985b485943e4664b83fad2f2cfd089e6031b062. ATTACHMENT ID: 12684370 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 182 warning messages. -1 checkstyle . The applied patch generated 3539 checkstyle errors (more than the master's current 3535 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + // Only when the replication is inter cluster replication we need to covert the visibility tags to + // string based tags. But for intra cluster replication like region replicas it is not needed. + + "would happen as per the existing format and not as string type for the cell " +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11879//console This message is automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Latest patch addressing RB comments. If this patch is fine I could use the same for branch-1 and 0.98.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Latest patch addressing RB comments. If this patch is fine I could use the same for branch-1 and 0.98.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          For this to work, are the other subtasks needed?

          Actually the 2nd sub task is not needed. It is already done as part of this JIRA as seperating it out was not possible/ not easy.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - For this to work, are the other subtasks needed? Actually the 2nd sub task is not needed. It is already done as part of this JIRA as seperating it out was not possible/ not easy.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Thanks for the review Anoop Sam John. Will check those RB comments.
          Enis Soztutar
          Once I get +1s for master will commit to branch-1 also. Thanks for your time.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Thanks for the review Anoop Sam John . Will check those RB comments. Enis Soztutar Once I get +1s for master will commit to branch-1 also. Thanks for your time.
          Hide
          enis Enis Soztutar added a comment -

          I was checking this to include in 0.99.2RC. From the RB, it seems fine to check this in to branch-1 as well once it gets +1's for master. I did not review in full detail though. For this to work, are the other subtasks needed?

          Show
          enis Enis Soztutar added a comment - I was checking this to include in 0.99.2RC. From the RB, it seems fine to check this in to branch-1 as well once it gets +1's for master. I did not review in full detail though. For this to work, are the other subtasks needed?
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Sorry for the delay Ram.
          Left some comments (final set) in RB (mostly nits). Thanks for the great work!

          Show
          anoop.hbase Anoop Sam John added a comment - Sorry for the delay Ram. Left some comments (final set) in RB (mostly nits). Thanks for the great work!
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Any more reviews appreciated here.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Any more reviews appreciated here.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Anymore comments on RB so that I could update the patch with the minor javadoc changes related to imports?

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Anymore comments on RB so that I could update the patch with the minor javadoc changes related to imports?
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12683285/HBASE-11639_v15.patch
          against master branch at commit 5911c030a509b8fc6ad5a3735f2e1279712485f7.
          ATTACHMENT ID: 12683285

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 checkstyle. The applied patch generated 3808 checkstyle errors (more than the master's current 3805 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/checkstyle-aggregate.html

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12683285/HBASE-11639_v15.patch against master branch at commit 5911c030a509b8fc6ad5a3735f2e1279712485f7. ATTACHMENT ID: 12683285 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 checkstyle . The applied patch generated 3808 checkstyle errors (more than the master's current 3805 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11812//console This message is automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Ashish Singhi
          Thanks for the input. Let me change accordingly.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Ashish Singhi Thanks for the input. Let me change accordingly.
          Hide
          ashish singhi Ashish Singhi added a comment -

          Actually the checkstyle does not account for the imports that are accounted thro @Link in javadoc. So when we remove that as unused imports javadoc starts complaining.

          We can remove the import and refer the class with fully qualified name in javadoc. By this we can avoid complains from both checkstyle and javadoc.

          Show
          ashish singhi Ashish Singhi added a comment - Actually the checkstyle does not account for the imports that are accounted thro @Link in javadoc. So when we remove that as unused imports javadoc starts complaining. We can remove the import and refer the class with fully qualified name in javadoc. By this we can avoid complains from both checkstyle and javadoc.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Latest patch addressing javadoc comments. Actually the checkstyle does not account for the imports that are accounted thro @Link in javadoc. So when we remove that as unused imports javadoc starts complaining.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Latest patch addressing javadoc comments. Actually the checkstyle does not account for the imports that are accounted thro @Link in javadoc. So when we remove that as unused imports javadoc starts complaining.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12683264/HBASE-11639_v14.patch
          against master branch at commit 5911c030a509b8fc6ad5a3735f2e1279712485f7.
          ATTACHMENT ID: 12683264

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 10 warning messages.

          -1 checkstyle. The applied patch generated 3806 checkstyle errors (more than the master's current 3805 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12683264/HBASE-11639_v14.patch against master branch at commit 5911c030a509b8fc6ad5a3735f2e1279712485f7. ATTACHMENT ID: 12683264 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 10 warning messages. -1 checkstyle . The applied patch generated 3806 checkstyle errors (more than the master's current 3805 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11811//console This message is automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Removes the javadoc warnings and some of the checkstyle comments like unused imports, private Constructor for Visibilityconstants, etc.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Removes the javadoc warnings and some of the checkstyle comments like unused imports, private Constructor for Visibilityconstants, etc.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12683046/HBASE-11639_v13.patch
          against master branch at commit 5911c030a509b8fc6ad5a3735f2e1279712485f7.
          ATTACHMENT ID: 12683046

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          -1 checkstyle. The applied patch generated 3811 checkstyle errors (more than the master's current 3805 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12683046/HBASE-11639_v13.patch against master branch at commit 5911c030a509b8fc6ad5a3735f2e1279712485f7. ATTACHMENT ID: 12683046 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. -1 checkstyle . The applied patch generated 3811 checkstyle errors (more than the master's current 3805 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11799//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12683045/HBASE-11639_v13.patch
          against master branch at commit 5911c030a509b8fc6ad5a3735f2e1279712485f7.
          ATTACHMENT ID: 12683045

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11798//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12683045/HBASE-11639_v13.patch against master branch at commit 5911c030a509b8fc6ad5a3735f2e1279712485f7. ATTACHMENT ID: 12683045 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11798//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12682617/HBASE-11639_v11.patch
          against master branch at commit b6dd9b441fb279bbd7b6c48d809166b2b0235514.
          ATTACHMENT ID: 12682617

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          -1 checkstyle. The applied patch generated 3813 checkstyle errors (more than the master's current 3809 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + visibilityString.append(VisibilityConstants.AND_OPERATOR + CellVisibility.quote(label));
          + * @param existingTags - a list where all the tags other than the visibility related tags are added

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12682617/HBASE-11639_v11.patch against master branch at commit b6dd9b441fb279bbd7b6c48d809166b2b0235514. ATTACHMENT ID: 12682617 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. -1 checkstyle . The applied patch generated 3813 checkstyle errors (more than the master's current 3809 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + visibilityString.append(VisibilityConstants.AND_OPERATOR + CellVisibility.quote(label)); + * @param existingTags - a list where all the tags other than the visibility related tags are added +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11761//console This message is automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          The latest patch always quotes any labels that is appended to the STRING_VIS_TAGS. Because in case of unicode characters we will need the quoting mechanism. So by quoting any incoming string we could handle any type of strings non-unicode and unicode.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - The latest patch always quotes any labels that is appended to the STRING_VIS_TAGS. Because in case of unicode characters we will need the quoting mechanism. So by quoting any incoming string we could handle any type of strings non-unicode and unicode.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Latest patch updating the comments from RB.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Latest patch updating the comments from RB.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment - - edited

          Updated patch. Removes the two APIS, one to get the replicated tag and the other to remove the replicated tag. The VC core code itself handles these.
          Both ordinal based and string based impl would rewrite the tag to a new tag type while in replication so that both the impl will remove the new tag added.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - - edited Updated patch. Removes the two APIS, one to get the replicated tag and the other to remove the replicated tag. The VC core code itself handles these. Both ordinal based and string based impl would rewrite the tag to a new tag type while in replication so that both the impl will remove the new tag added.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12681884/HBASE-11639_v6.patch
          against trunk revision .
          ATTACHMENT ID: 12681884

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          -1 checkstyle. The applied patch generated 3795 checkstyle errors (more than the trunk's current 3788 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + public List<Tag> encodeVisibilityForReplication(final List<Tag> tags, final Byte serializationFormat)
          + visibilityString.append(VisibilityConstants.CLOSED_PARAN + VisibilityConstants.OR_OPERATOR);
          + visibilityString.append(VisibilityConstants.OPEN_PARAN + VisibilityConstants.NOT_OPERATOR
          + public List<Tag> encodeVisibilityForReplication(List<Tag> tags, Byte serializationFormat) throws IOException {
          + User.createUserForTesting(conf, User.getCurrent().getShortName(), new String[]

          { "supergroup" }

          );

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12681884/HBASE-11639_v6.patch against trunk revision . ATTACHMENT ID: 12681884 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. -1 checkstyle . The applied patch generated 3795 checkstyle errors (more than the trunk's current 3788 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + public List<Tag> encodeVisibilityForReplication(final List<Tag> tags, final Byte serializationFormat) + visibilityString.append(VisibilityConstants.CLOSED_PARAN + VisibilityConstants.OR_OPERATOR); + visibilityString.append(VisibilityConstants.OPEN_PARAN + VisibilityConstants.NOT_OPERATOR + public List<Tag> encodeVisibilityForReplication(List<Tag> tags, Byte serializationFormat) throws IOException { + User.createUserForTesting(conf, User.getCurrent().getShortName(), new String[] { "supergroup" } ); +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11704//console This message is automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Updated patch based on review comments in RB

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Updated patch based on review comments in RB
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Any reviews very much appreciated here.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Any reviews very much appreciated here.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12677286/HBASE-11639_v5.patch
          against trunk revision .
          ATTACHMENT ID: 12677286

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          -1 checkstyle. The applied patch generated 3794 checkstyle errors (more than the trunk's current 3791 errors).

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/checkstyle-aggregate.html

          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12677286/HBASE-11639_v5.patch against trunk revision . ATTACHMENT ID: 12677286 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. -1 checkstyle . The applied patch generated 3794 checkstyle errors (more than the trunk's current 3791 errors). +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/checkstyle-aggregate.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11472//console This message is automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Updated patch in RB.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Updated patch in RB.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12675437/HBASE-11639_v3.patch
          against trunk revision .
          ATTACHMENT ID: 12675437

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12675437/HBASE-11639_v3.patch against trunk revision . ATTACHMENT ID: 12675437 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11390//console This message is automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Updated patch. Fixes the test case and also the javadoc warnings.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Updated patch. Fixes the test case and also the javadoc warnings.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Individually the test passed. Will check it once again.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Individually the test passed. Will check it once again.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12675310/HBASE-11639_v3.patch
          against trunk revision .
          ATTACHMENT ID: 12675310

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 5 warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 lineLengths. The patch introduces the following lines longer than 100:
          + User.createUserForTesting(conf, User.getCurrent().getShortName(), new String[]

          { "supergroup" }

          );
          + PrivilegedExceptionAction<VisibilityLabelsResponse> action = new PrivilegedExceptionAction<VisibilityLabelsResponse>() {
          + PrivilegedExceptionAction<VisibilityLabelsResponse> action = new PrivilegedExceptionAction<VisibilityLabelsResponse>() {

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
          Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/patchJavadocWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12675310/HBASE-11639_v3.patch against trunk revision . ATTACHMENT ID: 12675310 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 5 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 lineLengths . The patch introduces the following lines longer than 100: + User.createUserForTesting(conf, User.getCurrent().getShortName(), new String[] { "supergroup" } ); + PrivilegedExceptionAction<VisibilityLabelsResponse> action = new PrivilegedExceptionAction<VisibilityLabelsResponse>() { + PrivilegedExceptionAction<VisibilityLabelsResponse> action = new PrivilegedExceptionAction<VisibilityLabelsResponse>() { +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelReplicationWithExpAsString Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Javadoc warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11381//console This message is automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -
          Show
          ram_krish ramkrishna.s.vasudevan added a comment - https://reviews.apache.org/r/26814 - RB link.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Trying to get a QA run.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Trying to get a QA run.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12675273/HBASE-11639_v2.patch
          against trunk revision .
          ATTACHMENT ID: 12675273

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11376//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12675273/HBASE-11639_v2.patch against trunk revision . ATTACHMENT ID: 12675273 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11376//console This message is automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          All tests passed in the local run except for a test related log roll. Trying an updated patch for QA run.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - All tests passed in the local run except for a test related log roll. Trying an updated patch for QA run.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12675253/HBASE-11639_v2.patch
          against trunk revision .
          ATTACHMENT ID: 12675253

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 8 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11374//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12675253/HBASE-11639_v2.patch against trunk revision . ATTACHMENT ID: 12675253 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified tests. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/11374//console This message is automatically generated.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Patch that allows the cells to be replicated as strings to the peers. The control of modified the tags, identifying the tags were modified and removing them all lies with the VLS impl.
          Uploading for reviews and comments. Can refine the patch based on it.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Patch that allows the cells to be replicated as strings to the peers. The control of modified the tags, identifying the tags were modified and removing them all lies with the VLS impl. Uploading for reviews and comments. Can refine the patch based on it.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          In order to easily back port this feature to 0.98, it would be better if we could just remove the new hook added for Replicationendpoint to instead create a hook for the ReplicationSource and in the VC just wrap that ReplicationSource with custom impl.
          The ReplicaitonSourceInterface may need some interface changes to be done like add shipEdits() and a boolean returning API that checks if the interClusterReplicationIsPossible would ensure that the entire change that we are doing for 0.99 and master can easily be ported to 0.98 without the need for backporting the entire ReplicationEndpoint things.
          I can raise a JIRA to move the endpoints and then subsequent patches for all branches. Thoughts?

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - In order to easily back port this feature to 0.98, it would be better if we could just remove the new hook added for Replicationendpoint to instead create a hook for the ReplicationSource and in the VC just wrap that ReplicationSource with custom impl. The ReplicaitonSourceInterface may need some interface changes to be done like add shipEdits() and a boolean returning API that checks if the interClusterReplicationIsPossible would ensure that the entire change that we are doing for 0.99 and master can easily be ported to 0.98 without the need for backporting the entire ReplicationEndpoint things. I can raise a JIRA to move the endpoints and then subsequent patches for all branches. Thoughts?
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          When I was trying it out few days back I found that wrapping the existing endpoint with a new endpoint would mean that we need to start both the end points (I mean the actual endpoint and the one that wraps the actual endpoint). Because the replciation endpoint is treated as a services and it is handled as a service with different states.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - When I was trying it out few days back I found that wrapping the existing endpoint with a new endpoint would mean that we need to start both the end points (I mean the actual endpoint and the one that wraps the actual endpoint). Because the replciation endpoint is treated as a services and it is handled as a service with different states.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Just update the AC at the same time the new hooks go in?

          Yes. AC, as it is our internal CP impl, is not having any issue. We discussed here abt this later.
          The one concern I have is as follows
          User having a RegionServerObserver CP impl (Implementing RegionServerObserver) and this is based on older 98 version. Later he has upgraded to newer version of 98 which is having these extra method in CP. If no recompile there is no need to add the dummy impl. But the core code will try to call this hook on the existing CP impl object and will throw RTE. If abort on error in CP is true this will cause to RS to abort. Do we need to guard this case? In the past we have added new CP hooks in point releases. So what can be general agreement in this area?

          Show
          anoop.hbase Anoop Sam John added a comment - Just update the AC at the same time the new hooks go in? Yes. AC, as it is our internal CP impl, is not having any issue. We discussed here abt this later. The one concern I have is as follows User having a RegionServerObserver CP impl (Implementing RegionServerObserver) and this is based on older 98 version. Later he has upgraded to newer version of 98 which is having these extra method in CP. If no recompile there is no need to add the dummy impl. But the core code will try to call this hook on the existing CP impl object and will throw RTE. If abort on error in CP is true this will cause to RS to abort. Do we need to guard this case? In the past we have added new CP hooks in point releases. So what can be general agreement in this area?
          Hide
          apurtell Andrew Purtell added a comment -

          Adding new hooks to the RegionServerObserver will cause BC issues in 0.98 as AC is implementing RegionServerObserver and not extending the BaseRegionServerObserver.

          Just update the AC at the same time the new hooks go in?

          Show
          apurtell Andrew Purtell added a comment - Adding new hooks to the RegionServerObserver will cause BC issues in 0.98 as AC is implementing RegionServerObserver and not extending the BaseRegionServerObserver. Just update the AC at the same time the new hooks go in?
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Adding new hooks to the REgionServerObserver will cause BC issues in 0.98 as ACL is implementing RegionServerObserver and not extending the BaseRegionServerObserver.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Adding new hooks to the REgionServerObserver will cause BC issues in 0.98 as ACL is implementing RegionServerObserver and not extending the BaseRegionServerObserver.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          +1 for an impl with KV recreate now. We can optimize later.

          Show
          anoop.hbase Anoop Sam John added a comment - +1 for an impl with KV recreate now. We can optimize later.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          But currently we won't wrap the KV with a new cell impl because anyway the KVCodecWithTags will convert into KV. So this optimization will not be that useful. So we will use that way of Cell impl in future IA JIRA.

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - But currently we won't wrap the KV with a new cell impl because anyway the KVCodecWithTags will convert into KV. So this optimization will not be that useful. So we will use that way of Cell impl in future IA JIRA.
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Thinking abt a solution for this, 2 previous POC patches we made.

          Option 1 : Write the vis label tag in String form only into Cells added to WAL. Here this will affect the recovery time during RS crash as we will have to do Expression parsing, expansion and recreation of KV and so bytes copying etc etc. Also this approach will need us to add more CP hooks during the log replay stage

          Option 2 : To the WAL cell, write both expanded vis exp tags (ie. with label ordinals) as well as one tag with the vis exp String form itself. This will avoid all the MTTR down sides. But we will end up in writing more tag data into WAL cells. There is already concern for limited total tags length. Also if recovery happens and WAL cells gets replayed, those will have extra tag data and will get written to HFile and staying there from then on. (If we have to avoid this, we will need extra op in Log recovery with stripping of one tag which is like a no light op at least now)

          So I was thinking for an alternate way.

          Now in branch-1+ we have pluggable ReplicationEndpoint support. How about we have a wrapper impl wrapping the HBaseInterClusterReplicationEndpoint. We can impl replicate(ReplicateContext replicateContext) and in this we will rewrite the WALEdit cells not to have the ordinal based tags but the String based one and then calling the delegator to actually replicate.
          Add a hook in RegionServerObserver to have pre/post hooks while creation of the Replication Endpoint and we can do the wrap work in this hook impl in VC.

          Right now WALEdit allows KVs only in it. So the recreation will need us to do bytes copy for the key and value parts also even though there is no change. HBASE-11805 will solve this. If it takes cells, we can have a new Cell impl in which the KV part actually refers to the original Cell what we got in ReplicationContext's WALEdit. Only the tags array we can recreate.

          This will need us to back port the pluggable ReplicationEndpoint stuff to 0.98. Discussing offline with Andrew Purtell he is ok for this if it can be done with out any BC or wire compatibility issue (It should be possible I believe)

          Show
          anoop.hbase Anoop Sam John added a comment - Thinking abt a solution for this, 2 previous POC patches we made. Option 1 : Write the vis label tag in String form only into Cells added to WAL. Here this will affect the recovery time during RS crash as we will have to do Expression parsing, expansion and recreation of KV and so bytes copying etc etc. Also this approach will need us to add more CP hooks during the log replay stage Option 2 : To the WAL cell, write both expanded vis exp tags (ie. with label ordinals) as well as one tag with the vis exp String form itself. This will avoid all the MTTR down sides. But we will end up in writing more tag data into WAL cells. There is already concern for limited total tags length. Also if recovery happens and WAL cells gets replayed, those will have extra tag data and will get written to HFile and staying there from then on. (If we have to avoid this, we will need extra op in Log recovery with stripping of one tag which is like a no light op at least now) So I was thinking for an alternate way. Now in branch-1+ we have pluggable ReplicationEndpoint support. How about we have a wrapper impl wrapping the HBaseInterClusterReplicationEndpoint. We can impl replicate(ReplicateContext replicateContext) and in this we will rewrite the WALEdit cells not to have the ordinal based tags but the String based one and then calling the delegator to actually replicate. Add a hook in RegionServerObserver to have pre/post hooks while creation of the Replication Endpoint and we can do the wrap work in this hook impl in VC. Right now WALEdit allows KVs only in it. So the recreation will need us to do bytes copy for the key and value parts also even though there is no change. HBASE-11805 will solve this. If it takes cells, we can have a new Cell impl in which the KV part actually refers to the original Cell what we got in ReplicationContext's WALEdit. Only the tags array we can recreate. This will need us to back port the pluggable ReplicationEndpoint stuff to 0.98. Discussing offline with Andrew Purtell he is ok for this if it can be done with out any BC or wire compatibility issue (It should be possible I believe)
          Hide
          apurtell Andrew Purtell added a comment -

          Thanks. Will circle back to this at RC time

          Show
          apurtell Andrew Purtell added a comment - Thanks. Will circle back to this at RC time
          Hide
          anoop.hbase Anoop Sam John added a comment -

          We can work on that POC patch (There were some more things to be done) and see how we can merge the two patches together. Assigning to Ram. Hope you are ok with that Ram.

          Show
          anoop.hbase Anoop Sam John added a comment - We can work on that POC patch (There were some more things to be done) and see how we can merge the two patches together. Assigning to Ram. Hope you are ok with that Ram.
          Hide
          ram_krish ramkrishna.s.vasudevan added a comment -

          Actually Anoop had a patch like a POC which is not yet tested and I had some patch but with more new hooks. We need to see them once and test them but I think we could target this by the end of august. We will change the assignee based on that. Fine Andrew Purtell?

          Show
          ram_krish ramkrishna.s.vasudevan added a comment - Actually Anoop had a patch like a POC which is not yet tested and I had some patch but with more new hooks. We need to see them once and test them but I think we could target this by the end of august. We will change the assignee based on that. Fine Andrew Purtell ?
          Hide
          apurtell Andrew Purtell added a comment -

          This issue doesn't have an assignee. Does it have a shot at being ready at end of August for .6? Otherwise let's move it out.

          Show
          apurtell Andrew Purtell added a comment - This issue doesn't have an assignee. Does it have a shot at being ready at end of August for .6? Otherwise let's move it out.
          Hide
          apurtell Andrew Purtell added a comment -

          Suggest renaming this Jira to include the actual req. ie. Replicate the visibility of Cells as String exps

          +1, did that. Please feel free to change back if you disagree

          Show
          apurtell Andrew Purtell added a comment - Suggest renaming this Jira to include the actual req. ie. Replicate the visibility of Cells as String exps +1, did that. Please feel free to change back if you disagree
          Hide
          anoop.hbase Anoop Sam John added a comment -

          Suggest renaming this Jira to include the actual req. ie. Replicate the visibility of Cells as String exps rathen than Ordinal based exps. What do u say Ram?
          Have an idea and done some POC around that. Will write more.

          Show
          anoop.hbase Anoop Sam John added a comment - Suggest renaming this Jira to include the actual req. ie. Replicate the visibility of Cells as String exps rathen than Ordinal based exps. What do u say Ram? Have an idea and done some POC around that. Will write more.

            People

            • Assignee:
              ram_krish ramkrishna.s.vasudevan
              Reporter:
              ram_krish ramkrishna.s.vasudevan
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development