HBase
  1. HBase
  2. HBASE-11553

Abstract visibility label related services into an interface

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.99.0, 2.0.0, 0.98.6
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      • storage and retrieval of label dictionary and authentication sets
      • marshalling and unmarshalling of visibility expression representations in operation attributes and cell tags
      • management of assignment of authorizations to principals
        This will allow us to introduce additional serde implementations for visibility expressions, for example storing as strings in some places and compressed/tokenized representation in others in order to support additional use cases.
      1. HBASE-11553_0.98.patch
        195 kB
        Anoop Sam John
      2. HBASE-11553_0.99.patch
        197 kB
        Anoop Sam John
      3. HBASE-11553_V2.patch
        178 kB
        Anoop Sam John
      4. HBASE-11553_V3.patch
        179 kB
        Anoop Sam John
      5. HBASE-11553_V4.patch
        184 kB
        Anoop Sam John
      6. HBASE-11553_V5.patch
        191 kB
        Anoop Sam John
      7. HBASE-11553_V6.patch
        196 kB
        Anoop Sam John
      8. HBASE-11553.patch
        196 kB
        Anoop Sam John
      9. HBASE-11553.patch
        193 kB
        Anoop Sam John

        Issue Links

          Activity

          Hide
          Andrew Purtell added a comment -

          Good idea

          Show
          Andrew Purtell added a comment - Good idea
          Hide
          Anoop Sam John added a comment -

          Patch looks big as I renamed 2 files and and others also like code movement from VC to the VisibilityLabelService impl class.

          Show
          Anoop Sam John added a comment - Patch looks big as I renamed 2 files and and others also like code movement from VC to the VisibilityLabelService impl class.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12657087/HBASE-11553.patch
          against trunk revision .
          ATTACHMENT ID: 12657087

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 7 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.client.TestScan

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657087/HBASE-11553.patch against trunk revision . ATTACHMENT ID: 12657087 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 7 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 1 warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.client.TestScan Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10144//console This message is automatically generated.
          Hide
          Andrew Purtell added a comment -

          Patch looks big as I renamed 2 files and and others also like code movement from VC to the VisibilityLabelService impl class.

          Can we put it up on RB?

          Show
          Andrew Purtell added a comment - Patch looks big as I renamed 2 files and and others also like code movement from VC to the VisibilityLabelService impl class. Can we put it up on RB?
          Show
          Anoop Sam John added a comment - https://reviews.apache.org/r/23815/
          Hide
          Anoop Sam John added a comment -

          Will work on the comments and rebase patch once HBASE-11384 is committed.

          Show
          Anoop Sam John added a comment - Will work on the comments and rebase patch once HBASE-11384 is committed.
          Hide
          Andrew Purtell added a comment -

          Ok, cancelling patch

          Show
          Andrew Purtell added a comment - Ok, cancelling patch
          Hide
          Andrew Purtell added a comment -

          Moving out of .5

          Show
          Andrew Purtell added a comment - Moving out of .5
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12660153/HBASE-11553_V2.patch
          against trunk revision .
          ATTACHMENT ID: 12660153

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 10 new or modified tests.

          -1 javac. The patch appears to cause mvn compile goal to fail.

          Compilation errors resume:
          [ERROR] COMPILATION ERROR :
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java:[88,28] error: cannot find symbol
          [ERROR] symbol: variable VIS_SERIALIZATION_TAG
          [ERROR] symbol: variable VISIBILITY_TAG_TYPE
          [ERROR] symbol: variable VISIBILITY_TAG_TYPE
          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project hbase-server: Compilation failure: Compilation failure:
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java:[88,28] error: cannot find symbol
          [ERROR] symbol: variable VIS_SERIALIZATION_TAG
          [ERROR] location: class VisibilityUtils
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java:[92,38] error: cannot find symbol
          [ERROR] symbol: variable VISIBILITY_TAG_TYPE
          [ERROR] location: class VisibilityUtils
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java:[100,42] error: cannot find symbol
          [ERROR] symbol: variable VISIBILITY_TAG_TYPE
          [ERROR] location: class VisibilityUtils
          [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java:[107,40] error: cannot find symbol
          [ERROR] -> [Help 1]
          [ERROR]
          [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
          [ERROR] Re-run Maven using the -X switch to enable full debug logging.
          [ERROR]
          [ERROR] For more information about the errors and possible solutions, please read the following articles:
          [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
          [ERROR]
          [ERROR] After correcting the problems, you can resume the build with the command
          [ERROR] mvn <goals> -rf :hbase-server

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10318//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660153/HBASE-11553_V2.patch against trunk revision . ATTACHMENT ID: 12660153 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 10 new or modified tests. -1 javac . The patch appears to cause mvn compile goal to fail. Compilation errors resume: [ERROR] COMPILATION ERROR : [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java: [88,28] error: cannot find symbol [ERROR] symbol: variable VIS_SERIALIZATION_TAG [ERROR] symbol: variable VISIBILITY_TAG_TYPE [ERROR] symbol: variable VISIBILITY_TAG_TYPE [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.5.1:compile (default-compile) on project hbase-server: Compilation failure: Compilation failure: [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java: [88,28] error: cannot find symbol [ERROR] symbol: variable VIS_SERIALIZATION_TAG [ERROR] location: class VisibilityUtils [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java: [92,38] error: cannot find symbol [ERROR] symbol: variable VISIBILITY_TAG_TYPE [ERROR] location: class VisibilityUtils [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java: [100,42] error: cannot find symbol [ERROR] symbol: variable VISIBILITY_TAG_TYPE [ERROR] location: class VisibilityUtils [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java: [107,40] error: cannot find symbol [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :hbase-server Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10318//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12660168/HBASE-11553_V2.patch
          against trunk revision .
          ATTACHMENT ID: 12660168

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 10 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:

          -1 core zombie tests. There are 1 zombie test(s): at org.apache.hadoop.hbase.http.TestHttpServerLifecycle.testStartedServerIsAlive(TestHttpServerLifecycle.java:72)

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660168/HBASE-11553_V2.patch against trunk revision . ATTACHMENT ID: 12660168 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 10 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. -1 findbugs . The patch appears to introduce 1 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: -1 core zombie tests . There are 1 zombie test(s): at org.apache.hadoop.hbase.http.TestHttpServerLifecycle.testStartedServerIsAlive(TestHttpServerLifecycle.java:72) Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10320//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12660297/HBASE-11553_V3.patch
          against trunk revision .
          ATTACHMENT ID: 12660297

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 13 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12660297/HBASE-11553_V3.patch against trunk revision . ATTACHMENT ID: 12660297 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 13 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.io.hfile.TestBlockCacheReporting Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10333//console This message is automatically generated.
          Hide
          Anoop Sam John added a comment -

          Pls see ExpAsStringVisibilityLabelServiceImpl for an alternate impl for VisibilityLabelService.

          Show
          Anoop Sam John added a comment - Pls see ExpAsStringVisibilityLabelServiceImpl for an alternate impl for VisibilityLabelService.
          Hide
          Andrew Purtell added a comment -

          Can you update RB with the latest patch Anoop? There are a lot of lines of change here.

          Show
          Andrew Purtell added a comment - Can you update RB with the latest patch Anoop? There are a lot of lines of change here.
          Hide
          Anoop Sam John added a comment -

          Yes Andrew Purtell the RB is already updated with latest patch.

          Show
          Anoop Sam John added a comment - Yes Andrew Purtell the RB is already updated with latest patch.
          Hide
          Andrew Purtell added a comment -

          Thanks.

          +1

          Show
          Andrew Purtell added a comment - Thanks. +1
          Hide
          ramkrishna.s.vasudevan added a comment - - edited

          +1 for commit.

          {Edit}

          change 'on' to 'for'

          Show
          ramkrishna.s.vasudevan added a comment - - edited +1 for commit. {Edit} change 'on' to 'for'
          Hide
          Anoop Sam John added a comment -

          Thanks for the review Andy and Ram.
          I will commit tomorrow unless objection. Ping Enis Soztutar for branch-1
          (Will fix the typo Ram raised on commit)

          Show
          Anoop Sam John added a comment - Thanks for the review Andy and Ram. I will commit tomorrow unless objection. Ping Enis Soztutar for branch-1 (Will fix the typo Ram raised on commit)
          Hide
          Sean Busbey added a comment -

          I have some feedback in a review I'm ||<-- this close to submitting, just as soon as I can test my intuition on one of the issues.

          Show
          Sean Busbey added a comment - I have some feedback in a review I'm ||<-- this close to submitting, just as soon as I can test my intuition on one of the issues.
          Hide
          Andrew Purtell added a comment -

          Let's hold off on commit for more feedback

          Show
          Andrew Purtell added a comment - Let's hold off on commit for more feedback
          Hide
          Anoop Sam John added a comment -

          Retry forQA

          Show
          Anoop Sam John added a comment - Retry forQA
          Hide
          Anoop Sam John added a comment -

          All comment are addressed. Can I get some +1s for commit pls?

          Show
          Anoop Sam John added a comment - All comment are addressed. Can I get some +1s for commit pls?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12662447/HBASE-11553_V5.patch
          against trunk revision .
          ATTACHMENT ID: 12662447

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 15 new or modified tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          +1 site. The mvn site goal succeeds with this patch.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12662447/HBASE-11553_V5.patch against trunk revision . ATTACHMENT ID: 12662447 +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 15 new or modified tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 +1 site . The mvn site goal succeeds with this patch. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.wal.TestLogRollingNoCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10475//console This message is automatically generated.
          Hide
          ramkrishna.s.vasudevan added a comment -

          Just 2 minor nits in RB. Rest looks great. +1 from me.

          Show
          ramkrishna.s.vasudevan added a comment - Just 2 minor nits in RB. Rest looks great. +1 from me.
          Hide
          Andrew Purtell added a comment -

          My earlier +1 stands, but the recent comments addressed were from Sean Busbey. Any additional comments Sean?

          Show
          Andrew Purtell added a comment - My earlier +1 stands, but the recent comments addressed were from Sean Busbey . Any additional comments Sean?
          Hide
          Anoop Sam John added a comment -

          Committed to 0.98+
          Thanks for the reviews Andy, Ram and Sean.

          Show
          Anoop Sam John added a comment - Committed to 0.98+ Thanks for the reviews Andy, Ram and Sean.
          Hide
          Anoop Sam John added a comment - - edited

          Attached patches that I committed...

          Show
          Anoop Sam John added a comment - - edited Attached patches that I committed...
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #5414 (See https://builds.apache.org/job/HBase-TRUNK/5414/)
          HBASE-11553 Abstract visibility label related services into an interface. (anoopsamjohn: rev 062f6a6aac99a11e3f833a6d460d458452624425)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5414 (See https://builds.apache.org/job/HBase-TRUNK/5414/ ) HBASE-11553 Abstract visibility label related services into an interface. (anoopsamjohn: rev 062f6a6aac99a11e3f833a6d460d458452624425) hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.98 #461 (See https://builds.apache.org/job/HBase-0.98/461/)
          HBASE-11553 Abstract visibility label related services into an interface. (anoopsamjohn: rev d79861213da95df663136ba53930a789c4531e3f)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.98 #461 (See https://builds.apache.org/job/HBase-0.98/461/ ) HBASE-11553 Abstract visibility label related services into an interface. (anoopsamjohn: rev d79861213da95df663136ba53930a789c4531e3f) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #434 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/434/)
          HBASE-11553 Abstract visibility label related services into an interface. (anoopsamjohn: rev d79861213da95df663136ba53930a789c4531e3f)

          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #434 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/434/ ) HBASE-11553 Abstract visibility label related services into an interface. (anoopsamjohn: rev d79861213da95df663136ba53930a789c4531e3f) hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-1.0 #115 (See https://builds.apache.org/job/HBase-1.0/115/)
          HBASE-11553 Abstract visibility label related services into an interface. (anoopsamjohn: rev 98067274d9065a7aa7e4ff7cf40e66ef86e79b0e)

          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java
          • hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java
          • hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java
          • hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java
          • hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-1.0 #115 (See https://builds.apache.org/job/HBase-1.0/115/ ) HBASE-11553 Abstract visibility label related services into an interface. (anoopsamjohn: rev 98067274d9065a7aa7e4ff7cf40e66ef86e79b0e) hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityWithCheckAuths.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityUtils.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDistributedLogReplay.java hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/LabelExpander.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsCache.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/EnforcingScanLabelGenerator.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabels.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelService.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/ExpAsStringVisibilityLabelServiceImpl.java hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityConstants.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultVisibilityLabelServiceImpl.java hbase-common/src/main/java/org/apache/hadoop/hbase/TagType.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/DefaultScanLabelGenerator.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/OperationStatus.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithCustomVisLabService.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelFilter.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelServiceManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityScanDeleteTracker.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityExpEvaluator.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsManager.java hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/ZKVisibilityLabelWatcher.java hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperListener.java
          Hide
          Enis Soztutar added a comment -

          Closing this issue after 0.99.0 release.

          Show
          Enis Soztutar added a comment - Closing this issue after 0.99.0 release.

            People

            • Assignee:
              Anoop Sam John
              Reporter:
              Anoop Sam John
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development