HBase
  1. HBase
  2. HBASE-10306

Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.3
    • Fix Version/s: 0.94.16
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()

        Issue Links

          Activity

          chendihao created issue -
          Hide
          chendihao added a comment -

          patch for 0.94

          Show
          chendihao added a comment - patch for 0.94
          chendihao made changes -
          Field Original Value New Value
          Attachment HBASE-10306-0.94-v1.patch [ 12622127 ]
          Hide
          chendihao added a comment -

          The patch is recreated for the newest code of 0.94. Enis Soztutar please review.

          Show
          chendihao added a comment - The patch is recreated for the newest code of 0.94. Enis Soztutar please review.
          chendihao made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Fix Version/s 0.94.16 [ 12325656 ]
          Fix Version/s 0.94.3 [ 12323144 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12622127/HBASE-10306-0.94-v1.patch
          against trunk revision .
          ATTACHMENT ID: 12622127

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8375//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622127/HBASE-10306-0.94-v1.patch against trunk revision . ATTACHMENT ID: 12622127 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8375//console This message is automatically generated.
          Hide
          Lars Hofhansl added a comment -

          Is this part needed?

          -      FileUtil.fullyDelete(dir);
          +      if(!FileUtil.fullyDelete(dir)) {
          +        throw new IOException("Could not delete zk base directory: " + dir);
          +      }
          

          Would is negatively affect some tests?

          Show
          Lars Hofhansl added a comment - Is this part needed? - FileUtil.fullyDelete(dir); + if (!FileUtil.fullyDelete(dir)) { + throw new IOException( "Could not delete zk base directory: " + dir); + } Would is negatively affect some tests?
          Lars Hofhansl made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Lars Hofhansl added a comment -
          Show
          Lars Hofhansl added a comment - chendihao ?
          Hide
          Enis Soztutar added a comment -

          Is this part needed?

          I think that part comes from the original patch. That is needed for an early-exit strategy if the directory cannot be cleaned (in case open file handlers for example). But we can live without that as well.
          Other than that +1 from me.

          Show
          Enis Soztutar added a comment - Is this part needed? I think that part comes from the original patch. That is needed for an early-exit strategy if the directory cannot be cleaned (in case open file handlers for example). But we can live without that as well. Other than that +1 from me.
          Enis Soztutar made changes -
          Link This issue blocks HBASE-10274 [ HBASE-10274 ]
          Hide
          Enis Soztutar added a comment -

          See also: HBASE-10274

          Show
          Enis Soztutar added a comment - See also: HBASE-10274
          Hide
          Lars Hofhansl added a comment -

          I see. Let's commit the patch as is. Will do so unless I hear objections.

          Show
          Lars Hofhansl added a comment - I see. Let's commit the patch as is. Will do so unless I hear objections.
          Hide
          Enis Soztutar added a comment -

          Let's commit the patch as is. Will do so unless I hear objections.

          +1.

          Show
          Enis Soztutar added a comment - Let's commit the patch as is. Will do so unless I hear objections. +1.
          Lars Hofhansl made changes -
          Summary Backport HBASE-6820 to 0.94 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()
          Hide
          Lars Hofhansl added a comment -

          Committed to 0.94

          Show
          Lars Hofhansl added a comment - Committed to 0.94
          Lars Hofhansl made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 0.94.3 [ 12323144 ]
          Resolution Fixed [ 1 ]
          Hide
          Lars Hofhansl added a comment -

          Thanks chendihao.

          Show
          Lars Hofhansl added a comment - Thanks chendihao .
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94-security #386 (See https://builds.apache.org/job/HBase-0.94-security/386/)
          HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009)

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #386 (See https://builds.apache.org/job/HBase-0.94-security/386/ ) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.94-JDK7 #25 (See https://builds.apache.org/job/HBase-0.94-JDK7/25/)
          HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009)

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.94-JDK7 #25 (See https://builds.apache.org/job/HBase-0.94-JDK7/25/ ) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94 #1258 (See https://builds.apache.org/job/HBase-0.94/1258/)
          HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009)

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.94 #1258 (See https://builds.apache.org/job/HBase-0.94/1258/ ) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          chendihao added a comment -

          Thanks for the review. Lars Hofhansl Enis Soztutar

          Show
          chendihao added a comment - Thanks for the review. Lars Hofhansl Enis Soztutar
          Lars Hofhansl made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          20m 18s 1 chendihao 09/Jan/14 07:10
          Patch Available Patch Available Open Open
          9h 38m 1 Lars Hofhansl 09/Jan/14 16:48
          Open Open Resolved Resolved
          9h 4m 1 Lars Hofhansl 10/Jan/14 01:53
          Resolved Resolved Closed Closed
          10d 23h 38m 1 Lars Hofhansl 21/Jan/14 01:31

            People

            • Assignee:
              chendihao
              Reporter:
              chendihao
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development