Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-10306

Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.3
    • Fix Version/s: 0.94.16
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Backport HBASE-6820: [WINDOWS] MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown()

        Issue Links

          Activity

          Hide
          tobe chendihao added a comment -

          patch for 0.94

          Show
          tobe chendihao added a comment - patch for 0.94
          Hide
          tobe chendihao added a comment -

          The patch is recreated for the newest code of 0.94. Enis Soztutar please review.

          Show
          tobe chendihao added a comment - The patch is recreated for the newest code of 0.94. Enis Soztutar please review.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12622127/HBASE-10306-0.94-v1.patch
          against trunk revision .
          ATTACHMENT ID: 12622127

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8375//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622127/HBASE-10306-0.94-v1.patch against trunk revision . ATTACHMENT ID: 12622127 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8375//console This message is automatically generated.
          Hide
          lhofhansl Lars Hofhansl added a comment -

          Is this part needed?

          -      FileUtil.fullyDelete(dir);
          +      if(!FileUtil.fullyDelete(dir)) {
          +        throw new IOException("Could not delete zk base directory: " + dir);
          +      }
          

          Would is negatively affect some tests?

          Show
          lhofhansl Lars Hofhansl added a comment - Is this part needed? - FileUtil.fullyDelete(dir); + if (!FileUtil.fullyDelete(dir)) { + throw new IOException( "Could not delete zk base directory: " + dir); + } Would is negatively affect some tests?
          Hide
          lhofhansl Lars Hofhansl added a comment -
          Show
          lhofhansl Lars Hofhansl added a comment - chendihao ?
          Hide
          enis Enis Soztutar added a comment -

          Is this part needed?

          I think that part comes from the original patch. That is needed for an early-exit strategy if the directory cannot be cleaned (in case open file handlers for example). But we can live without that as well.
          Other than that +1 from me.

          Show
          enis Enis Soztutar added a comment - Is this part needed? I think that part comes from the original patch. That is needed for an early-exit strategy if the directory cannot be cleaned (in case open file handlers for example). But we can live without that as well. Other than that +1 from me.
          Hide
          enis Enis Soztutar added a comment -

          See also: HBASE-10274

          Show
          enis Enis Soztutar added a comment - See also: HBASE-10274
          Hide
          lhofhansl Lars Hofhansl added a comment -

          I see. Let's commit the patch as is. Will do so unless I hear objections.

          Show
          lhofhansl Lars Hofhansl added a comment - I see. Let's commit the patch as is. Will do so unless I hear objections.
          Hide
          enis Enis Soztutar added a comment -

          Let's commit the patch as is. Will do so unless I hear objections.

          +1.

          Show
          enis Enis Soztutar added a comment - Let's commit the patch as is. Will do so unless I hear objections. +1.
          Hide
          lhofhansl Lars Hofhansl added a comment -

          Committed to 0.94

          Show
          lhofhansl Lars Hofhansl added a comment - Committed to 0.94
          Hide
          lhofhansl Lars Hofhansl added a comment -

          Thanks chendihao.

          Show
          lhofhansl Lars Hofhansl added a comment - Thanks chendihao .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94-security #386 (See https://builds.apache.org/job/HBase-0.94-security/386/)
          HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009)

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #386 (See https://builds.apache.org/job/HBase-0.94-security/386/ ) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in HBase-0.94-JDK7 #25 (See https://builds.apache.org/job/HBase-0.94-JDK7/25/)
          HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009)

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in HBase-0.94-JDK7 #25 (See https://builds.apache.org/job/HBase-0.94-JDK7/25/ ) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94 #1258 (See https://builds.apache.org/job/HBase-0.94/1258/)
          HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009)

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in HBase-0.94 #1258 (See https://builds.apache.org/job/HBase-0.94/1258/ ) HBASE-10306 Backport HBASE-6820 to 0.94, MiniZookeeperCluster should ensure that ZKDatabase is closed upon shutdown() (chendihao) (larsh: rev 1557009) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          tobe chendihao added a comment -

          Thanks for the review. Lars Hofhansl Enis Soztutar

          Show
          tobe chendihao added a comment - Thanks for the review. Lars Hofhansl Enis Soztutar

            People

            • Assignee:
              tobe chendihao
              Reporter:
              tobe chendihao
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development