HBase
  1. HBase
  2. HBASE-10274

MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.3
    • Fix Version/s: 0.98.0, 0.96.2, 0.99.0, 0.94.17
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HBASE-6820 points out the problem but not fix completely.

      killCurrentActiveZooKeeperServer() and killOneBackupZooKeeperServer() will shutdown the ZooKeeperServer and need to close ZKDatabase as well.

      1. HBASE-10274-truck-v2.patch
        1 kB
        chendihao
      2. HBASE-10274-truck-v2.patch
        1 kB
        Enis Soztutar
      3. HBASE-10274-truck-v1.patch
        1 kB
        chendihao
      4. HBASE-10274-0.94-v2.patch
        1 kB
        chendihao
      5. HBASE-10274-0.94-v1.patch
        1 kB
        chendihao

        Issue Links

          Activity

          Hide
          Enis Soztutar added a comment -

          Thanks for reporting this. Would you mind attaching a patch?

          Show
          Enis Soztutar added a comment - Thanks for reporting this. Would you mind attaching a patch?
          Hide
          chendihao added a comment -

          patch for 0.94

          Show
          chendihao added a comment - patch for 0.94
          Hide
          chendihao added a comment -

          patch for trunk

          Show
          chendihao added a comment - patch for trunk
          Hide
          chendihao added a comment -

          BTW, the patch of HBASE-6820 is not committed in 0.94. Can you confirm this? Enis Soztutar

          Show
          chendihao added a comment - BTW, the patch of HBASE-6820 is not committed in 0.94. Can you confirm this? Enis Soztutar
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12621511/HBASE-10274-truck-v1.patch
          against trunk revision .
          ATTACHMENT ID: 12621511

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 4 release audit warnings (more than the trunk's current 0 warnings).

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          -1 core tests. The patch failed these unit tests:
          org.apache.hadoop.hbase.zookeeper.lock.TestZKInterProcessReadWriteLock

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12621511/HBASE-10274-truck-v1.patch against trunk revision . ATTACHMENT ID: 12621511 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 4 release audit warnings (more than the trunk's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. -1 core tests . The patch failed these unit tests: org.apache.hadoop.hbase.zookeeper.lock.TestZKInterProcessReadWriteLock Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8342//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12621511/HBASE-10274-truck-v1.patch
          against trunk revision .
          ATTACHMENT ID: 12621511

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 4 release audit warnings (more than the trunk's current 0 warnings).

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//testReport/
          Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12621511/HBASE-10274-truck-v1.patch against trunk revision . ATTACHMENT ID: 12621511 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit . The applied patch generated 4 release audit warnings (more than the trunk's current 0 warnings). +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8341//console This message is automatically generated.
          Hide
          Enis Soztutar added a comment -

          BTW, the patch of HBASE-6820 is not committed in 0.94.

          No it is not. Do you need to have this patch for 0.94? In that case we have to open another issue for backporting that to 0.94.

          Show
          Enis Soztutar added a comment - BTW, the patch of HBASE-6820 is not committed in 0.94. No it is not. Do you need to have this patch for 0.94? In that case we have to open another issue for backporting that to 0.94.
          Hide
          Enis Soztutar added a comment -

          For the killOneBackupZooKeeperServer(), I think you are closing the the ZKDatabase for the active server instead of the backupZkServer:

          +    zooKeeperServers.get(activeZKServerIndex).getZKDatabase().close();
          +
               // remove this backup zk server
               standaloneServerFactoryList.remove(backupZKServerIndex);
          
          Show
          Enis Soztutar added a comment - For the killOneBackupZooKeeperServer(), I think you are closing the the ZKDatabase for the active server instead of the backupZkServer: + zooKeeperServers.get(activeZKServerIndex).getZKDatabase().close(); + // remove this backup zk server standaloneServerFactoryList.remove(backupZKServerIndex);
          Hide
          chendihao added a comment -

          For the killOneBackupZooKeeperServer(), I think you are closing the the ZKDatabase for the active server instead of the backupZkServer

          My mistake. Fix it by uploading v2 patch and thanks for reviewing.

          Do you need to have this patch for 0.94?

          I think it's better to fix it because our codebase is 0.94.

          Show
          chendihao added a comment - For the killOneBackupZooKeeperServer(), I think you are closing the the ZKDatabase for the active server instead of the backupZkServer My mistake. Fix it by uploading v2 patch and thanks for reviewing. Do you need to have this patch for 0.94? I think it's better to fix it because our codebase is 0.94.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12621734/HBASE-10274-0.94-v2.patch
          against trunk revision .
          ATTACHMENT ID: 12621734

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8352//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12621734/HBASE-10274-0.94-v2.patch against trunk revision . ATTACHMENT ID: 12621734 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8352//console This message is automatically generated.
          Hide
          Enis Soztutar added a comment -

          I think it's better to fix it because our codebase is 0.94.

          Do you mind backporting the patch for HBASE-6820? We cannot commit this to 0.94 unless the backport is there.

          Show
          Enis Soztutar added a comment - I think it's better to fix it because our codebase is 0.94. Do you mind backporting the patch for HBASE-6820 ? We cannot commit this to 0.94 unless the backport is there.
          Hide
          chendihao added a comment -

          Backporting HBASE-6820 seems good for us. Thanks for considering. Enis Soztutar
          Let's opening another issue to do that.

          Show
          chendihao added a comment - Backporting HBASE-6820 seems good for us. Thanks for considering. Enis Soztutar Let's opening another issue to do that.
          Hide
          Enis Soztutar added a comment -

          Do you mind backporting the patch for HBASE-6820

          I meant do you want to do the backport : )

          Show
          Enis Soztutar added a comment - Do you mind backporting the patch for HBASE-6820 I meant do you want to do the backport : )
          Hide
          chendihao added a comment -

          Thank Enis Soztutar and you're so considerate. It's all good as long as the problem is solved.
          HBASE-10306 is opened and needs a quick fix.

          Show
          chendihao added a comment - Thank Enis Soztutar and you're so considerate. It's all good as long as the problem is solved. HBASE-10306 is opened and needs a quick fix.
          Hide
          chendihao added a comment -

          Thank Lars Hofhansl to resolve HBASE-10306 and please commit this by the way.

          Show
          chendihao added a comment - Thank Lars Hofhansl to resolve HBASE-10306 and please commit this by the way.
          Hide
          Lars Hofhansl added a comment -

          stack, Andrew Purtell, I assume you want this (test stability fix) in 0.96/0.98.

          Show
          Lars Hofhansl added a comment - stack , Andrew Purtell , I assume you want this (test stability fix) in 0.96/0.98.
          Hide
          Andrew Purtell added a comment -

          One HadoopQA run was good, the other failed org.apache.hadoop.hbase.zookeeper.lock.TestZKInterProcessReadWriteLock. Has anyone tested if this changes makes our ZK unit tests flaky?

          Show
          Andrew Purtell added a comment - One HadoopQA run was good, the other failed org.apache.hadoop.hbase.zookeeper.lock.TestZKInterProcessReadWriteLock. Has anyone tested if this changes makes our ZK unit tests flaky?
          Hide
          Andrew Purtell added a comment -

          Anyway, we can try it on 0.98. If tests do flake, I can revert and recommit to 0.98.1.

          Show
          Andrew Purtell added a comment - Anyway, we can try it on 0.98. If tests do flake, I can revert and recommit to 0.98.1.
          Hide
          Enis Soztutar added a comment -

          Let's try the qa one more time. I'll also run the test a couple of times.

          Show
          Enis Soztutar added a comment - Let's try the qa one more time. I'll also run the test a couple of times.
          Hide
          Enis Soztutar added a comment -

          Reattaching the patch for hadoopqa.

          Show
          Enis Soztutar added a comment - Reattaching the patch for hadoopqa.
          Hide
          Enis Soztutar added a comment -

          Run TestZKInterProcessReadWriteLock 20 times. I'll commit this if hadoopqa reports ok.

          Show
          Enis Soztutar added a comment - Run TestZKInterProcessReadWriteLock 20 times. I'll commit this if hadoopqa reports ok.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12622734/HBASE-10274-truck-v2.patch
          against trunk revision .
          ATTACHMENT ID: 12622734

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 hadoop1.0. The patch compiles against the hadoop 1.0 profile.

          +1 hadoop1.1. The patch compiles against the hadoop 1.1 profile.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 lineLengths. The patch does not introduce lines longer than 100

          -1 site. The patch appears to cause mvn site goal to fail.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12622734/HBASE-10274-truck-v2.patch against trunk revision . ATTACHMENT ID: 12622734 +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop1.0 . The patch compiles against the hadoop 1.0 profile. +1 hadoop1.1 . The patch compiles against the hadoop 1.1 profile. +1 javadoc . The javadoc tool did not generate any warning messages. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 lineLengths . The patch does not introduce lines longer than 100 -1 site . The patch appears to cause mvn site goal to fail. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/8410//console This message is automatically generated.
          Hide
          Enis Soztutar added a comment -

          Committed this to 0.94,0.96,0.98 and trunk (bugfix). Thanks chendihao for the patch.

          Show
          Enis Soztutar added a comment - Committed this to 0.94,0.96,0.98 and trunk (bugfix). Thanks chendihao for the patch.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-0.94-security #388 (See https://builds.apache.org/job/HBase-0.94-security/388/)
          HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557923)

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-0.94-security #388 (See https://builds.apache.org/job/HBase-0.94-security/388/ ) HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557923) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.94-JDK7 #28 (See https://builds.apache.org/job/HBase-0.94-JDK7/28/)
          HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557923)

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.94-JDK7 #28 (See https://builds.apache.org/job/HBase-0.94-JDK7/28/ ) HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557923) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.94 #1260 (See https://builds.apache.org/job/HBase-0.94/1260/)
          HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557923)

          • /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.94 #1260 (See https://builds.apache.org/job/HBase-0.94/1260/ ) HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557923) /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-TRUNK #4813 (See https://builds.apache.org/job/HBase-TRUNK/4813/)
          HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557919)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #4813 (See https://builds.apache.org/job/HBase-TRUNK/4813/ ) HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557919) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96 #255 (See https://builds.apache.org/job/hbase-0.96/255/)
          HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557921)

          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - SUCCESS: Integrated in hbase-0.96 #255 (See https://builds.apache.org/job/hbase-0.96/255/ ) HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557921) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          chendihao added a comment -

          Thanks all
          There're two minor issues about minicluster, HBASE-10282 and HBASE-10283, do you mind taking a look? Enis Soztutar Lars Hofhansl Andrew Purtell

          Show
          chendihao added a comment - Thanks all There're two minor issues about minicluster, HBASE-10282 and HBASE-10283 , do you mind taking a look? Enis Soztutar Lars Hofhansl Andrew Purtell
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #71 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/71/)
          HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557920)

          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #71 (See https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/71/ ) HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557920) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in HBase-0.98 #77 (See https://builds.apache.org/job/HBase-0.98/77/)
          HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557920)

          • /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - FAILURE: Integrated in HBase-0.98 #77 (See https://builds.apache.org/job/HBase-0.98/77/ ) HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557920) /hbase/branches/0.98/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in hbase-0.96-hadoop2 #174 (See https://builds.apache.org/job/hbase-0.96-hadoop2/174/)
          HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557921)

          • /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - SUCCESS: Integrated in hbase-0.96-hadoop2 #174 (See https://builds.apache.org/job/hbase-0.96-hadoop2/174/ ) HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557921) /hbase/branches/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #53 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/53/)
          HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557919)

          • /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java
          Show
          Hudson added a comment - SUCCESS: Integrated in HBase-TRUNK-on-Hadoop-1.1 #53 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-1.1/53/ ) HBASE-10274 MiniZookeeperCluster should close ZKDatabase when shutdown ZooKeeperServers (chendihao via enis) (enis: rev 1557919) /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/zookeeper/MiniZooKeeperCluster.java

            People

            • Assignee:
              chendihao
              Reporter:
              chendihao
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development