Hadoop Common
  1. Hadoop Common
  2. HADOOP-9848

Create a MiniKDC for use with security testing

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.3.0
    • Component/s: security, test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Create a MiniKDC using Apache Directory Server. MiniKDC builds an embedded KDC (key distribution center), and allows to create principals and keytabs on the fly. MiniKDC can be integrated for Hadoop security unit testing.

      1. HADOOP-9848.patch
        45 kB
        Wei Yan
      2. HADOOP-9848.patch
        45 kB
        Wei Yan
      3. HADOOP-9848.patch
        45 kB
        Wei Yan
      4. HADOOP-9848.patch
        46 kB
        Wei Yan
      5. HADOOP-9848.patch
        45 kB
        Wei Yan

        Issue Links

          Activity

          Hide
          Wei Yan added a comment -

          Upload a patch that creates a module hadoop-minikdc under hadoop-common-project. Testcases also included showing how to use MiniKdc.

          Show
          Wei Yan added a comment - Upload a patch that creates a module hadoop-minikdc under hadoop-common-project. Testcases also included showing how to use MiniKdc.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12596928/HADOOP-9848.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-minikdc.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2948//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2948//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596928/HADOOP-9848.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-minikdc. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2948//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2948//console This message is automatically generated.
          Hide
          Wei Yan added a comment -

          Update patch to remove javadoc annotation warnings.

          Show
          Wei Yan added a comment - Update patch to remove javadoc annotation warnings.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12596984/HADOOP-9848.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          -1 javac. The applied patch generated 1151 javac compiler warnings (more than the trunk's current 1149 warnings).

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-minikdc.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2952//testReport/
          Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2952//artifact/trunk/patchprocess/diffJavacWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2952//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12596984/HADOOP-9848.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. -1 javac . The applied patch generated 1151 javac compiler warnings (more than the trunk's current 1149 warnings). +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-minikdc. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2952//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/2952//artifact/trunk/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2952//console This message is automatically generated.
          Hide
          Wei Yan added a comment -

          The javac warnings are irrelevant to the patch. It is the checksum missing in jboss repository.

          [WARNING] Checksum validation failed, no checksums available from the repository for 
          http://repository.jboss.org/nexus/content/groups/public/com/github/stephenc/findbugs/findbugs-annotations/1.3.9-1/findbugs-annotations-1.3.9-1.pom
          [WARNING] Checksum validation failed, no checksums available from the repository for 
          http://repository.jboss.org/nexus/content/groups/public/com/github/stephenc/findbugs/findbugs-annotations/1.3.9-1/findbugs-annotations-1.3.9-1.jar
          
          Show
          Wei Yan added a comment - The javac warnings are irrelevant to the patch. It is the checksum missing in jboss repository. [WARNING] Checksum validation failed, no checksums available from the repository for http: //repository.jboss.org/nexus/content/groups/ public /com/github/stephenc/findbugs/findbugs-annotations/1.3.9-1/findbugs-annotations-1.3.9-1.pom [WARNING] Checksum validation failed, no checksums available from the repository for http: //repository.jboss.org/nexus/content/groups/ public /com/github/stephenc/findbugs/findbugs-annotations/1.3.9-1/findbugs-annotations-1.3.9-1.jar
          Hide
          Alejandro Abdelnur added a comment -

          Nice, this will enable some critical tests exercise kerberos as part of the build.

          It looks good, just a bunch of minor comments:

          on the 'hacked' ApacheDS classes, please open a JIRA again Apache DS stating that the KeytbaEncoder.write() method should take into account the size of the entries list to determine the buffer size (IMO that is the correct fix), for this a reasonable max size per entry must be determined, I would assume given the current 512 buffer size that works for the entries (5) of one principal, something reasonable is 103, still I would suggest using 256 to be safe. Mention in the comments that these classes should be removed once we use an ApacheDS version that has the fix (mention the ApacheDS JIRA). Also create a Hadoop JIRA blocked by the ApacheDS JIRA.

          remove the minikdc script, the idea of the MiniKdc is tobe used for unittesting, not as a 'kdc' (at least when used from hadoop-minikdc)

          the minikdc-krb5.conf file should have a license header. If I'm correct, krb5.conf comment lines must start with ';'

          ON the MiniKdc, remove the class comments from "As a standalone KDC" till the end. Still leave the main() method intact.

          minikdc.ldiff file should have license header, comments in ldiff files start with '#'

          minikdc.xml assembly file, remove it, use the emtpy.xml as many other modules. Same rationale as the minikdc script

          hadoop-minikdc pom.xml, the apache-rat plugin & exclusions are not needed after adding the license headers to those 2 files as mentioned above.

          Show
          Alejandro Abdelnur added a comment - Nice, this will enable some critical tests exercise kerberos as part of the build. It looks good, just a bunch of minor comments: on the 'hacked' ApacheDS classes, please open a JIRA again Apache DS stating that the KeytbaEncoder.write() method should take into account the size of the entries list to determine the buffer size (IMO that is the correct fix), for this a reasonable max size per entry must be determined, I would assume given the current 512 buffer size that works for the entries (5) of one principal, something reasonable is 103, still I would suggest using 256 to be safe. Mention in the comments that these classes should be removed once we use an ApacheDS version that has the fix (mention the ApacheDS JIRA). Also create a Hadoop JIRA blocked by the ApacheDS JIRA. remove the minikdc script, the idea of the MiniKdc is tobe used for unittesting, not as a 'kdc' (at least when used from hadoop-minikdc) the minikdc-krb5.conf file should have a license header. If I'm correct, krb5.conf comment lines must start with ';' ON the MiniKdc, remove the class comments from "As a standalone KDC" till the end. Still leave the main() method intact. minikdc.ldiff file should have license header, comments in ldiff files start with '#' minikdc.xml assembly file, remove it, use the emtpy.xml as many other modules. Same rationale as the minikdc script hadoop-minikdc pom.xml, the apache-rat plugin & exclusions are not needed after adding the license headers to those 2 files as mentioned above.
          Hide
          Daryn Sharp added a comment -

          I'm lacking the time to thoroughly review, but I'm quite excited by this! Questions: is it possible use the ApacheDS KDC w/o ldap? If no, is it possible to create a file for the ldifs? It looks like an awful lot of programatic code to get the miniKDC up and running, but maybe that's unavoidable?

          What would be very nice is for a unit test base class, ex. KerberosSecurityTest, that junit files can extend. The base class may have a @BeforeClass and @AfterClass to start/stop the kdc. It would extremely nice to show that we can take existing junit tests, extend the test base class, and have them "just work".

          Show
          Daryn Sharp added a comment - I'm lacking the time to thoroughly review, but I'm quite excited by this! Questions: is it possible use the ApacheDS KDC w/o ldap? If no, is it possible to create a file for the ldifs? It looks like an awful lot of programatic code to get the miniKDC up and running, but maybe that's unavoidable? What would be very nice is for a unit test base class, ex. KerberosSecurityTest, that junit files can extend. The base class may have a @BeforeClass and @AfterClass to start/stop the kdc. It would extremely nice to show that we can take existing junit tests, extend the test base class, and have them "just work".
          Hide
          Alejandro Abdelnur added a comment -

          Daryn Sharp, I was helping Wei getting started with this patch, I don't think there is a way to start the kdc without the ldap server backing it. Regarding the creation of the schema, I know Wei tried a few different ways of doing this with the goal of making things completely transparent to the users, other approaches required using a bunch of annotations before starting the kdc and that was not pretty. The generated files after this schema initialization are ~1400 files in the working directory, so I'd say that these extra 70lines do create the schema are far better than checking in ~1400 ldiff files (which I don't know how they could be parameterized). The MiniKdc trashes its private working dir on shutdown not to leave those files around.

          About having a KerberosSecurityTestcase, that sounds like a good Idea. Wei, mind doing that? It should be under main/source/java, and you'll have to make junit a compile dependency.

          Show
          Alejandro Abdelnur added a comment - Daryn Sharp , I was helping Wei getting started with this patch, I don't think there is a way to start the kdc without the ldap server backing it. Regarding the creation of the schema, I know Wei tried a few different ways of doing this with the goal of making things completely transparent to the users, other approaches required using a bunch of annotations before starting the kdc and that was not pretty. The generated files after this schema initialization are ~1400 files in the working directory, so I'd say that these extra 70lines do create the schema are far better than checking in ~1400 ldiff files (which I don't know how they could be parameterized). The MiniKdc trashes its private working dir on shutdown not to leave those files around. About having a KerberosSecurityTestcase , that sounds like a good Idea. Wei, mind doing that? It should be under main/source/java, and you'll have to make junit a compile dependency.
          Hide
          Wei Yan added a comment -

          I'll update a patch combining previous comments.

          Show
          Wei Yan added a comment - I'll update a patch combining previous comments.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12597502/HADOOP-9848.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-minikdc.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2967//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2967//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12597502/HADOOP-9848.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-minikdc. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2967//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2967//console This message is automatically generated.
          Hide
          Wei Yan added a comment -

          The javadoc warnings can be ignored. The javadoc warnings show that the findbugs-annotations cannot be found for ApacheDS. Our MiniKdc doesn't need findbugs-annoations.

          [WARNING] org/apache/directory/api/ldap/model/name/Dn.class(org/apache/directory/api/ldap/model/name:Dn.class): warning: Cannot find annotation method 'value()' in type 'edu.umd.cs.findbugs.annotations.SuppressWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressWarnings not found
          [WARNING] org/apache/directory/api/ldap/model/name/Dn.class(org/apache/directory/api/ldap/model/name:Dn.class): warning: Cannot find annotation method 'justification()' in type 'edu.umd.cs.findbugs.annotations.SuppressWarnings'
          
          Show
          Wei Yan added a comment - The javadoc warnings can be ignored. The javadoc warnings show that the findbugs-annotations cannot be found for ApacheDS. Our MiniKdc doesn't need findbugs-annoations. [WARNING] org/apache/directory/api/ldap/model/name/Dn.class(org/apache/directory/api/ldap/model/name:Dn.class): warning: Cannot find annotation method 'value()' in type 'edu.umd.cs.findbugs.annotations.SuppressWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressWarnings not found [WARNING] org/apache/directory/api/ldap/model/name/Dn.class(org/apache/directory/api/ldap/model/name:Dn.class): warning: Cannot find annotation method 'justification()' in type 'edu.umd.cs.findbugs.annotations.SuppressWarnings'
          Hide
          Alejandro Abdelnur added a comment -

          Wei Yan, on the new KerberosSecurityTestcase class:

          • abstract class is good
          • instead using @Before and @After, Daryn Sharp was suggesting @BeforeClass and @AfterClass, this makes the KDC to come up once for all tests in the testcase class, before the first one, and shutdown after the last one. I think that is better as starting the kdc takes its good second. Note that the methods annotated with @BeforeClass and @AfterClass must be static.
          • The getTestDir() and and createConf() should be concrete methods in this class.
          • The createConf() method should be renamed to the more explicit createMiniKdcConf() name.
          • The instance vars should be private, the should be a 'MiniKdc getKdc()' method

          After those changes it looks good to me to go in, then we can start with using it in hadoop-auth for the SPNEGO imp.

          Show
          Alejandro Abdelnur added a comment - Wei Yan , on the new KerberosSecurityTestcase class: abstract class is good instead using @Before and @After, Daryn Sharp was suggesting @BeforeClass and @AfterClass, this makes the KDC to come up once for all tests in the testcase class, before the first one, and shutdown after the last one. I think that is better as starting the kdc takes its good second. Note that the methods annotated with @BeforeClass and @AfterClass must be static. The getTestDir() and and createConf() should be concrete methods in this class. The createConf() method should be renamed to the more explicit createMiniKdcConf() name. The instance vars should be private, the should be a 'MiniKdc getKdc()' method After those changes it looks good to me to go in, then we can start with using it in hadoop-auth for the SPNEGO imp.
          Hide
          Wei Yan added a comment -

          After offline discussion with Alejandro Abdelnur, here we keep using @Before and @After instead of @BeforeClass and @AfterClass.

          Using @BeforeClass and @AfterClass would cause the other two functions (createTestDir() and createMiniKdcConf()) to be static. That means users cannot override these two functions with new settings.

          With @Before and @After, users can inherit class KerberosSecurityTestcase and override functions createTestDir() and createMiniKdcConf() if needed. Note that the kdc will be created and stopped for each @Test function.

          Show
          Wei Yan added a comment - After offline discussion with Alejandro Abdelnur , here we keep using @Before and @After instead of @BeforeClass and @AfterClass. Using @BeforeClass and @AfterClass would cause the other two functions (createTestDir() and createMiniKdcConf()) to be static. That means users cannot override these two functions with new settings. With @Before and @After, users can inherit class KerberosSecurityTestcase and override functions createTestDir() and createMiniKdcConf() if needed. Note that the kdc will be created and stopped for each @Test function.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12597520/HADOOP-9848.patch
          against trunk revision .

          -1 patch. Trunk compilation may be broken.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2968//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12597520/HADOOP-9848.patch against trunk revision . -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2968//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12597538/HADOOP-9848.patch
          against trunk revision .

          -1 patch. Trunk compilation may be broken.

          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2970//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12597538/HADOOP-9848.patch against trunk revision . -1 patch . Trunk compilation may be broken. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2970//console This message is automatically generated.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12597538/HADOOP-9848.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-minikdc.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2972//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2972//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12597538/HADOOP-9848.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. -1 javadoc . The javadoc tool appears to have generated 2 warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-minikdc. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2972//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2972//console This message is automatically generated.
          Hide
          Alejandro Abdelnur added a comment -

          +1, nice job.

          Show
          Alejandro Abdelnur added a comment - +1, nice job.
          Hide
          Alejandro Abdelnur added a comment -

          Thanks Wei. Committed to trunk and branch-2.

          Show
          Alejandro Abdelnur added a comment - Thanks Wei. Committed to trunk and branch-2.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #4250 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4250/)
          HADOOP-9848. Create a MiniKDC for use with security testing. (ywskycn via tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513308)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytab.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytabEncoder.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/KerberosSecurityTestcase.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/MiniKdc.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/log4j.properties
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc-krb5.conf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc.ldiff
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java
          • /hadoop/common/trunk/hadoop-common-project/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4250 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4250/ ) HADOOP-9848 . Create a MiniKDC for use with security testing. (ywskycn via tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513308 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytab.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytabEncoder.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/KerberosSecurityTestcase.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/MiniKdc.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/log4j.properties /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc-krb5.conf /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc.ldiff /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java /hadoop/common/trunk/hadoop-common-project/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Tsz Wo Nicholas Sze added a comment -

          > -1 javadoc. The javadoc tool appears to have generated 2 warning messages.

          Has anyone checked the javadoc warnings?

          Show
          Tsz Wo Nicholas Sze added a comment - > -1 javadoc. The javadoc tool appears to have generated 2 warning messages. Has anyone checked the javadoc warnings?
          Hide
          Wei Yan added a comment -

          Tsz Wo Nicholas Sze
          The two javadoc warnings are not related to this patch.

          [WARNING] org/apache/directory/api/ldap/model/name/Dn.class(org/apache/directory/api/ldap/model/name:Dn.class): warning: Cannot find annotation method
           'value()' in type 'edu.umd.cs.findbugs.annotations.SuppressWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressWarnings not found
          [WARNING] org/apache/directory/api/ldap/model/name/Dn.class(org/apache/directory/api/ldap/model/name:Dn.class): warning: Cannot find annotation method 
          'justification()' in type 'edu.umd.cs.findbugs.annotations.SuppressWarnings'
          

          This patch uses class Dn from ApacheDS, but doesn't use findbugs-annotations. So I don't include findbugs-annotations in this patch. Actually, if we import findbugs-annotations here, it would introduce javac warnings (https://issues.apache.org/jira/browse/HADOOP-9848?focusedCommentId=13735059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13735059) because of unavailable jar package checksum.

          This javadoc warnings also discussed in YARN-107, YARN-643.

          Show
          Wei Yan added a comment - Tsz Wo Nicholas Sze The two javadoc warnings are not related to this patch. [WARNING] org/apache/directory/api/ldap/model/name/Dn.class(org/apache/directory/api/ldap/model/name:Dn.class): warning: Cannot find annotation method 'value()' in type 'edu.umd.cs.findbugs.annotations.SuppressWarnings': class file for edu.umd.cs.findbugs.annotations.SuppressWarnings not found [WARNING] org/apache/directory/api/ldap/model/name/Dn.class(org/apache/directory/api/ldap/model/name:Dn.class): warning: Cannot find annotation method 'justification()' in type 'edu.umd.cs.findbugs.annotations.SuppressWarnings' This patch uses class Dn from ApacheDS, but doesn't use findbugs-annotations. So I don't include findbugs-annotations in this patch. Actually, if we import findbugs-annotations here, it would introduce javac warnings ( https://issues.apache.org/jira/browse/HADOOP-9848?focusedCommentId=13735059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13735059 ) because of unavailable jar package checksum. This javadoc warnings also discussed in YARN-107 , YARN-643 .
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #300 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/300/)
          HADOOP-9848. Create a MiniKDC for use with security testing. (ywskycn via tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513308)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytab.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytabEncoder.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/KerberosSecurityTestcase.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/MiniKdc.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/log4j.properties
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc-krb5.conf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc.ldiff
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java
          • /hadoop/common/trunk/hadoop-common-project/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #300 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/300/ ) HADOOP-9848 . Create a MiniKDC for use with security testing. (ywskycn via tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513308 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytab.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytabEncoder.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/KerberosSecurityTestcase.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/MiniKdc.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/log4j.properties /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc-krb5.conf /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc.ldiff /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java /hadoop/common/trunk/hadoop-common-project/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1490 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1490/)
          HADOOP-9848. Create a MiniKDC for use with security testing. (ywskycn via tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513308)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytab.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytabEncoder.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/KerberosSecurityTestcase.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/MiniKdc.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/log4j.properties
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc-krb5.conf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc.ldiff
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java
          • /hadoop/common/trunk/hadoop-common-project/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1490 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1490/ ) HADOOP-9848 . Create a MiniKDC for use with security testing. (ywskycn via tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513308 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytab.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytabEncoder.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/KerberosSecurityTestcase.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/MiniKdc.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/log4j.properties /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc-krb5.conf /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc.ldiff /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java /hadoop/common/trunk/hadoop-common-project/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Hi Wei,

          Thanks for checking it. I understand that these two javadoc warnings may be unavoidable. However, after the patch is committed, all the future builds will fail with javadoc warnings. After this patch, all QA results will give "-1 javadoc. ..." for any patch, for example this one. I believe it is not something you want.

          Could we use some library other than Dn? If there is really no way to fix it and we cannot use something else, we may increase OK_JAVADOC_WARNINGS, i.e.

          --- dev-support/test-patch.sh	(revision 1513320)
          +++ dev-support/test-patch.sh	(working copy)
          @@ -426,7 +426,7 @@
             echo "There appear to be $javadocWarnings javadoc warnings generated by the patched build."
           
             #There are 11 warnings that are caused by things that are caused by using sun internal APIs.
          -  OK_JAVADOC_WARNINGS=11;
          +  OK_JAVADOC_WARNINGS=13;
             ### if current warnings greater than OK_JAVADOC_WARNINGS
             if [[ $javadocWarnings -ne $OK_JAVADOC_WARNINGS ]] ; then
               JIRA_COMMENT="$JIRA_COMMENT
          
          Show
          Tsz Wo Nicholas Sze added a comment - Hi Wei, Thanks for checking it. I understand that these two javadoc warnings may be unavoidable. However, after the patch is committed, all the future builds will fail with javadoc warnings. After this patch, all QA results will give "-1 javadoc. ..." for any patch, for example this one . I believe it is not something you want. Could we use some library other than Dn? If there is really no way to fix it and we cannot use something else, we may increase OK_JAVADOC_WARNINGS, i.e. --- dev-support/test-patch.sh (revision 1513320) +++ dev-support/test-patch.sh (working copy) @@ -426,7 +426,7 @@ echo "There appear to be $javadocWarnings javadoc warnings generated by the patched build." #There are 11 warnings that are caused by things that are caused by using sun internal APIs. - OK_JAVADOC_WARNINGS=11; + OK_JAVADOC_WARNINGS=13; ### if current warnings greater than OK_JAVADOC_WARNINGS if [[ $javadocWarnings -ne $OK_JAVADOC_WARNINGS ]] ; then JIRA_COMMENT="$JIRA_COMMENT
          Hide
          Suresh Srinivas added a comment -
          Show
          Suresh Srinivas added a comment - Alejandro Abdelnur Please do not commit patches without addressing -1 from jenkins - https://issues.apache.org/jira/secure/EditComment!default.jspa?id=12662454&commentId=13737505 .
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1517 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1517/)
          HADOOP-9848. Create a MiniKDC for use with security testing. (ywskycn via tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513308)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/pom.xml
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytab.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytabEncoder.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/KerberosSecurityTestcase.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/MiniKdc.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/log4j.properties
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc-krb5.conf
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc.ldiff
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc
          • /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java
          • /hadoop/common/trunk/hadoop-common-project/pom.xml
          • /hadoop/common/trunk/hadoop-project/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1517 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1517/ ) HADOOP-9848 . Create a MiniKDC for use with security testing. (ywskycn via tucu) (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513308 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/pom.xml /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytab.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/directory/server/kerberos/shared/keytab/HackedKeytabEncoder.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/KerberosSecurityTestcase.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/java/org/apache/hadoop/minikdc/MiniKdc.java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/log4j.properties /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc-krb5.conf /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/main/resources/minikdc.ldiff /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc /hadoop/common/trunk/hadoop-common-project/hadoop-minikdc/src/test/java/org/apache/hadoop/minikdc/TestMiniKdc.java /hadoop/common/trunk/hadoop-common-project/pom.xml /hadoop/common/trunk/hadoop-project/pom.xml
          Hide
          Alejandro Abdelnur added a comment -

          Suresh Srinivas, Tsz Wo Nicholas Sze, missed test-patch before (thought the warning count was using trunk as base). I've just committed a fix for test-patch in trunk and branch-2. Answering Nicholas, is not possible to use other class than Dn as that is what ApacheDS uses.

          Show
          Alejandro Abdelnur added a comment - Suresh Srinivas , Tsz Wo Nicholas Sze , missed test-patch before (thought the warning count was using trunk as base). I've just committed a fix for test-patch in trunk and branch-2. Answering Nicholas, is not possible to use other class than Dn as that is what ApacheDS uses.
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #4252 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4252/)
          HADOOP-9848 Addendum fixing OK_JAVADOC_WARNINGS in test-patch (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513527)

          • /hadoop/common/trunk/dev-support/test-patch.sh
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4252 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4252/ ) HADOOP-9848 Addendum fixing OK_JAVADOC_WARNINGS in test-patch (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513527 ) /hadoop/common/trunk/dev-support/test-patch.sh
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #301 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/301/)
          HADOOP-9848 Addendum fixing OK_JAVADOC_WARNINGS in test-patch (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513527)

          • /hadoop/common/trunk/dev-support/test-patch.sh
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #301 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/301/ ) HADOOP-9848 Addendum fixing OK_JAVADOC_WARNINGS in test-patch (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513527 ) /hadoop/common/trunk/dev-support/test-patch.sh
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1491 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1491/)
          HADOOP-9848 Addendum fixing OK_JAVADOC_WARNINGS in test-patch (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513527)

          • /hadoop/common/trunk/dev-support/test-patch.sh
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1491 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1491/ ) HADOOP-9848 Addendum fixing OK_JAVADOC_WARNINGS in test-patch (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513527 ) /hadoop/common/trunk/dev-support/test-patch.sh
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1518 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1518/)
          HADOOP-9848 Addendum fixing OK_JAVADOC_WARNINGS in test-patch (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513527)

          • /hadoop/common/trunk/dev-support/test-patch.sh
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1518 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1518/ ) HADOOP-9848 Addendum fixing OK_JAVADOC_WARNINGS in test-patch (tucu: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1513527 ) /hadoop/common/trunk/dev-support/test-patch.sh
          Hide
          Kai Zheng added a comment -

          HADOOP-9881 was opened to document some questions and possible improvement for MiniKdc/TestMiniKdc. Would you comment on that? Thanks.

          Show
          Kai Zheng added a comment - HADOOP-9881 was opened to document some questions and possible improvement for MiniKdc/TestMiniKdc. Would you comment on that? Thanks.

            People

            • Assignee:
              Wei Yan
              Reporter:
              Wei Yan
            • Votes:
              0 Vote for this issue
              Watchers:
              18 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development