Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9707

Fix register lists for crc32c inline assembly

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1.0-beta, 3.0.0-alpha1
    • 2.1.0-beta
    • util
    • None
    • Reviewed

    Description

      The inline assembly used for the crc32 instructions has an incorrect clobber list: the computed CRC values are "in-out" variables and thus need to use the "matching constraint" syntax in the clobber list.

      This doesn't seem to cause a problem now in Hadoop, but may break in a different compiler version which allocates registers differently, or may break when the same code is used in another context.

      Attachments

        1. hadoop-9707.txt
          3 kB
          Todd Lipcon

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tlipcon Todd Lipcon
            tlipcon Todd Lipcon
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment