Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9707

Fix register lists for crc32c inline assembly

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.0-beta, 3.0.0-alpha1
    • Fix Version/s: 2.1.0-beta
    • Component/s: util
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The inline assembly used for the crc32 instructions has an incorrect clobber list: the computed CRC values are "in-out" variables and thus need to use the "matching constraint" syntax in the clobber list.

      This doesn't seem to cause a problem now in Hadoop, but may break in a different compiler version which allocates registers differently, or may break when the same code is used in another context.

        Attachments

        1. hadoop-9707.txt
          3 kB
          Todd Lipcon

          Activity

            People

            • Assignee:
              tlipcon Todd Lipcon
              Reporter:
              tlipcon Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: