[HADOOP-9443] Port winutils static code analysis change to trunk

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.1.0-beta
• Hadoop Flags: Reviewed
• Assignee: Chuan Liu
• Reporter: Chuan Liu
• Created: 29/Mar/13 01:33
• Updated: 12/May/16 18:25
• Resolved: 20/Apr/13 20:21

Description

We hit a problem in winutils when running tests on Windows. The static code analysis change will fix the problem. More specifically, the old code always assumes the security descriptor get from GetSecurityDescriptorControl() is relative, and will make an absolute security descriptor out of it. The new absolute security descriptor will then pass to SetSecurityDescriptorDacl() to set permissions on the file. If the security descriptor is absolute, the new absolute security descriptor will be NULL, and we will run into the problem. This is what happened exactly in our case. The fix from static code analysis will solve the problem.

Issue Links

• is part of: HADOOP-8562 Enhancements to support Hadoop on Windows Server and Windows Azure environments
• relates to: HADOOP-9177 Address issues that came out from running static code analysis on winutils