Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9177

Address issues that came out from running static code analysis on winutils

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1-win
    • Fix Version/s: 1-win
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Issue Links

        Activity

        Hide
        ivanmi Ivan Mitic added a comment -

        Attaching the patch.

        Show
        ivanmi Ivan Mitic added a comment - Attaching the patch.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12565847/HADOOP-9177.branch-1-win.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2075//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565847/HADOOP-9177.branch-1-win.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2075//console This message is automatically generated.
        Hide
        chuanliu Chuan Liu added a comment -

        +1

        Change looks good. Static code analysis could help us elimite potential vulnerable code in the future. The annotations also make the code more robust.

        Show
        chuanliu Chuan Liu added a comment - +1 Change looks good. Static code analysis could help us elimite potential vulnerable code in the future. The annotations also make the code more robust.
        Hide
        sureshms Suresh Srinivas added a comment -

        +1 for the patch. Committed it to branch-1-win.

        Thank you Ivan.

        Show
        sureshms Suresh Srinivas added a comment - +1 for the patch. Committed it to branch-1-win. Thank you Ivan.

          People

          • Assignee:
            ivanmi Ivan Mitic
            Reporter:
            ivanmi Ivan Mitic
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development