Hadoop Common
  1. Hadoop Common
  2. HADOOP-9339

IPC.Server incorrectly sets UGI auth type

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0, 2.0.0-alpha, 3.0.0
    • Fix Version/s: 0.23.7, 2.1.0-beta
    • Component/s: ipc
    • Labels:
      None

      Description

      For non-secure servers, IPC.Server#processConnectionContext will explicitly set the UGI's auth type to SIMPLE. However the auth type has already been set by this point, and this explicit set causes proxy UGIs to be SIMPLE/SIMPLE instead of PROXY/SIMPLE.

      1. HADOOP-9339.patch
        0.7 kB
        Daryn Sharp
      2. HADOOP-9339.patch
        2 kB
        Daryn Sharp
      3. HADOOP-9339.branch-23.patch
        2 kB
        Daryn Sharp

        Issue Links

          Activity

          Hide
          Daryn Sharp added a comment -

          No tests because it will be tested by HADOOP-9336.

          Show
          Daryn Sharp added a comment - No tests because it will be tested by HADOOP-9336 .
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12571239/HADOOP-9339.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.security.TestDoAsEffectiveUser

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2234//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2234//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571239/HADOOP-9339.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.security.TestDoAsEffectiveUser +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2234//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2234//console This message is automatically generated.
          Hide
          Daryn Sharp added a comment -

          Sadly the failed test is testing for the bad behavior. At least now I have a test independent of 9336. Also discovered its in 23, just a different location.

          Show
          Daryn Sharp added a comment - Sadly the failed test is testing for the bad behavior. At least now I have a test independent of 9336. Also discovered its in 23, just a different location.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12571265/HADOOP-9339.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 tests included appear to have a timeout.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2237//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2237//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12571265/HADOOP-9339.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 tests included appear to have a timeout. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2237//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2237//console This message is automatically generated.
          Hide
          Kihwal Lee added a comment -

          +1 It looks good to me.

          Show
          Kihwal Lee added a comment - +1 It looks good to me.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3393 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3393/)
          HADOOP-9339. IPC.Server incorrectly sets UGI auth type. Contributed by Daryn Sharp (Revision 1450963)

          Result = SUCCESS
          kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450963
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3393 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3393/ ) HADOOP-9339 . IPC.Server incorrectly sets UGI auth type. Contributed by Daryn Sharp (Revision 1450963) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450963 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          Hide
          Kihwal Lee added a comment -

          Thanks Daryn for the patch. I've committed it to trunk, branch-2 and branch-0.23.

          Show
          Kihwal Lee added a comment - Thanks Daryn for the patch. I've committed it to trunk, branch-2 and branch-0.23.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-trunk-Commit #3394 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3394/)
          Typo in CHANGES.txt for HADOOP-9339 (Revision 1450970)

          Result = SUCCESS
          kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450970
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          Hudson added a comment - Integrated in Hadoop-trunk-Commit #3394 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3394/ ) Typo in CHANGES.txt for HADOOP-9339 (Revision 1450970) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450970 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Yarn-trunk #141 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/141/)
          Typo in CHANGES.txt for HADOOP-9339 (Revision 1450970)
          HADOOP-9339. IPC.Server incorrectly sets UGI auth type. Contributed by Daryn Sharp (Revision 1450963)

          Result = SUCCESS
          kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450970
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

          kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450963
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          Show
          Hudson added a comment - Integrated in Hadoop-Yarn-trunk #141 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/141/ ) Typo in CHANGES.txt for HADOOP-9339 (Revision 1450970) HADOOP-9339 . IPC.Server incorrectly sets UGI auth type. Contributed by Daryn Sharp (Revision 1450963) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450970 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450963 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #539 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/539/)
          HADOOP-9339. IPC.Server incorrectly sets UGI auth type. Contributed by Daryn Sharp (Revision 1450968)

          Result = UNSTABLE
          kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450968
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #539 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/539/ ) HADOOP-9339 . IPC.Server incorrectly sets UGI auth type. Contributed by Daryn Sharp (Revision 1450968) Result = UNSTABLE kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450968 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1330 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1330/)
          Typo in CHANGES.txt for HADOOP-9339 (Revision 1450970)
          HADOOP-9339. IPC.Server incorrectly sets UGI auth type. Contributed by Daryn Sharp (Revision 1450963)

          Result = SUCCESS
          kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450970
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

          kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450963
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1330 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1330/ ) Typo in CHANGES.txt for HADOOP-9339 (Revision 1450970) HADOOP-9339 . IPC.Server incorrectly sets UGI auth type. Contributed by Daryn Sharp (Revision 1450963) Result = SUCCESS kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450970 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450963 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1358 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1358/)
          Typo in CHANGES.txt for HADOOP-9339 (Revision 1450970)
          HADOOP-9339. IPC.Server incorrectly sets UGI auth type. Contributed by Daryn Sharp (Revision 1450963)

          Result = FAILURE
          kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450970
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

          kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450963
          Files :

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1358 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1358/ ) Typo in CHANGES.txt for HADOOP-9339 (Revision 1450970) HADOOP-9339 . IPC.Server incorrectly sets UGI auth type. Contributed by Daryn Sharp (Revision 1450963) Result = FAILURE kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450970 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1450963 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java

            People

            • Assignee:
              Daryn Sharp
              Reporter:
              Daryn Sharp
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development