Daryn, how (if) will this affect RPC calls done within the context of a doAs()?

The semantics will be returning the UGI of the connection, so it will always report the UGI of the original user making the connection, not of any subsequent UGI.doAs calls. However, this jira will not universally affect anything that doesn't explicitly use it. I intend for only the FSNamesystem audit calls to currently use it to reduce the significant performance bottlenecks we are encountering.

I'm contemplating filing another jira for UGI.doAs to cache a stack of UGIs. That would greatly accelerate UGI.getCurrentUser in general.

Testing of this jira revealed a 3.0/2.x bug, not present in 23, where auth type is set incorrectly.

Add a Server.getRemoteUser to return the current RPC connection's UGI.

Update tests to ensure that UGI.getCurrentUser matches Server.getRemoteUser - note: as mentioned before, another doAs on the server-side intentionally won't be reflected in Server.getRemoteUser.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12571299/HADOOP-9336.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

-1 one of tests included doesn't have a timeout.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2241//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2241//console

This message is automatically generated.

I only modified existing test cases, but was dinged for no timeout which I thought only applied to new tests, so I added timeouts to the tests I modified.

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12571421/HADOOP-9336.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 tests included appear to have a timeout.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2243//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2243//console

This message is automatically generated.

+1 on the code change, but more detailed comment on getRemoteUser() will be nice, in order to avoid potential misuse.

Updated comments per Kihwal

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12571459/HADOOP-9336.patch
against trunk revision .

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 1 new or modified test files.

+1 tests included appear to have a timeout.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 eclipse:eclipse. The patch built with eclipse:eclipse.

+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

+1 contrib tests. The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2246//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2246//console

This message is automatically generated.

I've committed the patch to branch-2 and branch-0.23.

Integrated in Hadoop-trunk-Commit #3400 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3400/)
HADOOP-9336. Allow UGI of current connection to be queried. Contributed by Daryn Sharp. (Revision 1451376)

Result = SUCCESS
kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451376
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java

Integrated in Hadoop-Yarn-trunk #142 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/142/)
HADOOP-9336. Allow UGI of current connection to be queried. Contributed by Daryn Sharp. (Revision 1451376)

Result = SUCCESS
kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451376
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java

Integrated in Hadoop-Hdfs-0.23-Build #540 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/540/)
HADOOP-9336. Allow UGI of current connection to be queried. Contributed by Daryn Sharp. (Revision 1451383)

Result = SUCCESS
kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451383
Files :

• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
• /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java

Integrated in Hadoop-Hdfs-trunk #1331 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1331/)
HADOOP-9336. Allow UGI of current connection to be queried. Contributed by Daryn Sharp. (Revision 1451376)

Result = FAILURE
kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451376
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java

Integrated in Hadoop-Mapreduce-trunk #1359 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1359/)
HADOOP-9336. Allow UGI of current connection to be queried. Contributed by Daryn Sharp. (Revision 1451376)

Result = SUCCESS
kihwal : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1451376
Files :

• /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
• /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/TestDoAsEffectiveUser.java