Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8840

Fix the test-patch colorizer to cover all sorts of +1 lines.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None

      Description

      As noticed by Jason on HADOOP-8838, I missed some of the entries needed to be colorized.

        Issue Links

          Activity

          Hide
          revans2 Robert Joseph Evans added a comment -

          I guess I was too fast on the checkin there. I guess I was just too excited . I'll take a closer look next time.

          Show
          revans2 Robert Joseph Evans added a comment - I guess I was too fast on the checkin there. I guess I was just too excited . I'll take a closer look next time.
          Hide
          qwertymaniac Harsh J added a comment -

          No problem Robert, I was equally excited and the fault's mine for not having basic-checked the coverage

          Here's the rest of them.

          Show
          qwertymaniac Harsh J added a comment - No problem Robert, I was equally excited and the fault's mine for not having basic-checked the coverage Here's the rest of them.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12546558/HADOOP-8840.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1519//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1519//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546558/HADOOP-8840.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1519//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1519//console This message is automatically generated.
          Hide
          revans2 Robert Joseph Evans added a comment -

          It looks good +1. All the +1s are green and all of the -1 are red. I'll check it in.

          Show
          revans2 Robert Joseph Evans added a comment - It looks good +1 . All the +1s are green and all of the -1 are red. I'll check it in.
          Hide
          revans2 Robert Joseph Evans added a comment -

          Checked this into trunk

          Show
          revans2 Robert Joseph Evans added a comment - Checked this into trunk
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2770 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2770/)
          HADOOP-8840. Fix the test-patch colorizer to cover all sorts of +1 lines. (Harsh J via bobby) (Revision 1390129)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390129
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2770 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2770/ ) HADOOP-8840 . Fix the test-patch colorizer to cover all sorts of +1 lines. (Harsh J via bobby) (Revision 1390129) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390129 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2833 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2833/)
          HADOOP-8840. Fix the test-patch colorizer to cover all sorts of +1 lines. (Harsh J via bobby) (Revision 1390129)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390129
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2833 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2833/ ) HADOOP-8840 . Fix the test-patch colorizer to cover all sorts of +1 lines. (Harsh J via bobby) (Revision 1390129) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390129 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2792 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2792/)
          HADOOP-8840. Fix the test-patch colorizer to cover all sorts of +1 lines. (Harsh J via bobby) (Revision 1390129)

          Result = ABORTED
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390129
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2792 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2792/ ) HADOOP-8840 . Fix the test-patch colorizer to cover all sorts of +1 lines. (Harsh J via bobby) (Revision 1390129) Result = ABORTED bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390129 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1177/)
          HADOOP-8840. Fix the test-patch colorizer to cover all sorts of +1 lines. (Harsh J via bobby) (Revision 1390129)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390129
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1177/ ) HADOOP-8840 . Fix the test-patch colorizer to cover all sorts of +1 lines. (Harsh J via bobby) (Revision 1390129) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390129 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1208 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1208/)
          HADOOP-8840. Fix the test-patch colorizer to cover all sorts of +1 lines. (Harsh J via bobby) (Revision 1390129)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390129
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1208 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1208/ ) HADOOP-8840 . Fix the test-patch colorizer to cover all sorts of +1 lines. (Harsh J via bobby) (Revision 1390129) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390129 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2844 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2844/)
          HADOOP-8864. Addendum to HADOOP-8840: Add a coloring case for +0 results too. Contributed by Harsh J. (harsh) (Revision 1391480)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391480
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2844 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2844/ ) HADOOP-8864 . Addendum to HADOOP-8840 : Add a coloring case for +0 results too. Contributed by Harsh J. (harsh) (Revision 1391480) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391480 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2781 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2781/)
          HADOOP-8864. Addendum to HADOOP-8840: Add a coloring case for +0 results too. Contributed by Harsh J. (harsh) (Revision 1391480)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391480
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2781 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2781/ ) HADOOP-8864 . Addendum to HADOOP-8840 : Add a coloring case for +0 results too. Contributed by Harsh J. (harsh) (Revision 1391480) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391480 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2803 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2803/)
          HADOOP-8864. Addendum to HADOOP-8840: Add a coloring case for +0 results too. Contributed by Harsh J. (harsh) (Revision 1391480)

          Result = FAILURE
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391480
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2803 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2803/ ) HADOOP-8864 . Addendum to HADOOP-8840 : Add a coloring case for +0 results too. Contributed by Harsh J. (harsh) (Revision 1391480) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391480 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1180/)
          HADOOP-8864. Addendum to HADOOP-8840: Add a coloring case for +0 results too. Contributed by Harsh J. (harsh) (Revision 1391480)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391480
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1180/ ) HADOOP-8864 . Addendum to HADOOP-8840 : Add a coloring case for +0 results too. Contributed by Harsh J. (harsh) (Revision 1391480) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391480 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1211/)
          HADOOP-8864. Addendum to HADOOP-8840: Add a coloring case for +0 results too. Contributed by Harsh J. (harsh) (Revision 1391480)

          Result = FAILURE
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391480
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1211/ ) HADOOP-8864 . Addendum to HADOOP-8840 : Add a coloring case for +0 results too. Contributed by Harsh J. (harsh) (Revision 1391480) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1391480 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              qwertymaniac Harsh J
              Reporter:
              qwertymaniac Harsh J
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development