Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8838

Colorize the test-patch output sent to JIRA

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None

      Description

      It would be helpful to mark the -1s in red and +1s in green. Helps avoid missing stuff like findbugs warnings, etc., we've been bitten by. Also helps run through the results faster.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1208 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1208/)
          HADOOP-8838. Colorize the test-patch output sent to JIRA (Harsh J via bobby) (Revision 1389875)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389875
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1208 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1208/ ) HADOOP-8838 . Colorize the test-patch output sent to JIRA (Harsh J via bobby) (Revision 1389875) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389875 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1177/)
          HADOOP-8838. Colorize the test-patch output sent to JIRA (Harsh J via bobby) (Revision 1389875)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389875
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1177/ ) HADOOP-8838 . Colorize the test-patch output sent to JIRA (Harsh J via bobby) (Revision 1389875) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389875 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          qwertymaniac Harsh J added a comment -

          No, seems like I missed them (blame my search regex skills). Let me fix this up via HADOOP-8840.

          Show
          qwertymaniac Harsh J added a comment - No, seems like I missed them (blame my search regex skills). Let me fix this up via HADOOP-8840 .
          Hide
          jlowe Jason Lowe added a comment -

          Some of the test patch lines are not colorized, see this example. Was that intentional?

          Show
          jlowe Jason Lowe added a comment - Some of the test patch lines are not colorized, see this example . Was that intentional?
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2790 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2790/)
          HADOOP-8838. Colorize the test-patch output sent to JIRA (Harsh J via bobby) (Revision 1389875)

          Result = FAILURE
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389875
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2790 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2790/ ) HADOOP-8838 . Colorize the test-patch output sent to JIRA (Harsh J via bobby) (Revision 1389875) Result = FAILURE bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389875 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          qwertymaniac Harsh J added a comment -

          Thanks bobby for the fast commit!

          Show
          qwertymaniac Harsh J added a comment - Thanks bobby for the fast commit!
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2831 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2831/)
          HADOOP-8838. Colorize the test-patch output sent to JIRA (Harsh J via bobby) (Revision 1389875)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389875
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2831 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2831/ ) HADOOP-8838 . Colorize the test-patch output sent to JIRA (Harsh J via bobby) (Revision 1389875) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389875 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2768 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2768/)
          HADOOP-8838. Colorize the test-patch output sent to JIRA (Harsh J via bobby) (Revision 1389875)

          Result = SUCCESS
          bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389875
          Files :

          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2768 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2768/ ) HADOOP-8838 . Colorize the test-patch output sent to JIRA (Harsh J via bobby) (Revision 1389875) Result = SUCCESS bobby : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1389875 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          revans2 Robert Joseph Evans added a comment -

          I checked this into trunk

          Show
          revans2 Robert Joseph Evans added a comment - I checked this into trunk
          Hide
          revans2 Robert Joseph Evans added a comment -

          Awesome idea. +1 on the patch. I am checking this in.

          Show
          revans2 Robert Joseph Evans added a comment - Awesome idea. +1 on the patch. I am checking this in.
          Hide
          qwertymaniac Harsh J added a comment -

          +1 overall.

          -1 @author. The patch appears to contain 4 @author tags which the Hadoop community has agreed to not allow in code contributions.

          Filed HADOOP-8839 for this bug.

          Show
          qwertymaniac Harsh J added a comment - +1 overall. -1 @author. The patch appears to contain 4 @author tags which the Hadoop community has agreed to not allow in code contributions. Filed HADOOP-8839 for this bug.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12546496/HADOOP-8838.patch
          against trunk revision .

          -1 @author. The patch appears to contain 4 @author tags which the Hadoop community has agreed to not allow in code contributions.

          +1 tests included. The patch appears to include 1 new or modified test files.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1516//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1516//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546496/HADOOP-8838.patch against trunk revision . -1 @author. The patch appears to contain 4 @author tags which the Hadoop community has agreed to not allow in code contributions. +1 tests included. The patch appears to include 1 new or modified test files. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 javadoc. The javadoc tool did not generate any warning messages. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1516//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1516//console This message is automatically generated.

            People

            • Assignee:
              qwertymaniac Harsh J
              Reporter:
              qwertymaniac Harsh J
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development