Hadoop Common
  1. Hadoop Common
  2. HADOOP-7695

RPC.stopProxy can throw unintended exception while logging error

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.24.0
    • Fix Version/s: 2.0.0-alpha
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      RPC.stopProxy includes the following lines in case of error:

      LOG.error("Could not get invocation handler " + invocationHandler +
                " for proxy " + proxy + ", or invocation handler is not closeable.");
      

      Trouble is, the proxy object is usually backed by WritableRpcEngine, which will fail in the event toString is called on one of its proxy objects. See HADOOP-7694 for more details on that issue. Until that's addressed, we might as well change the log message in RPC.stopProxy to not call toString() on proxy.

      1. HADOOP-7695.patch
        0.7 kB
        Aaron T. Myers

        Issue Links

          Activity

          Aaron T. Myers created issue -
          Uma Maheswara Rao G made changes -
          Field Original Value New Value
          Link This issue relates to HADOOP-7694 [ HADOOP-7694 ]
          Aaron T. Myers made changes -
          Attachment HADOOP-7695.patch [ 12496958 ]
          Aaron T. Myers made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Aaron T. Myers made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Resolution Fixed [ 1 ]
          Tsz Wo Nicholas Sze made changes -
          Fix Version/s 0.23.3 [ 12320059 ]
          Arun C Murthy made changes -
          Fix Version/s 2.0.0 [ 12320352 ]
          Fix Version/s 0.24.0 [ 12317652 ]
          Fix Version/s 0.23.3 [ 12320059 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Aaron T. Myers
              Reporter:
              Aaron T. Myers
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development