[HADOOP-7695] RPC.stopProxy can throw unintended exception while logging error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.24.0
• Fix Version/s: 2.0.0-alpha
• Component/s: ipc
• Hadoop Flags: Reviewed
• Assignee: Aaron Myers
• Reporter: Aaron Myers
• Created: 29/Sep/11 00:54
• Updated: 23/May/12 20:15
• Resolved: 06/Oct/11 06:08

Description

RPC.stopProxy includes the following lines in case of error:

LOG.error("Could not get invocation handler " + invocationHandler +
          " for proxy " + proxy + ", or invocation handler is not closeable.");

Trouble is, the proxy object is usually backed by WritableRpcEngine, which will fail in the event toString is called on one of its proxy objects. See HADOOP-7694 for more details on that issue. Until that's addressed, we might as well change the log message in RPC.stopProxy to not call toString() on proxy.

Issue Links

• relates to: HADOOP-7694 Calling toString() on an RPC proxy object backed by WritableRpcEngine fails