Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The logs servlet in HttpServer should use a pathspec of /* instead of /.
      logContext.addServlet(AdminAuthorizedServlet.class, "/*");

      In making the changes for the yarn webapps (MAPREDUCE-2999), I registered a webapp to use "/". This blocked the /logs servlet from working. because both had a pathSpec of "/" and the guice filter seemed to take precendence. Changing the pathspec of the logs servlet to /* fixes the issue.

      1. HADOOP-7662.patch
        0.8 kB
        Thomas Graves

        Activity

        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12495278/HADOOP-7662.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/210//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/210//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12495278/HADOOP-7662.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/210//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/210//console This message is automatically generated.
        Hide
        Thomas Graves added a comment -

        Manual testing done. This was done in conjunction with MAPREDUCE-2999, which when specifying a auth filter via hadoop.http.filter.initializers caused the /logs servlet to stop working for yarn webapps.

        • load up a yarn web page (do for all resource manager, node manager, app master, and job history). Verify that going to host:port/logs loads up the logs servlet and calls the AdminAuthorizedServlet class and you can see the log directory. verify the other default servlets still work (/stacks,/logLevel,/metrics,/conf,/jmx,/static).
        • also test dfshealth.jsp and verify /logs and other default servlets work (/stacks,/logLevel,/metrics,/conf,/jmx,/static).
        Show
        Thomas Graves added a comment - Manual testing done. This was done in conjunction with MAPREDUCE-2999 , which when specifying a auth filter via hadoop.http.filter.initializers caused the /logs servlet to stop working for yarn webapps. load up a yarn web page (do for all resource manager, node manager, app master, and job history). Verify that going to host:port/logs loads up the logs servlet and calls the AdminAuthorizedServlet class and you can see the log directory. verify the other default servlets still work (/stacks,/logLevel,/metrics,/conf,/jmx,/static). also test dfshealth.jsp and verify /logs and other default servlets work (/stacks,/logLevel,/metrics,/conf,/jmx,/static).
        Hide
        Luke Lu added a comment -

        +1, lgtm.

        Show
        Luke Lu added a comment - +1, lgtm.
        Hide
        Vinod Kumar Vavilapalli added a comment -

        I just committed this to trunk and branch-0.23. Thanks Thomas!

        Show
        Vinod Kumar Vavilapalli added a comment - I just committed this to trunk and branch-0.23. Thanks Thomas!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #1055 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1055/)
        HADOOP-7662. Fixed logs servlet to use the pathspec '/*' instead of '/' for correct filtering. Contributed by Thomas Graves.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176849
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1055 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1055/ ) HADOOP-7662 . Fixed logs servlet to use the pathspec '/*' instead of '/' for correct filtering. Contributed by Thomas Graves. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176849 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #977 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/977/)
        HADOOP-7662. Fixed logs servlet to use the pathspec '/*' instead of '/' for correct filtering. Contributed by Thomas Graves.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176849
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #977 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/977/ ) HADOOP-7662 . Fixed logs servlet to use the pathspec '/*' instead of '/' for correct filtering. Contributed by Thomas Graves. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176849 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #998 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/998/)
        HADOOP-7662. Fixed logs servlet to use the pathspec '/*' instead of '/' for correct filtering. Contributed by Thomas Graves.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176849
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #998 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/998/ ) HADOOP-7662 . Fixed logs servlet to use the pathspec '/*' instead of '/' for correct filtering. Contributed by Thomas Graves. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176849 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-0.23-Build #30 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/30/)
        HADOOP-7662. svn merge -c r1176849 --ignore-ancestry ../../trunk/

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176852
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #30 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/30/ ) HADOOP-7662 . svn merge -c r1176849 --ignore-ancestry ../../trunk/ vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176852 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #844 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/844/)
        HADOOP-7662. Fixed logs servlet to use the pathspec '/*' instead of '/' for correct filtering. Contributed by Thomas Graves.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176849
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #844 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/844/ ) HADOOP-7662 . Fixed logs servlet to use the pathspec '/*' instead of '/' for correct filtering. Contributed by Thomas Graves. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176849 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #815 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/815/)
        HADOOP-7662. Fixed logs servlet to use the pathspec '/*' instead of '/' for correct filtering. Contributed by Thomas Graves.

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176849
        Files :

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #815 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/815/ ) HADOOP-7662 . Fixed logs servlet to use the pathspec '/*' instead of '/' for correct filtering. Contributed by Thomas Graves. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176849 Files : /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #24 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/24/)
        HADOOP-7662. svn merge -c r1176849 --ignore-ancestry ../../trunk/

        vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176852
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #24 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/24/ ) HADOOP-7662 . svn merge -c r1176849 --ignore-ancestry ../../trunk/ vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176852 Files : /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer.java

          People

          • Assignee:
            Thomas Graves
            Reporter:
            Thomas Graves
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development