Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2999

hadoop.http.filter.initializers not working properly on yarn UI

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.0
    • Fix Version/s: 0.23.0
    • Component/s: mrv2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently httpserver only has .html", ".jsp as user facing urls when you add a filter. For the new web framework in yarn, the pages no longer have the *.html or *.jsp and thus they are not properly being filtered.

      1. MAPREDUCE-2999.patch
        7 kB
        Thomas Graves
      2. MAPREDUCE-2999.patch
        9 kB
        Thomas Graves
      3. MAPREDUCE-2999.patch
        9 kB
        Thomas Graves
      4. MAPREDUCE-2999.patch
        7 kB
        Thomas Graves
      5. MAPREDUCE-2999.patch
        7 kB
        Thomas Graves
      6. MAPREDUCE-2999.patch
        7 kB
        Thomas Graves

        Issue Links

          Activity

          Thomas Graves created issue -
          Thomas Graves made changes -
          Field Original Value New Value
          Assignee Thomas Graves [ tgraves ]
          Thomas Graves made changes -
          Link This issue depends on HADOOP-7639 [ HADOOP-7639 ]
          Hide
          Thomas Graves added a comment -

          HADOOP-7639 is making is possible for the HttpServer to add path specifications to the filters. The yarn Webapp can then pass in the path specifications they are going to service when creating the httpserver (ie /yarn, /yarn*). We should make sure all WebApps have a name/base serve path spec so that it doesn't mess up any of the other servlets. ie should be of the format <host:port>/somename/*

          This is a bit ugly but I think it would potentially mess up other existing apps if we were to add the filter for /*. All of them currently have a name anyway. Since many of the yarn UI's currently don't append the /somename to the uri's in links (like in the RM nodes page) and just have host:port, I am making it redirect anything from host:port/ to the registered webapp name host:port/somename. Ideally I think all the ui links should be updated but that can be done separately.

          Show
          Thomas Graves added a comment - HADOOP-7639 is making is possible for the HttpServer to add path specifications to the filters. The yarn Webapp can then pass in the path specifications they are going to service when creating the httpserver (ie /yarn, /yarn*). We should make sure all WebApps have a name/base serve path spec so that it doesn't mess up any of the other servlets. ie should be of the format <host:port>/somename/* This is a bit ugly but I think it would potentially mess up other existing apps if we were to add the filter for /*. All of them currently have a name anyway. Since many of the yarn UI's currently don't append the /somename to the uri's in links (like in the RM nodes page) and just have host:port, I am making it redirect anything from host:port/ to the registered webapp name host:port/somename. Ideally I think all the ui links should be updated but that can be done separately.
          Hide
          Thomas Graves added a comment -

          Another issue I just thought of is that since all the yarn webapps (rm/nm/am/jh) have the same urls host:port/yarn/, that doesn't lend itself to easily filter and say have some authenticated and others not based on the url. Perhaps naming them differently is a better idea. Something more like ResourceManager -> host:port/rm/ , NodeManager -> host:port/nm/*, etc... Thoughts?

          Show
          Thomas Graves added a comment - Another issue I just thought of is that since all the yarn webapps (rm/nm/am/jh) have the same urls host:port/yarn/ , that doesn't lend itself to easily filter and say have some authenticated and others not based on the url. Perhaps naming them differently is a better idea. Something more like ResourceManager -> host:port/rm/ , NodeManager -> host:port/nm/*, etc... Thoughts?
          Hide
          Thomas Graves added a comment -

          patch to make the filtering work.

          I think I will file separate jira for the naming issue (where everything is /yarn/*).

          Show
          Thomas Graves added a comment - patch to make the filtering work. I think I will file separate jira for the naming issue (where everything is /yarn/*).
          Thomas Graves made changes -
          Attachment MAPREDUCE-2999.patch [ 12494799 ]
          Thomas Graves made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12494799/MAPREDUCE-2999.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/763//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/763//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12494799/MAPREDUCE-2999.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/763//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/763//console This message is automatically generated.
          Hide
          Thomas Graves added a comment -

          looks like I'm a bit out of date. Updating and fixing compile issues with the examples. Note that the compile error with common will exist until HADOOP-7639 is checked in.

          Show
          Thomas Graves added a comment - looks like I'm a bit out of date. Updating and fixing compile issues with the examples. Note that the compile error with common will exist until HADOOP-7639 is checked in.
          Thomas Graves made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Thomas Graves made changes -
          Attachment MAPREDUCE-2999.patch [ 12494801 ]
          Hide
          Thomas Graves added a comment -

          fixed issues, going to wait for HADOOP-7639 to push patch available again.

          Show
          Thomas Graves added a comment - fixed issues, going to wait for HADOOP-7639 to push patch available again.
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1927/
          -----------------------------------------------------------

          (Updated 2011-09-16 15:29:19.601021)

          Review request for Jeffrey Naisbitt, Robert Evans and Jonathan Eagles.

          Summary
          -------

          note that this depends on HADOOP-7639

          This addresses bug MAPREDUCE-2999.
          https://issues.apache.org/jira/browse/MAPREDUCE-2999

          Diffs


          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java 1169939
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java 1169939
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java 1169939
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/HelloWorld.java 1169939
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/MyApp.java 1169939
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java 1169939
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java 1169939

          Diff: https://reviews.apache.org/r/1927/diff

          Testing
          -------

          Thanks,

          Tom

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1927/ ----------------------------------------------------------- (Updated 2011-09-16 15:29:19.601021) Review request for Jeffrey Naisbitt, Robert Evans and Jonathan Eagles. Summary ------- note that this depends on HADOOP-7639 This addresses bug MAPREDUCE-2999 . https://issues.apache.org/jira/browse/MAPREDUCE-2999 Diffs /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/HelloWorld.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/MyApp.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java 1169939 Diff: https://reviews.apache.org/r/1927/diff Testing ------- Thanks, Tom
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1927/#review1942
          -----------------------------------------------------------

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java
          <https://reviews.apache.org/r/1927/#comment4426>

          This may be more descriptive written as an expected failure test

          @Test(expected= WebAppException.class)

          • Jonathan

          On 2011-09-16 15:29:19, Tom Graves wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1927/

          -----------------------------------------------------------

          (Updated 2011-09-16 15:29:19)

          Review request for Jeffrey Naisbitt, Robert Evans and Jonathan Eagles.

          Summary

          -------

          note that this depends on HADOOP-7639

          This addresses bug MAPREDUCE-2999.

          https://issues.apache.org/jira/browse/MAPREDUCE-2999

          Diffs

          -----

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/HelloWorld.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/MyApp.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java 1169939

          Diff: https://reviews.apache.org/r/1927/diff

          Testing

          -------

          Thanks,

          Tom

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1927/#review1942 ----------------------------------------------------------- /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java < https://reviews.apache.org/r/1927/#comment4426 > This may be more descriptive written as an expected failure test @Test(expected= WebAppException.class) Jonathan On 2011-09-16 15:29:19, Tom Graves wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1927/ ----------------------------------------------------------- (Updated 2011-09-16 15:29:19) Review request for Jeffrey Naisbitt, Robert Evans and Jonathan Eagles. Summary ------- note that this depends on HADOOP-7639 This addresses bug MAPREDUCE-2999 . https://issues.apache.org/jira/browse/MAPREDUCE-2999 Diffs ----- /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/HelloWorld.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/MyApp.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java 1169939 Diff: https://reviews.apache.org/r/1927/diff Testing ------- Thanks, Tom
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-09-16 20:14:10, Jonathan Eagles wrote:

          > /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java, line 165

          > <https://reviews.apache.org/r/1927/diff/1/?file=41442#file41442line165>

          >

          > This may be more descriptive written as an expected failure test

          >

          > @Test(expected= WebAppException.class)

          thanks I forgot about that - I will update.

          • Tom

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1927/#review1942
          -----------------------------------------------------------

          On 2011-09-16 15:29:19, Tom Graves wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1927/

          -----------------------------------------------------------

          (Updated 2011-09-16 15:29:19)

          Review request for Jeffrey Naisbitt, Robert Evans and Jonathan Eagles.

          Summary

          -------

          note that this depends on HADOOP-7639

          This addresses bug MAPREDUCE-2999.

          https://issues.apache.org/jira/browse/MAPREDUCE-2999

          Diffs

          -----

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/HelloWorld.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/MyApp.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java 1169939

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java 1169939

          Diff: https://reviews.apache.org/r/1927/diff

          Testing

          -------

          Thanks,

          Tom

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-09-16 20:14:10, Jonathan Eagles wrote: > /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java, line 165 > < https://reviews.apache.org/r/1927/diff/1/?file=41442#file41442line165 > > > This may be more descriptive written as an expected failure test > > @Test(expected= WebAppException.class) thanks I forgot about that - I will update. Tom ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1927/#review1942 ----------------------------------------------------------- On 2011-09-16 15:29:19, Tom Graves wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1927/ ----------------------------------------------------------- (Updated 2011-09-16 15:29:19) Review request for Jeffrey Naisbitt, Robert Evans and Jonathan Eagles. Summary ------- note that this depends on HADOOP-7639 This addresses bug MAPREDUCE-2999 . https://issues.apache.org/jira/browse/MAPREDUCE-2999 Diffs ----- /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/HelloWorld.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/MyApp.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java 1169939 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java 1169939 Diff: https://reviews.apache.org/r/1927/diff Testing ------- Thanks, Tom
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1927/
          -----------------------------------------------------------

          (Updated 2011-09-19 14:32:00.672239)

          Review request for Jeffrey Naisbitt, Robert Evans and Jonathan Eagles.

          Changes
          -------

          updated from Jon's comments.

          Summary
          -------

          note that this depends on HADOOP-7639

          This addresses bug MAPREDUCE-2999.
          https://issues.apache.org/jira/browse/MAPREDUCE-2999

          Diffs (updated)


          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java 1171638
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java 1171638
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java 1171638
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/HelloWorld.java 1171638
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/MyApp.java 1171638
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java 1171638
          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java 1171638

          Diff: https://reviews.apache.org/r/1927/diff

          Testing
          -------

          Thanks,

          Tom

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1927/ ----------------------------------------------------------- (Updated 2011-09-19 14:32:00.672239) Review request for Jeffrey Naisbitt, Robert Evans and Jonathan Eagles. Changes ------- updated from Jon's comments. Summary ------- note that this depends on HADOOP-7639 This addresses bug MAPREDUCE-2999 . https://issues.apache.org/jira/browse/MAPREDUCE-2999 Diffs (updated) /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/HelloWorld.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/MyApp.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java 1171638 Diff: https://reviews.apache.org/r/1927/diff Testing ------- Thanks, Tom
          Thomas Graves made changes -
          Attachment MAPREDUCE-2999.patch [ 12495077 ]
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/1927/#review1965
          -----------------------------------------------------------

          Ship it!

          +1

          • Jonathan

          On 2011-09-19 14:32:00, Tom Graves wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/1927/

          -----------------------------------------------------------

          (Updated 2011-09-19 14:32:00)

          Review request for Jeffrey Naisbitt, Robert Evans and Jonathan Eagles.

          Summary

          -------

          note that this depends on HADOOP-7639

          This addresses bug MAPREDUCE-2999.

          https://issues.apache.org/jira/browse/MAPREDUCE-2999

          Diffs

          -----

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java 1171638

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java 1171638

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java 1171638

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/HelloWorld.java 1171638

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/MyApp.java 1171638

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java 1171638

          /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java 1171638

          Diff: https://reviews.apache.org/r/1927/diff

          Testing

          -------

          Thanks,

          Tom

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1927/#review1965 ----------------------------------------------------------- Ship it! +1 Jonathan On 2011-09-19 14:32:00, Tom Graves wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1927/ ----------------------------------------------------------- (Updated 2011-09-19 14:32:00) Review request for Jeffrey Naisbitt, Robert Evans and Jonathan Eagles. Summary ------- note that this depends on HADOOP-7639 This addresses bug MAPREDUCE-2999 . https://issues.apache.org/jira/browse/MAPREDUCE-2999 Diffs ----- /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/HelloWorld.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/example/MyApp.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java 1171638 /trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java 1171638 Diff: https://reviews.apache.org/r/1927/diff Testing ------- Thanks, Tom
          Hide
          Thomas Graves added a comment -

          HADOOP-7639 is not integrated so putting this patch available.

          Show
          Thomas Graves added a comment - HADOOP-7639 is not integrated so putting this patch available.
          Thomas Graves made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12495077/MAPREDUCE-2999.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          -1 javac. The patch appears to cause tar ant target to fail.

          -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/800//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/800//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12495077/MAPREDUCE-2999.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/800//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/800//console This message is automatically generated.
          Hide
          Thomas Graves added a comment -

          hmm, looks like the changes from HADOOP-7639 weren't picked up my hudson yet.

          Show
          Thomas Graves added a comment - hmm, looks like the changes from HADOOP-7639 weren't picked up my hudson yet.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Having looked at the patch. But shouldn't passing "/" to HttpServer only filter the root-path and not everything? If that is true, then we don't need all the redirecting magic.

          Cancelling the patch to fix the findBugs warnings and code changes in case my above comment is valid.

          Show
          Vinod Kumar Vavilapalli added a comment - Having looked at the patch. But shouldn't passing "/" to HttpServer only filter the root-path and not everything? If that is true, then we don't need all the redirecting magic. Cancelling the patch to fix the findBugs warnings and code changes in case my above comment is valid.
          Vinod Kumar Vavilapalli made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Having looked at the patch

          I meant "Haven't".

          Show
          Vinod Kumar Vavilapalli added a comment - Having looked at the patch I meant "Haven't".
          Hide
          Thomas Graves added a comment -

          So it doesn't appear that registering "/" or the redirect I have implemented now actually fully work because they both block the base log servlet from serving /logs.

          I think whats happening is that if you try to go to /logs it goes to the logs servlet (AdminAuthorizedServlet.class), then it goes to the filters. Since guice has the "/" registered guice hijacks it and tries to dispatch it on its own and the logs servlet never gets it back.

          Now I changed the pathSpec on the /logs to /* (logContext.addServlet(AdminAuthorizedServlet.class, "/*")). Then the guice filter doesn't hijack it and logs is served up. I don't quite understand why this works as I would have thought the pathSpec being served was still "/" and guice filter would have grabbed it. Any servlet experts out there that can explain that?

          Another option might be to not have guice register "/" and have an index.html that redirects it similar to how jobtracker and namenode do now.

          Show
          Thomas Graves added a comment - So it doesn't appear that registering "/" or the redirect I have implemented now actually fully work because they both block the base log servlet from serving /logs. I think whats happening is that if you try to go to /logs it goes to the logs servlet (AdminAuthorizedServlet.class), then it goes to the filters. Since guice has the "/" registered guice hijacks it and tries to dispatch it on its own and the logs servlet never gets it back. Now I changed the pathSpec on the /logs to /* (logContext.addServlet(AdminAuthorizedServlet.class, "/*")). Then the guice filter doesn't hijack it and logs is served up. I don't quite understand why this works as I would have thought the pathSpec being served was still "/" and guice filter would have grabbed it. Any servlet experts out there that can explain that? Another option might be to not have guice register "/" and have an index.html that redirects it similar to how jobtracker and namenode do now.
          Arun C Murthy made changes -
          Priority Major [ 3 ] Critical [ 2 ]
          Hide
          Thomas Graves added a comment -

          I filed HADOOP-7662 to fix the issue with /logs. That does mean that we could just register "/" instead of doing the redirect. However I think the redirect makes it easier for filters to differentiate urls. This goes along with MAPREDUCE-3021. If we allow all the webapps to use host:port/ then the filters have no way of differentiation rm from nm from am, etc. The redirect would allow the filters to work as well as still allow you to go to host:port/. We can either leave redirect how it is in the patch or we could probably put in index.html similar to how jobtracker/namenode did redirect.

          Show
          Thomas Graves added a comment - I filed HADOOP-7662 to fix the issue with /logs. That does mean that we could just register "/" instead of doing the redirect. However I think the redirect makes it easier for filters to differentiate urls. This goes along with MAPREDUCE-3021 . If we allow all the webapps to use host:port/ then the filters have no way of differentiation rm from nm from am, etc. The redirect would allow the filters to work as well as still allow you to go to host:port/. We can either leave redirect how it is in the patch or we could probably put in index.html similar to how jobtracker/namenode did redirect.
          Thomas Graves made changes -
          Attachment MAPREDUCE-2999.patch [ 12495370 ]
          Thomas Graves made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Thomas Graves added a comment -

          Updated a new patch. the things it implements:

          • update to use new HttpServer constructor added in HADOOP-7639. Registers pathspecs for "/", "/<webapp name> , "/<webapp name>/". If not webapp name provided then it registered "/", "/".
          • Add a redirect from / to /<webapp name>. This is to allow a filter to be able to differentiate pages.

          All of the base servlets still work as long as HADOOP-7662 (for /logs) is included. Filters now apply properly to the yarn webapps.

          Show
          Thomas Graves added a comment - Updated a new patch. the things it implements: update to use new HttpServer constructor added in HADOOP-7639 . Registers pathspecs for "/", "/<webapp name> , "/<webapp name>/ ". If not webapp name provided then it registered "/", "/ ". Add a redirect from / to /<webapp name>. This is to allow a filter to be able to differentiate pages. All of the base servlets still work as long as HADOOP-7662 (for /logs) is included. Filters now apply properly to the yarn webapps.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12495370/MAPREDUCE-2999.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/810//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/810//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/810//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12495370/MAPREDUCE-2999.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/810//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/810//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/810//console This message is automatically generated.
          Hide
          Thomas Graves added a comment -

          need to fix findbugs warning.

          Show
          Thomas Graves added a comment - need to fix findbugs warning.
          Thomas Graves made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Thomas Graves added a comment -

          fixed findbugs

          Show
          Thomas Graves added a comment - fixed findbugs
          Thomas Graves made changes -
          Attachment MAPREDUCE-2999.patch [ 12495434 ]
          Thomas Graves made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12495434/MAPREDUCE-2999.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/814//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/814//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12495434/MAPREDUCE-2999.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/814//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/814//console This message is automatically generated.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Was working on some of my patches, couldn't sneak in the review of this patch. Will look at it tomorrow.

          Show
          Vinod Kumar Vavilapalli added a comment - Was working on some of my patches, couldn't sneak in the review of this patch. Will look at it tomorrow.
          Vinod Kumar Vavilapalli made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Patch looks good, resubmitting to Jenkins just to be sure, been a while the last time it was blessed.

          Show
          Vinod Kumar Vavilapalli added a comment - Patch looks good, resubmitting to Jenkins just to be sure, been a while the last time it was blessed.
          Vinod Kumar Vavilapalli made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hadoop Flags Reviewed [ 10343 ]
          Hide
          Thomas Graves added a comment -

          reattaching same patch to kick jenkins.

          Show
          Thomas Graves added a comment - reattaching same patch to kick jenkins.
          Thomas Graves made changes -
          Attachment MAPREDUCE-2999.patch [ 12496763 ]
          Hide
          Thomas Graves added a comment -

          Manual testing done:

          Test with and without an auth filter (config settinghadoop.http.filter.initializers). When filter setting is set verified that the load of each page properly went through the filter specified. When going through the filter the page properly showed the current User in the upper right hand corner. Without the filter it shows the default hadoop user of "dr.who". Modified my auth filter to be able to choose which pages to actually authenticate and which not to. When it didn't authenticate pages verified that anyone could go there and the upper right corner was empty (didn't show the "Logged in as:").

          Tested that all the yarn web pages and links from yarn web pages to other pages worked. For instance RM page has link to node manager, links from app to job history and to app master. Verified the links from app master back to RM work, etc... and that when the filter is there they properly go through the filter and ask for authentication.

          Verify that each yarn web app allows the user to get there from:

          • host:port/ -> This redirects you to host:port/yarn so that the filter can differentiate and chose to authenticate or not
          • host:port/yarn -> goes to default page specified by webapp
          • host:port/yarn/* -> goes to page specified by webapp

          Verify that all of the default applications registered in HttpServer still work. (note that HADOOP-7662 is needed for the /logs to work).

          • /logs
          • /static
          • /stacks
          • /logLevel
          • /metrics
          • /jmx
          • /conf
          Show
          Thomas Graves added a comment - Manual testing done: Test with and without an auth filter (config settinghadoop.http.filter.initializers). When filter setting is set verified that the load of each page properly went through the filter specified. When going through the filter the page properly showed the current User in the upper right hand corner. Without the filter it shows the default hadoop user of "dr.who". Modified my auth filter to be able to choose which pages to actually authenticate and which not to. When it didn't authenticate pages verified that anyone could go there and the upper right corner was empty (didn't show the "Logged in as:"). Tested that all the yarn web pages and links from yarn web pages to other pages worked. For instance RM page has link to node manager, links from app to job history and to app master. Verified the links from app master back to RM work, etc... and that when the filter is there they properly go through the filter and ask for authentication. Verify that each yarn web app allows the user to get there from: host:port/ -> This redirects you to host:port/yarn so that the filter can differentiate and chose to authenticate or not host:port/yarn -> goes to default page specified by webapp host:port/yarn/* -> goes to page specified by webapp Verify that all of the default applications registered in HttpServer still work. (note that HADOOP-7662 is needed for the /logs to work). /logs /static /stacks /logLevel /metrics /jmx /conf
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12496763/MAPREDUCE-2999.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/872//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/872//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12496763/MAPREDUCE-2999.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/872//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/872//console This message is automatically generated.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Great coverage of the manual tests, good job!

          I just committed this to trunk and branch-0.23. Thanks Thomas!

          Show
          Vinod Kumar Vavilapalli added a comment - Great coverage of the manual tests, good job! I just committed this to trunk and branch-0.23. Thanks Thomas!
          Vinod Kumar Vavilapalli made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #1040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1040/)
          MAPREDUCE-2999. Fix YARN webapp framework to properly filter servlet paths. Contributed by Thomas Graves.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176469
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #1040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1040/ ) MAPREDUCE-2999 . Fix YARN webapp framework to properly filter servlet paths. Contributed by Thomas Graves. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176469 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #962 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/962/)
          MAPREDUCE-2999. Fix YARN webapp framework to properly filter servlet paths. Contributed by Thomas Graves.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176469
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #962 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/962/ ) MAPREDUCE-2999 . Fix YARN webapp framework to properly filter servlet paths. Contributed by Thomas Graves. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176469 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #982 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/982/)
          MAPREDUCE-2999. Fix YARN webapp framework to properly filter servlet paths. Contributed by Thomas Graves.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176469
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #982 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/982/ ) MAPREDUCE-2999 . Fix YARN webapp framework to properly filter servlet paths. Contributed by Thomas Graves. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176469 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #814 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/814/)
          MAPREDUCE-2999. Fix YARN webapp framework to properly filter servlet paths. Contributed by Thomas Graves.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176469
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #814 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/814/ ) MAPREDUCE-2999 . Fix YARN webapp framework to properly filter servlet paths. Contributed by Thomas Graves. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176469 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-0.23-Build #30 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/30/)
          MAPREDUCE-2999. svn merge -c r1176469 --ignore-ancestry ../../trunk/

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176470
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-0.23-Build #30 (See https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/30/ ) MAPREDUCE-2999 . svn merge -c r1176469 --ignore-ancestry ../../trunk/ vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176470 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #844 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/844/)
          MAPREDUCE-2999. Fix YARN webapp framework to properly filter servlet paths. Contributed by Thomas Graves.

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176469
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #844 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/844/ ) MAPREDUCE-2999 . Fix YARN webapp framework to properly filter servlet paths. Contributed by Thomas Graves. vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176469 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-0.23-Build #23 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/23/)
          MAPREDUCE-2999. svn merge -c r1176469 --ignore-ancestry ../../trunk/

          vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176470
          Files :

          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java
          • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #23 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/23/ ) MAPREDUCE-2999 . svn merge -c r1176469 --ignore-ancestry ../../trunk/ vinodkv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1176470 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/Dispatcher.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApp.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmnode/RMNodeImpl.java
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Gavin made changes -
          Link This issue depends on HADOOP-7639 [ HADOOP-7639 ]
          Gavin made changes -
          Link This issue depends upon HADOOP-7639 [ HADOOP-7639 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          5d 23h 28m 4 Vinod Kumar Vavilapalli 27/Sep/11 16:58
          Open Open Patch Available Patch Available
          7d 23h 13m 5 Vinod Kumar Vavilapalli 27/Sep/11 16:59
          Patch Available Patch Available Resolved Resolved
          1h 6m 1 Vinod Kumar Vavilapalli 27/Sep/11 18:06
          Resolved Resolved Closed Closed
          48d 7h 42m 1 Arun C Murthy 15/Nov/11 00:49

            People

            • Assignee:
              Thomas Graves
              Reporter:
              Thomas Graves
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development