Hadoop Common
  1. Hadoop Common
  2. HADOOP-7612

Change test-patch to run tests for all nested modules

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      HADOOP-7561 changed the behaviour of test-patch to run tests for changed modules, however this was assuming a flat structure. Given the nested maven hierarchy we should always run all the common tests for any common change, all the HDFS tests for any HDFS change, and all the MapReduce tests for any MapReduce change.

      In addition, we should do a top-level build to test compilation after any change.

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #788 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/788/)
        HADOOP-7612. Change test-patch to run tests for all nested modules.

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166848
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #788 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/788/ ) HADOOP-7612 . Change test-patch to run tests for all nested modules. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166848 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #811 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/811/)
        HADOOP-7612. Change test-patch to run tests for all nested modules.

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166848
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #811 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/811/ ) HADOOP-7612 . Change test-patch to run tests for all nested modules. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166848 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Tom White added a comment -

        I've just committed this.

        Show
        Tom White added a comment - I've just committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #927 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/927/)
        HADOOP-7612. Change test-patch to run tests for all nested modules.

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166848
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #927 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/927/ ) HADOOP-7612 . Change test-patch to run tests for all nested modules. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166848 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk-Commit #861 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/861/)
        HADOOP-7612. Change test-patch to run tests for all nested modules.

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166848
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #861 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/861/ ) HADOOP-7612 . Change test-patch to run tests for all nested modules. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166848 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #850 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/850/)
        HADOOP-7612. Change test-patch to run tests for all nested modules.

        tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166848
        Files :

        • /hadoop/common/trunk/dev-support/test-patch.sh
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #850 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/850/ ) HADOOP-7612 . Change test-patch to run tests for all nested modules. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166848 Files : /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me. Thanks a lot for doing this, Tom.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me. Thanks a lot for doing this, Tom.
        Hide
        Tom White added a comment -

        This patch makes a change to test top-level compilation, and run all tests under the base directory it is run from (or specified in --basedir). It also add a --run-tests option so developers can run tests using test-patch.

        Show
        Tom White added a comment - This patch makes a change to test top-level compilation, and run all tests under the base directory it is run from (or specified in --basedir). It also add a --run-tests option so developers can run tests using test-patch.

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development