Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      By running test-patch from trunk we can check that a change in one project (e.g. common) doesn't cause compile errors in other projects (e.g. HDFS). To get this to work we only need to run tests for the modules that are affected by the patch.

        Issue Links

          Activity

          Hide
          Tom White added a comment -

          I tested this by running test-patch for

          1. a patch containing changes to common, run from from trunk (with and without failing tests)
          2. a patch containing changes to common and HDFS, run from trunk (with and without failing tests)
          3. a patch containing changes to common, run from common (with and without failing tests)

          Show
          Tom White added a comment - I tested this by running test-patch for 1. a patch containing changes to common, run from from trunk (with and without failing tests) 2. a patch containing changes to common and HDFS, run from trunk (with and without failing tests) 3. a patch containing changes to common, run from common (with and without failing tests)
          Hide
          Todd Lipcon added a comment -

          Seems reasonable. I guess we have to change the precommit build setups as well to change the checkout root?

          Show
          Todd Lipcon added a comment - Seems reasonable. I guess we have to change the precommit build setups as well to change the checkout root?
          Hide
          Tom White added a comment -

          Yes, this would need doing after commit.

          Show
          Tom White added a comment - Yes, this would need doing after commit.
          Hide
          Mahadev konar added a comment -

          +1 looks good to me.

          Show
          Mahadev konar added a comment - +1 looks good to me.
          Hide
          Tom White added a comment -

          I've just committed this.

          Show
          Tom White added a comment - I've just committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #853 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/853/)
          HADOOP-7561. Make test-patch only run tests for changed modules.

          tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1161291
          Files :

          • /hadoop/common/trunk/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/dev-support/smart-apply-patch.sh
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #853 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/853/ ) HADOOP-7561 . Make test-patch only run tests for changed modules. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1161291 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/dev-support/smart-apply-patch.sh
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #775 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/775/)
          HADOOP-7561. Make test-patch only run tests for changed modules.

          tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1161291
          Files :

          • /hadoop/common/trunk/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/dev-support/smart-apply-patch.sh
          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #775 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/775/ ) HADOOP-7561 . Make test-patch only run tests for changed modules. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1161291 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/dev-support/smart-apply-patch.sh
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #778 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/778/)
          HADOOP-7561. Make test-patch only run tests for changed modules.

          tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1161291
          Files :

          • /hadoop/common/trunk/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/dev-support/smart-apply-patch.sh
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #778 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/778/ ) HADOOP-7561 . Make test-patch only run tests for changed modules. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1161291 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/dev-support/smart-apply-patch.sh
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #787 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/787/)
          HADOOP-7561. Make test-patch only run tests for changed modules.

          tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1161291
          Files :

          • /hadoop/common/trunk/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/dev-support/smart-apply-patch.sh
          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #787 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/787/ ) HADOOP-7561 . Make test-patch only run tests for changed modules. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1161291 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/dev-support/smart-apply-patch.sh
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #765 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/765/)
          HADOOP-7561. Make test-patch only run tests for changed modules.

          tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1161291
          Files :

          • /hadoop/common/trunk/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/dev-support/test-patch.sh
          • /hadoop/common/trunk/dev-support/smart-apply-patch.sh
          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #765 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/765/ ) HADOOP-7561 . Make test-patch only run tests for changed modules. tomwhite : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1161291 Files : /hadoop/common/trunk/hadoop-common/CHANGES.txt /hadoop/common/trunk/dev-support/test-patch.sh /hadoop/common/trunk/dev-support/smart-apply-patch.sh

            People

            • Assignee:
              Tom White
              Reporter:
              Tom White
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development