Hadoop Common
  1. Hadoop Common
  2. HADOOP-7312

core-default.xml lists configuration version as 0.21

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This key was added in HADOOP-6233, though appears unused. I suppose it's somewhat useful to try to diagnose if someone has old versions of core-default.xml on the classpath.

      Either way it should probably be updated to say 0.22 in the branch and 0.23 in trunk.

      1. HADOOP-7312-23.r1.diff
        0.4 kB
        Harsh J
      2. HADOOP-7312-22.r1.diff
        0.4 kB
        Harsh J

        Activity

        Hide
        Harsh J added a comment -

        The version string also carries the complete version number (0.21.0, for instance) instead of just the major.minor – perhaps its a good idea to switch to just two ones for avoiding maintaining over time?

        Show
        Harsh J added a comment - The version string also carries the complete version number (0.21.0, for instance) instead of just the major.minor – perhaps its a good idea to switch to just two ones for avoiding maintaining over time?
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12479881/HADOOP-7312-23.r1.diff
        against trunk revision 1125221.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/491//testReport/
        Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/491//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/491//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12479881/HADOOP-7312-23.r1.diff against trunk revision 1125221. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/491//testReport/ Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/491//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/491//console This message is automatically generated.
        Hide
        Todd Lipcon added a comment -

        +1. Committed to trunk and 22. Thanks, Harsh!

        Show
        Todd Lipcon added a comment - +1. Committed to trunk and 22. Thanks, Harsh!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk-Commit #624 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/624/)
        HADOOP-7312. Update value of hadoop.common.configuration.version. Contributed by Harsh J Chouraria.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128003
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/core-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #624 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/624/ ) HADOOP-7312 . Update value of hadoop.common.configuration.version. Contributed by Harsh J Chouraria. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128003 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/core-default.xml
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-22-branch #58 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/58/)
        HADOOP-7312. Update value of hadoop.common.configuration.version. Contributed by Harsh J Chouraria.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128004
        Files :

        • /hadoop/common/branches/branch-0.22/src/java/core-default.xml
        • /hadoop/common/branches/branch-0.22/CHANGES.txt
        Show
        Hudson added a comment - Integrated in Hadoop-Common-22-branch #58 (See https://builds.apache.org/hudson/job/Hadoop-Common-22-branch/58/ ) HADOOP-7312 . Update value of hadoop.common.configuration.version. Contributed by Harsh J Chouraria. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128004 Files : /hadoop/common/branches/branch-0.22/src/java/core-default.xml /hadoop/common/branches/branch-0.22/CHANGES.txt
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Common-trunk #701 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/701/)
        HADOOP-7312. Update value of hadoop.common.configuration.version. Contributed by Harsh J Chouraria.

        todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128003
        Files :

        • /hadoop/common/trunk/CHANGES.txt
        • /hadoop/common/trunk/src/java/core-default.xml
        Show
        Hudson added a comment - Integrated in Hadoop-Common-trunk #701 (See https://builds.apache.org/hudson/job/Hadoop-Common-trunk/701/ ) HADOOP-7312 . Update value of hadoop.common.configuration.version. Contributed by Harsh J Chouraria. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1128003 Files : /hadoop/common/trunk/CHANGES.txt /hadoop/common/trunk/src/java/core-default.xml

          People

          • Assignee:
            Harsh J
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development