Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.21.1, 0.22.0, 0.23.0
    • Fix Version/s: 0.21.1, 0.22.0, 0.23.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ant test-patch on an empty patch over hdfs trunk.

           [exec] -1 overall.  
           [exec] 
           [exec]     +1 @author.  The patch does not contain any @author tags.
           [exec] 
           [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
           [exec]                         Please justify why no new tests are needed for this patch.
           [exec]                         Also please list what manual steps were performed to verify this patch.
           [exec] 
           [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
           [exec] 
           [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
           [exec] 
           [exec]     -1 findbugs.  The patch appears to introduce 200 new Findbugs (version 1.3.9) warnings.
           [exec] 
           [exec]     -1 release audit.  The applied patch generated 1 release audit warnings (more than the trunk's current 0 warnings).
           [exec] 
           [exec]     +1 system test framework.  The patch passed system test framework compile.
      
      1. newPatchFindbugsWarnings.html
        3 kB
        Tsz Wo Nicholas Sze
      2. c7120_20110126.patch
        0.7 kB
        Tsz Wo Nicholas Sze

        Issue Links

          Activity

          Hide
          Tsz Wo Nicholas Sze added a comment -

          The release audit warning is known caused by HDFS-1600.

          Show
          Tsz Wo Nicholas Sze added a comment - The release audit warning is known caused by HDFS-1600 .
          Hide
          Tsz Wo Nicholas Sze added a comment -

          It seems that the bug is in test-patch.sh. The generated FindBugs Report (newPatchFindbugsWarnings.html) shows no new warnings.

          Show
          Tsz Wo Nicholas Sze added a comment - It seems that the bug is in test-patch.sh. The generated FindBugs Report (newPatchFindbugsWarnings.html) shows no new warnings.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          c7120_20110126.patch: fix an obvious bug.

          Show
          Tsz Wo Nicholas Sze added a comment - c7120_20110126.patch: fix an obvious bug.
          Hide
          Jakob Homan added a comment -

          +1

          Show
          Jakob Homan added a comment - +1
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12469502/c7120_20110126.patch
          against trunk revision 1063613.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/201//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/201//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/201//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12469502/c7120_20110126.patch against trunk revision 1063613. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/201//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/201//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/201//console This message is automatically generated.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Thanks Jakob for reviewing it.

          Show
          Tsz Wo Nicholas Sze added a comment - Thanks Jakob for reviewing it.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I have committed this.

          Show
          Tsz Wo Nicholas Sze added a comment - I have committed this.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #588 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/588/)
          HADOOP-7120. Fix a syntax error in test-patch.sh.

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #588 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/588/ ) HADOOP-7120 . Fix a syntax error in test-patch.sh.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-22-branch #20 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/20/)
          HADOOP-7120. Fix a syntax error in test-patch.sh.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-22-branch #20 (See https://hudson.apache.org/hudson/job/Hadoop-Common-22-branch/20/ ) HADOOP-7120 . Fix a syntax error in test-patch.sh.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #589 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/589/)
          HADOOP-7120. Fix a syntax error in test-patch.sh.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #589 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/589/ ) HADOOP-7120 . Fix a syntax error in test-patch.sh.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #492 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/492/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #539 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/539/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #539 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/539/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-22-branch #33 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-22-branch/33/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #643 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk/643/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #643 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-22-branch #35 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #35 (See https://builds.apache.org/hudson/job/Hadoop-Hdfs-22-branch/35/ )

            People

            • Assignee:
              Tsz Wo Nicholas Sze
              Reporter:
              Tsz Wo Nicholas Sze
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development