Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-7023

Add listCorruptFileBlocks to FileSystem

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.23.0
    • None
    • None
    • Reviewed
    • Add a new API listCorruptFileBlocks to FIleContext that returns a list of files that have corrupt blocks.

    Description

      Add listCorruptFileBlocks to FileSystem as discussed in HDFS-1482.

      Attachments

        1. HADOOP-7023.patch
          10 kB
          Patrick Kling
        2. HADOOP-7023.5.patch
          10 kB
          Patrick Kling
        3. HADOOP-7023.4.patch
          7 kB
          Patrick Kling
        4. HADOOP-7023.3.patch
          6 kB
          Patrick Kling
        5. HADOOP-7023.2.patch
          4 kB
          Patrick Kling

        Issue Links

          Activity

            pkling Patrick Kling added a comment -
            pkling Patrick Kling added a comment - Review board entry: https://reviews.apache.org/r/49/
            pkling Patrick Kling added a comment -

            Added default implementation of listCorruptFileBlocks to FileSystem, which throws UnsupportedOperationException. ant test-patch output is unchanged.

            ant test-patch:

                 [exec] -1 overall.  
                 [exec] 
                 [exec]     +1 @author.  The patch does not contain any @author tags.
                 [exec] 
                 [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
                 [exec]                         Please justify why no new tests are needed for this patch.
                 [exec]                         Also please list what manual steps were performed to verify this patch.
                 [exec] 
                 [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
                 [exec] 
                 [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
                 [exec] 
                 [exec]     -1 findbugs.  The patch appears to introduce 2 new Findbugs warnings.
                 [exec] 
                 [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
                 [exec] 
                 [exec]     +1 system test framework.  The patch passed system test framework compile.
            

            As before, findbugs warnings are caused by MAPREDUCE-2172

            pkling Patrick Kling added a comment - Added default implementation of listCorruptFileBlocks to FileSystem, which throws UnsupportedOperationException. ant test-patch output is unchanged. ant test-patch: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] -1 findbugs. The patch appears to introduce 2 new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. As before, findbugs warnings are caused by MAPREDUCE-2172
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12459952/HADOOP-7023.2.patch
            against trunk revision 1036130.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed core unit tests.

            +1 contrib tests. The patch passed contrib unit tests.

            +1 system test framework. The patch passed system test framework compile.

            Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/111//testReport/
            Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/111//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/111//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459952/HADOOP-7023.2.patch against trunk revision 1036130. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/111//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/111//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/111//console This message is automatically generated.
            pkling Patrick Kling added a comment -

            Added listCorruptFileBlocks to FileContext.
            Changed FilterFileSystem to call underlying filesystem's listCorruptFileBlocks.

            pkling Patrick Kling added a comment - Added listCorruptFileBlocks to FileContext. Changed FilterFileSystem to call underlying filesystem's listCorruptFileBlocks.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12459967/HADOOP-7023.3.patch
            against trunk revision 1036729.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed these core unit tests:

            +1 contrib tests. The patch passed contrib unit tests.

            +1 system test framework. The patch passed system test framework compile.

            Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/114//testReport/
            Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/114//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/114//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459967/HADOOP-7023.3.patch against trunk revision 1036729. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/114//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/114//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/114//console This message is automatically generated.
            pkling Patrick Kling added a comment -

            Added listCorruptFileBlocks to FilterFs.

            pkling Patrick Kling added a comment - Added listCorruptFileBlocks to FilterFs.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12459970/HADOOP-7023.4.patch
            against trunk revision 1036733.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed core unit tests.

            +1 contrib tests. The patch passed contrib unit tests.

            +1 system test framework. The patch passed system test framework compile.

            Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/115//testReport/
            Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/115//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/115//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12459970/HADOOP-7023.4.patch against trunk revision 1036733. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/115//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/115//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/115//console This message is automatically generated.
            hairong Hairong Kuang added a comment -

            The default constructor of CorruptFileBlocks should set the files array to be an array of length 0 and the cookie to be an empty string. Otherwise, there will be a serialization/deseriablization problem.

            hairong Hairong Kuang added a comment - The default constructor of CorruptFileBlocks should set the files array to be an array of length 0 and the cookie to be an empty string. Otherwise, there will be a serialization/deseriablization problem.
            pkling Patrick Kling added a comment -

            Incorporated Hairong's feedback. Thank you!

            Changed default constructor of CorruptFileBlocks to use an empty array and empty string instead of null.
            Added serialization and deserialization test case.

            pkling Patrick Kling added a comment - Incorporated Hairong's feedback. Thank you! Changed default constructor of CorruptFileBlocks to use an empty array and empty string instead of null. Added serialization and deserialization test case.
            hadoopqa Hadoop QA added a comment -

            +1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12460201/HADOOP-7023.5.patch
            against trunk revision 1036746.

            +1 @author. The patch does not contain any @author tags.

            +1 tests included. The patch appears to include 3 new or modified tests.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed core unit tests.

            +1 contrib tests. The patch passed contrib unit tests.

            +1 system test framework. The patch passed system test framework compile.

            Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/117//testReport/
            Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/117//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/117//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12460201/HADOOP-7023.5.patch against trunk revision 1036746. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/117//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/117//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/117//console This message is automatically generated.
            hairong Hairong Kuang added a comment -

            +1. The patch looks good to me.

            hairong Hairong Kuang added a comment - +1. The patch looks good to me.
            hudson Hudson added a comment -

            Integrated in Hadoop-Common-trunk-Commit #443 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/443/)
            HADOOP-7023. Add listCorruptFileBlocks to FileSystem. Contributed by Patrick Kling.

            hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #443 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/443/ ) HADOOP-7023 . Add listCorruptFileBlocks to FileSystem. Contributed by Patrick Kling.
            hudson Hudson added a comment -

            Integrated in Hadoop-Common-trunk #523 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/523/)
            HADOOP-7023. Add listCorruptFileBlocks to FileSystem. Contributed by Patrick Kling.

            hudson Hudson added a comment - Integrated in Hadoop-Common-trunk #523 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/523/ ) HADOOP-7023 . Add listCorruptFileBlocks to FileSystem. Contributed by Patrick Kling.
            hairong Hairong Kuang added a comment -

            I've committed this. Thanks, Patrick!

            hairong Hairong Kuang added a comment - I've committed this. Thanks, Patrick!

            People

              pkling Patrick Kling
              pkling Patrick Kling
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: