Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-2172

test-patch.properties contains incorrect/version-dependent values of OK_FINDBUGS_WARNINGS and OK_RELEASEAUDIT_WARNINGS

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.23.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      FindBugs 1.3.4

      Description

      Running ant test-patch with an empty patch yields 25 findbugs warning and 3 release audit warnings (rather than the 0 findbugs warnings and 1 release audit warning specified in test-patch.properties):

      [exec] -1 overall.  
      [exec] 
      [exec]     +1 @author.  The patch does not contain any @author tags.
      [exec] 
      [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
      [exec]                         Please justify why no new tests are needed for this patch.
      [exec]                         Also please list what manual steps were performed to verify this patch.
      [exec] 
      [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
      [exec] 
      [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
      [exec] 
      [exec]     -1 findbugs.  The patch appears to introduce 25 new Findbugs warnings.
      [exec] 
      [exec]     -1 release audit.  The applied patch generated 3 release audit warnings (more than the trunk's current 1 warnings).
      [exec] 
      [exec]     +1 system test framework.  The patch passed system test framework compile.
      

        Attachments

          Activity

            People

            • Assignee:
              nidaley Nigel Daley
              Reporter:
              pkling Patrick Kling
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: