Hadoop Common
  1. Hadoop Common
  2. HADOOP-6984

NPE from SequenceFile::Writer.CompressionCodecOption

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The deprecated HADOOP-6856 constructors can create a compressed writers with a null-wrapped CompressionCodecOption

      1. 6984-0.patch
        1 kB
        Chris Douglas
      2. 6984-1.patch
        19 kB
        Chris Douglas
      3. 6984-2.patch
        19 kB
        Chris Douglas
      4. 6984-3.patch
        19 kB
        Chris Douglas

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          1d 9h 29m 1 Chris Douglas 04/Oct/10 18:22
          Open Open Patch Available Patch Available
          1h 50m 2 Jakob Homan 04/Oct/10 20:11
          Patch Available Patch Available Resolved Resolved
          1d 11h 6m 1 Owen O'Malley 06/Oct/10 07:17
          Gavin made changes -
          Link This issue is depended upon by HADOOP-6991 [ HADOOP-6991 ]
          Gavin made changes -
          Link This issue blocks HADOOP-6991 [ HADOOP-6991 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #489 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/489/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #489 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/489/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #395 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/395/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #395 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/395/ )
          Owen O'Malley made changes -
          Component/s io [ 12310687 ]
          Component/s fs [ 12310689 ]
          Owen O'Malley made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Owen O'Malley added a comment -

          This looks great. It passes unit tests.

          I just committed this. Thanks, Chris!

          Show
          Owen O'Malley added a comment - This looks great. It passes unit tests. I just committed this. Thanks, Chris!
          Chris Douglas made changes -
          Link This issue blocks HADOOP-6991 [ HADOOP-6991 ]
          Chris Douglas made changes -
          Attachment 6984-3.patch [ 12456412 ]
          Hide
          Chris Douglas added a comment -

          Merge with trunk

          Show
          Chris Douglas added a comment - Merge with trunk
          Chris Douglas made changes -
          Attachment 6984-2.patch [ 12456368 ]
          Hide
          Chris Douglas added a comment -

          nod That does look cleaner.

          Show
          Chris Douglas added a comment - nod That does look cleaner.
          Hide
          Owen O'Malley added a comment -

          I really like the second iteration of the patch, but maybe we could have compress(kind) and compress(kind, codec) instead of using compress(kind, null) for the default codec. The implementation could be the same.

          Show
          Owen O'Malley added a comment - I really like the second iteration of the patch, but maybe we could have compress(kind) and compress(kind, codec) instead of using compress(kind, null) for the default codec. The implementation could be the same.
          Chris Douglas made changes -
          Attachment 6984-1.patch [ 12456345 ]
          Hide
          Chris Douglas added a comment -

          Collapsed CompressionTypeOption and CompressionCodecOption into a single Option type.

          Show
          Chris Douglas added a comment - Collapsed CompressionTypeOption and CompressionCodecOption into a single Option type.
          Jakob Homan made changes -
          Fix Version/s 0.22.0 [ 12314296 ]
          Fix Version/s 0.21.1 [ 12315270 ]
          Jakob Homan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jakob Homan made changes -
          Hadoop Flags [Reviewed]
          Assignee Chris Douglas [ chris.douglas ]
          Fix Version/s 0.21.1 [ 12315270 ]
          Component/s fs [ 12310689 ]
          Hide
          Jakob Homan added a comment -

          +1

          Show
          Jakob Homan added a comment - +1
          Chris Douglas made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Chris Douglas made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Chris Douglas made changes -
          Field Original Value New Value
          Attachment 6984-0.patch [ 12456230 ]
          Chris Douglas created issue -

            People

            • Assignee:
              Chris Douglas
              Reporter:
              Chris Douglas
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development