Hadoop Common
  1. Hadoop Common
  2. HADOOP-6984

NPE from SequenceFile::Writer.CompressionCodecOption

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: io
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The deprecated HADOOP-6856 constructors can create a compressed writers with a null-wrapped CompressionCodecOption

      1. 6984-3.patch
        19 kB
        Chris Douglas
      2. 6984-2.patch
        19 kB
        Chris Douglas
      3. 6984-1.patch
        19 kB
        Chris Douglas
      4. 6984-0.patch
        1 kB
        Chris Douglas

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #489 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/489/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #489 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk/489/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #395 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/395/)

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #395 (See https://hudson.apache.org/hudson/job/Hadoop-Common-trunk-Commit/395/ )
          Hide
          Owen O'Malley added a comment -

          This looks great. It passes unit tests.

          I just committed this. Thanks, Chris!

          Show
          Owen O'Malley added a comment - This looks great. It passes unit tests. I just committed this. Thanks, Chris!
          Hide
          Chris Douglas added a comment -

          Merge with trunk

          Show
          Chris Douglas added a comment - Merge with trunk
          Hide
          Chris Douglas added a comment -

          nod That does look cleaner.

          Show
          Chris Douglas added a comment - nod That does look cleaner.
          Hide
          Owen O'Malley added a comment -

          I really like the second iteration of the patch, but maybe we could have compress(kind) and compress(kind, codec) instead of using compress(kind, null) for the default codec. The implementation could be the same.

          Show
          Owen O'Malley added a comment - I really like the second iteration of the patch, but maybe we could have compress(kind) and compress(kind, codec) instead of using compress(kind, null) for the default codec. The implementation could be the same.
          Hide
          Chris Douglas added a comment -

          Collapsed CompressionTypeOption and CompressionCodecOption into a single Option type.

          Show
          Chris Douglas added a comment - Collapsed CompressionTypeOption and CompressionCodecOption into a single Option type.
          Hide
          Jakob Homan added a comment -

          +1

          Show
          Jakob Homan added a comment - +1

            People

            • Assignee:
              Chris Douglas
              Reporter:
              Chris Douglas
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development