[HADOOP-6856] SequenceFile and MapFile need cleanup to remove redundant constructors

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.22.0
• Component/s: io
• Hadoop Flags: Reviewed
• Assignee: Owen O'Malley
• Reporter: Owen O'Malley
• Created: 09/Jul/10 16:04
• Updated: 12/Dec/11 06:19
• Resolved: 30/Sep/10 03:00

Description

Currently there are 2 public SequenceFile.Reader constructors, 3 public SequenceFile.Writer constructors, 9 public SequenceFile.createWriter, 2 public MapFile.Reader constructors, and 8 public MapFile.Writer constructors. All of with various historical combinations of parameters that don't cover the entire space.

All of this makes it very difficult to add new optional parameters to SequenceFile and MapFile.

I'd like change to the style of FileContext.create with option parameters. I'll implement one public SequenceFile.Reader constructor and one public SequenceFile.createWriter and implement all of the current variants based on those two. I'll do the same for MapFile.Reader and MapFile.Writer including passing parameters down to the underlying SequenceFile.

Issue Links

• is duplicated by: HADOOP-888 SequenceFile constructors should not accept a FileSystem parameter
• relates to: HADOOP-7087 SequenceFile.createWriter ignores FileSystem parameter