Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None

      Description

      This jira tracks common changes for MAPREDUCE-1528.

      1. HADOOP-6845.1.patch
        22 kB
        Jitendra Nath Pandey
      2. HADOOP-6845.2.patch
        22 kB
        Jitendra Nath Pandey
      3. HADOOP-6845.3.patch
        22 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12448245/HADOOP-6845.1.patch
          against trunk revision 957074.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448245/HADOOP-6845.1.patch against trunk revision 957074. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/console This message is automatically generated.
          Hide
          Devaraj Das added a comment -

          Looks good. Minor nits - Credentials.java should be annotated with the same annotations that was there in TokenStorage,java. Also, the class TestJobCredentials should be renamed to TestCredentials. Although not related to this refactoring patch, do you want to have a teardown method in the testcase that removes the directory created in the setup method?

          Show
          Devaraj Das added a comment - Looks good. Minor nits - Credentials.java should be annotated with the same annotations that was there in TokenStorage,java. Also, the class TestJobCredentials should be renamed to TestCredentials. Although not related to this refactoring patch, do you want to have a teardown method in the testcase that removes the directory created in the setup method?
          Hide
          Jitendra Nath Pandey added a comment -

          New patch addressing the comments.

          Show
          Jitendra Nath Pandey added a comment - New patch addressing the comments.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12449007/HADOOP-6845.2.patch
          against trunk revision 961911.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449007/HADOOP-6845.2.patch against trunk revision 961911. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          Updated InterfaceAudience annotation for Credentials to include HDFS as well.

          Show
          Jitendra Nath Pandey added a comment - Updated InterfaceAudience annotation for Credentials to include HDFS as well.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12449017/HADOOP-6845.3.patch
          against trunk revision 961911.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449017/HADOOP-6845.3.patch against trunk revision 961911. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/console This message is automatically generated.
          Hide
          Devaraj Das added a comment -

          +1

          Show
          Devaraj Das added a comment - +1
          Hide
          Jitendra Nath Pandey added a comment -

          Javadoc warnings are in KerberosName.java and SecurityUtil.java which are unrelated.

          Show
          Jitendra Nath Pandey added a comment - Javadoc warnings are in KerberosName.java and SecurityUtil.java which are unrelated.
          Hide
          Devaraj Das added a comment -

          I just committed this. Thanks, Jitendra!

          Show
          Devaraj Das added a comment - I just committed this. Thanks, Jitendra!
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #323 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/323/)
          HADOOP-6845. Renames the TokenStorage class to Credentials. Contributed by Jitendra Pandey.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #323 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/323/ ) HADOOP-6845 . Renames the TokenStorage class to Credentials. Contributed by Jitendra Pandey.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #337 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/337/)
          HDFS-1272. Fixes to take care of the changes in HADOOP-6845. Contributed by Jitendra Pandey.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #337 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/337/ ) HDFS-1272 . Fixes to take care of the changes in HADOOP-6845 . Contributed by Jitendra Pandey.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #391 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/391/)
          HADOOP-6845. Renames the TokenStorage class to Credentials. Contributed by Jitendra Pandey.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #391 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/391/ ) HADOOP-6845 . Renames the TokenStorage class to Credentials. Contributed by Jitendra Pandey.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development