Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None

      Description

      This jira tracks common changes for MAPREDUCE-1528.

      1. HADOOP-6845.1.patch
        22 kB
        Jitendra Nath Pandey
      2. HADOOP-6845.2.patch
        22 kB
        Jitendra Nath Pandey
      3. HADOOP-6845.3.patch
        22 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Patch Available Patch Available Open Open
          10d 25m 2 Jitendra Nath Pandey 08/Jul/10 21:51
          Open Open Patch Available Patch Available
          30m 8s 3 Jitendra Nath Pandey 08/Jul/10 21:53
          Patch Available Patch Available Resolved Resolved
          22h 15m 1 Devaraj Das 09/Jul/10 20:08
          Resolved Resolved Closed Closed
          520d 10h 10m 1 Konstantin Shvachko 12/Dec/11 06:18
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #391 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/391/)
          HADOOP-6845. Renames the TokenStorage class to Credentials. Contributed by Jitendra Pandey.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #391 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/391/ ) HADOOP-6845 . Renames the TokenStorage class to Credentials. Contributed by Jitendra Pandey.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #337 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/337/)
          HDFS-1272. Fixes to take care of the changes in HADOOP-6845. Contributed by Jitendra Pandey.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #337 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/337/ ) HDFS-1272 . Fixes to take care of the changes in HADOOP-6845 . Contributed by Jitendra Pandey.
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #323 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/323/)
          HADOOP-6845. Renames the TokenStorage class to Credentials. Contributed by Jitendra Pandey.

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #323 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/323/ ) HADOOP-6845 . Renames the TokenStorage class to Credentials. Contributed by Jitendra Pandey.
          Devaraj Das made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.22.0 [ 12314296 ]
          Resolution Fixed [ 1 ]
          Hide
          Devaraj Das added a comment -

          I just committed this. Thanks, Jitendra!

          Show
          Devaraj Das added a comment - I just committed this. Thanks, Jitendra!
          Hide
          Jitendra Nath Pandey added a comment -

          Javadoc warnings are in KerberosName.java and SecurityUtil.java which are unrelated.

          Show
          Jitendra Nath Pandey added a comment - Javadoc warnings are in KerberosName.java and SecurityUtil.java which are unrelated.
          Hide
          Devaraj Das added a comment -

          +1

          Show
          Devaraj Das added a comment - +1
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12449017/HADOOP-6845.3.patch
          against trunk revision 961911.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449017/HADOOP-6845.3.patch against trunk revision 961911. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/607/console This message is automatically generated.
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6845.3.patch [ 12449017 ]
          Hide
          Jitendra Nath Pandey added a comment -

          Updated InterfaceAudience annotation for Credentials to include HDFS as well.

          Show
          Jitendra Nath Pandey added a comment - Updated InterfaceAudience annotation for Credentials to include HDFS as well.
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12449007/HADOOP-6845.2.patch
          against trunk revision 961911.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12449007/HADOOP-6845.2.patch against trunk revision 961911. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/606/console This message is automatically generated.
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6845.2.patch [ 12449007 ]
          Hide
          Jitendra Nath Pandey added a comment -

          New patch addressing the comments.

          Show
          Jitendra Nath Pandey added a comment - New patch addressing the comments.
          Hide
          Devaraj Das added a comment -

          Looks good. Minor nits - Credentials.java should be annotated with the same annotations that was there in TokenStorage,java. Also, the class TestJobCredentials should be renamed to TestCredentials. Although not related to this refactoring patch, do you want to have a teardown method in the testcase that removes the directory created in the setup method?

          Show
          Devaraj Das added a comment - Looks good. Minor nits - Credentials.java should be annotated with the same annotations that was there in TokenStorage,java. Also, the class TestJobCredentials should be renamed to TestCredentials. Although not related to this refactoring patch, do you want to have a teardown method in the testcase that removes the directory created in the setup method?
          Jitendra Nath Pandey made changes -
          Link This issue blocks HDFS-1272 [ HDFS-1272 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12448245/HADOOP-6845.1.patch
          against trunk revision 957074.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 6 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448245/HADOOP-6845.1.patch against trunk revision 957074. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/595/console This message is automatically generated.
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6845.1.patch [ 12448245 ]
          Jitendra Nath Pandey made changes -
          Link This issue blocks MAPREDUCE-1528 [ MAPREDUCE-1528 ]
          Jitendra Nath Pandey made changes -
          Field Original Value New Value
          Assignee Jitendra Nath Pandey [ jnp ]
          Jitendra Nath Pandey created issue -

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development