Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently, TokenStorage is a singleton. This doesn't work for some use cases, such as Oozie. I think that each Job should have a TokenStorage that is associated it.

      1. MAPREDUCE-1528.4.patch
        54 kB
        Jitendra Nath Pandey
      2. MAPREDUCE-1528.3.patch
        55 kB
        Jitendra Nath Pandey
      3. MAPREDUCE-1528.2.patch
        55 kB
        Jitendra Nath Pandey
      4. MAPREDUCE-1528.1.patch
        44 kB
        Jitendra Nath Pandey
      5. MAPREDUCE-1528_yhadoop20.patch
        66 kB
        Arun C Murthy
      6. MAPREDUCE-1528_yhadoop20.patch
        63 kB
        Arun C Murthy
      7. MAPREDUCE-1528_yhadoop20.patch
        60 kB
        Arun C Murthy
      8. MAPREDUCE-1528_yhadoop20.patch
        52 kB
        Arun C Murthy
      9. MAPREDUCE-1528_yhadoop20.patch
        53 kB
        Arun C Murthy
      10. MAPREDUCE-1528_yhadoop20.patch
        52 kB
        Arun C Murthy
      11. MAPREDUCE-1528_yhadoop20.patch
        49 kB
        Arun C Murthy

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/)

          Show
          Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #523 (See https://hudson.apache.org/hudson/job/Hadoop-Mapreduce-trunk-Commit/523/ )
          Hide
          Devaraj Das added a comment -

          I just committed this. Thanks, Jitendra and Arun!

          Show
          Devaraj Das added a comment - I just committed this. Thanks, Jitendra and Arun!
          Hide
          Jitendra Nath Pandey added a comment -

          tests, javadoc, findbugs, javac warnings were run manually.

          Show
          Jitendra Nath Pandey added a comment - tests, javadoc, findbugs, javac warnings were run manually.
          Hide
          Jitendra Nath Pandey added a comment -

          New patch addressing the comments.

          Show
          Jitendra Nath Pandey added a comment - New patch addressing the comments.
          Hide
          Devaraj Das added a comment -

          1) MiniMRCluster seems to have some unrelated changes
          2) The ClientProtocol's version should be bumped up.

          Show
          Devaraj Das added a comment - 1) MiniMRCluster seems to have some unrelated changes 2) The ClientProtocol's version should be bumped up.
          Hide
          Jitendra Nath Pandey added a comment -

          Added a test using the old mr api.

          Show
          Jitendra Nath Pandey added a comment - Added a test using the old mr api.
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for trunk added.

          Show
          Jitendra Nath Pandey added a comment - Patch for trunk added.
          Hide
          Arun C Murthy added a comment -

          Sigh, more merges!

          Show
          Arun C Murthy added a comment - Sigh, more merges!
          Hide
          Arun C Murthy added a comment -

          Updated patch, needed to merge more changes.

          Show
          Arun C Murthy added a comment - Updated patch, needed to merge more changes.
          Hide
          Arun C Murthy added a comment -

          Renamed TestTokenStorage to TestJobCredentials.

          Show
          Arun C Murthy added a comment - Renamed TestTokenStorage to TestJobCredentials.
          Hide
          Arun C Murthy added a comment -

          Pretty-fied patch.

          Show
          Arun C Murthy added a comment - Pretty-fied patch.
          Hide
          Owen O'Malley added a comment -

          Other than the commented out code, this looks fine for y20. +1

          Show
          Owen O'Malley added a comment - Other than the commented out code, this looks fine for y20. +1
          Hide
          Arun C Murthy added a comment -

          Uh, wrong patch previously...

          Show
          Arun C Murthy added a comment - Uh, wrong patch previously...
          Hide
          Arun C Murthy added a comment -

          Minor update to y20 branch.

          Show
          Arun C Murthy added a comment - Minor update to y20 branch.
          Hide
          Arun C Murthy added a comment -

          Summary of changes:

          1. Renamed TokenStorage to Credentials to better reflect it's utility.
          2. Added a Credentials to JobConf (and an accessor: JobConf.getCredentials) since it's the only per-job identifier in an MR application for the old apis, added a JobContext.getCredentials for the new, context-objects api.
          3. Removed as much cruft as possible from TokenCache, without really going overboard - we need to keep TokenCache since it's Hadoop MapReduce specific and I can't really put everything into Credentials as it's in Hadoop Common.
          Show
          Arun C Murthy added a comment - Summary of changes: Renamed TokenStorage to Credentials to better reflect it's utility. Added a Credentials to JobConf (and an accessor: JobConf.getCredentials) since it's the only per-job identifier in an MR application for the old apis, added a JobContext.getCredentials for the new, context-objects api. Removed as much cruft as possible from TokenCache, without really going overboard - we need to keep TokenCache since it's Hadoop MapReduce specific and I can't really put everything into Credentials as it's in Hadoop Common.

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Owen O'Malley
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development