Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-6718

Client does not close connection when an exception happens during SASL negotiation

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Duplicate
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: ipc
    • Labels:
      None

      Description

      setupSaslConnection in the RPC client might fail to successfully set up a sasl connection (e.g. if the principal is wrongly configured). It throws an exception back to the caller (setupIOstreams). setupIOstreams marks the connection as closed but it doesn't really close the socket.

      1. 6718-bp20.patch
        0.8 kB
        Devaraj Das

        Issue Links

          Activity

          Hide
          devaraj Devaraj Das added a comment -

          Attaching a patch for Y20S. Not for commit.

          Show
          devaraj Devaraj Das added a comment - Attaching a patch for Y20S. Not for commit.
          Hide
          jghoman Jakob Homan added a comment -

          Seems reasonable. +1.

          Show
          jghoman Jakob Homan added a comment - Seems reasonable. +1.
          Hide
          raj_velu Soundararajan Velu added a comment -

          Devaraj, Patch looks great, but shouldn't we catch Exception instead of IOException, Just in case... and then handle the situation.

          Show
          raj_velu Soundararajan Velu added a comment - Devaraj, Patch looks great, but shouldn't we catch Exception instead of IOException, Just in case... and then handle the situation.
          Hide
          shv Konstantin Shvachko added a comment -

          Incorporated in HADOOP-6706 for 0.22.

          Show
          shv Konstantin Shvachko added a comment - Incorporated in HADOOP-6706 for 0.22.

            People

            • Assignee:
              devaraj Devaraj Das
              Reporter:
              devaraj Devaraj Das
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development