Hadoop Common
  1. Hadoop Common
  2. HADOOP-6706

Relogin behavior for RPC clients could be improved

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: security
    • Labels:
      None

      Description

      Currently, the relogin in the RPC client happens on only a SaslException. But we have seen cases where other exceptions are thrown (like IllegalStateException when the client's ticket is invalid). This jira is to fix that behavior.

      1. 6706.bp20.1.patch
        0.7 kB
        Devaraj Das
      2. 6706-bp20-2.patch
        12 kB
        Devaraj Das
      3. ASF.LICENSE.NOT.GRANTED--6706.bp20.patch
        2 kB
        Devaraj Das
      4. HADOOP-6706.2.patch
        29 kB
        Jitendra Nath Pandey
      5. HADOOP-6706.4.patch
        15 kB
        Jitendra Nath Pandey
      6. HADOOP-6706.5.patch
        15 kB
        Jitendra Nath Pandey
      7. HADOOP-6706.6.patch
        15 kB
        Jitendra Nath Pandey
      8. HADOOP-6706.7.patch
        15 kB
        Jitendra Nath Pandey
      9. HADOOP-6706.8.patch
        15 kB
        Jitendra Nath Pandey
      10. HADOOP-6706-BP20-fix1.patch
        3 kB
        Boris Shkolnik
      11. HADOOP-6706-BP20-fix2.patch
        3 kB
        Boris Shkolnik
      12. HADOOP-6706-BP20-fix3.patch
        2 kB
        Boris Shkolnik

        Issue Links

          Activity

          Hide
          Devaraj Das added a comment -

          Attaching a patch for the Y20 branch. "Exception" is caught and a relogin is attempted. We were debating whether to have relogin done outside the exception block before doing a saslConnect. But even in that case, we need to be able to handle exceptions since some other thread might be currently using the subject credentials that we are just about to destroy (in relogin) and that thread should retry the connection after a relogin. In any case the exception handling is required.

          Show
          Devaraj Das added a comment - Attaching a patch for the Y20 branch. "Exception" is caught and a relogin is attempted. We were debating whether to have relogin done outside the exception block before doing a saslConnect. But even in that case, we need to be able to handle exceptions since some other thread might be currently using the subject credentials that we are just about to destroy (in relogin) and that thread should retry the connection after a relogin. In any case the exception handling is required.
          Hide
          Jitendra Nath Pandey added a comment -

          patch looks good.

          Show
          Jitendra Nath Pandey added a comment - patch looks good.
          Hide
          Devaraj Das added a comment -

          One note on the patch is that this is a stop-gap solution (and is lame, in that it banks on exception handling to do relogins). The ideal solution is to use the Refreshable interface and in that case we don't have to rely on exceptions being thrown before attempting relogins. However, as Owen noted in http://tinyurl.com/y6putxk, the patch that uses the Refreshable interface doesn't seem to be working as expected.

          Show
          Devaraj Das added a comment - One note on the patch is that this is a stop-gap solution (and is lame, in that it banks on exception handling to do relogins). The ideal solution is to use the Refreshable interface and in that case we don't have to rely on exceptions being thrown before attempting relogins. However, as Owen noted in http://tinyurl.com/y6putxk , the patch that uses the Refreshable interface doesn't seem to be working as expected.
          Hide
          Devaraj Das added a comment -

          Attaching a patch that fixes a bug in the earlier version of the Y20s patch. Not for commit.

          Show
          Devaraj Das added a comment - Attaching a patch that fixes a bug in the earlier version of the Y20s patch. Not for commit.
          Hide
          Devaraj Das added a comment -

          Updates the relogin behavior even more. Closes the RPC socket on a connection failure. (patch for Y20s).

          Show
          Devaraj Das added a comment - Updates the relogin behavior even more. Closes the RPC socket on a connection failure. (patch for Y20s).
          Hide
          Boris Shkolnik added a comment -

          FIX on top .

          Show
          Boris Shkolnik added a comment - FIX on top .
          Hide
          Boris Shkolnik added a comment -

          addressed comments from Devaraj

          Show
          Boris Shkolnik added a comment - addressed comments from Devaraj
          Hide
          Boris Shkolnik added a comment -

          removed unneeded imports.

          Show
          Boris Shkolnik added a comment - removed unneeded imports.
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for trunk.
          Incorporates HADOOP-6718 and HADOOP-6776

          Show
          Jitendra Nath Pandey added a comment - Patch for trunk. Incorporates HADOOP-6718 and HADOOP-6776
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12450536/HADOOP-6706.2.patch
          against trunk revision 979387.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12450536/HADOOP-6706.2.patch against trunk revision 979387. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/637/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          HADOOP-6706.2.patch is not for commit. It also includes the patch for HADOOP-6656.

          Show
          Jitendra Nath Pandey added a comment - HADOOP-6706 .2.patch is not for commit. It also includes the patch for HADOOP-6656 .
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for latest trunk.

          Show
          Jitendra Nath Pandey added a comment - Patch for latest trunk.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12450869/HADOOP-6706.4.patch
          against trunk revision 980533.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12450869/HADOOP-6706.4.patch against trunk revision 980533. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/650/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          New patch uploaded. Previous patch had an error.

          Show
          Jitendra Nath Pandey added a comment - New patch uploaded. Previous patch had an error.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12450920/HADOOP-6706.5.patch
          against trunk revision 980648.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12450920/HADOOP-6706.5.patch against trunk revision 980648. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/651/console This message is automatically generated.
          Hide
          Kan Zhang added a comment -

          +1, patch looks good. Couple nits.

          It's better to call disposeSasl() immediately after closeConnection() in handleSaslConnectionFailure().

          Please don't format lines you're not changing otherwise. This will make patch easier to read.

          Show
          Kan Zhang added a comment - +1, patch looks good. Couple nits. It's better to call disposeSasl() immediately after closeConnection() in handleSaslConnectionFailure(). Please don't format lines you're not changing otherwise. This will make patch easier to read.
          Hide
          Jitendra Nath Pandey added a comment -

          New patch addressing the comments.

          Show
          Jitendra Nath Pandey added a comment - New patch addressing the comments.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12450934/HADOOP-6706.6.patch
          against trunk revision 980953.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12450934/HADOOP-6706.6.patch against trunk revision 980953. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/654/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          javadoc warnings are in KerberosName.java and SecurityUtil.java and are unrelated to this patch.

          The patch was manually tested on Y20 branch.

          Show
          Jitendra Nath Pandey added a comment - javadoc warnings are in KerberosName.java and SecurityUtil.java and are unrelated to this patch. The patch was manually tested on Y20 branch.
          Hide
          Devaraj Das added a comment -

          Looks like due to the order in which the patches from HADOOP-6706 and HADOOP-6718 got applied, there is a small problem in the part where the exception thrown by setupSaslConnection is handled. handleSaslConnection is not called anymore. Please remove that call from your patch.

          Show
          Devaraj Das added a comment - Looks like due to the order in which the patches from HADOOP-6706 and HADOOP-6718 got applied, there is a small problem in the part where the exception thrown by setupSaslConnection is handled. handleSaslConnection is not called anymore. Please remove that call from your patch.
          Hide
          Jitendra Nath Pandey added a comment -

          New patch addressing the comment.

          Show
          Jitendra Nath Pandey added a comment - New patch addressing the comment.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12451082/HADOOP-6706.7.patch
          against trunk revision 981688.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 1 new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12451082/HADOOP-6706.7.patch against trunk revision 981688. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/659/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          Updated patch fixing the findbugs warning.

          Show
          Jitendra Nath Pandey added a comment - Updated patch fixing the findbugs warning.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12451090/HADOOP-6706.8.patch
          against trunk revision 981688.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javadoc. The javadoc tool appears to have generated 1 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12451090/HADOOP-6706.8.patch against trunk revision 981688. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javadoc. The javadoc tool appears to have generated 1 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/660/console This message is automatically generated.
          Hide
          Devaraj Das added a comment -

          I just committed this. Thanks, Jitendra for the trunk patches.

          Show
          Devaraj Das added a comment - I just committed this. Thanks, Jitendra for the trunk patches.

            People

            • Assignee:
              Devaraj Das
              Reporter:
              Devaraj Das
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development