[HADOOP-6554] DelegationTokenSecretManager lifecycle is inconsistent

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.22.0
• Assignee: Todd Lipcon
• Reporter: Todd Lipcon
• Created: 10/Feb/10 02:48
• Updated: 11/Mar/10 21:26
• Resolved: 11/Mar/10 21:26

Description

FSNamesystem.dtSecretManager is initialized in FSNamesystem.initialize(), but not started until activate(). In FSN.stop() it calls dtSecretManager.stopThreads so long as it's non-null, but doesn't check that the threads have started (ie activate() may never have been called). This causes an NPE in stopThreads()

To fix this, stopThreads should check tokenRemoverThread against null before interrupting it.

Issue Links

• blocks: HDFS-909 Race condition between rollEditLog or rollFSImage ant FSEditsLog.write operations corrupts edits log
• is duplicated by: HADOOP-6565 AbstractDelegationTokenSecretManager.stopThreads() will NPE if called before startThreads()
• is part of: HADOOP-6573 Delegation Tokens should be persisted.