[HADOOP-6565] AbstractDelegationTokenSecretManager.stopThreads() will NPE if called before startThreads()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 0.22.0
• Component/s: security
• Assignee: Unassigned
• Reporter: Steve Loughran
• Created: 13/Feb/10 17:02
• Updated: 07/Aug/13 16:17
• Resolved: 07/Aug/13 16:17

Description

Looking at the code for starting/stopping SecretManagers, it seems to me that AbstractDelegationTokenSecretManager.stopThreads() assumes that tokenRemoverThread is never null. That assumption is only valid if AbstractDelegationTokenSecretManager.startThreads() was called first.

the call to tokenRemoverThread.interrupt() should be guarded with a check for tokenRemoverThread!=null

I haven't encountered this in the field yet, but it should be trivial to replicate in a test and then fix.

Issue Links

• duplicates: HADOOP-6554 DelegationTokenSecretManager lifecycle is inconsistent