Hadoop Common
  1. Hadoop Common
  2. HADOOP-6343

Stack trace of any runtime exceptions should be recorded in the server logs.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Record runtime exceptions in server log to facilitate fault analysis.

      Description

      Hadoop RPC catches any server side exception and throws an IOException. Runtime excpetions should be recorded in the server logs before being thrown as IOException.

      1. HADOOP-6343.1.patch
        0.5 kB
        Jitendra Nath Pandey
      2. HADOOP-6343.2.patch
        0.5 kB
        Jitendra Nath Pandey
      3. HADOOP-6343.0-20.patch
        0.5 kB
        Jitendra Nath Pandey

        Issue Links

          Activity

          Jitendra Nath Pandey created issue -
          Jitendra Nath Pandey made changes -
          Field Original Value New Value
          Attachment HADOOP-6343.1.patch [ 12423625 ]
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6343.2.patch [ 12423735 ]
          Hide
          Jitendra Nath Pandey added a comment -

          HADOOP-6343.2.patch is submitted for hudson tests.

          Show
          Jitendra Nath Pandey added a comment - HADOOP-6343 .2.patch is submitted for hudson tests.
          Jitendra Nath Pandey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          +1 patch looks good.

          Show
          Tsz Wo Nicholas Sze added a comment - +1 patch looks good.
          Tsz Wo Nicholas Sze made changes -
          Hadoop Flags [Reviewed]
          Component/s ipc [ 12310688 ]
          Tsz Wo Nicholas Sze made changes -
          Link This issue relates to HDFS-626 [ HDFS-626 ]
          Hide
          Tsz Wo Nicholas Sze added a comment -

          This is very useful. Otherwise, the stack trace of uncaught RuntimeException may not be logged. See also HDFS-626.

          Show
          Tsz Wo Nicholas Sze added a comment - This is very useful. Otherwise, the stack trace of uncaught RuntimeException may not be logged. See also HDFS-626 .
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12423735/HADOOP-6343.2.patch
          against trunk revision 831478.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/121/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/121/artifact/trunk/build/test/checkstyle-errors.html
          Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/121/console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12423735/HADOOP-6343.2.patch against trunk revision 831478. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/121/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/121/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/121/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/121/console This message is automatically generated.
          Hide
          Jitendra Nath Pandey added a comment -

          This change adds stack-trace to the server logs. Since the change is only in log message, no additional unit tests are required.

          Show
          Jitendra Nath Pandey added a comment - This change adds stack-trace to the server logs. Since the change is only in log message, no additional unit tests are required.
          Hide
          Tsz Wo Nicholas Sze added a comment -

          I suggest committing this to 0.20. Otherwise, it is hard to fix bugs like HDFS-626.

          Show
          Tsz Wo Nicholas Sze added a comment - I suggest committing this to 0.20. Otherwise, it is hard to fix bugs like HDFS-626 .
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #80 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/80/)
          . Log unexpected throwable object caught in RPC. Contributed by Jitendra Nath Pandey

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #80 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/80/ ) . Log unexpected throwable object caught in RPC. Contributed by Jitendra Nath Pandey
          Hide
          Tsz Wo Nicholas Sze added a comment -

          Unfortunately, this improvement is not qualified to be committed to 0.20.

          I have committed this to 0.21 and above. Thanks, Jitendra!

          Show
          Tsz Wo Nicholas Sze added a comment - Unfortunately, this improvement is not qualified to be committed to 0.20. I have committed this to 0.21 and above. Thanks, Jitendra!
          Tsz Wo Nicholas Sze made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.21.0 [ 12313563 ]
          Fix Version/s 0.22.0 [ 12314296 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Common-trunk #147 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/147/)
          . Log unexpected throwable object caught in RPC. Contributed by Jitendra Nath Pandey

          Show
          Hudson added a comment - Integrated in Hadoop-Common-trunk #147 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/147/ ) . Log unexpected throwable object caught in RPC. Contributed by Jitendra Nath Pandey
          Hide
          Jitendra Nath Pandey added a comment -

          Patch for hadoop-20 is added.

          Show
          Jitendra Nath Pandey added a comment - Patch for hadoop-20 is added.
          Jitendra Nath Pandey made changes -
          Attachment HADOOP-6343.0-20.patch [ 12424150 ]
          Robert Chansler made changes -
          Release Note Record runtime exceptions in server log to facilitate fault analysis.
          Tom White made changes -
          Fix Version/s 0.22.0 [ 12314296 ]
          Tom White made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          1d 2h 46m 1 Jitendra Nath Pandey 30/Oct/09 23:25
          Patch Available Patch Available Resolved Resolved
          3d 2h 19m 1 Tsz Wo Nicholas Sze 03/Nov/09 01:44
          Resolved Resolved Closed Closed
          294d 18h 55m 1 Tom White 24/Aug/10 21:40

            People

            • Assignee:
              Jitendra Nath Pandey
              Reporter:
              Jitendra Nath Pandey
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development